127289 CVE-2013-6663 2014-01-20 06:07:41 -0800 Update overlay scrollbars in single pass 2014-05-02 14:32:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127354 1 koivisto webkit-unassigned bdakin commit-queue jeffcz kling simon.fraser oldest_to_newest 969826 0 koivisto 2014-01-20 06:07:41 -0800 Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout. 969828 1 221656 koivisto 2014-01-20 06:36:06 -0800 Created attachment 221656 patch 969829 2 commit-queue 2014-01-20 06:38:03 -0800 Attachment 221656 did not pass style-queue: ERROR: Source/WebCore/platform/ScrollView.cpp:560: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 969873 3 koivisto 2014-01-20 09:17:38 -0800 https://trac.webkit.org/r162354 969951 4 221656 simon.fraser 2014-01-20 12:13:44 -0800 Comment on attachment 221656 patch I think this might be a no-op after r155660? 970295 5 commit-queue 2014-01-21 09:58:52 -0800 Re-opened since this is blocked by bug 127354 970310 6 ap 2014-01-21 10:37:44 -0800 Rolled out in <http://trac.webkit.org/changeset/162447>, and confirmed that this fixed the test. Looks like this is a good patch overall, but straightening its effects on accessibility seems tricky. It manifested in really weird behavior, see bug 127323. 970337 7 ap 2014-01-21 11:30:32 -0800 > I think this might be a no-op after r155660? Definitely still not a no-op, because rolling it out changed test behavior. 970378 8 simon.fraser 2014-01-21 12:24:18 -0800 Yeah, I confirmed yesterday that it does eliminate calls to visibleContentsResized() 970671 9 koivisto 2014-01-22 05:05:28 -0800 Relanded in https://trac.webkit.org/r162515 It tries to resolve accessibility test flakiness by forcing layout in the test. The real bug might be in the AccessibilityController. 221656 2014-01-20 06:36:06 -0800 2014-01-20 12:13:44 -0800 patch single-pass-overlay-scrollbar.patch text/plain 4522 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjMzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTIwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgb3ZlcmxheSBzY3Jv bGxiYXJzIGluIHNpbmdsZSBwYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjcyODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U2Nyb2xsVmlldzo6dXBkYXRlU2Nyb2xsYmFycyk6CisgICAgICAgIAorICAgICAgICAgICAg TXVsdGktcGFzcyBzY3JvbGxiYXIgcmVzb2x1dGlvbiBpcyBvbmx5IG5lZWRlZCBmb3IgdHJhZGl0 aW9uYWwgc2Nyb2xsYmFycy4gT3ZlcmxheSBzY3JvbGxiYXJzIGRvbid0IGFmZmVjdCBsYXlvdXQu CisKIDIwMTQtMDEtMjAgIEd1cnByZWV0IEthdXIgIDxrLmd1cnByZWV0QHNhbXN1bmcuY29tPgog CiAgICAgICAgIENvbCB3aWR0aCBpcyBub3QgaG9ub3JlZCB3aGVuIGR5bmFtaWNhbGx5IHVwZGF0 ZWQgYW5kIGl0IHdvdWxkIG1ha2UgdGFibGUgbmFycm93ZXIKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL1Njcm9sbFZpZXcuY3BwCShyZXZpc2lvbiAxNjIyMDEpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTA1LDEwICs1MDUs MTIgQEAgdm9pZCBTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKGNvbnN0IAogICAgIGlmICht X2luVXBkYXRlU2Nyb2xsYmFycyB8fCBwcm9oaWJpdHNTY3JvbGxpbmcoKSB8fCBwbGF0Zm9ybVdp ZGdldCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBib29sIGhhc092ZXJsYXlTY3JvbGxiYXJz ID0gKCFtX2hvcml6b250YWxTY3JvbGxiYXIgfHwgbV9ob3Jpem9udGFsU2Nyb2xsYmFyLT5pc092 ZXJsYXlTY3JvbGxiYXIoKSkgJiYgKCFtX3ZlcnRpY2FsU2Nyb2xsYmFyIHx8IG1fdmVydGljYWxT Y3JvbGxiYXItPmlzT3ZlcmxheVNjcm9sbGJhcigpKTsKKwogICAgIC8vIElmIHdlIGNhbWUgaW4g aGVyZSB3aXRoIHRoZSB2aWV3IGFscmVhZHkgbmVlZGluZyBhIGxheW91dCwgdGhlbiBnbyBhaGVh ZCBhbmQgZG8gdGhhdAogICAgIC8vIGZpcnN0LiAgKFRoaXMgd2lsbCBiZSB0aGUgY29tbW9uIGNh c2UsIGUuZy4sIHdoZW4gdGhlIHBhZ2UgY2hhbmdlcyBkdWUgdG8gd2luZG93IHJlc2l6aW5nIGZv ciBleGFtcGxlKS4KICAgICAvLyBUaGlzIGxheW91dCB3aWxsIG5vdCByZS1lbnRlciB1cGRhdGVT Y3JvbGxiYXJzIGFuZCBkb2VzIG5vdCBjb3VudCB0b3dhcmRzIG91ciBtYXggbGF5b3V0IHBhc3Mg dG90YWwuCi0gICAgaWYgKCFtX3Njcm9sbGJhcnNTdXBwcmVzc2VkKSB7CisgICAgaWYgKCFtX3Nj cm9sbGJhcnNTdXBwcmVzc2VkICYmICFoYXNPdmVybGF5U2Nyb2xsYmFycykgewogICAgICAgICBt X2luVXBkYXRlU2Nyb2xsYmFycyA9IHRydWU7CiAgICAgICAgIHZpc2libGVDb250ZW50c1Jlc2l6 ZWQoKTsKICAgICAgICAgbV9pblVwZGF0ZVNjcm9sbGJhcnMgPSBmYWxzZTsKQEAgLTU0OCwyOCAr NTUwLDI5IEBAIHZvaWQgU2Nyb2xsVmlldzo6dXBkYXRlU2Nyb2xsYmFycyhjb25zdCAKICAgICAg ICAgSW50U2l6ZSBkb2NTaXplID0gdG90YWxDb250ZW50c1NpemUoKTsKICAgICAgICAgSW50U2l6 ZSBmdWxsVmlzaWJsZVNpemUgPSB2aXNpYmxlQ29udGVudFJlY3QoSW5jbHVkZVNjcm9sbGJhcnMp LnNpemUoKTsKIAotICAgICAgICBpZiAoaFNjcm9sbCA9PSBTY3JvbGxiYXJBdXRvKSB7CisgICAg ICAgIGlmIChoU2Nyb2xsID09IFNjcm9sbGJhckF1dG8pCiAgICAgICAgICAgICBuZXdIYXNIb3Jp em9udGFsU2Nyb2xsYmFyID0gZG9jU2l6ZS53aWR0aCgpID4gdmlzaWJsZVdpZHRoKCk7Ci0gICAg ICAgICAgICBpZiAobmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciAmJiAhbV91cGRhdGVTY3JvbGxi YXJzUGFzcyAmJiBkb2NTaXplLndpZHRoKCkgPD0gZnVsbFZpc2libGVTaXplLndpZHRoKCkgJiYg ZG9jU2l6ZS5oZWlnaHQoKSA8PSBmdWxsVmlzaWJsZVNpemUuaGVpZ2h0KCkpCi0gICAgICAgICAg ICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IGZhbHNlOwotICAgICAgICB9Ci0gICAg ICAgIGlmICh2U2Nyb2xsID09IFNjcm9sbGJhckF1dG8pIHsKKyAgICAgICAgaWYgKHZTY3JvbGwg PT0gU2Nyb2xsYmFyQXV0bykKICAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0g ZG9jU2l6ZS5oZWlnaHQoKSA+IHZpc2libGVIZWlnaHQoKTsKLSAgICAgICAgICAgIGlmIChuZXdI YXNWZXJ0aWNhbFNjcm9sbGJhciAmJiAhbV91cGRhdGVTY3JvbGxiYXJzUGFzcyAmJiBkb2NTaXpl LndpZHRoKCkgPD0gZnVsbFZpc2libGVTaXplLndpZHRoKCkgJiYgZG9jU2l6ZS5oZWlnaHQoKSA8 PSBmdWxsVmlzaWJsZVNpemUuaGVpZ2h0KCkpCi0gICAgICAgICAgICAgICAgbmV3SGFzVmVydGlj YWxTY3JvbGxiYXIgPSBmYWxzZTsKLSAgICAgICAgfQogCi0gICAgICAgIC8vIElmIHdlIGV2ZXIg dHVybiBvbmUgc2Nyb2xsYmFyIG9mZiwgYWx3YXlzIHR1cm4gdGhlIG90aGVyIG9uZSBvZmYgdG9v LiAgTmV2ZXIgZXZlcgotICAgICAgICAvLyB0cnkgdG8gYm90aCBnYWluL2xvc2UgYSBzY3JvbGxi YXIgaW4gdGhlIHNhbWUgcGFzcy4KICAgICAgICAgYm9vbCBuZWVkQW5vdGhlclBhc3MgPSBmYWxz ZTsKLSAgICAgICAgaWYgKCFuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyICYmIGhhc0hvcml6b250 YWxTY3JvbGxiYXIgJiYgdlNjcm9sbCAhPSBTY3JvbGxiYXJBbHdheXNPbikgewotICAgICAgICAg ICAgbmV3SGFzVmVydGljYWxTY3JvbGxiYXIgPSBmYWxzZTsKLSAgICAgICAgICAgIG5lZWRBbm90 aGVyUGFzcyA9IHRydWU7Ci0gICAgICAgIH0KLQotICAgICAgICBpZiAoIW5ld0hhc1ZlcnRpY2Fs U2Nyb2xsYmFyICYmIGhhc1ZlcnRpY2FsU2Nyb2xsYmFyICYmIGhTY3JvbGwgIT0gU2Nyb2xsYmFy QWx3YXlzT24pIHsKLSAgICAgICAgICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIgPSBmYWxz ZTsKLSAgICAgICAgICAgIG5lZWRBbm90aGVyUGFzcyA9IHRydWU7CisgICAgICAgIGlmICghaGFz T3ZlcmxheVNjcm9sbGJhcnMpIHsKKyAgICAgICAgICAgIC8vIElmIHdlIGV2ZXIgdHVybiBvbmUg c2Nyb2xsYmFyIG9mZiwgYWx3YXlzIHR1cm4gdGhlIG90aGVyIG9uZSBvZmYgdG9vLiAgTmV2ZXIg ZXZlcgorICAgICAgICAgICAgLy8gdHJ5IHRvIGJvdGggZ2Fpbi9sb3NlIGEgc2Nyb2xsYmFyIGlu IHRoZSBzYW1lIHBhc3MuCisgICAgICAgICAgICBpZiAoIW1fdXBkYXRlU2Nyb2xsYmFyc1Bhc3Mg JiYgZG9jU2l6ZS53aWR0aCgpIDw9IGZ1bGxWaXNpYmxlU2l6ZS53aWR0aCgpICYmIGRvY1NpemUu aGVpZ2h0KCkgPD0gZnVsbFZpc2libGVTaXplLmhlaWdodCgpKSB7CisgICAgICAgICAgICAgICAg aWYgKGhTY3JvbGwgPT0gU2Nyb2xsYmFyQXV0bykKKyAgICAgICAgICAgICAgICAgICAgbmV3SGFz SG9yaXpvbnRhbFNjcm9sbGJhciA9IGZhbHNlOworICAgICAgICAgICAgICAgIGlmICh2U2Nyb2xs ID09IFNjcm9sbGJhckF1dG8pCisgICAgICAgICAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Ny b2xsYmFyID0gZmFsc2U7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBpZiAoIW5ld0hhc0hv cml6b250YWxTY3JvbGxiYXIgJiYgaGFzSG9yaXpvbnRhbFNjcm9sbGJhciAmJiB2U2Nyb2xsICE9 IFNjcm9sbGJhckFsd2F5c09uKSB7CisgICAgICAgICAgICAgICAgbmV3SGFzVmVydGljYWxTY3Jv bGxiYXIgPSBmYWxzZTsKKyAgICAgICAgICAgICAgICBuZWVkQW5vdGhlclBhc3MgPSB0cnVlOwor ICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKCFuZXdIYXNWZXJ0aWNhbFNjcm9sbGJhciAm JiBoYXNWZXJ0aWNhbFNjcm9sbGJhciAmJiBoU2Nyb2xsICE9IFNjcm9sbGJhckFsd2F5c09uKSB7 CisgICAgICAgICAgICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IGZhbHNlOworICAg ICAgICAgICAgICAgIG5lZWRBbm90aGVyUGFzcyA9IHRydWU7CisgICAgICAgICAgICB9CiAgICAg ICAgIH0KIAogICAgICAgICBpZiAoaGFzSG9yaXpvbnRhbFNjcm9sbGJhciAhPSBuZXdIYXNIb3Jp em9udGFsU2Nyb2xsYmFyICYmIChoYXNIb3Jpem9udGFsU2Nyb2xsYmFyIHx8ICFhdm9pZFNjcm9s bGJhckNyZWF0aW9uKCkpKSB7Cg==