127273 2014-01-20 01:22:27 -0800 [GTK][WK2] Move the rest of GTK's WorkQueue implementation to std::function 2014-01-20 13:13:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan andersca commit-queue oldest_to_newest 969765 0 zan 2014-01-20 01:22:27 -0800 [GTK][WK2] Move the rest of GTK's WorkQueue implementation to std::function 969767 1 221634 zan 2014-01-20 01:34:40 -0800 Created attachment 221634 Patch 969768 2 commit-queue 2014-01-20 01:35:41 -0800 Attachment 221634 did not pass style-queue: ERROR: Source/WebKit2/Platform/WorkQueue.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:110: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:162: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:170: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 969950 3 221634 andersca 2014-01-20 11:57:39 -0800 Comment on attachment 221634 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221634&action=review > Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:73 > + : EventSource(std::forward<std::function<void ()>>(function), workQueue) This should just use std::move. > Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:170 > - SocketEventSource* eventSource = new SocketEventSource(function, this, cancellable.get(), closeFunction); > + SocketEventSource* eventSource = new SocketEventSource(std::forward<std::function<void ()>>(function), this, > + cancellable.get(), std::forward<std::function<void ()>>(closeFunction)); This should use std::move instead of std::forward. 969973 4 zan 2014-01-20 13:13:08 -0800 Committed r162370: <http://trac.webkit.org/changeset/162370> 221634 2014-01-20 01:34:40 -0800 2014-01-20 11:57:39 -0800 Patch bug-127273-20140120013439.patch text/plain 5213 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTIyMjk1YzRlYTg3N2Jl ZmUyMDE3ZWE1ZDE2Nzc3N2EzYWQxNDYwOS4uNWMyYzM0NDYxYzRhODY4ZWQ0MGVjOWIzMmJjMjNj ZWJlYTU5NmIzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTAxLTIwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXVtXSzJdIE1v dmUgdGhlIHJlc3Qgb2YgR1RLJ3MgV29ya1F1ZXVlIGltcGxlbWVudGF0aW9uIHRvIHN0ZDo6ZnVu Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NzI3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1v dmUgdG8gdXNpbmcgc3RkOjpmdW5jdGlvbiBhbmQgbW92ZSBzZW1hbnRpY3MgaW4gV29ya1F1ZXVl OjpyZWdpc3RlclNvY2tldEV2ZW50SGFuZGxlcgorICAgICAgICBhbmQgV29ya1F1ZXVlOjpTb2Nr ZXRFdmVudFNvdXJjZS4KKworICAgICAgICAqIFBsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25V bml4LmNwcDoKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6b3Blbik6CisgICAgICAgICogUGxh dGZvcm0vV29ya1F1ZXVlLmg6CisgICAgICAgICogUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5j cHA6CisgICAgICAgIChXb3JrUXVldWU6OlNvY2tldEV2ZW50U291cmNlOjpTb2NrZXRFdmVudFNv dXJjZSk6CisgICAgICAgIChXb3JrUXVldWU6OnJlZ2lzdGVyU29ja2V0RXZlbnRIYW5kbGVyKToK KworMjAxNC0wMS0yMCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CisKICAg ICAgICAgVW5yZXZpZXdlZC4gQWRkaXRpb25hbCBidWlsZCBmaXhlcyBhZnRlciByMTYyMjc2IGFu ZCByMTYzMzA0LgogCiAgICAgICAgICogUGxhdGZvcm0vV29ya1F1ZXVlLmg6CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAKaW5kZXgg MjZjYjA2YjZlOGMyZDFjN2MzZTAyNDZlNDQ5NDY5OTJlN2E3MTFjNy4uNmZmODJlNmVkOTJkMDBi ZjE4MjlhZjY2NDliOGZiMzllYjAzMjUwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxh dGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcApAQCAtMzg4LDcgKzM4OCwxNCBAQCBi b29sIENvbm5lY3Rpb246Om9wZW4oKQogCiAgICAgbV9pc0Nvbm5lY3RlZCA9IHRydWU7CiAjaWYg UExBVEZPUk0oR1RLKQotICAgIG1fY29ubmVjdGlvblF1ZXVlLT5yZWdpc3RlclNvY2tldEV2ZW50 SGFuZGxlcihtX3NvY2tldERlc2NyaXB0b3IsIFdURjo6YmluZCgmQ29ubmVjdGlvbjo6cmVhZHlS ZWFkSGFuZGxlciwgdGhpcyksIFdURjo6YmluZCgmQ29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENs b3NlLCB0aGlzKSk7CisgICAgUmVmUHRyPENvbm5lY3Rpb24+IHByb3RlY3Rvcih0aGlzKTsKKyAg ICBtX2Nvbm5lY3Rpb25RdWV1ZS0+cmVnaXN0ZXJTb2NrZXRFdmVudEhhbmRsZXIobV9zb2NrZXRE ZXNjcmlwdG9yLAorICAgICAgICBbPV0geworICAgICAgICAgICAgcHJvdGVjdG9yLT5yZWFkeVJl YWRIYW5kbGVyKCk7CisgICAgICAgIH0sCisgICAgICAgIFs9XSB7CisgICAgICAgICAgICBwcm90 ZWN0b3ItPmNvbm5lY3Rpb25EaWRDbG9zZSgpOworICAgICAgICB9KTsKICNlbGlmIFBMQVRGT1JN KEVGTCkKICAgICBtX2Nvbm5lY3Rpb25RdWV1ZS0+cmVnaXN0ZXJTb2NrZXRFdmVudEhhbmRsZXIo bV9zb2NrZXREZXNjcmlwdG9yLCBXVEY6OmJpbmQoJkNvbm5lY3Rpb246OnJlYWR5UmVhZEhhbmRs ZXIsIHRoaXMpKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0v V29ya1F1ZXVlLmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Xb3JrUXVldWUuaAppbmRleCAw ZDY4NzM2OTJmODc0NTU1YzU5YmEyM2MzMTliMjUwZjYyOGUzNzA0Li4yMzRiMWZiYzUxYzkwMTRl ZDgxMzY1YThlZDgxODk1YjA2MGNkN2E5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9Xb3JrUXVldWUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Xb3JrUXVldWUu aApAQCAtNjMsNyArNjMsNyBAQCBwdWJsaWM6CiAjaWYgT1MoREFSV0lOKQogICAgIGRpc3BhdGNo X3F1ZXVlX3QgZGlzcGF0Y2hRdWV1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fZGlzcGF0Y2hRdWV1ZTsg fQogI2VsaWYgUExBVEZPUk0oR1RLKQotICAgIHZvaWQgcmVnaXN0ZXJTb2NrZXRFdmVudEhhbmRs ZXIoaW50LCBjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiwgY29uc3QgRnVuY3Rpb248dm9pZCgpPiYp OworICAgIHZvaWQgcmVnaXN0ZXJTb2NrZXRFdmVudEhhbmRsZXIoaW50LCBzdGQ6OmZ1bmN0aW9u PHZvaWQgKCk+LCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+KTsKICAgICB2b2lkIHVucmVnaXN0ZXJT b2NrZXRFdmVudEhhbmRsZXIoaW50KTsKICNlbGlmIFBMQVRGT1JNKEVGTCkKICAgICB2b2lkIHJl Z2lzdGVyU29ja2V0RXZlbnRIYW5kbGVyKGludCwgY29uc3QgRnVuY3Rpb248dm9pZCgpPiYpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9ndGsvV29ya1F1ZXVlR3RrLmNwcAppbmRleCAzYWE1 ZTgxY2ZiNDZiN2Y5ZjM3NTdhZTk1YWY5MTEwOTllYmQxZWI0Li5kMDM2OTYzNjU4OTgxMzRiNDVm MTEyNmM0OTcwYjMyNmFiMmI4MWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9ndGsvV29ya1F1ZXVlR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9ndGsv V29ya1F1ZXVlR3RrLmNwcApAQCAtNjksMTAgKzY5LDEwIEBAIHByaXZhdGU6CiAKIGNsYXNzIFdv cmtRdWV1ZTo6U29ja2V0RXZlbnRTb3VyY2UgOiBwdWJsaWMgV29ya1F1ZXVlOjpFdmVudFNvdXJj ZSB7CiBwdWJsaWM6Ci0gICAgU29ja2V0RXZlbnRTb3VyY2UoY29uc3QgRnVuY3Rpb248dm9pZCgp PiYgZnVuY3Rpb24sIFdvcmtRdWV1ZSogd29ya1F1ZXVlLCBHQ2FuY2VsbGFibGUqIGNhbmNlbGxh YmxlLCBjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiBjbG9zZUZ1bmN0aW9uKQotICAgICAgICA6IEV2 ZW50U291cmNlKGZ1bmN0aW9uLCB3b3JrUXVldWUpCisgICAgU29ja2V0RXZlbnRTb3VyY2Uoc3Rk OjpmdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlvbiwgV29ya1F1ZXVlKiB3b3JrUXVldWUsIEdDYW5j ZWxsYWJsZSogY2FuY2VsbGFibGUsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4gY2xvc2VGdW5jdGlv bikKKyAgICAgICAgOiBFdmVudFNvdXJjZShzdGQ6OmZvcndhcmQ8c3RkOjpmdW5jdGlvbjx2b2lk ICgpPj4oZnVuY3Rpb24pLCB3b3JrUXVldWUpCiAgICAgICAgICwgbV9jYW5jZWxsYWJsZShjYW5j ZWxsYWJsZSkKLSAgICAgICAgLCBtX2Nsb3NlRnVuY3Rpb24oY2xvc2VGdW5jdGlvbikKKyAgICAg ICAgLCBtX2Nsb3NlRnVuY3Rpb24oc3RkOjptb3ZlKGNsb3NlRnVuY3Rpb24pKQogICAgIHsKICAg ICAgICAgQVNTRVJUKGNhbmNlbGxhYmxlKTsKICAgICB9CkBAIC0xMDcsNyArMTA3LDcgQEAgcHVi bGljOgogCiBwcml2YXRlOgogICAgIEdDYW5jZWxsYWJsZSogbV9jYW5jZWxsYWJsZTsKLSAgICBG dW5jdGlvbjx2b2lkKCk+IG1fY2xvc2VGdW5jdGlvbjsKKyAgICBzdGQ6OmZ1bmN0aW9uPHZvaWQg KCk+IG1fY2xvc2VGdW5jdGlvbjsKIH07CiAKIC8vIFdvcmtRdWV1ZQpAQCAtMTU5LDE0ICsxNTks MTUgQEAgdm9pZCBXb3JrUXVldWU6OndvcmtRdWV1ZVRocmVhZEJvZHkoKQogICAgIGdfbWFpbl9s b29wX3J1bihtX2V2ZW50TG9vcC5nZXQoKSk7CiB9CiAKLXZvaWQgV29ya1F1ZXVlOjpyZWdpc3Rl clNvY2tldEV2ZW50SGFuZGxlcihpbnQgZmlsZURlc2NyaXB0b3IsIGNvbnN0IEZ1bmN0aW9uPHZv aWQoKT4mIGZ1bmN0aW9uLCBjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiBjbG9zZUZ1bmN0aW9uKQor dm9pZCBXb3JrUXVldWU6OnJlZ2lzdGVyU29ja2V0RXZlbnRIYW5kbGVyKGludCBmaWxlRGVzY3Jp cHRvciwgc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlvbiwgc3RkOjpmdW5jdGlvbjx2b2lk ICgpPiBjbG9zZUZ1bmN0aW9uKQogewogICAgIEdSZWZQdHI8R1NvY2tldD4gc29ja2V0ID0gYWRv cHRHUmVmKGdfc29ja2V0X25ld19mcm9tX2ZkKGZpbGVEZXNjcmlwdG9yLCAwKSk7CiAgICAgQVNT RVJUKHNvY2tldCk7CiAgICAgR1JlZlB0cjxHQ2FuY2VsbGFibGU+IGNhbmNlbGxhYmxlID0gYWRv cHRHUmVmKGdfY2FuY2VsbGFibGVfbmV3KCkpOwogICAgIEdSZWZQdHI8R1NvdXJjZT4gZGlzcGF0 Y2hTb3VyY2UgPSBhZG9wdEdSZWYoZ19zb2NrZXRfY3JlYXRlX3NvdXJjZShzb2NrZXQuZ2V0KCks IEdfSU9fSU4sIGNhbmNlbGxhYmxlLmdldCgpKSk7CiAgICAgQVNTRVJUKGRpc3BhdGNoU291cmNl KTsKLSAgICBTb2NrZXRFdmVudFNvdXJjZSogZXZlbnRTb3VyY2UgPSBuZXcgU29ja2V0RXZlbnRT b3VyY2UoZnVuY3Rpb24sIHRoaXMsIGNhbmNlbGxhYmxlLmdldCgpLCBjbG9zZUZ1bmN0aW9uKTsK KyAgICBTb2NrZXRFdmVudFNvdXJjZSogZXZlbnRTb3VyY2UgPSBuZXcgU29ja2V0RXZlbnRTb3Vy Y2Uoc3RkOjpmb3J3YXJkPHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4+KGZ1bmN0aW9uKSwgdGhpcywK KyAgICAgICAgY2FuY2VsbGFibGUuZ2V0KCksIHN0ZDo6Zm9yd2FyZDxzdGQ6OmZ1bmN0aW9uPHZv aWQgKCk+PihjbG9zZUZ1bmN0aW9uKSk7CiAKICAgICBnX3NvdXJjZV9zZXRfY2FsbGJhY2soZGlz cGF0Y2hTb3VyY2UuZ2V0KCksIHJlaW50ZXJwcmV0X2Nhc3Q8R1NvdXJjZUZ1bmM+KCZXb3JrUXVl dWU6OlNvY2tldEV2ZW50U291cmNlOjpldmVudENhbGxiYWNrKSwKICAgICAgICAgZXZlbnRTb3Vy Y2UsIHJlaW50ZXJwcmV0X2Nhc3Q8R0Rlc3Ryb3lOb3RpZnk+KCZXb3JrUXVldWU6OkV2ZW50U291 cmNlOjpkZWxldGVFdmVudFNvdXJjZSkpOwo=