127263 2014-01-19 22:16:41 -0800 [EFL][WK2] Use nanoseconds in TimerWorkItem class consistently 2014-01-21 17:58:37 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song benjamin bunhere bw80.lee cdumez cmarcelo commit-queue gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 969703 0 jinwoo7.song 2014-01-19 22:16:41 -0800 After r162276 and r162300, TimerWorkItem is getting nanoseconds as parameter. So it would be better to use nanoseconds in TimerWorkItem for consistency. 969704 1 221614 jinwoo7.song 2014-01-19 22:23:43 -0800 Created attachment 221614 Patch 969705 2 commit-queue 2014-01-19 22:24:56 -0800 Attachment 221614 did not pass style-queue: ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:66: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 969706 3 221614 gyuyoung.kim 2014-01-19 22:30:14 -0800 Comment on attachment 221614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221614&action=review Looks make sense except for style nits and a new function in CurrentTime. > Source/WTF/wtf/CurrentTime.h:64 > +inline double monotonicallyIncreasingTimeNS() Should we add this function ? Can't we use this functionality by using monotonicallyIncreasingTimeMS() ? It looks this new function need to be reviewed by other reviewer. 969720 4 221614 jinwoo7.song 2014-01-19 23:16:05 -0800 Comment on attachment 221614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221614&action=review Regarding the style error, I got a guide from andersca to make a space after 'void'. It seems that the style-checker need to be updated for this rule. >> Source/WTF/wtf/CurrentTime.h:64 >> +inline double monotonicallyIncreasingTimeNS() > > Should we add this function ? Can't we use this functionality by using monotonicallyIncreasingTimeMS() ? > > It looks this new function need to be reviewed by other reviewer. It would be better not to add new function as it is only used in EFL port. I'll use monotonicallyIncreasingTime(). 969721 5 221619 jinwoo7.song 2014-01-19 23:17:22 -0800 Created attachment 221619 Patch 969722 6 commit-queue 2014-01-19 23:18:28 -0800 Attachment 221619 did not pass style-queue: ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:66: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 969751 7 gyuyoung.kim 2014-01-20 00:47:07 -0800 CC'ing Byungwoo 969756 8 221619 gyuyoung.kim 2014-01-20 00:54:53 -0800 Comment on attachment 221619 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221619&action=review Byungwoo, any comment ? > Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:245 > + double timeOutSeconds = (m_timerWorkItems[0]->expirationTimeNanoSeconds() - monotonicallyIncreasingTime() * nanoSecondsPerSecond) / nanoSecondsPerSecond; It looks "* nanoSecondsPerSecond) / nanoSecondsPerSecond;" is useless. 970164 9 221619 jinwoo7.song 2014-01-20 20:58:15 -0800 Comment on attachment 221619 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221619&action=review >> Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:245 >> + double timeOutSeconds = (m_timerWorkItems[0]->expirationTimeNanoSeconds() - monotonicallyIncreasingTime() * nanoSecondsPerSecond) / nanoSecondsPerSecond; > > It looks "* nanoSecondsPerSecond) / nanoSecondsPerSecond;" is useless. monotonicallyIncreasingTime() is seconds but 'm_timerWorkItems[0]->expirationTimeNanoSeconds()' is nanoseconds. 970196 10 221619 gyuyoung.kim 2014-01-21 00:43:32 -0800 Comment on attachment 221619 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221619&action=review >>> Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:245 >>> + double timeOutSeconds = (m_timerWorkItems[0]->expirationTimeNanoSeconds() - monotonicallyIncreasingTime() * nanoSecondsPerSecond) / nanoSecondsPerSecond; >> >> It looks "* nanoSecondsPerSecond) / nanoSecondsPerSecond;" is useless. > > monotonicallyIncreasingTime() is seconds but 'm_timerWorkItems[0]->expirationTimeNanoSeconds()' is nanoseconds. I'm sorry. I mistook this code. Yes, looks correct. 970505 11 221619 commit-queue 2014-01-21 17:58:33 -0800 Comment on attachment 221619 Patch Clearing flags on attachment: 221619 Committed r162490: <http://trac.webkit.org/changeset/162490> 970506 12 commit-queue 2014-01-21 17:58:37 -0800 All reviewed patches have been landed. Closing bug. 221614 2014-01-19 22:23:43 -0800 2014-01-19 23:17:16 -0800 Patch bug-127263-20140120152332.patch text/plain 7429 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI5MThjZjRiNDVlNDM5ZTQwN2EyZWZi ZDE0MWM0NTUyNjZkZGMzOGYuLmRiZTFlNDdhZDRmNDAxYzI3M2Y5Y2JhNDI1NmFhMmQ4Zjc5M2Ni MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDEtMTkgIEppbndvbyBTb25nICA8amlud29v Ny5zb25nQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gVXNlIG5hbm9zZWNvbmRz IGluIFRpbWVyV29ya0l0ZW0gY2xhc3MgY29uc2lzdGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcyNjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9DdXJyZW50VGltZS5oOgorICAgICAg ICAoV1RGOjptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWVOUyk6IEFkZGVkIG5hbm8gc2Vjb25k IHZlcnNpb24gb2YgbW9ub3RvbmljIHRpbWUgQVBJLgorCiAyMDE0LTAxLTE4ICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHN1cHBvcnQgZm9y IHRoZSB2aWV3c291cmNlIGF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGY3OWE5Y2RjZTEzMmM2OWRi NDNlNzZlZGQ4NzcyNWJmN2QyNzg4MDAuLmM1MTM5NjgxMjVkMWMxMmM2NGI2NzNjNzRhNTE4OGRj Zjk2MWZmNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNSBAQAogMjAxNC0wMS0xOSAgSmlud29v IFNvbmcgIDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF1bV0syXSBV c2UgbmFub3NlY29uZHMgaW4gVGltZXJXb3JrSXRlbSBjbGFzcyBjb25zaXN0ZW50bHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzI2MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHIxNjIyNzYg YW5kIHIxNjIzMDAsIFRpbWVyV29ya0l0ZW0gaXMgZ2V0dGluZyBuYW5vc2Vjb25kcyBhcyBwYXJh bWV0ZXIuCisgICAgICAgIFNvIGl0IHdvdWxkIGJlIGJldHRlciB0byB1c2UgbmFub3NlY29uZHMg aW4gVGltZXJXb3JrSXRlbSBmb3IgY29uc2lzdGVuY3kuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9l ZmwvRGlzcGF0Y2hRdWV1ZUVmbC5jcHA6CisgICAgICAgIChEaXNwYXRjaFF1ZXVlOjpwZXJmb3Jt VGltZXJXb3JrKToKKyAgICAgICAgKERpc3BhdGNoUXVldWU6Omluc2VydFRpbWVyV29ya0l0ZW0p OgorICAgICAgICAoRGlzcGF0Y2hRdWV1ZTo6Z2V0TmV4dFRpbWVPdXQpOgorICAgICAgICAqIFBs YXRmb3JtL2VmbC9EaXNwYXRjaFF1ZXVlV29ya0l0ZW1FZmwuaDoKKyAgICAgICAgKFRpbWVyV29y a0l0ZW06OmNyZWF0ZSk6CisgICAgICAgIChUaW1lcldvcmtJdGVtOjpleHBpcmF0aW9uVGltZU5h bm9TZWNvbmRzKToKKyAgICAgICAgKFRpbWVyV29ya0l0ZW06Omhhc0V4cGlyZWQpOgorICAgICAg ICAoVGltZXJXb3JrSXRlbTo6VGltZXJXb3JrSXRlbSk6CisKKzIwMTQtMDEtMTkgIEppbndvbyBT b25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQgZGVi dWcgYnVpbGQgZml4IG9uIEVGTCBwb3J0IGFmdGVyIHIxNjIzMDAuCiAKICAgICAgICAgKiBQbGF0 Zm9ybS9lZmwvRGlzcGF0Y2hRdWV1ZVdvcmtJdGVtRWZsLmg6CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9DdXJyZW50VGltZS5oIGIvU291cmNlL1dURi93dGYvQ3VycmVudFRpbWUuaAppbmRl eCBiZjlmYjMzYWZmYjkzY2UzN2RjZDViNWI3ZTVlZTViM2EzZTMzMDA3Li4zYzUzM2QyNDhjOTNl YzU1NjIxMzg5ZDcwOTI4Mjk2ZTU3ODM2MGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9D dXJyZW50VGltZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0N1cnJlbnRUaW1lLmgKQEAgLTYwLDYg KzYwLDEyIEBAIGlubGluZSBkb3VibGUgbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lTVMoKQog ICAgIHJldHVybiBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAqIDEwMDAuMDsKIH0KIAor Ly8gU2FtZSB0aGluZyBpbiBuYW5vc2Vjb25kcy4KK2lubGluZSBkb3VibGUgbW9ub3RvbmljYWxs eUluY3JlYXNpbmdUaW1lTlMoKQoreworICAgIHJldHVybiBtb25vdG9uaWNhbGx5SW5jcmVhc2lu Z1RpbWUoKSAqIDEwMDAwMDAwMDAuMDsKK30KKwogLy8gUmV0dXJucyB0aGUgY3VycmVudCBDUFUg dGltZSBvZiB0aGUgY3VycmVudCB0aHJlYWQgaW4gc2Vjb25kcy4KIC8vIFByZWNpc2lvbiB2YXJp ZXMgZGVwZW5kaW5nIG9uIHBsYXRmb3JtIGJ1dCBpcyB1c3VhbGx5IGFzIGdvb2Qgb3IgYmV0dGVy CiAvLyB0aGFuIGEgbWlsbGlzZWNvbmQuCkBAIC03NCw2ICs4MCw3IEBAIHVzaW5nIFdURjo6Y3Vy cmVudFRpbWU7CiB1c2luZyBXVEY6OmN1cnJlbnRUaW1lTVM7CiB1c2luZyBXVEY6Om1vbm90b25p Y2FsbHlJbmNyZWFzaW5nVGltZTsKIHVzaW5nIFdURjo6bW9ub3RvbmljYWxseUluY3JlYXNpbmdU aW1lTVM7Cit1c2luZyBXVEY6Om1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZU5TOwogdXNpbmcg V1RGOjpjdXJyZW50Q1BVVGltZTsKIAogI2VuZGlmIC8vIEN1cnJlbnRUaW1lX2gKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9EaXNwYXRjaFF1ZXVlRWZsLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9EaXNwYXRjaFF1ZXVlRWZsLmNwcAppbmRleCA5OTRl NzY5MGI5MTgwOTIyNzk3NDFiZWY5MTk5YjM2YzQzYmQyMzkwLi4zMjE0YTA0ODJjYzQ5MTM4NGJi NmU1MWQ5NGFmZmVkMWRkYjZlNjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9lZmwvRGlzcGF0Y2hRdWV1ZUVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0v ZWZsL0Rpc3BhdGNoUXVldWVFZmwuY3BwCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSA8d3Rm L1RocmVhZGluZy5oPgogCiBzdGF0aWMgY29uc3QgaW50IG1pY3JvU2Vjb25kc1BlclNlY29uZCA9 IDEwMDAwMDA7CitzdGF0aWMgY29uc3QgaW50IG5hbm9TZWNvbmRzUGVyU2Vjb25kID0gMTAwMDAw MDAwMDsKIHN0YXRpYyBjb25zdCBpbnQgaW52YWxpZFNvY2tldERlc2NyaXB0b3IgPSAtMTsKIHN0 YXRpYyBjb25zdCBjaGFyIHdha2VVcFRocmVhZE1lc3NhZ2UgPSAnVyc7CiAKQEAgLTE3MCwxMCAr MTcxLDEwIEBAIHZvaWQgRGlzcGF0Y2hRdWV1ZTo6cGVyZm9ybVRpbWVyV29yaygpCiAgICAgICAg IG1fdGltZXJXb3JrSXRlbXMuc3dhcCh0aW1lcldvcmtJdGVtcyk7CiAgICAgfQogCi0gICAgZG91 YmxlIGN1cnJlbnRUaW1lU2Vjb25kcyA9IG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOwor ICAgIGRvdWJsZSBjdXJyZW50VGltZU5hbm9TZWNvbmRzID0gbW9ub3RvbmljYWxseUluY3JlYXNp bmdUaW1lTlMoKTsKIAogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgdGltZXJXb3JrSXRlbXMu c2l6ZSgpOyArK2kpIHsKLSAgICAgICAgaWYgKCF0aW1lcldvcmtJdGVtc1tpXS0+aGFzRXhwaXJl ZChjdXJyZW50VGltZVNlY29uZHMpKSB7CisgICAgICAgIGlmICghdGltZXJXb3JrSXRlbXNbaV0t Pmhhc0V4cGlyZWQoY3VycmVudFRpbWVOYW5vU2Vjb25kcykpIHsKICAgICAgICAgICAgIGluc2Vy dFRpbWVyV29ya0l0ZW0oc3RkOjptb3ZlKHRpbWVyV29ya0l0ZW1zW2ldKSk7CiAgICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgfQpAQCAtMjEwLDcgKzIxMSw3IEBAIHZvaWQgRGlzcGF0Y2hR dWV1ZTo6aW5zZXJ0VGltZXJXb3JrSXRlbShzdGQ6OnVuaXF1ZV9wdHI8VGltZXJXb3JrSXRlbT4g aXRlbSkKICAgICBNdXRleExvY2tlciBsb2NrZXIobV90aW1lcldvcmtJdGVtc0xvY2spOwogICAg IC8vIFRoZSBpdGVtcyBzaG91bGQgYmUgb3JkZXJlZCBieSBleHBpcmUgdGltZS4KICAgICBmb3Ig KDsgcG9zaXRpb24gPCBtX3RpbWVyV29ya0l0ZW1zLnNpemUoKTsgKytwb3NpdGlvbikKLSAgICAg ICAgaWYgKGl0ZW0tPmV4cGlyYXRpb25UaW1lU2Vjb25kcygpIDwgbV90aW1lcldvcmtJdGVtc1tw b3NpdGlvbl0tPmV4cGlyYXRpb25UaW1lU2Vjb25kcygpKQorICAgICAgICBpZiAoaXRlbS0+ZXhw aXJhdGlvblRpbWVOYW5vU2Vjb25kcygpIDwgbV90aW1lcldvcmtJdGVtc1twb3NpdGlvbl0tPmV4 cGlyYXRpb25UaW1lTmFub1NlY29uZHMoKSkKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgbV90 aW1lcldvcmtJdGVtcy5pbnNlcnQocG9zaXRpb24sIHN0ZDo6bW92ZShpdGVtKSk7CkBAIC0yNDEs MTAgKzI0MiwxMCBAQCB0aW1ldmFsKiBEaXNwYXRjaFF1ZXVlOjpnZXROZXh0VGltZU91dCgpIGNv bnN0CiAgICAgc3RhdGljIHRpbWV2YWwgdGltZVZhbHVlOwogICAgIHRpbWVWYWx1ZS50dl9zZWMg PSAwOwogICAgIHRpbWVWYWx1ZS50dl91c2VjID0gMDsKLSAgICBkb3VibGUgdGltZU91dCA9IG1f dGltZXJXb3JrSXRlbXNbMF0tPmV4cGlyYXRpb25UaW1lU2Vjb25kcygpIC0gbW9ub3RvbmljYWxs eUluY3JlYXNpbmdUaW1lKCk7Ci0gICAgaWYgKHRpbWVPdXQgPiAwKSB7Ci0gICAgICAgIHRpbWVW YWx1ZS50dl9zZWMgPSBzdGF0aWNfY2FzdDxsb25nPih0aW1lT3V0KTsKLSAgICAgICAgdGltZVZh bHVlLnR2X3VzZWMgPSBzdGF0aWNfY2FzdDxsb25nPigodGltZU91dCAtIHRpbWVWYWx1ZS50dl9z ZWMpICogbWljcm9TZWNvbmRzUGVyU2Vjb25kKTsKKyAgICBkb3VibGUgdGltZU91dFNlY29uZHMg PSAobV90aW1lcldvcmtJdGVtc1swXS0+ZXhwaXJhdGlvblRpbWVOYW5vU2Vjb25kcygpIC0gbW9u b3RvbmljYWxseUluY3JlYXNpbmdUaW1lTlMoKSkgLyBuYW5vU2Vjb25kc1BlclNlY29uZDsKKyAg ICBpZiAodGltZU91dFNlY29uZHMgPiAwKSB7CisgICAgICAgIHRpbWVWYWx1ZS50dl9zZWMgPSBz dGF0aWNfY2FzdDxsb25nPih0aW1lT3V0U2Vjb25kcyk7CisgICAgICAgIHRpbWVWYWx1ZS50dl91 c2VjID0gc3RhdGljX2Nhc3Q8bG9uZz4oKHRpbWVPdXRTZWNvbmRzIC0gdGltZVZhbHVlLnR2X3Nl YykgKiBtaWNyb1NlY29uZHNQZXJTZWNvbmQpOwogICAgIH0KIAogICAgIHJldHVybiAmdGltZVZh bHVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZWZsL0Rpc3BhdGNoUXVl dWVXb3JrSXRlbUVmbC5oIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZWZsL0Rpc3BhdGNoUXVl dWVXb3JrSXRlbUVmbC5oCmluZGV4IGM3MGJhMWVmMWU1OTM5YmFlODRkNmZkZjM0NzFkYjI5ZGYx NDk2ZDMuLjc4OWYyMjZmZTA5ZDg0OTI0NjE4NTU3YWRjNjlkOWM5Y2NkYmIyMDkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9EaXNwYXRjaFF1ZXVlV29ya0l0ZW1FZmwu aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9lZmwvRGlzcGF0Y2hRdWV1ZVdvcmtJdGVt RWZsLmgKQEAgLTU0LDIzICs1NCwyMyBAQCBwcml2YXRlOgogCiBjbGFzcyBUaW1lcldvcmtJdGVt IDogcHVibGljIFdvcmtJdGVtIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRy PFRpbWVyV29ya0l0ZW0+IGNyZWF0ZShQYXNzUmVmUHRyPFdvcmtRdWV1ZT4gd29ya1F1ZXVlLCBz dGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGZ1bmN0aW9uLCBzdGQ6OmNocm9ubzo6bmFub3NlY29uZHMg ZGVsYXkpCisgICAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxUaW1lcldvcmtJdGVtPiBjcmVhdGUo UGFzc1JlZlB0cjxXb3JrUXVldWU+IHdvcmtRdWV1ZSwgc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBm dW5jdGlvbiwgc3RkOjpjaHJvbm86Om5hbm9zZWNvbmRzIGRlbGF5TmFub1NlY29uZHMpCiAgICAg ewotICAgICAgICBBU1NFUlQoZGVsYXkuY291bnQoKSA+PSAwKTsKLSAgICAgICAgcmV0dXJuIHN0 ZDo6dW5pcXVlX3B0cjxUaW1lcldvcmtJdGVtPihuZXcgVGltZXJXb3JrSXRlbSh3b3JrUXVldWUs IHN0ZDo6bW92ZShmdW5jdGlvbiksIG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpICsgZGVs YXkuY291bnQoKSAvIDEwMDAwMDAwMDBVTEwpKTsKKyAgICAgICAgQVNTRVJUKGRlbGF5TmFub1Nl Y29uZHMuY291bnQoKSA+PSAwKTsKKyAgICAgICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxUaW1l cldvcmtJdGVtPihuZXcgVGltZXJXb3JrSXRlbSh3b3JrUXVldWUsIHN0ZDo6bW92ZShmdW5jdGlv biksIG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZU5TKCkgKyBkZWxheU5hbm9TZWNvbmRzLmNv dW50KCkpKTsKICAgICB9Ci0gICAgZG91YmxlIGV4cGlyYXRpb25UaW1lU2Vjb25kcygpIGNvbnN0 IHsgcmV0dXJuIG1fZXhwaXJhdGlvblRpbWVTZWNvbmRzOyB9Ci0gICAgYm9vbCBoYXNFeHBpcmVk KGRvdWJsZSBjdXJyZW50VGltZVNlY29uZHMpIGNvbnN0IHsgcmV0dXJuIGN1cnJlbnRUaW1lU2Vj b25kcyA+PSBtX2V4cGlyYXRpb25UaW1lU2Vjb25kczsgfQorICAgIGRvdWJsZSBleHBpcmF0aW9u VGltZU5hbm9TZWNvbmRzKCkgY29uc3QgeyByZXR1cm4gbV9leHBpcmF0aW9uVGltZU5hbm9TZWNv bmRzOyB9CisgICAgYm9vbCBoYXNFeHBpcmVkKGRvdWJsZSBjdXJyZW50VGltZU5hbm9TZWNvbmRz KSBjb25zdCB7IHJldHVybiBjdXJyZW50VGltZU5hbm9TZWNvbmRzID49IG1fZXhwaXJhdGlvblRp bWVOYW5vU2Vjb25kczsgfQogCiBwcm90ZWN0ZWQ6Ci0gICAgVGltZXJXb3JrSXRlbShQYXNzUmVm UHRyPFdvcmtRdWV1ZT4gd29ya1F1ZXVlLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGZ1bmN0aW9u LCBkb3VibGUgZXhwaXJhdGlvblRpbWVTZWNvbmRzKQorICAgIFRpbWVyV29ya0l0ZW0oUGFzc1Jl ZlB0cjxXb3JrUXVldWU+IHdvcmtRdWV1ZSwgc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlv biwgZG91YmxlIGV4cGlyYXRpb25UaW1lTmFub1NlY29uZHMpCiAgICAgICAgIDogV29ya0l0ZW0o d29ya1F1ZXVlLCBzdGQ6Om1vdmUoZnVuY3Rpb24pKQotICAgICAgICAsIG1fZXhwaXJhdGlvblRp bWVTZWNvbmRzKGV4cGlyYXRpb25UaW1lU2Vjb25kcykKKyAgICAgICAgLCBtX2V4cGlyYXRpb25U aW1lTmFub1NlY29uZHMoZXhwaXJhdGlvblRpbWVOYW5vU2Vjb25kcykKICAgICB7CiAgICAgfQog CiBwcml2YXRlOgotICAgIGRvdWJsZSBtX2V4cGlyYXRpb25UaW1lU2Vjb25kczsKKyAgICBkb3Vi bGUgbV9leHBpcmF0aW9uVGltZU5hbm9TZWNvbmRzOwogfTsKIAogI2VuZGlmIC8vIERpc3BhdGNo UXVldWVXb3JrSXRlbUVmbF9oCg== 221619 2014-01-19 23:17:22 -0800 2014-01-21 17:58:33 -0800 Patch bug-127263-20140120161711.patch text/plain 5879 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjc5YTljZGNlMTMyYzY5 ZGI0M2U3NmVkZDg3NzI1YmY3ZDI3ODgwMC4uYzUxMzk2ODEyNWQxYzEyYzY0YjY3M2M3NGE1MTg4 ZGNmOTYxZmY1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE0LTAxLTE5ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJd IFVzZSBuYW5vc2Vjb25kcyBpbiBUaW1lcldvcmtJdGVtIGNsYXNzIGNvbnNpc3RlbnRseQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MjYzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjE2MjI3 NiBhbmQgcjE2MjMwMCwgVGltZXJXb3JrSXRlbSBpcyBnZXR0aW5nIG5hbm9zZWNvbmRzIGFzIHBh cmFtZXRlci4KKyAgICAgICAgU28gaXQgd291bGQgYmUgYmV0dGVyIHRvIHVzZSBuYW5vc2Vjb25k cyBpbiBUaW1lcldvcmtJdGVtIGZvciBjb25zaXN0ZW5jeS4KKworICAgICAgICAqIFBsYXRmb3Jt L2VmbC9EaXNwYXRjaFF1ZXVlRWZsLmNwcDoKKyAgICAgICAgKERpc3BhdGNoUXVldWU6OnBlcmZv cm1UaW1lcldvcmspOgorICAgICAgICAoRGlzcGF0Y2hRdWV1ZTo6aW5zZXJ0VGltZXJXb3JrSXRl bSk6CisgICAgICAgIChEaXNwYXRjaFF1ZXVlOjpnZXROZXh0VGltZU91dCk6CisgICAgICAgICog UGxhdGZvcm0vZWZsL0Rpc3BhdGNoUXVldWVXb3JrSXRlbUVmbC5oOgorICAgICAgICAoVGltZXJX b3JrSXRlbTo6Y3JlYXRlKToKKyAgICAgICAgKFRpbWVyV29ya0l0ZW06OmV4cGlyYXRpb25UaW1l TmFub1NlY29uZHMpOgorICAgICAgICAoVGltZXJXb3JrSXRlbTo6aGFzRXhwaXJlZCk6CisgICAg ICAgIChUaW1lcldvcmtJdGVtOjpUaW1lcldvcmtJdGVtKToKKworMjAxNC0wMS0xOSAgSmlud29v IFNvbmcgIDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCBk ZWJ1ZyBidWlsZCBmaXggb24gRUZMIHBvcnQgYWZ0ZXIgcjE2MjMwMC4KIAogICAgICAgICAqIFBs YXRmb3JtL2VmbC9EaXNwYXRjaFF1ZXVlV29ya0l0ZW1FZmwuaDoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9EaXNwYXRjaFF1ZXVlRWZsLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtL2VmbC9EaXNwYXRjaFF1ZXVlRWZsLmNwcAppbmRleCA5OTRlNzY5MGI5MTgw OTIyNzk3NDFiZWY5MTk5YjM2YzQzYmQyMzkwLi5jMTFjMjk0NTgzMjdmZTMzODZlYzg1NzkzNTg4 MDNkYTQyOWUyYzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9lZmwvRGlz cGF0Y2hRdWV1ZUVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZWZsL0Rpc3Bh dGNoUXVldWVFZmwuY3BwCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSA8d3RmL1RocmVhZGlu Zy5oPgogCiBzdGF0aWMgY29uc3QgaW50IG1pY3JvU2Vjb25kc1BlclNlY29uZCA9IDEwMDAwMDA7 CitzdGF0aWMgY29uc3QgaW50IG5hbm9TZWNvbmRzUGVyU2Vjb25kID0gMTAwMDAwMDAwMDsKIHN0 YXRpYyBjb25zdCBpbnQgaW52YWxpZFNvY2tldERlc2NyaXB0b3IgPSAtMTsKIHN0YXRpYyBjb25z dCBjaGFyIHdha2VVcFRocmVhZE1lc3NhZ2UgPSAnVyc7CiAKQEAgLTE3MCwxMCArMTcxLDEwIEBA IHZvaWQgRGlzcGF0Y2hRdWV1ZTo6cGVyZm9ybVRpbWVyV29yaygpCiAgICAgICAgIG1fdGltZXJX b3JrSXRlbXMuc3dhcCh0aW1lcldvcmtJdGVtcyk7CiAgICAgfQogCi0gICAgZG91YmxlIGN1cnJl bnRUaW1lU2Vjb25kcyA9IG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOworICAgIGRvdWJs ZSBjdXJyZW50VGltZU5hbm9TZWNvbmRzID0gbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkg KiBuYW5vU2Vjb25kc1BlclNlY29uZDsKIAogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgdGlt ZXJXb3JrSXRlbXMuc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgaWYgKCF0aW1lcldvcmtJdGVtc1tp XS0+aGFzRXhwaXJlZChjdXJyZW50VGltZVNlY29uZHMpKSB7CisgICAgICAgIGlmICghdGltZXJX b3JrSXRlbXNbaV0tPmhhc0V4cGlyZWQoY3VycmVudFRpbWVOYW5vU2Vjb25kcykpIHsKICAgICAg ICAgICAgIGluc2VydFRpbWVyV29ya0l0ZW0oc3RkOjptb3ZlKHRpbWVyV29ya0l0ZW1zW2ldKSk7 CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQpAQCAtMjEwLDcgKzIxMSw3IEBAIHZv aWQgRGlzcGF0Y2hRdWV1ZTo6aW5zZXJ0VGltZXJXb3JrSXRlbShzdGQ6OnVuaXF1ZV9wdHI8VGlt ZXJXb3JrSXRlbT4gaXRlbSkKICAgICBNdXRleExvY2tlciBsb2NrZXIobV90aW1lcldvcmtJdGVt c0xvY2spOwogICAgIC8vIFRoZSBpdGVtcyBzaG91bGQgYmUgb3JkZXJlZCBieSBleHBpcmUgdGlt ZS4KICAgICBmb3IgKDsgcG9zaXRpb24gPCBtX3RpbWVyV29ya0l0ZW1zLnNpemUoKTsgKytwb3Np dGlvbikKLSAgICAgICAgaWYgKGl0ZW0tPmV4cGlyYXRpb25UaW1lU2Vjb25kcygpIDwgbV90aW1l cldvcmtJdGVtc1twb3NpdGlvbl0tPmV4cGlyYXRpb25UaW1lU2Vjb25kcygpKQorICAgICAgICBp ZiAoaXRlbS0+ZXhwaXJhdGlvblRpbWVOYW5vU2Vjb25kcygpIDwgbV90aW1lcldvcmtJdGVtc1tw b3NpdGlvbl0tPmV4cGlyYXRpb25UaW1lTmFub1NlY29uZHMoKSkKICAgICAgICAgICAgIGJyZWFr OwogCiAgICAgbV90aW1lcldvcmtJdGVtcy5pbnNlcnQocG9zaXRpb24sIHN0ZDo6bW92ZShpdGVt KSk7CkBAIC0yNDEsMTAgKzI0MiwxMCBAQCB0aW1ldmFsKiBEaXNwYXRjaFF1ZXVlOjpnZXROZXh0 VGltZU91dCgpIGNvbnN0CiAgICAgc3RhdGljIHRpbWV2YWwgdGltZVZhbHVlOwogICAgIHRpbWVW YWx1ZS50dl9zZWMgPSAwOwogICAgIHRpbWVWYWx1ZS50dl91c2VjID0gMDsKLSAgICBkb3VibGUg dGltZU91dCA9IG1fdGltZXJXb3JrSXRlbXNbMF0tPmV4cGlyYXRpb25UaW1lU2Vjb25kcygpIC0g bW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCk7Ci0gICAgaWYgKHRpbWVPdXQgPiAwKSB7Ci0g ICAgICAgIHRpbWVWYWx1ZS50dl9zZWMgPSBzdGF0aWNfY2FzdDxsb25nPih0aW1lT3V0KTsKLSAg ICAgICAgdGltZVZhbHVlLnR2X3VzZWMgPSBzdGF0aWNfY2FzdDxsb25nPigodGltZU91dCAtIHRp bWVWYWx1ZS50dl9zZWMpICogbWljcm9TZWNvbmRzUGVyU2Vjb25kKTsKKyAgICBkb3VibGUgdGlt ZU91dFNlY29uZHMgPSAobV90aW1lcldvcmtJdGVtc1swXS0+ZXhwaXJhdGlvblRpbWVOYW5vU2Vj b25kcygpIC0gbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkgKiBuYW5vU2Vjb25kc1BlclNl Y29uZCkgLyBuYW5vU2Vjb25kc1BlclNlY29uZDsKKyAgICBpZiAodGltZU91dFNlY29uZHMgPiAw KSB7CisgICAgICAgIHRpbWVWYWx1ZS50dl9zZWMgPSBzdGF0aWNfY2FzdDxsb25nPih0aW1lT3V0 U2Vjb25kcyk7CisgICAgICAgIHRpbWVWYWx1ZS50dl91c2VjID0gc3RhdGljX2Nhc3Q8bG9uZz4o KHRpbWVPdXRTZWNvbmRzIC0gdGltZVZhbHVlLnR2X3NlYykgKiBtaWNyb1NlY29uZHNQZXJTZWNv bmQpOwogICAgIH0KIAogICAgIHJldHVybiAmdGltZVZhbHVlOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vZWZsL0Rpc3BhdGNoUXVldWVXb3JrSXRlbUVmbC5oIGIvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vZWZsL0Rpc3BhdGNoUXVldWVXb3JrSXRlbUVmbC5oCmluZGV4IGM3 MGJhMWVmMWU1OTM5YmFlODRkNmZkZjM0NzFkYjI5ZGYxNDk2ZDMuLmQyMDllYjMzNjVmYWM4NWQ5 ZDJjMTg2YTJkOWIzY2VlOTQwODg3NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL2VmbC9EaXNwYXRjaFF1ZXVlV29ya0l0ZW1FZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9lZmwvRGlzcGF0Y2hRdWV1ZVdvcmtJdGVtRWZsLmgKQEAgLTU0LDIzICs1NCwyMyBA QCBwcml2YXRlOgogCiBjbGFzcyBUaW1lcldvcmtJdGVtIDogcHVibGljIFdvcmtJdGVtIHsKIHB1 YmxpYzoKLSAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPFRpbWVyV29ya0l0ZW0+IGNyZWF0ZShQ YXNzUmVmUHRyPFdvcmtRdWV1ZT4gd29ya1F1ZXVlLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGZ1 bmN0aW9uLCBzdGQ6OmNocm9ubzo6bmFub3NlY29uZHMgZGVsYXkpCisgICAgc3RhdGljIHN0ZDo6 dW5pcXVlX3B0cjxUaW1lcldvcmtJdGVtPiBjcmVhdGUoUGFzc1JlZlB0cjxXb3JrUXVldWU+IHdv cmtRdWV1ZSwgc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlvbiwgc3RkOjpjaHJvbm86Om5h bm9zZWNvbmRzIGRlbGF5TmFub1NlY29uZHMpCiAgICAgewotICAgICAgICBBU1NFUlQoZGVsYXku Y291bnQoKSA+PSAwKTsKLSAgICAgICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxUaW1lcldvcmtJ dGVtPihuZXcgVGltZXJXb3JrSXRlbSh3b3JrUXVldWUsIHN0ZDo6bW92ZShmdW5jdGlvbiksIG1v bm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpICsgZGVsYXkuY291bnQoKSAvIDEwMDAwMDAwMDBV TEwpKTsKKyAgICAgICAgQVNTRVJUKGRlbGF5TmFub1NlY29uZHMuY291bnQoKSA+PSAwKTsKKyAg ICAgICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxUaW1lcldvcmtJdGVtPihuZXcgVGltZXJXb3Jr SXRlbSh3b3JrUXVldWUsIHN0ZDo6bW92ZShmdW5jdGlvbiksIG1vbm90b25pY2FsbHlJbmNyZWFz aW5nVGltZSgpICogMTAwMDAwMDAwMC4wICsgZGVsYXlOYW5vU2Vjb25kcy5jb3VudCgpKSk7CiAg ICAgfQotICAgIGRvdWJsZSBleHBpcmF0aW9uVGltZVNlY29uZHMoKSBjb25zdCB7IHJldHVybiBt X2V4cGlyYXRpb25UaW1lU2Vjb25kczsgfQotICAgIGJvb2wgaGFzRXhwaXJlZChkb3VibGUgY3Vy cmVudFRpbWVTZWNvbmRzKSBjb25zdCB7IHJldHVybiBjdXJyZW50VGltZVNlY29uZHMgPj0gbV9l eHBpcmF0aW9uVGltZVNlY29uZHM7IH0KKyAgICBkb3VibGUgZXhwaXJhdGlvblRpbWVOYW5vU2Vj b25kcygpIGNvbnN0IHsgcmV0dXJuIG1fZXhwaXJhdGlvblRpbWVOYW5vU2Vjb25kczsgfQorICAg IGJvb2wgaGFzRXhwaXJlZChkb3VibGUgY3VycmVudFRpbWVOYW5vU2Vjb25kcykgY29uc3QgeyBy ZXR1cm4gY3VycmVudFRpbWVOYW5vU2Vjb25kcyA+PSBtX2V4cGlyYXRpb25UaW1lTmFub1NlY29u ZHM7IH0KIAogcHJvdGVjdGVkOgotICAgIFRpbWVyV29ya0l0ZW0oUGFzc1JlZlB0cjxXb3JrUXVl dWU+IHdvcmtRdWV1ZSwgc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlvbiwgZG91YmxlIGV4 cGlyYXRpb25UaW1lU2Vjb25kcykKKyAgICBUaW1lcldvcmtJdGVtKFBhc3NSZWZQdHI8V29ya1F1 ZXVlPiB3b3JrUXVldWUsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4gZnVuY3Rpb24sIGRvdWJsZSBl eHBpcmF0aW9uVGltZU5hbm9TZWNvbmRzKQogICAgICAgICA6IFdvcmtJdGVtKHdvcmtRdWV1ZSwg c3RkOjptb3ZlKGZ1bmN0aW9uKSkKLSAgICAgICAgLCBtX2V4cGlyYXRpb25UaW1lU2Vjb25kcyhl eHBpcmF0aW9uVGltZVNlY29uZHMpCisgICAgICAgICwgbV9leHBpcmF0aW9uVGltZU5hbm9TZWNv bmRzKGV4cGlyYXRpb25UaW1lTmFub1NlY29uZHMpCiAgICAgewogICAgIH0KIAogcHJpdmF0ZToK LSAgICBkb3VibGUgbV9leHBpcmF0aW9uVGltZVNlY29uZHM7CisgICAgZG91YmxlIG1fZXhwaXJh dGlvblRpbWVOYW5vU2Vjb25kczsKIH07CiAKICNlbmRpZiAvLyBEaXNwYXRjaFF1ZXVlV29ya0l0 ZW1FZmxfaAo=