<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>127250</bug_id>
          
          <creation_ts>2014-01-19 10:06:54 -0800</creation_ts>
          <short_desc>Modernize ReverbConvolver</short_desc>
          <delta_ts>2014-01-19 10:16:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>969595</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-01-19 10:06:54 -0800</bug_when>
    <thetext>Modernize ThreadConvolver</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>969596</commentid>
    <comment_count>1</comment_count>
      <attachid>221587</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-01-19 10:10:50 -0800</bug_when>
    <thetext>Created attachment 221587
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>969597</commentid>
    <comment_count>2</comment_count>
      <attachid>221587</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2014-01-19 10:14:53 -0800</bug_when>
    <thetext>Comment on attachment 221587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221587&amp;action=review

&gt; Source/WebCore/ChangeLog:4
&gt; +        Modernize ReverbConvolver
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=127250

Kinda thin ChangeLog here, Carlsson.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>969598</commentid>
    <comment_count>3</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-01-19 10:16:30 -0800</bug_when>
    <thetext>Committed r162291: &lt;http://trac.webkit.org/changeset/162291&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>221587</attachid>
            <date>2014-01-19 10:10:50 -0800</date>
            <delta_ts>2014-01-19 10:16:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-127250-20140119101049.patch</filename>
            <type>text/plain</type>
            <size>6023</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjJjMWFiYzA3MjhmZTQw
NjA2YzM2NTAxODBlNDUzYzRmMzhjM2QxMC4uMmQ0M2Q5NWE3OGYzYmEwMTIwMjFlZGIwOTZlODRm
YmZjMmU5OGU4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTE5ICBBbmRl
cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTW9kZXJuaXplIFJl
dmVyYkNvbnZvbHZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTI3MjUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBwbGF0Zm9ybS9hdWRpby9SZXZlcmJDb252b2x2ZXIuY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6UmV2ZXJiQ29udm9sdmVyOjpSZXZlcmJDb252b2x2ZXIpOgorICAgICAgICAoV2ViQ29y
ZTo6UmV2ZXJiQ29udm9sdmVyOjp+UmV2ZXJiQ29udm9sdmVyKToKKyAgICAgICAgKFdlYkNvcmU6
OlJldmVyYkNvbnZvbHZlcjo6YmFja2dyb3VuZFRocmVhZEVudHJ5KToKKyAgICAgICAgKFdlYkNv
cmU6OlJldmVyYkNvbnZvbHZlcjo6cHJvY2Vzcyk6CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8v
UmV2ZXJiQ29udm9sdmVyLmg6CisKIDIwMTQtMDEtMTggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBw
bGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJlbmFtZSBHZXN0dXJlRXZlbnRJT1Mue2NwcCxofSB0
byBHZXN0dXJlRXZlbnQue2NwcCxofSB0byBmaXggdGhlIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9SZXZlcmJDb252b2x2ZXIuY3BwIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vYXVkaW8vUmV2ZXJiQ29udm9sdmVyLmNwcAppbmRleCBhNWYwN2UwOTU0
NWM0NDQ4NjM0ZWFlOTYwMDg2YzhjMDIxMGYzNWM4Li43ZjdiMTE5ZjA2OWY0ZWVmNDEwYmMxNGYz
NzhkMjgzNjQ0ZWI0MWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp
by9SZXZlcmJDb252b2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv
L1JldmVyYkNvbnZvbHZlci5jcHAKQEAgLTEwMiwxNSArMTAyLDE1IEBAIFJldmVyYkNvbnZvbHZl
cjo6UmV2ZXJiQ29udm9sdmVyKEF1ZGlvQ2hhbm5lbCogaW1wdWxzZVJlc3BvbnNlLCBzaXplX3Qg
cmVuZGVyU2xpCiAKICAgICAgICAgYm9vbCB1c2VEaXJlY3RDb252b2x2ZXIgPSAhc3RhZ2VPZmZz
ZXQ7CiAKLSAgICAgICAgT3duUHRyPFJldmVyYkNvbnZvbHZlclN0YWdlPiBzdGFnZSA9IGFkb3B0
UHRyKG5ldyBSZXZlcmJDb252b2x2ZXJTdGFnZShyZXNwb25zZSwgdG90YWxSZXNwb25zZUxlbmd0
aCwgcmV2ZXJiVG90YWxMYXRlbmN5LCBzdGFnZU9mZnNldCwgc3RhZ2VTaXplLCBmZnRTaXplLCBy
ZW5kZXJQaGFzZSwgcmVuZGVyU2xpY2VTaXplLCAmbV9hY2N1bXVsYXRpb25CdWZmZXIsIHVzZURp
cmVjdENvbnZvbHZlcikpOworICAgICAgICBhdXRvIHN0YWdlID0gc3RkOjptYWtlX3VuaXF1ZTxS
ZXZlcmJDb252b2x2ZXJTdGFnZT4ocmVzcG9uc2UsIHRvdGFsUmVzcG9uc2VMZW5ndGgsIHJldmVy
YlRvdGFsTGF0ZW5jeSwgc3RhZ2VPZmZzZXQsIHN0YWdlU2l6ZSwgZmZ0U2l6ZSwgcmVuZGVyUGhh
c2UsIHJlbmRlclNsaWNlU2l6ZSwgJm1fYWNjdW11bGF0aW9uQnVmZmVyLCB1c2VEaXJlY3RDb252
b2x2ZXIpOwogCiAgICAgICAgIGJvb2wgaXNCYWNrZ3JvdW5kU3RhZ2UgPSBmYWxzZTsKIAogICAg
ICAgICBpZiAodGhpcy0+dXNlQmFja2dyb3VuZFRocmVhZHMoKSAmJiBzdGFnZU9mZnNldCA+IFJl
YWx0aW1lRnJhbWVMaW1pdCkgewotICAgICAgICAgICAgbV9iYWNrZ3JvdW5kU3RhZ2VzLmFwcGVu
ZChzdGFnZS5yZWxlYXNlKCkpOworICAgICAgICAgICAgbV9iYWNrZ3JvdW5kU3RhZ2VzLmFwcGVu
ZChzdGQ6Om1vdmUoc3RhZ2UpKTsKICAgICAgICAgICAgIGlzQmFja2dyb3VuZFN0YWdlID0gdHJ1
ZTsKICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICBtX3N0YWdlcy5hcHBlbmQoc3RhZ2UucmVs
ZWFzZSgpKTsKKyAgICAgICAgICAgIG1fc3RhZ2VzLmFwcGVuZChzdGQ6Om1vdmUoc3RhZ2UpKTsK
IAogICAgICAgICBzdGFnZU9mZnNldCArPSBzdGFnZVNpemU7CiAgICAgICAgICsraTsKQEAgLTE0
MCw5ICsxNDAsOSBAQCBSZXZlcmJDb252b2x2ZXI6On5SZXZlcmJDb252b2x2ZXIoKQogCiAgICAg
ICAgIC8vIFdha2UgdXAgdGhyZWFkIHNvIGl0IGNhbiByZXR1cm4KICAgICAgICAgewotICAgICAg
ICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fYmFja2dyb3VuZFRocmVhZExvY2spOworICAgICAg
ICAgICAgc3RkOjpsb2NrX2d1YXJkPHN0ZDo6bXV0ZXg+IGxvY2sobV9iYWNrZ3JvdW5kVGhyZWFk
TXV0ZXgpOwogICAgICAgICAgICAgbV9tb3JlSW5wdXRCdWZmZXJlZCA9IHRydWU7Ci0gICAgICAg
ICAgICBtX2JhY2tncm91bmRUaHJlYWRDb25kaXRpb24uc2lnbmFsKCk7CisgICAgICAgICAgICBt
X2JhY2tncm91bmRUaHJlYWRDb25kaXRpb25WYXJpYWJsZS5ub3RpZnlfb25lKCk7CiAgICAgICAg
IH0KIAogICAgICAgICB3YWl0Rm9yVGhyZWFkQ29tcGxldGlvbihtX2JhY2tncm91bmRUaHJlYWQp
OwpAQCAtMTU1LDkgKzE1NSw5IEBAIHZvaWQgUmV2ZXJiQ29udm9sdmVyOjpiYWNrZ3JvdW5kVGhy
ZWFkRW50cnkoKQogICAgICAgICAvLyBXYWl0IGZvciByZWFsdGltZSB0aHJlYWQgdG8gZ2l2ZSB1
cyBtb3JlIGlucHV0CiAgICAgICAgIG1fbW9yZUlucHV0QnVmZmVyZWQgPSBmYWxzZTsgICAgICAg
IAogICAgICAgICB7Ci0gICAgICAgICAgICBNdXRleExvY2tlciBsb2NrZXIobV9iYWNrZ3JvdW5k
VGhyZWFkTG9jayk7Ci0gICAgICAgICAgICB3aGlsZSAoIW1fbW9yZUlucHV0QnVmZmVyZWQgJiYg
IW1fd2FudHNUb0V4aXQpCi0gICAgICAgICAgICAgICAgbV9iYWNrZ3JvdW5kVGhyZWFkQ29uZGl0
aW9uLndhaXQobV9iYWNrZ3JvdW5kVGhyZWFkTG9jayk7CisgICAgICAgICAgICBzdGQ6OnVuaXF1
ZV9sb2NrPHN0ZDo6bXV0ZXg+IGxvY2sobV9iYWNrZ3JvdW5kVGhyZWFkTXV0ZXgpOworCisgICAg
ICAgICAgICBtX2JhY2tncm91bmRUaHJlYWRDb25kaXRpb25WYXJpYWJsZS53YWl0KGxvY2ssIFt0
aGlzXSB7IHJldHVybiBtX21vcmVJbnB1dEJ1ZmZlcmVkIHx8IG1fd2FudHNUb0V4aXQ7IH0pOwog
ICAgICAgICB9CiAKICAgICAgICAgLy8gUHJvY2VzcyBhbGwgb2YgdGhlIHN0YWdlcyB1bnRpbCB0
aGVpciByZWFkIGluZGljZXMgcmVhY2ggdGhlIGlucHV0IGJ1ZmZlcidzIHdyaXRlIGluZGV4CkBA
IC0yMDQsMTYgKzIwNCwxNyBAQCB2b2lkIFJldmVyYkNvbnZvbHZlcjo6cHJvY2Vzcyhjb25zdCBB
dWRpb0NoYW5uZWwqIHNvdXJjZUNoYW5uZWwsIEF1ZGlvQ2hhbm5lbCogZAogICAgICAgICAKICAg
ICAvLyBOb3cgdGhhdCB3ZSd2ZSBidWZmZXJlZCBtb3JlIGlucHV0LCB3YWtlIHVwIG91ciBiYWNr
Z3JvdW5kIHRocmVhZC4KICAgICAKLSAgICAvLyBOb3QgdXNpbmcgYSBNdXRleExvY2tlciBsb29r
cyBzdHJhbmdlLCBidXQgd2UgdXNlIGEgdHJ5TG9jaygpIGluc3RlYWQgYmVjYXVzZSB0aGlzIGlz
IHJ1biBvbiB0aGUgcmVhbC10aW1lCisgICAgLy8gV2UgdXNlIHVzZSBzdGQ6OnVuaXF1ZV9sb2Nr
IHdpdGggc3RkOjp0cnlfbG9jayBoZXJlIGJlY2F1c2UgdGhpcyBpcyBydW4gb24gdGhlIHJlYWwt
dGltZQogICAgIC8vIHRocmVhZCB3aGVyZSBpdCBpcyBhIGRpc2FzdGVyIGZvciB0aGUgbG9jayB0
byBiZSBjb250ZW5kZWQgKGNhdXNlcyBhdWRpbyBnbGl0Y2hpbmcpLiAgSXQncyBPSyBpZiB3ZSBm
YWlsIHRvCiAgICAgLy8gc2lnbmFsIGZyb20gdGltZSB0byB0aW1lLCBzaW5jZSB3ZSdsbCBnZXQg
dG8gaXQgdGhlIG5leHQgdGltZSB3ZSdyZSBjYWxsZWQuICBXZSdyZSBjYWxsZWQgcmVwZWF0ZWRs
eQogICAgIC8vIGFuZCBmcmVxdWVudGx5IChhcm91bmQgZXZlcnkgM21zKS4gIFRoZSBiYWNrZ3Jv
dW5kIHRocmVhZCBpcyBwcm9jZXNzaW5nIHdlbGwgaW50byB0aGUgZnV0dXJlIGFuZCBoYXMgYSBj
b25zaWRlcmFibGUgYW1vdW50IG9mIAogICAgIC8vIGxlZXdheSBoZXJlLi4uCi0gICAgaWYgKG1f
YmFja2dyb3VuZFRocmVhZExvY2sudHJ5TG9jaygpKSB7Ci0gICAgICAgIG1fbW9yZUlucHV0QnVm
ZmVyZWQgPSB0cnVlOwotICAgICAgICBtX2JhY2tncm91bmRUaHJlYWRDb25kaXRpb24uc2lnbmFs
KCk7Ci0gICAgICAgIG1fYmFja2dyb3VuZFRocmVhZExvY2sudW5sb2NrKCk7Ci0gICAgfQorICAg
IHN0ZDo6dW5pcXVlX2xvY2s8c3RkOjptdXRleD4gbG9jayhtX2JhY2tncm91bmRUaHJlYWRNdXRl
eCwgc3RkOjp0cnlfdG9fbG9jayk7CisgICAgaWYgKCFsb2NrLm93bnNfbG9jaygpKQorICAgICAg
ICByZXR1cm47CisKKyAgICBtX21vcmVJbnB1dEJ1ZmZlcmVkID0gdHJ1ZTsKKyAgICBtX2JhY2tn
cm91bmRUaHJlYWRDb25kaXRpb25WYXJpYWJsZS5ub3RpZnlfb25lKCk7CiB9CiAKIHZvaWQgUmV2
ZXJiQ29udm9sdmVyOjpyZXNldCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9hdWRpby9SZXZlcmJDb252b2x2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv
L1JldmVyYkNvbnZvbHZlci5oCmluZGV4IDgzZmJmZTE5MTE4ZDAyMWNjOTQ2OWZkODM4NjA1Mzc5
OTAwZmIwZjAuLjFkMzgxOWRiYTdkMmM3NjMxZjQ3OTMzMWZjYjFjOGUzMjJjZTUyOGEgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1JldmVyYkNvbnZvbHZlci5oCisr
KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1JldmVyYkNvbnZvbHZlci5oCkBAIC0z
NSw3ICszNSw4IEBACiAjaW5jbHVkZSAiUmV2ZXJiQWNjdW11bGF0aW9uQnVmZmVyLmgiCiAjaW5j
bHVkZSAiUmV2ZXJiQ29udm9sdmVyU3RhZ2UuaCIKICNpbmNsdWRlICJSZXZlcmJJbnB1dEJ1ZmZl
ci5oIgotI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyNpbmNsdWRlIDxjb25kaXRpb25fdmFyaWFi
bGU+CisjaW5jbHVkZSA8bXV0ZXg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNs
dWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgpAQCAtNjUsOCAr
NjYsOCBAQCBwdWJsaWM6CiAKICAgICBzaXplX3QgbGF0ZW5jeUZyYW1lcygpIGNvbnN0OwogcHJp
dmF0ZToKLSAgICBWZWN0b3I8T3duUHRyPFJldmVyYkNvbnZvbHZlclN0YWdlPj4gbV9zdGFnZXM7
Ci0gICAgVmVjdG9yPE93blB0cjxSZXZlcmJDb252b2x2ZXJTdGFnZT4+IG1fYmFja2dyb3VuZFN0
YWdlczsKKyAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPFJldmVyYkNvbnZvbHZlclN0YWdlPj4g
bV9zdGFnZXM7CisgICAgVmVjdG9yPHN0ZDo6dW5pcXVlX3B0cjxSZXZlcmJDb252b2x2ZXJTdGFn
ZT4+IG1fYmFja2dyb3VuZFN0YWdlczsKICAgICBzaXplX3QgbV9pbXB1bHNlUmVzcG9uc2VMZW5n
dGg7CiAKICAgICBSZXZlcmJBY2N1bXVsYXRpb25CdWZmZXIgbV9hY2N1bXVsYXRpb25CdWZmZXI7
CkBAIC04Niw4ICs4Nyw4IEBAIHByaXZhdGU6CiAgICAgVGhyZWFkSWRlbnRpZmllciBtX2JhY2tn
cm91bmRUaHJlYWQ7CiAgICAgYm9vbCBtX3dhbnRzVG9FeGl0OwogICAgIGJvb2wgbV9tb3JlSW5w
dXRCdWZmZXJlZDsKLSAgICBtdXRhYmxlIE11dGV4IG1fYmFja2dyb3VuZFRocmVhZExvY2s7Ci0g
ICAgbXV0YWJsZSBUaHJlYWRDb25kaXRpb24gbV9iYWNrZ3JvdW5kVGhyZWFkQ29uZGl0aW9uOwor
ICAgIG11dGFibGUgc3RkOjptdXRleCBtX2JhY2tncm91bmRUaHJlYWRNdXRleDsKKyAgICBtdXRh
YmxlIHN0ZDo6Y29uZGl0aW9uX3ZhcmlhYmxlIG1fYmFja2dyb3VuZFRocmVhZENvbmRpdGlvblZh
cmlhYmxlOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>