127248 2014-01-19 04:44:11 -0800 Does not build with SVG disabled 2014-01-19 11:19:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned oldest_to_newest 969587 0 berto 2014-01-19 04:44:11 -0800 In file included from ../../Source/WebCore/dom/Element.h:30: ../../Source/WebCore/dom/ElementData.h:116:79: error: use of undeclared identifier 's_flagAnimatedSVGAttributesAreDirty'; did you mean 'setAnimatedSVGAttributesAreDirty'? This broke in r162274 969588 1 221583 berto 2014-01-19 04:45:15 -0800 Created attachment 221583 Patch 969607 2 221583 sam 2014-01-19 10:55:38 -0800 Comment on attachment 221583 Patch r=me. As a side question, why are you building without SVG? I don't think it makes sense in the long run for us to support this build style (any more than we should support a build without tables), so I would like to figure out what people are using this for. 969612 3 berto 2014-01-19 11:09:00 -0800 Committed r162295: <http://trac.webkit.org/changeset/162295> 969613 4 berto 2014-01-19 11:19:26 -0800 (In reply to comment #2) > As a side question, why are you building without SVG? I do it once a while in my laptop because it takes less time. No other reason really. 221583 2014-01-19 04:45:15 -0800 2014-01-19 10:55:37 -0800 Patch 127248.diff text/plain 1418 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MmMxYWJjLi5jMjIzNmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDEtMTkgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBEb2VzIG5vdCBidWlsZCB3aXRoIFNWRyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MjQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgI2lmIEVOQUJMRShTVkcp IGd1YXJkLgorCisgICAgICAgICogZG9tL0VsZW1lbnREYXRhLmg6CisKIDIwMTQtMDEtMTggIEFu ZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJlbmFtZSBHZXN0 dXJlRXZlbnRJT1Mue2NwcCxofSB0byBHZXN0dXJlRXZlbnQue2NwcCxofSB0byBmaXggdGhlIGJ1 aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudERhdGEuaCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50RGF0YS5oCmluZGV4IDYzZWJhYzUuLjUwZGYwNTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50RGF0YS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50RGF0YS5oCkBAIC0xMTMsOCArMTEzLDEwIEBAIHByb3RlY3RlZDoKICAg ICBib29sIHByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0eWxlSXNEaXJ0eSgpIGNvbnN0IHsgcmV0dXJu IG1fYXJyYXlTaXplQW5kRmxhZ3MgJiBzX2ZsYWdQcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZUlz RGlydHk7IH0KICAgICB2b2lkIHNldFByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0eWxlSXNEaXJ0eShi b29sIGlzRGlydHkpIGNvbnN0IHsgdXBkYXRlRmxhZyhzX2ZsYWdQcmVzZW50YXRpb25BdHRyaWJ1 dGVTdHlsZUlzRGlydHksIGlzRGlydHkpOyB9CiAKKyNpZiBFTkFCTEUoU1ZHKQogICAgIGJvb2wg YW5pbWF0ZWRTVkdBdHRyaWJ1dGVzQXJlRGlydHkoKSBjb25zdCB7IHJldHVybiBtX2FycmF5U2l6 ZUFuZEZsYWdzICYgc19mbGFnQW5pbWF0ZWRTVkdBdHRyaWJ1dGVzQXJlRGlydHk7IH0KICAgICB2 b2lkIHNldEFuaW1hdGVkU1ZHQXR0cmlidXRlc0FyZURpcnR5KGJvb2wgZGlydHkpIGNvbnN0IHsg dXBkYXRlRmxhZyhzX2ZsYWdBbmltYXRlZFNWR0F0dHJpYnV0ZXNBcmVEaXJ0eSwgZGlydHkpOyB9 CisjZW5kaWYKIAogICAgIG11dGFibGUgUmVmUHRyPFN0eWxlUHJvcGVydGllcz4gbV9pbmxpbmVT dHlsZTsKICAgICBtdXRhYmxlIFNwYWNlU3BsaXRTdHJpbmcgbV9jbGFzc05hbWVzOwo=