127241 2014-01-18 16:24:07 -0800 Memory leak in JSSubtleCrypto::wrapKey 2014-01-18 22:35:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca commit-queue sam oldest_to_newest 969555 0 ap 2014-01-18 16:24:07 -0800 Where is my C++14? 969556 1 221576 ap 2014-01-18 16:25:59 -0800 Created attachment 221576 proposed patch 969565 2 221576 commit-queue 2014-01-18 18:10:32 -0800 Comment on attachment 221576 proposed patch Rejecting attachment 221576 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 221576, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5722464168443904 969578 3 ap 2014-01-18 22:35:31 -0800 Committed <http://trac.webkit.org/changeset/162287>. 221576 2014-01-18 16:25:59 -0800 2014-01-18 18:10:32 -0800 proposed patch CryptoLeak.txt text/plain 1881 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjI4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDE0LTAxLTE4ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE1lbW9yeSBsZWFrIGluIEpT U3VidGxlQ3J5cHRvOjp3cmFwS2V5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjcyNDEKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTU3VidGxlQ3J5 cHRvQ3VzdG9tLmNwcDogKFdlYkNvcmU6OkpTU3VidGxlQ3J5cHRvOjp3cmFwS2V5KToKKyAgICAg ICAgRGVsZXRlIGFsZ29yaXRobVB0ciBhbmQgcGFyYW1ldGVyc1B0ciB0aGF0IGFyZW4ndCBzbWFy dCBwb2ludGVycyBiZWNhdXNlIG9mIGxhbWJkYXMuCisKIDIwMTQtMDEtMTggIEFsYmVydG8gR2Fy Y2lhICA8YmVydG9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ29kZUdlbmVyYXRvckpTXSBTb3J0 IG91dHB1dCBvZiBTdHJ1Y3R1cmVGbGFncyBhbmQgZnVuY3Rpb24gcGFyYW1ldGVycwpJbmRleDog U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNTdWJ0bGVDcnlwdG9DdXN0b20uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTU3VidGxlQ3J5cHRvQ3VzdG9t LmNwcAkocmV2aXNpb24gMTYyMjgxKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNT dWJ0bGVDcnlwdG9DdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NjIsMTAgKzY2MiwxNCBA QCBKU1ZhbHVlIEpTU3VidGxlQ3J5cHRvOjp3cmFwS2V5KEV4ZWNTdGF0CiAgICAgQ3J5cHRvQWxn b3JpdGhtUGFyYW1ldGVycyogcGFyYW1ldGVyc1B0ciA9IHBhcmFtZXRlcnMucmVsZWFzZSgpOwog CiAgICAgYXV0byBleHBvcnRTdWNjZXNzQ2FsbGJhY2sgPSBba2V5Rm9ybWF0LCBhbGdvcml0aG1Q dHIsIHBhcmFtZXRlcnNQdHIsIHdyYXBwaW5nS2V5LCB3cmFwcGVyXShjb25zdCBWZWN0b3I8dWlu dDhfdD4mIGV4cG9ydGVkS2V5RGF0YSkgbXV0YWJsZSB7Ci0gICAgICAgIGF1dG8gZW5jcnlwdFN1 Y2Nlc3NDYWxsYmFjayA9IFt3cmFwcGVyXShjb25zdCBWZWN0b3I8dWludDhfdD4mIGVuY3J5cHRl ZERhdGEpIG11dGFibGUgeworICAgICAgICBhdXRvIGVuY3J5cHRTdWNjZXNzQ2FsbGJhY2sgPSBb d3JhcHBlciwgYWxnb3JpdGhtUHRyLCBwYXJhbWV0ZXJzUHRyXShjb25zdCBWZWN0b3I8dWludDhf dD4mIGVuY3J5cHRlZERhdGEpIG11dGFibGUgeworICAgICAgICAgICAgZGVsZXRlIGFsZ29yaXRo bVB0cjsKKyAgICAgICAgICAgIGRlbGV0ZSBwYXJhbWV0ZXJzUHRyOwogICAgICAgICAgICAgd3Jh cHBlci5yZXNvbHZlKGVuY3J5cHRlZERhdGEpOwogICAgICAgICB9OwotICAgICAgICBhdXRvIGVu Y3J5cHRGYWlsdXJlQ2FsbGJhY2sgPSBbd3JhcHBlcl0oKSBtdXRhYmxlIHsKKyAgICAgICAgYXV0 byBlbmNyeXB0RmFpbHVyZUNhbGxiYWNrID0gW3dyYXBwZXIsIGFsZ29yaXRobVB0ciwgcGFyYW1l dGVyc1B0cl0oKSBtdXRhYmxlIHsKKyAgICAgICAgICAgIGRlbGV0ZSBhbGdvcml0aG1QdHI7Cisg ICAgICAgICAgICBkZWxldGUgcGFyYW1ldGVyc1B0cjsKICAgICAgICAgICAgIHdyYXBwZXIucmVq ZWN0KG51bGxwdHIpOwogICAgICAgICB9OwogICAgICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsK