127230 2014-01-18 11:51:11 -0800 Add a hasBreakpointFlag arg to the op_debug bytecode 2014-01-18 13:07:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 122836 1 mark.lam mark.lam commit-queue fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 969493 0 mark.lam 2014-01-18 11:51:11 -0800 This is in anticipation of upcoming changes to support bytecode level breakpoints. This patch adds the flag to the op_debug bytecode and initializes it, but does not use it yet. 969495 1 221563 mark.lam 2014-01-18 11:55:06 -0800 Created attachment 221563 the patch. 969503 2 221563 ggaren 2014-01-18 12:38:46 -0800 Comment on attachment 221563 the patch. r=me 969507 3 221563 commit-queue 2014-01-18 13:07:40 -0800 Comment on attachment 221563 the patch. Clearing flags on attachment: 221563 Committed r162270: <http://trac.webkit.org/changeset/162270> 969508 4 commit-queue 2014-01-18 13:07:43 -0800 All reviewed patches have been landed. Closing bug. 221563 2014-01-18 11:55:06 -0800 2014-01-18 13:07:40 -0800 the patch. bug-127230.patch text/plain 3348 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyMjY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTAxLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgYSBoYXNCcmVha3BvaW50RmxhZyBhcmcgdG8gdGhlIG9wX2RlYnVnIGJ5dGVjb2RlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MjMwLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgaW4g YW50aWNpcGF0aW9uIG9mIHVwY29taW5nIGNoYW5nZXMgdG8gc3VwcG9ydCBieXRlY29kZSBsZXZl bAorICAgICAgICBicmVha3BvaW50cy4gVGhpcyBwYXRjaCBhZGRzIHRoZSBmbGFnIHRvIHRoZSBv cF9kZWJ1ZyBieXRlY29kZSBhbmQKKyAgICAgICAgaW5pdGlhbGl6ZXMgaXQsIGJ1dCBkb2VzIG5v dCB1c2UgaXQgeWV0LgorCisgICAgICAgICogYnl0ZWNvZGUvT3Bjb2RlLmg6CisgICAgICAgIChK U0M6OnBhZE9wY29kZU5hbWUpOgorICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVy YXRvci5jcHA6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0RGVidWdIb29r KToKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbToKKwogMjAxNC0wMS0x OCAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEphdmFTY3Jp cHRDb3JlIHVzZXMgUExBVEZPUk0oTUFDKSB3aGVuIGl0IG1lYW5zIE9TKERBUldJTikKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgJKHJldmlzaW9uIDE2MjI1NykK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaAkod29ya2luZyBjb3B5 KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDgsIDIwMDksIDIwMTMg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA4LCAy MDA5LCAyMDEzLCAyMDE0IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHly aWdodCAoQykgMjAwOCBDYW1lcm9uIFp3YXJpY2ggPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CiAg KgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywg d2l0aCBvciB3aXRob3V0CkBAIC0xODUsNyArMTg1LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAg bWFjcm8ob3BfdGhyb3csIDIpIFwKICAgICBtYWNybyhvcF90aHJvd19zdGF0aWNfZXJyb3IsIDMp IFwKICAgICBcCi0gICAgbWFjcm8ob3BfZGVidWcsIDIpIFwKKyAgICBtYWNybyhvcF9kZWJ1Zywg MykgXAogICAgIG1hY3JvKG9wX3Byb2ZpbGVfd2lsbF9jYWxsLCAyKSBcCiAgICAgbWFjcm8ob3Bf cHJvZmlsZV9kaWRfY2FsbCwgMikgXAogICAgIFwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCShyZXZp c2lvbiAxNjIyNTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVj b2RlR2VuZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBD b3B5cmlnaHQgKEMpIDIwMDgsIDIwMDksIDIwMTIsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5LCAyMDEyLCAyMDEzLCAyMDE0 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwOCBD YW1lcm9uIFp3YXJpY2ggPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CiAgKiBDb3B5cmlnaHQgKEMp IDIwMTIgSWdhbGlhLCBTLkwuCiAgKgpAQCAtMTk1MCw2ICsxOTUwLDcgQEAgdm9pZCBCeXRlY29k ZUdlbmVyYXRvcjo6ZW1pdERlYnVnSG9vayhEZQogICAgIGVtaXRFeHByZXNzaW9uSW5mbyhkaXZv dCwgZGl2b3QsIGRpdm90KTsKICAgICBlbWl0T3Bjb2RlKG9wX2RlYnVnKTsKICAgICBpbnN0cnVj dGlvbnMoKS5hcHBlbmQoZGVidWdIb29rSUQpOworICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChm YWxzZSk7CiB9CiAKIHZvaWQgQnl0ZWNvZGVHZW5lcmF0b3I6OnB1c2hGaW5hbGx5Q29udGV4dChT dGF0ZW1lbnROb2RlKiBmaW5hbGx5QmxvY2spCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCShyZXZpc2lvbiAxNjIyNTcp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20J KHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi0jIENvcHlyaWdodCAoQykgMjAxMSwgMjAx MiwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykg MjAxMSwgMjAxMiwgMjAxMywgMjAxNCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAj CiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTg0NCw3ICs4NDQsNyBAQCBfbGxpbnRfb3Bf ZGVidWc6CiAKICAgICBjYWxsU2xvd1BhdGgoX2xsaW50X3Nsb3dfcGF0aF9kZWJ1ZykKIC5vcERl YnVnRG9uZTogICAgICAgICAgICAgICAgICAgIAotICAgIGRpc3BhdGNoKDIpCisgICAgZGlzcGF0 Y2goMykKIAogCiBfbGxpbnRfbmF0aXZlX2NhbGxfdHJhbXBvbGluZToK