127229 2014-01-18 11:38:59 -0800 XMLTreeViewer shouldn't use the view source mode 2014-01-18 12:30:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 969488 0 andersca 2014-01-18 11:38:59 -0800 XMLTreeViewer shouldn't use the view source mode 969489 1 221561 andersca 2014-01-18 11:41:10 -0800 Created attachment 221561 Patch 969492 2 221561 kling 2014-01-18 11:45:22 -0800 Comment on attachment 221561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221561&action=review OK r=me > Source/WebCore/ChangeLog:8 > + Add the relevant styles from view-source.css to XMLViewer.css. I take it view-source.css is going away after this. 969500 3 andersca 2014-01-18 12:30:49 -0800 Committed r162269: <http://trac.webkit.org/changeset/162269> 221561 2014-01-18 11:41:10 -0800 2014-01-18 11:45:22 -0800 Patch bug-127229-20140118114109.patch text/plain 5416 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODliYWJiNmM2YWNhOGRk OTUzNjgwZWFiYzdlMDQxNmZjZWMzOWQxYS4uYWRkOWE0NjI5ZDhmYjM3ZTQ4YzVmOTE3YzMzODAz ZWVjOGQzNDc2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE0LTAxLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgWE1MVHJlZVZpZXdl ciBzaG91bGRuJ3QgdXNlIHRoZSB2aWV3IHNvdXJjZSBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcyMjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIHJlbGV2YW50IHN0eWxlcyBmcm9t IHZpZXctc291cmNlLmNzcyB0byBYTUxWaWV3ZXIuY3NzLgorCisgICAgICAgICogeG1sL1hNTFRy ZWVWaWV3ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MVHJlZVZpZXdlcjo6dHJhbnNmb3Jt RG9jdW1lbnRUb1RyZWVWaWV3KToKKyAgICAgICAgKiB4bWwvWE1MVmlld2VyLmNzczoKKyAgICAg ICAgKGJvZHkpOgorICAgICAgICAoLmNvbW1lbnQpOgorICAgICAgICAoLnRhZyk6CisgICAgICAg ICguYXR0cmlidXRlLW5hbWUpOgorICAgICAgICAoLmF0dHJpYnV0ZS12YWx1ZSk6CisgICAgICAg ICogeG1sL1hNTFZpZXdlci5qczoKKyAgICAgICAgKGNyZWF0ZUNvbW1lbnQpOgorICAgICAgICAo Y3JlYXRlVGFnKToKKyAgICAgICAgKGNyZWF0ZUF0dHJpYnV0ZSk6CisKKzIwMTQtMDEtMTggIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgRU5B QkxFX1RIUkVBREVEX0hUTUxfUEFSU0VSIGRlZmluZXMgZXZlcnl3aGVyZQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MjI1CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3htbC9YTUxUcmVlVmlld2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3ht bC9YTUxUcmVlVmlld2VyLmNwcAppbmRleCBjMzllNzUyNDg3MjA4YTA4YjIxMjBkMTEwMWQ2Mjcw OTkwMmJiZDcxLi4yN2UxZjgwNDNkNTg3YjJmZWFlMTM0ODY0YmYyNWY0YzkyMGI1NjZkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MVHJlZVZpZXdlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUveG1sL1hNTFRyZWVWaWV3ZXIuY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5jbHVk ZSAiRnJhbWUuaCIKICNpbmNsdWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2Ny aXB0U291cmNlQ29kZS5oIgorI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5jbHVkZSAi VGV4dC5oIgogI2luY2x1ZGUgIlhNTFZpZXdlckNTUy5oIgogI2luY2x1ZGUgIlhNTFZpZXdlckpT LmgiCkBAIC01MiwxMyArNTMsMTQgQEAgWE1MVHJlZVZpZXdlcjo6WE1MVHJlZVZpZXdlcihEb2N1 bWVudCogZG9jdW1lbnQpCiAKIHZvaWQgWE1MVHJlZVZpZXdlcjo6dHJhbnNmb3JtRG9jdW1lbnRU b1RyZWVWaWV3KCkKIHsKLSAgICBtX2RvY3VtZW50LT5zZXRJc1ZpZXdTb3VyY2UodHJ1ZSk7Ci0g ICAgU3RyaW5nIHNjcmlwdFN0cmluZyhyZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihYTUxW aWV3ZXJfanMpLCBzaXplb2YoWE1MVmlld2VyX2pzKSk7CisgICAgbV9kb2N1bWVudC0+c2V0U2Vj dXJpdHlPcmlnaW4oU2VjdXJpdHlPcmlnaW46OmNyZWF0ZVVuaXF1ZSgpKTsKKworICAgIFN0cmlu ZyBzY3JpcHRTdHJpbmcgPSBTdHJpbmdJbXBsOjpjcmVhdGVXaXRob3V0Q29weWluZyhYTUxWaWV3 ZXJfanMsIHNpemVvZihYTUxWaWV3ZXJfanMpKTsKICAgICBtX2RvY3VtZW50LT5mcmFtZSgpLT5z Y3JpcHQoKS5ldmFsdWF0ZShTY3JpcHRTb3VyY2VDb2RlKHNjcmlwdFN0cmluZykpOwogICAgIFN0 cmluZyBub1N0eWxlTWVzc2FnZSgiVGhpcyBYTUwgZmlsZSBkb2VzIG5vdCBhcHBlYXIgdG8gaGF2 ZSBhbnkgc3R5bGUgaW5mb3JtYXRpb24gYXNzb2NpYXRlZCB3aXRoIGl0LiBUaGUgZG9jdW1lbnQg dHJlZSBpcyBzaG93biBiZWxvdy4iKTsKICAgICBtX2RvY3VtZW50LT5mcmFtZSgpLT5zY3JpcHQo KS5ldmFsdWF0ZShTY3JpcHRTb3VyY2VDb2RlKCJwcmVwYXJlV2ViS2l0WE1MVmlld2VyKCciICsg bm9TdHlsZU1lc3NhZ2UgKyAiJyk7IikpOwogCi0gICAgU3RyaW5nIGNzc1N0cmluZyhyZWludGVy cHJldF9jYXN0PGNvbnN0IGNoYXIqPihYTUxWaWV3ZXJfY3NzKSwgc2l6ZW9mKFhNTFZpZXdlcl9j c3MpKTsKKyAgICBTdHJpbmcgY3NzU3RyaW5nID0gU3RyaW5nSW1wbDo6Y3JlYXRlV2l0aG91dENv cHlpbmcoWE1MVmlld2VyX2Nzcywgc2l6ZW9mKFhNTFZpZXdlcl9jc3MpKTsKICAgICBSZWZQdHI8 VGV4dD4gdGV4dCA9IG1fZG9jdW1lbnQtPmNyZWF0ZVRleHROb2RlKGNzc1N0cmluZyk7CiAgICAg bV9kb2N1bWVudC0+Z2V0RWxlbWVudEJ5SWQoInhtbC12aWV3ZXItc3R5bGUiKS0+YXBwZW5kQ2hp bGQodGV4dCwgSUdOT1JFX0VYQ0VQVElPTik7CiAgICAgbV9kb2N1bWVudC0+c3R5bGVSZXNvbHZl ckNoYW5nZWQoUmVjYWxjU3R5bGVJbW1lZGlhdGVseSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS94bWwvWE1MVmlld2VyLmNzcyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxWaWV3ZXIuY3Nz CmluZGV4IDIyNzBhMDlhMjk2N2JhNDU2ZDk4YWU1ZWVjZjEzZjViYWQ1Zjg3ZjcuLjg1MTQ5OTI3 MjcwMzEyY2MwMjI4ZGJmYjQ4NWVhZDYwMmViNGU5NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3htbC9YTUxWaWV3ZXIuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxWaWV3ZXIu Y3NzCkBAIC0yNiw2ICsyNiwxMCBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJ U0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCitib2R5IHsKKyAg ICBtYXJnaW46IDAKK30KKwogZGl2LmhlYWRlciB7CiAgICAgYm9yZGVyLWJvdHRvbTogMnB4IHNv bGlkIGJsYWNrOwogICAgIHBhZGRpbmctYm90dG9tOiA1cHg7CkBAIC00OCw5ICs1MiwyNyBAQCBk aXYuY29sbGFwc2libGUgPiBkaXYuaGlkZGVuIHsKIH0KIAogLmNvbW1lbnQgeworICAgIC8qIEtl ZXAgdGhpcyBpbiBzeW5jIHdpdGggaW5zcGVjdG9yLmNzcyAoLndlYmtpdC1odG1sLWNvbW1lbnQp ICovCisgICAgY29sb3I6IHJnYigzNSwgMTEwLCAzNyk7CisKICAgICB3aGl0ZS1zcGFjZTogcHJl OwogfQogCisudGFnIHsKKyAgICAvKiBLZWVwIHRoaXMgaW4gc3luYyB3aXRoIGluc3BlY3Rvci5j c3MgKC53ZWJraXQtaHRtbC10YWcpICovCisgICAgY29sb3I6IHJnYigxMzYsIDE4LCAxMjgpOwor fQorCisuYXR0cmlidXRlLW5hbWUgeworICAgIC8qIEtlZXAgdGhpcyBpbiBzeW5jIHdpdGggaW5z cGVjdG9yLmNzcyAoLndlYmtpdC1odG1sLWF0dHJpYnV0ZS1uYW1lKSAqLworICAgIGNvbG9yOiBy Z2IoMTUzLCA2OSwgMCk7Cit9CisKKy5hdHRyaWJ1dGUtdmFsdWUgeworICAgIC8qIEtlZXAgdGhp cyBpbiBzeW5jIHdpdGggaW5zcGVjdG9yLmNzcyAoLndlYmtpdC1odG1sLWF0dHJpYnV0ZS12YWx1 ZSkgKi8KKyAgICBjb2xvcjogcmdiKDI2LCAyNiwgMTY2KTsKK30KKwogLmJ1dHRvbiB7CiAgICAg LXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZTsKICAgICBjdXJzb3I6IHBvaW50ZXI7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MVmlld2VyLmpzIGIvU291cmNlL1dlYkNvcmUveG1s L1hNTFZpZXdlci5qcwppbmRleCBjYjY4Nzc1YjU2YTFmNTg2ODNlYjJmNzhiYjYzYmQ3MjUxMGNk YzBiLi41ZmRhNDg2N2I4MDhkNGY4Nzk3ZDk2YjljMGYyNGY2ZWUxMjJiNWQ5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MVmlld2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL3ht bC9YTUxWaWV3ZXIuanMKQEAgLTI4NCw3ICsyODQsNiBAQCBmdW5jdGlvbiBjcmVhdGVDb21tZW50 KGNvbW1lbnRTdHJpbmcpCiB7CiAgICAgdmFyIGNvbW1lbnQgPSBjcmVhdGVIVE1MRWxlbWVudCgn c3BhbicpOwogICAgIGNvbW1lbnQuY2xhc3NMaXN0LmFkZCgnY29tbWVudCcpOwotICAgIGNvbW1l bnQuY2xhc3NMaXN0LmFkZCgnd2Via2l0LWh0bWwtY29tbWVudCcpOwogICAgIGNvbW1lbnQudGV4 dENvbnRlbnQgPSBjb21tZW50U3RyaW5nOwogICAgIHJldHVybiBjb21tZW50OwogfQpAQCAtMzA3 LDcgKzMwNiw3IEBAIGZ1bmN0aW9uIGNyZWF0ZUxpbmUoKQogZnVuY3Rpb24gY3JlYXRlVGFnKG5v ZGUsIGlzQ2xvc2luZywgaXNFbXB0eSkKIHsKICAgICB2YXIgdGFnID0gY3JlYXRlSFRNTEVsZW1l bnQoJ3NwYW4nKTsKLSAgICB0YWcuY2xhc3NMaXN0LmFkZCgnd2Via2l0LWh0bWwtdGFnJyk7Cisg ICAgdGFnLmNsYXNzTGlzdC5hZGQoJ3RhZycpOwogCiAgICAgdmFyIHN0cmluZ0JlZm9yZUF0dHJz ID0gJzwnOwogICAgIGlmIChpc0Nsb3NpbmcpCkBAIC0zMzQsMTcgKzMzMywxNiBAQCBmdW5jdGlv biBjcmVhdGVUYWcobm9kZSwgaXNDbG9zaW5nLCBpc0VtcHR5KQogZnVuY3Rpb24gY3JlYXRlQXR0 cmlidXRlKGF0dHJpYnV0ZU5vZGUpCiB7CiAgICAgdmFyIGF0dHJpYnV0ZSA9IGNyZWF0ZUhUTUxF bGVtZW50KCdzcGFuJyk7Ci0gICAgYXR0cmlidXRlLmNsYXNzTGlzdC5hZGQoJ3dlYmtpdC1odG1s LWF0dHJpYnV0ZScpOwogCiAgICAgdmFyIGF0dHJpYnV0ZU5hbWUgPSBjcmVhdGVIVE1MRWxlbWVu dCgnc3BhbicpOwotICAgIGF0dHJpYnV0ZU5hbWUuY2xhc3NMaXN0LmFkZCgnd2Via2l0LWh0bWwt YXR0cmlidXRlLW5hbWUnKTsKKyAgICBhdHRyaWJ1dGVOYW1lLmNsYXNzTGlzdC5hZGQoJ2F0dHJp YnV0ZS1uYW1lJyk7CiAgICAgYXR0cmlidXRlTmFtZS50ZXh0Q29udGVudCA9IGF0dHJpYnV0ZU5v ZGUubmFtZTsKIAogICAgIHZhciB0ZXh0QmVmb3JlID0gZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUo JyAnKTsKICAgICB2YXIgdGV4dEJldHdlZW4gPSBkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnPSIn KTsKIAogICAgIHZhciBhdHRyaWJ1dGVWYWx1ZSA9IGNyZWF0ZUhUTUxFbGVtZW50KCdzcGFuJyk7 Ci0gICAgYXR0cmlidXRlVmFsdWUuY2xhc3NMaXN0LmFkZCgnd2Via2l0LWh0bWwtYXR0cmlidXRl LXZhbHVlJyk7CisgICAgYXR0cmlidXRlVmFsdWUuY2xhc3NMaXN0LmFkZCgnYXR0cmlidXRlLXZh bHVlJyk7CiAgICAgYXR0cmlidXRlVmFsdWUudGV4dENvbnRlbnQgPSBhdHRyaWJ1dGVOb2RlLnZh bHVlOwogCiAgICAgdmFyIHRleHRBZnRlciA9IGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCciJyk7 Cg==