127217 2014-01-18 06:44:21 -0800 Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method 2014-01-18 15:58:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned commit-queue dbates oldest_to_newest 969430 0 berto 2014-01-18 06:44:21 -0800 [...] Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl ................................... ok Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl ............................ 'tempdir' can't be called as a method at Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl line 120. Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl ............................ Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run Tools/Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl ..................................... ok [...] That's because we're calling File::Temp->tempdir() but that's not supporte by the API. 969431 1 221544 berto 2014-01-18 06:46:03 -0800 Created attachment 221544 Patch 969433 2 berto 2014-01-18 06:58:25 -0800 This used to work in earlier Perl versions (although it was undocumented) but not anymore: https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565 969494 3 221544 dbates 2014-01-18 11:54:38 -0800 Comment on attachment 221544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221544&action=review Are there any other call sites that use the bad syntax? > Tools/ChangeLog:8 > + Call the tempdir() function using the proper syntax. Although you document the commit that made the old syntax invalid, you may want to consider adding a remark that explains that we were using an undocumented calling convention and that this convention has been explicitly made invalid following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>. It would be great if we also documented the version of Perl this change affected. 969550 4 berto 2014-01-18 15:49:09 -0800 (In reply to comment #3) > Although you document the commit that made the old syntax invalid, > you may want to consider adding a remark that explains that we were > using an undocumented calling convention and that this convention > has been explicitly made invalid following > <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>. It > would be great if we also documented the version of Perl this change > affected. Sure, I'll do that. The Perl version is 5.18.0, which included File::Temp v0.23 http://perldoc.perl.org/perl5180delta.html 969551 5 berto 2014-01-18 15:55:50 -0800 Committed r162283: <http://trac.webkit.org/changeset/162283> 969552 6 berto 2014-01-18 15:58:24 -0800 (In reply to comment #3) > (From update of attachment 221544 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221544&action=review > > Are there any other call sites that use the bad syntax? No, that was the only one. 221544 2014-01-18 06:46:03 -0800 2014-01-18 11:54:38 -0800 Patch 127217.diff text/plain 1515 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNjNm ZTc4Li5lZTRlZTljIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDEtMTggIEFsYmVydG8gR2FyY2lhICA8YmVy dG9AaWdhbGlhLmNvbT4KKworICAgICAgICBUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cGVybCBm YWlsczogJ3RlbXBkaXInIGNhbid0IGJlIGNhbGxlZCBhcyBhIG1ldGhvZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MjE3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbCB0aGUgdGVtcGRpcigpIGZ1 bmN0aW9uIHVzaW5nIHRoZSBwcm9wZXIgc3ludGF4LgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L3BhcnNlRGlmZldpdGhNb2NrRmlsZXMucGw6CisKIDIw MTQtMDEtMTcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAg YnVpbGQud2Via2l0Lm9yZy9kYXNoYm9hcmQgc2hvdWxkIGhhdmUgZGlmZiBsaW5rcyBpbiB0ZXN0 IHJlc3VsdHMgcG9wb3ZlcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9W Q1NVdGlsc191bml0dGVzdC9wYXJzZURpZmZXaXRoTW9ja0ZpbGVzLnBsIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L3BhcnNlRGlmZldpdGhNb2NrRmlsZXMucGwK aW5kZXggMmIxZDFhMi4uYWJhMzkxOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw ZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L3BhcnNlRGlmZldpdGhNb2NrRmlsZXMucGwKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L3BhcnNlRGlmZldpdGhNb2Nr RmlsZXMucGwKQEAgLTExNyw3ICsxMTcsNyBAQCBNT0RVTEVTID0gSmF2YVNjcmlwdENvcmUgSmF2 YVNjcmlwdEdsdWUgV2ViQ29yZSBXZWJLaXQgV2ViS2l0VG9vbHMKIGFsbDoKIEVPRgogCi1teSAk bW9ja0RpciA9IEZpbGU6OlRlbXAtPnRlbXBkaXIoInBhcnNlRGlmZlhYWFgiLCBDTEVBTlVQID0+ IDEpOworbXkgJG1vY2tEaXIgPSBGaWxlOjpUZW1wOjp0ZW1wZGlyKCJwYXJzZURpZmZYWFhYIiwg Q0xFQU5VUCA9PiAxKTsKIHdyaXRlVG9GaWxlKEZpbGU6OlNwZWMtPmNhdGZpbGUoJG1vY2tEaXIs ICJNYWtlZmlsZVdpdGhVbml4RU9MIiksICRNYWtlZmlsZUNvbnRlbnRzKTsKIHdyaXRlVG9GaWxl KEZpbGU6OlNwZWMtPmNhdGZpbGUoJG1vY2tEaXIsICJNYWtlZmlsZVdpdGhXaW5kb3dzRU9MIiks IHRvV2luZG93c0xpbmVFbmRpbmdzKCRNYWtlZmlsZUNvbnRlbnRzKSk7CiB3cml0ZVRvRmlsZShG aWxlOjpTcGVjLT5jYXRmaWxlKCRtb2NrRGlyLCAiTWFrZWZpbGVXaXRoTWFjRU9MIiksIHRvTWFj TGluZUVuZGluZ3MoJE1ha2VmaWxlQ29udGVudHMpKTsK