127215 2014-01-17 22:14:57 -0800 FTL mishandles (-2147483648 % 0) | 0 2014-01-30 13:34:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 969393 0 fpizlo 2014-01-17 22:14:57 -0800 The refactoring that made the ArithDiv and ArithMod share a common path caused this bug. I think it's generally not a good idea to try to refactor such boilerplate paths into sharing code. Every time we do it, we get it wrong. 969394 1 221536 fpizlo 2014-01-17 22:16:12 -0800 Created attachment 221536 the patch 969402 2 fpizlo 2014-01-17 22:28:14 -0800 Landed on branch on http://trac.webkit.org/changeset/162246 221536 2014-01-17 22:16:12 -0800 2014-01-17 23:30:06 -0800 the patch blah.patch text/plain 2950 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyMjQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTAxLTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIG1pc2hhbmRsZXMgKC0yMTQ3NDgzNjQ4ICUgMCkgfCAwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcyMTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgZml4ZXM6CisgICAgICAg IAorICAgICAgICAgICAganNjLWxheW91dC10ZXN0cy55YW1sL2pzL3NjcmlwdC10ZXN0cy9kZmct bW9kLW5lZzJ0b3RoZTMxLWJ5LW9uZS1hbmQtdGhlbi1vci16ZXJvLXdpdGgtaW50ZXJlc3Rpbmct cmVnLWFsbG9jLmpzLmxheW91dC1mdGwtZWFnZXItbm8tY2ppdAorICAgICAgICAKKyAgICAgICAg Tm93IHRoZSBGVEwgcGFzc2VzIGFsbCBKU0MgbGF5b3V0IHRlc3RzLgorCisgICAgICAgICogZnRs L0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExW TTo6Y29tcGlsZU5vZGUpOgorICAgICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9MTFZNOjpjb21w aWxlQXJpdGhEaXZNb2QpOgorCiAyMDE0LTAxLTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgRlRMIHNob3VsZCB1cGRhdGUgbWFjaGluZSB2aXJ0dWFsIHJlZ2lz dGVycyBpbiBydW50aW1lIG1ldGEtZGF0YSBhY2NvcmRpbmcgdG8gdGhlIGNhcHR1cmVkIHN0YWNr bWFwCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9M TFZNLmNwcAkocmV2aXNpb24gMTYyMjQzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxNCw4ICszMTQsNiBAQCBw cml2YXRlOgogICAgICAgICAgICAgY29tcGlsZUFyaXRoTXVsKCk7CiAgICAgICAgICAgICBicmVh azsKICAgICAgICAgY2FzZSBBcml0aERpdjoKLSAgICAgICAgICAgIGNvbXBpbGVBcml0aERpdk1v ZCgpOwotICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQXJpdGhNb2Q6CiAgICAgICAg ICAgICBjb21waWxlQXJpdGhEaXZNb2QoKTsKICAgICAgICAgICAgIGJyZWFrOwpAQCAtMTA0Nyw5 ICsxMDQ1LDkgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICAvLyBJZiB0aGUgZGVub21pbmF0 b3IgaXMgbm90IHplcm8gKGkuZS4gaXQncyAtMSBiZWNhdXNlIHdlJ3JlIGd1YXJkZWQgYnkgdGhl CiAgICAgICAgICAgICAgICAgLy8gY2hlY2sgYWJvdmUpIGFuZCB0aGUgbnVtZXJhdG9yIGlzIC0y XjMxIHRoZW4gdGhlIHJlc3VsdCBzaG91bGQgYmUgLTJeMzEuCiAgICAgICAgICAgICAgICAgCi0g ICAgICAgICAgICAgICAgTEJhc2ljQmxvY2sgZGl2QnlaZXJvID0gRlRMX05FV19CTE9DSyhtX291 dCwgKCJBcml0aERpdiBkaXZpZGUgYnkgemVybyIpKTsKLSAgICAgICAgICAgICAgICBMQmFzaWNC bG9jayBub3REaXZCeVplcm8gPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkFyaXRoRGl2IG5vdCBk aXZpZGUgYnkgemVybyIpKTsKLSAgICAgICAgICAgICAgICBMQmFzaWNCbG9jayBuZWcyVG9UaGUz MUJ5TmVnMSA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiQXJpdGhEaXYgLTJeMzEvLTEiKSk7Cisg ICAgICAgICAgICAgICAgTEJhc2ljQmxvY2sgZGl2QnlaZXJvID0gRlRMX05FV19CTE9DSyhtX291 dCwgKCJBcml0aERpdk1vZCBkaXZpZGUgYnkgemVybyIpKTsKKyAgICAgICAgICAgICAgICBMQmFz aWNCbG9jayBub3REaXZCeVplcm8gPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkFyaXRoRGl2TW9k IG5vdCBkaXZpZGUgYnkgemVybyIpKTsKKyAgICAgICAgICAgICAgICBMQmFzaWNCbG9jayBuZWcy VG9UaGUzMUJ5TmVnMSA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiQXJpdGhEaXZNb2QgLTJeMzEv LTEiKSk7CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgbV9vdXQuYnJhbmNoKG1f b3V0LmlzWmVybzMyKGRlbm9taW5hdG9yKSwgZGl2QnlaZXJvLCBub3REaXZCeVplcm8pOwogICAg ICAgICAgICAgICAgIApAQCAtMTA2MSw3ICsxMDU5LDEwIEBAIHByaXZhdGU6CiAgICAgICAgICAg ICAgICAgbV9vdXQuYnJhbmNoKG1fb3V0LmVxdWFsKG51bWVyYXRvciwgbmVnMlRvVGhlMzEpLCBu ZWcyVG9UaGUzMUJ5TmVnMSwgY29udGludWF0aW9uKTsKICAgICAgICAgICAgICAgICAKICAgICAg ICAgICAgICAgICBtX291dC5hcHBlbmRUbyhuZWcyVG9UaGUzMUJ5TmVnMSwgY29udGludWF0aW9u KTsKLSAgICAgICAgICAgICAgICByZXN1bHRzLmFwcGVuZChtX291dC5hbmNob3IobmVnMlRvVGhl MzEpKTsKKyAgICAgICAgICAgICAgICBpZiAobV9ub2RlLT5vcCgpID09IEFyaXRoRGl2KQorICAg ICAgICAgICAgICAgICAgICByZXN1bHRzLmFwcGVuZChtX291dC5hbmNob3IobmVnMlRvVGhlMzEp KTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIHJlc3VsdHMuYXBw ZW5kKG1fb3V0LmFuY2hvcihtX291dC5pbnQzMlplcm8pKTsKICAgICAgICAgICAgICAgICBtX291 dC5qdW1wKGRvbmUpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgCg==