127211 2014-01-17 20:42:48 -0800 Use unsigned type for the size of CSSParserValueList 2014-01-19 23:21:01 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue esprehn+autocc glenn gyuyoung.kim kling koivisto macpherson menard oldest_to_newest 969372 0 jinwoo7.song 2014-01-17 20:42:48 -0800 The type of CSSParserValueList's size is unsigned. 969377 1 221529 jinwoo7.song 2014-01-17 21:05:13 -0800 Created attachment 221529 Patch 969549 2 221529 kling 2014-01-18 15:38:13 -0800 Comment on attachment 221529 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221529&action=review > Source/WebCore/css/CSSParser.cpp:1798 > - int num = inShorthand() ? 1 : m_valueList->size(); > + unsigned num = inShorthand() ? 1 : m_valueList->size(); There's identical code on line 3499. Please make the same change there. 969709 3 221615 jinwoo7.song 2014-01-19 22:39:44 -0800 Created attachment 221615 Patch Applied Kling's comment. 969723 4 221615 commit-queue 2014-01-19 23:20:59 -0800 Comment on attachment 221615 Patch Clearing flags on attachment: 221615 Committed r162305: <http://trac.webkit.org/changeset/162305> 969724 5 commit-queue 2014-01-19 23:21:01 -0800 All reviewed patches have been landed. Closing bug. 221529 2014-01-17 21:05:13 -0800 2014-01-19 22:39:38 -0800 Patch bug-127211-20140118140505.patch text/plain 1274 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZmYzU0ZWZkZTNkOTg1 Yjg2ZTM4YTgzZjk5MDMzNTk0ZjM2YTc5NC4uMDU3ZDYxZWJhNjEwYzZmOGU3ZWQxYjg0NjJjYzI4 ZTQ0MjhhNGZjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTE3ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBVc2UgdW5zaWdu ZWQgdHlwZSBmb3IgdGhlIHNpemUgb2YgQ1NTUGFyc2VyVmFsdWVMaXN0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcyMTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOiBD aGFuZ2VkIHZhcmlhYmxlIHR5cGUgZnJvbSBpbnQgdG8gdW5zaWduZWQuCisgICAgICAgIChXZWJD b3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOgorCiAyMDE0LTAxLTE3ICBBbmR5IEVzdGVzICA8 YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBXb3JrIGFyb3VuZCBhIHByZXByb2Nlc3NvciB3 YXJuaW5nIGluIG1lZGlhQ29udHJvbHNBcHBsZS5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApp bmRleCAwY2NiYmEzOTgwOWIxZjAwYWM4NDg4NDQ0OTlmMzdkOTNkOWE3YmYzLi4wMDk4NmVkYTlj NzA2YmQ2M2E2YzU0OWNiZDI4ZjUyMmE1YzA0NDQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cApAQCAtMTc5NSw3ICsxNzk1LDcgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NTUHJv cGVydHlJRCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQogICAgIAogICAgIENTU1ZhbHVlSUQgaWQg PSB2YWx1ZS0+aWQ7CiAKLSAgICBpbnQgbnVtID0gaW5TaG9ydGhhbmQoKSA/IDEgOiBtX3ZhbHVl TGlzdC0+c2l6ZSgpOworICAgIHVuc2lnbmVkIG51bSA9IGluU2hvcnRoYW5kKCkgPyAxIDogbV92 YWx1ZUxpc3QtPnNpemUoKTsKIAogICAgIGlmIChpZCA9PSBDU1NWYWx1ZUluaGVyaXQpIHsKICAg ICAgICAgaWYgKG51bSAhPSAxKQo= 221615 2014-01-19 22:39:44 -0800 2014-01-19 23:20:58 -0800 Patch bug-127211-20140120153933.patch text/plain 1578 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNiZWQ3ZDEwOTllYWRi YzQyN2YyZjVhMjI2Y2VlYjQxYzYwODc1My4uM2U5NzFjYTllMDMwODY4NmZkOWExMDVmOWZiY2Vk NjM4ZWI1Y2U1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTE5ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBVc2UgdW5zaWdu ZWQgdHlwZSBmb3IgdGhlIHNpemUgb2YgQ1NTUGFyc2VyVmFsdWVMaXN0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcyMTEKKworICAgICAgICBSZXZp ZXdlZCBieSBBbmRyZWFzIEtsaW5nLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6IENo YW5nZWQgdmFyaWFibGUgdHlwZSBmcm9tIGludCB0byB1bnNpZ25lZC4KKyAgICAgICAgKFdlYkNv cmU6OkNTU1BhcnNlcjo6cGFyc2VWYWx1ZSk6CisKIDIwMTQtMDEtMTkgIEphZWh1biBMaW0gIDxs amFlaHVuLmxpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBh ZnRlciByMTYyMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDBjY2JiYTM5ODA5YjFm MDBhYzg0ODg0NDQ5OWYzN2Q5M2Q5YTdiZjMuLjUzNzUyMTY3MjI1MTM5ZDBlODg5MGY4NWUyZTY5 NjdhZjE4YTNiMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0xNzk1LDcgKzE3OTUs NyBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9v bCBpbXBvcnRhbnQpCiAgICAgCiAgICAgQ1NTVmFsdWVJRCBpZCA9IHZhbHVlLT5pZDsKIAotICAg IGludCBudW0gPSBpblNob3J0aGFuZCgpID8gMSA6IG1fdmFsdWVMaXN0LT5zaXplKCk7CisgICAg dW5zaWduZWQgbnVtID0gaW5TaG9ydGhhbmQoKSA/IDEgOiBtX3ZhbHVlTGlzdC0+c2l6ZSgpOwog CiAgICAgaWYgKGlkID09IENTU1ZhbHVlSW5oZXJpdCkgewogICAgICAgICBpZiAobnVtICE9IDEp CkBAIC0zNDk2LDcgKzM0OTYsNyBAQCBib29sIENTU1BhcnNlcjo6cGFyc2U0VmFsdWVzKENTU1By b3BlcnR5SUQgcHJvcElkLCBjb25zdCBDU1NQcm9wZXJ0eUlEICpwcm9wZXJ0aQogICAgICAqIHJp Z2h0LCBib3R0b20sIGFuZCBsZWZ0LCByZXNwZWN0aXZlbHkuCiAgICAgICovCiAKLSAgICBpbnQg bnVtID0gaW5TaG9ydGhhbmQoKSA/IDEgOiBtX3ZhbHVlTGlzdC0+c2l6ZSgpOworICAgIHVuc2ln bmVkIG51bSA9IGluU2hvcnRoYW5kKCkgPyAxIDogbV92YWx1ZUxpc3QtPnNpemUoKTsKIAogICAg IFNob3J0aGFuZFNjb3BlIHNjb3BlKHRoaXMsIHByb3BJZCk7CiAK