127205 2014-01-17 16:44:03 -0800 CStack Branch: VM::currentReturnThunkPC appears to be unused and should be removed 2014-02-13 10:40:12 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127201 1 msaboff msaboff oldest_to_newest 969322 0 msaboff 2014-01-17 16:44:03 -0800 I cannot find where it is ever set. Code in ThunkGenerators.cpp looks like it is expected to be used, but that was disabled with a FIXME in <https://bugs.webkit.org/show_bug.cgi?id=127201> 980359 1 224086 msaboff 2014-02-13 10:31:11 -0800 Created attachment 224086 Patch 980365 2 224086 ggaren 2014-02-13 10:34:27 -0800 Comment on attachment 224086 Patch r=me 980366 3 msaboff 2014-02-13 10:40:12 -0800 Committed r164039: <http://trac.webkit.org/changeset/164039> 224086 2014-02-13 10:31:11 -0800 2014-02-13 10:34:27 -0800 Patch 127205.patch text/plain 2674 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0MDM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAyLTEzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IFZNOjpjdXJyZW50UmV0dXJuVGh1bmtQQyBhcHBlYXJzIHRvIGJl IHVudXNlZCBhbmQgc2hvdWxkIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzIwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgdW51bnNlZCByZWZlcmVuY2VzIHRvIFZNOjpj dXJyZW50UmV0dXJuVGh1bmtQQy4KKworICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMuY3Bw OgorICAgICAgICAoSlNDOjphcml0eUZpeHVwKToKKyAgICAgICAgKiBydW50aW1lL1ZNLmg6CisK IDIwMTQtMDItMTMgIFRhbWFzIEdlcmdlbHkgIDx0Z2VyZ2VseS51LXN6ZWdlZEBwYXJ0bmVyLnNh bXN1bmcuY29tPgogCiAgICAgICAgIENvZGUgY2xlYW51cDogcmVtb3ZlIGdjYzw0LjcgZ3VhcmRz LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNw cAkocmV2aXNpb24gMTYzOTY0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dl bmVyYXRvcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjgsNyArNDI4LDcgQEAgTWFjcm9Bc3Nl bWJsZXJDb2RlUmVmIGFyaXR5Rml4dXAoVk0qIHZtKQogICAgIEpTSW50ZXJmYWNlSklUIGppdCh2 bSk7CiAKICAgICAvLyBXZSBlbnRlciB3aXRoIGZpeHVwIGNvdW50LCBpbiBhbGlnbmVkIHN0YWNr IHVuaXRzLCBpbiByZWdUMCBhbmQgdGhlIHJldHVybiB0aHVuayBpbgotICAgIC8vIHJlZ1Q1LiBX ZSB1c2UgVk06OmN1cnJlbnRSZXR1cm5UaHVua1BDIGluc3RlYWQgb2YgcmVnVDUgb24gWDg2LTMy LgorICAgIC8vIHJlZ1Q1LgogI2lmIFVTRShKU1ZBTFVFNjQpCiAjICBpZiBDUFUoWDg2XzY0KQog ICAgIGppdC5wb3AoSlNJbnRlcmZhY2VKSVQ6OnJlZ1Q0KTsKQEAgLTUxNCwxMyArNTE0LDcgQEAg TWFjcm9Bc3NlbWJsZXJDb2RlUmVmIGFyaXR5Rml4dXAoVk0qIHZtKQogICAgIGppdC5zdG9yZVB0 cihHUFJJbmZvOjpyZWdUMSwgTWFjcm9Bc3NlbWJsZXI6OkJhc2VJbmRleChKU0ludGVyZmFjZUpJ VDo6cmVnVDMsIEpTSW50ZXJmYWNlSklUOjpyZWdUMCwgSlNJbnRlcmZhY2VKSVQ6OlRpbWVzRWln aHQpKTsKICAgICAKICAgICAvLyBJbnN0YWxsIHRoZSBuZXcgcmV0dXJuIFBDLgotICAgIC8vIEZJ WE1FOiBJIGRvbid0IHRoaW5rIGN1cnJlbnRSZXR1cm5UaHVua1BDIGlzIHVzZWQgYW5kIHNob3Vs ZCBiZSBkZWxldGVkLgotIyAgaWYgMAotICAgIGppdC5sb2FkUHRyKCZ2bS0+Y3VycmVudFJldHVy blRodW5rUEMsIEdQUkluZm86OnJlZ1QyKTsKLSAgICBqaXQuc3RvcmVQdHIoR1BSSW5mbzo6cmVn VDIsIEpTSW50ZXJmYWNlSklUOjpBZGRyZXNzKEpTSW50ZXJmYWNlSklUOjpjYWxsRnJhbWVSZWdp c3RlciwgQ2FsbEZyYW1lOjpyZXR1cm5QQ09mZnNldCgpKSk7Ci0jICAgZWxzZQogICAgIGppdC5z dG9yZVB0cihHUFJJbmZvOjpyZWdUNSwgSlNJbnRlcmZhY2VKSVQ6OkFkZHJlc3MoSlNJbnRlcmZh Y2VKSVQ6OmNhbGxGcmFtZVJlZ2lzdGVyLCBDYWxsRnJhbWU6OnJldHVyblBDT2Zmc2V0KCkpKTsK LSMgICBlbmRpZgogICAgIAogIyAgaWYgQ1BVKFg4NikKICAgICBqaXQucHVzaChKU0ludGVyZmFj ZUpJVDo6cmVnVDQpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCShyZXZpc2lv biAxNjM5NjQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zNDMsOSArMzQzLDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIE5hdGl2 ZUV4ZWN1dGFibGUqIGdldEhvc3RGdW5jdGlvbihOYXRpdmVGdW5jdGlvbiwgSW50cmluc2ljKTsK ICAgICAgICAgCiAgICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxBcml0eUNoZWNrRmFpbFJldHVyblRo dW5rcz4gYXJpdHlDaGVja0ZhaWxSZXR1cm5UaHVua3M7Ci0jaWYgQ1BVKFg4NikKLSAgICAgICAg dm9pZCogY3VycmVudFJldHVyblRodW5rUEM7Ci0jZW5kaWYgLy8gQ1BVKFg4NikKICNlbmRpZiAv LyBFTkFCTEUoSklUKQogICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8Q29tbW9uU2xvd1BhdGhzOjpB cml0eUNoZWNrRGF0YT4gYXJpdHlDaGVja0RhdGE7CiAjaWYgRU5BQkxFKEZUTF9KSVQpCg==