127204 2014-01-17 16:25:30 -0800 Silence a warning emitted when preprocessing mediaControlsApple.js 2014-01-17 17:13:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes commit-queue eric.carlson glenn jer.noble oldest_to_newest 969313 0 aestes 2014-01-17 16:25:30 -0800 Silence a warning emitted when preprocessing mediaControlsApple.js 969314 1 221509 aestes 2014-01-17 16:26:42 -0800 Created attachment 221509 Silence a warning emitted when preprocessing mediaControlsApple.js 969320 2 221509 eric.carlson 2014-01-17 16:41:13 -0800 Comment on attachment 221509 Silence a warning emitted when preprocessing mediaControlsApple.js View in context: https://bugs.webkit.org/attachment.cgi?id=221509&action=review r=me, although my suggestion would be slightly cleaner if it works because we can still use the JS file as-is during development. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:839 > return (time < 0 ? '-' : '' ) + String('00' + intMinutes).slice(-2) + ":" + String('00' + intSeconds).slice(-2) I think you can also silence this warning by replacing the empty single-quotes with double-quotes: '' -> "" 969321 3 221511 aestes 2014-01-17 16:43:12 -0800 Created attachment 221511 Work around a preprocessor warning in mediaControlsApple.js 969331 4 221511 commit-queue 2014-01-17 17:13:49 -0800 Comment on attachment 221511 Work around a preprocessor warning in mediaControlsApple.js Clearing flags on attachment: 221511 Committed r162233: <http://trac.webkit.org/changeset/162233> 969332 5 commit-queue 2014-01-17 17:13:52 -0800 All reviewed patches have been landed. Closing bug. 221509 2014-01-17 16:26:42 -0800 2014-01-17 16:43:10 -0800 Silence a warning emitted when preprocessing mediaControlsApple.js bug-127204-20140117162641.patch text/plain 1545 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzkyMDRhOTIzZWIwOGRi ODg3ZTRkMTViMjQxYWU2YjZjYmIyY2I2Ny4uYzBkYjhiZmRiOWY3MzNjMTI5ZDk5ZGRhYjE3MGU2 YzI1NjI4MTI1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAxLTE3ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBTaWxlbmNlIGEgd2FybmluZyBl bWl0dGVkIHdoZW4gcHJlcHJvY2Vzc2luZyBtZWRpYUNvbnRyb2xzQXBwbGUuanMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzIwNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qczogSWdub3JlZCAtV2ludmFsaWQtcHAtdG9rZW4u CisKIDIwMTQtMDEtMTcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgaU9TIGJ1aWxkIGFmdGVyIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5n ZXNldC8xNjIxNzg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29u dHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwppbmRleCBjMzg0YWM2OTVmMTBiMDU0NmFj ZjJkODMwMTkyODc4NmVjMTQ4NmRlLi41MDhiNDc5NjYxOGUwM2Q2ZGRhMWY3YzQ4NGY1ZjhiNTRl MTg2ODQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMv bWVkaWFDb250cm9sc0FwcGxlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFj b250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKQEAgLTgzNCw3ICs4MzQsMTAgQEAgQ29udHJv bGxlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBhYnNUaW1lID0gTWF0aC5hYnModGltZSk7 CiAgICAgICAgIHZhciBpbnRTZWNvbmRzID0gTWF0aC5mbG9vcihhYnNUaW1lICUgNjApLnRvRml4 ZWQoMCk7CiAgICAgICAgIHZhciBpbnRNaW51dGVzID0gTWF0aC5mbG9vcihhYnNUaW1lIC8gNjAp LnRvRml4ZWQoMCk7CisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBjbGFu ZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XaW52YWxpZC1wcC10b2tlbiIKICAgICAgICAgcmV0dXJu ICh0aW1lIDwgMCA/ICctJyA6ICcnICkgKyBTdHJpbmcoJzAwJyArIGludE1pbnV0ZXMpLnNsaWNl KC0yKSArICI6IiArIFN0cmluZygnMDAnICsgaW50U2Vjb25kcykuc2xpY2UoLTIpCisjcHJhZ21h IGNsYW5nIGRpYWdub3N0aWMgcG9wCiAgICAgfSwKIAogICAgIHVwZGF0ZVBsYXlpbmc6IGZ1bmN0 aW9uKCkK 221511 2014-01-17 16:43:12 -0800 2014-01-17 17:13:49 -0800 Work around a preprocessor warning in mediaControlsApple.js bug-127204-20140117164311.patch text/plain 1542 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzkyMDRhOTIzZWIwOGRi ODg3ZTRkMTViMjQxYWU2YjZjYmIyY2I2Ny4uNzBjMzJjYmNlYWJkMzM4OGFhMWJjYWEyNjU3ZDFj YWFlZTFiZGFlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAxLTE3ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBXb3JrIGFyb3VuZCBhIHByZXBy b2Nlc3NvciB3YXJuaW5nIGluIG1lZGlhQ29udHJvbHNBcHBsZS5qcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MjA0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgRGFuIEJlcm5zdGVpbi4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzQXBwbGUuanM6IENoYW5nZWQgJycgdG8gU3RyaW5nKCkuCisKIDIwMTQtMDEt MTcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUg aU9TIGJ1aWxkIGFmdGVyIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNjIxNzg+ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFD b250cm9sc0FwcGxlLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNBcHBsZS5qcwppbmRleCBjMzg0YWM2OTVmMTBiMDU0NmFjZjJkODMwMTkyODc4 NmVjMTQ4NmRlLi5lMTQyNTY3YTlkMjkyM2ExNjhjMmUyMDM2YTBmMGNmZmZiODVmM2Q4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0FwcGxlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRp YUNvbnRyb2xzQXBwbGUuanMKQEAgLTgzNCw3ICs4MzQsNyBAQCBDb250cm9sbGVyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgdmFyIGFic1RpbWUgPSBNYXRoLmFicyh0aW1lKTsKICAgICAgICAgdmFy IGludFNlY29uZHMgPSBNYXRoLmZsb29yKGFic1RpbWUgJSA2MCkudG9GaXhlZCgwKTsKICAgICAg ICAgdmFyIGludE1pbnV0ZXMgPSBNYXRoLmZsb29yKGFic1RpbWUgLyA2MCkudG9GaXhlZCgwKTsK LSAgICAgICAgcmV0dXJuICh0aW1lIDwgMCA/ICctJyA6ICcnICkgKyBTdHJpbmcoJzAwJyArIGlu dE1pbnV0ZXMpLnNsaWNlKC0yKSArICI6IiArIFN0cmluZygnMDAnICsgaW50U2Vjb25kcykuc2xp Y2UoLTIpCisgICAgICAgIHJldHVybiAodGltZSA8IDAgPyAnLScgOiBTdHJpbmcoKSkgKyBTdHJp bmcoJzAwJyArIGludE1pbnV0ZXMpLnNsaWNlKC0yKSArICI6IiArIFN0cmluZygnMDAnICsgaW50 U2Vjb25kcykuc2xpY2UoLTIpCiAgICAgfSwKIAogICAgIHVwZGF0ZVBsYXlpbmc6IGZ1bmN0aW9u KCkK