12720 2007-02-09 15:37:45 -0800 Re-defining window.location.toString function keeps re-loading forever 2007-03-07 12:47:44 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction P2 Normal --- 1 ian.eng.webkit ian.eng.webkit ap oldest_to_newest 24565 0 ian.eng.webkit 2007-02-09 15:37:45 -0800 Create a page with a statement: window.location.toString = function() { return "www.cnn.com"; } Open it in a new window, it keeps re-loading the page. 24562 1 ddkilzer 2007-02-09 15:57:34 -0800 Behavior confirmed in shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037) and a local debug build of WebKit r19537 with the same software. Both Firefox 2.0.0.1 and Opera 9.10 don't appear to log any errors when the test case is loaded--they just silently refuse to change the built-in function. 24550 2 13098 ddkilzer 2007-02-09 15:58:14 -0800 Created attachment 13098 Test case 20992 3 13417 ian.eng.webkit 2007-02-27 18:41:01 -0800 Created attachment 13417 patch The bug is caused by Location::put if the property name is a function name in the LocationTable. It does not change URL, but put() will think the URL was changed and reload the file again, and into an infinite loop. The fix just returns early when it founds the property name is in the LocationTable, but not changing URL. 20993 4 13418 ian.eng.webkit 2007-02-27 18:45:16 -0800 Created attachment 13418 a better test with expected output 20995 5 mjs 2007-02-27 18:50:23 -0800 This looks ok, but it might be better to mark the functions that should not be replaceable as read-only. 20935 6 13418 mjs 2007-02-27 22:53:35 -0800 Comment on attachment 13418 a better test with expected output After further consideration this fix seems ok. 20807 7 ian.eng.webkit 2007-03-01 12:04:51 -0800 (In reply to comment #5) > This looks ok, but it might be better to mark the functions that should not be > replaceable as read-only. > How does ReadOnly attribute work? Will the call be returned before calling Location::put ? 20275 8 mrowe 2007-03-06 19:30:41 -0800 Landed in r19995. Thanks for the patch Ian. Can you please ensure that you use spaces rather than tabs in your ChangeLog entries, and that they are consistent in formatting with other entries. I'm specifically thinking of new lines between description and file list, and the presence of the "Reviewed by NOBODY" line. The latter will ensure that the patch cannot be landed unless the reviewer is added. 20277 9 mrowe 2007-03-06 19:44:32 -0800 I also just noticed that you forgot to include a changelog for the LayoutTests portion of your patch. 20266 10 mrowe 2007-03-06 20:30:07 -0800 Not to keep going on... but the expected results you provided didn't match the test. I updated the test in r20002 to make things pass. 20024 11 ian.eng.webkit 2007-03-07 12:47:44 -0800 (In reply to comment #8) > Landed in r19995. > > Thanks for the patch Ian. Can you please ensure that you use spaces rather > than tabs in your ChangeLog entries, and that they are consistent in formatting > with other entries. I'm specifically thinking of new lines between description > and file list, and the presence of the "Reviewed by NOBODY" line. The latter > will ensure that the patch cannot be landed unless the reviewer is added. Thanks Mike. I will try my best to remember these style rules. > 13098 2007-02-09 15:58:14 -0800 2007-02-09 15:58:14 -0800 Test case bug-12720-test.html text/html 83 ddkilzer PHNjcmlwdD4Kd2luZG93LmxvY2F0aW9uLnRvU3RyaW5nID0gZnVuY3Rpb24oKSB7IHJldHVybiAi d3d3LmNubi5jb20iOyB9Cjwvc2NyaXB0Pgo= 13417 2007-02-27 18:41:01 -0800 2007-02-27 18:45:16 -0800 patch bug12720.patch text/plain 1570 ian.eng.webkit SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMva2pzX3dpbmRvdy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfd2luZG93LmNwcAkocmV2aXNpb24gMTk4NTUpCisrKyBX ZWJDb3JlL2JpbmRpbmdzL2pzL2tqc193aW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjE0 LDYgKzIyMTQsMTAgQEAgdm9pZCBMb2NhdGlvbjo6cHV0KEV4ZWNTdGF0ZSAqZXhlYywgY29ucwog ICAgIGNhc2UgU2VhcmNoOgogICAgICAgdXJsLnNldFF1ZXJ5KHN0cik7CiAgICAgICBicmVhazsK KyAgICBkZWZhdWx0OgorICAgICAgLy8gRGlzYWxsb3cgY2hhbmdpbmcgb3RoZXIgcHJvcGVydGll cyBpbiBMb2NhdGlvblRhYmxlLiBlLmcuLCAid2luZG93LmxvY2F0aW9uLnRvU3RyaW5nID0gLi4u Ii4KKyAgICAgIC8vIFNlZSAjMTI3MjAKKyAgICAgIHJldHVybjsKICAgICB9CiAgIGVsc2Ugewog ICAgIEpTT2JqZWN0OjpwdXQoZXhlYywgcCwgdiwgYXR0cik7CkluZGV4OiBXZWJDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5MDUpCisr KyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEwIEBACisyMDA3 LTAyLTI3ICBJYW4gRW5nIDxpYW4uZW5nLndlYmtpdEBnbWFpbC5jb20+CisKKwktIGZpeGVkIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzIwCisJKiBiaW5kaW5ncy9q cy9ranNfd2luZG93LmNwcDoKKwlEaXNhbGxvdyByZXBsYWNpbmcgZnVuY3Rpb25zIGluIExvY2F0 aW9uVGFibGUsIGFuZCByZXR1cm5zIGVhcmx5CisJd2l0aG91dCB1cGRhdGluZyBVUkwuCisKIDIw MDctMDItMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBhcHBsZS5jb20+CiAKICAgICAg ICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3dpbmRvdy1sb2NhdGlvbi1yZXBsYWNlLWZ1bmN0aW9ucy5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctbG9jYXRpb24tcmVwbGFj ZS1mdW5jdGlvbnMuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1dp bmRvdy93aW5kb3ctbG9jYXRpb24tcmVwbGFjZS1mdW5jdGlvbnMuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSw3IEBACis8aHRtbD4KKzxzY3JpcHQ+d2luZG93LmxvY2F0aW9uLnRvU3RyaW5n ID0gZnVuY3Rpb24oKSB7IHJldHVybiAiaHR0cDovL3dlYmtpdC5vcmciOyB9Cis8L3NjcmlwdD4K Kzxib2R5PgorPHNjcmlwdD5kb2N1bWVudC53cml0ZSh3aW5kb3cubG9jYXRpb24udG9TdHJpbmco KSk7PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 13418 2007-02-27 18:45:16 -0800 2007-02-27 22:53:35 -0800 a better test with expected output bug12720.patch text/plain 1900 ian.eng.webkit SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMva2pzX3dpbmRvdy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfd2luZG93LmNwcAkocmV2aXNpb24gMTk4NTUpCisrKyBX ZWJDb3JlL2JpbmRpbmdzL2pzL2tqc193aW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjE0 LDYgKzIyMTQsMTAgQEAgdm9pZCBMb2NhdGlvbjo6cHV0KEV4ZWNTdGF0ZSAqZXhlYywgY29ucwog ICAgIGNhc2UgU2VhcmNoOgogICAgICAgdXJsLnNldFF1ZXJ5KHN0cik7CiAgICAgICBicmVhazsK KyAgICBkZWZhdWx0OgorICAgICAgLy8gRGlzYWxsb3cgY2hhbmdpbmcgb3RoZXIgcHJvcGVydGll cyBpbiBMb2NhdGlvblRhYmxlLiBlLmcuLCAid2luZG93LmxvY2F0aW9uLnRvU3RyaW5nID0gLi4u Ii4KKyAgICAgIC8vIFNlZSAjMTI3MjAKKyAgICAgIHJldHVybjsKICAgICB9CiAgIGVsc2Ugewog ICAgIEpTT2JqZWN0OjpwdXQoZXhlYywgcCwgdiwgYXR0cik7CkluZGV4OiBXZWJDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5MDUpCisr KyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEwIEBACisyMDA3 LTAyLTI3ICBJYW4gRW5nIDxpYW4uZW5nLndlYmtpdEBnbWFpbC5jb20+CisKKwktIGZpeGVkIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzIwCisJKiBiaW5kaW5ncy9q cy9ranNfd2luZG93LmNwcDoKKwlEaXNhbGxvdyByZXBsYWNpbmcgZnVuY3Rpb25zIGluIExvY2F0 aW9uVGFibGUsIGFuZCByZXR1cm5zIGVhcmx5CisJd2l0aG91dCB1cGRhdGluZyBVUkwuCisKIDIw MDctMDItMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBhcHBsZS5jb20+CiAKICAgICAg ICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3dpbmRvdy1sb2NhdGlvbi1yZXBsYWNlLWZ1bmN0aW9ucy1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1sb2NhdGlv bi1yZXBsYWNlLWZ1bmN0aW9ucy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LWxvY2F0aW9uLXJlcGxhY2UtZnVuY3Rpb25zLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorWW91IHNob3VsZCBzZWUgdGhp cy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctbG9jYXRpb24tcmVw bGFjZS1mdW5jdGlvbnMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9X aW5kb3cvd2luZG93LWxvY2F0aW9uLXJlcGxhY2UtZnVuY3Rpb25zLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LWxvY2F0aW9uLXJlcGxhY2Ut ZnVuY3Rpb25zLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNyBAQAorPGh0bWw+Cis8c2Ny aXB0PndpbmRvdy5sb2NhdGlvbi50b1N0cmluZyA9IGZ1bmN0aW9uKCkgeyByZXR1cm4gImh0dHA6 Ly93ZWJraXQub3JnIjsgfQorPC9zY3JpcHQ+Cis8Ym9keT4KK1lvdSBzaG91bGQgc2VlIHRoaXMu Cis8L2JvZHk+Cis8L2h0bWw+Cg==