127189 2014-01-17 14:12:13 -0800 Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:] 2014-01-17 14:34:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue japhet oldest_to_newest 969255 0 andersca 2014-01-17 14:12:13 -0800 Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:] 969256 1 221492 andersca 2014-01-17 14:16:38 -0800 Created attachment 221492 Patch 969260 2 221492 mitz 2014-01-17 14:20:17 -0800 Comment on attachment 221492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221492&action=review > Source/WebKit/mac/WebView/WebView.mm:2891 > + > + if (_private->_didPerformFirstNavigation) > + return; Please remove. 969262 3 andersca 2014-01-17 14:34:39 -0800 Committed r162224: <http://trac.webkit.org/changeset/162224> 221492 2014-01-17 14:16:38 -0800 2014-01-17 14:20:16 -0800 Patch bug-127189-20140117141637.patch text/plain 6582 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWEyMDAwNDBmZjkxMDY4 MzhhODFhNzQwMGFhY2U5Njk5MzE4MjAzMy4uNzg4ODEzNDcyMjZkODhkYTFlN2FlNzAxZDUxMDBi MzNmMWQ1NWU2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTE3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBkaWRQZXJm b3JtRmlyc3ROYXZpZ2F0aW9uKCkgbG9naWMgdG8gLVtXZWJWaWV3IF9kaWRDb21taXRMb2FkRm9y RnJhbWU6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI3MTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBsb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9h ZGVyQ2xpZW50OjpkaWRQZXJmb3JtRmlyc3ROYXZpZ2F0aW9uKToKKyAgICAgICAgQWRkIGFuIGVt cHR5IGltcGxlbWVudGF0aW9uIG9mIGRpZFBlcmZvcm1GaXJzdE5hdmlnYXRpb24oKSB0byBtYWtl IGl0IGVhc2llciB0byByZW1vdmUgaXQgZnJvbSBzdWJjbGFzc2VzLgorCiAyMDE0LTAxLTE3ICBF cmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEhU TUxNZWRpYVNlc3Npb24gc2hvdWxkIHNldCBBdWRpb1Nlc3Npb24gY2F0ZWdvcnkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5n ZUxvZwppbmRleCBiMjk5NGVhYmQwMTk4ZmQyNDgzNjg2MjFkYjExMmI3OWZiOTVlOGJiLi5mM2Ew ZTI3ZGMwY2I4ZmU3NWQ3NzcyNzQzYzU4Y2ZjYTEwMTE2MDcwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjggQEAKKzIwMTQtMDEtMTcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBNb3ZlIGRpZFBlcmZvcm1GaXJzdE5hdmlnYXRpb24oKSBsb2dp YyB0byAtW1dlYlZpZXcgX2RpZENvbW1pdExvYWRGb3JGcmFtZTpdCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcxODkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgZmlyc3Qgc3RlcCB0b3dh cmRzIGNvbXBsZXRlbHkgZWxpbWluYXRpbmcgdGhlIGRpZFBlcmZvcm1GaXJzdE5hdmlnYXRpb24o KSBjbGllbnQgY2FsbGJhY2suCisgICAgICAgIAorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dl YkZyYW1lTG9hZGVyQ2xpZW50Lmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVM b2FkZXJDbGllbnQubW06CisgICAgICAgIFJlbW92ZSBkaWRQZXJmb3JtRmlyc3ROYXZpZ2F0aW9u KCkgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAg ICAgICgtW1dlYlZpZXcgX2NoZWNrRGlkUGVyZm9ybUZpcnN0TmF2aWdhdGlvbl0pOgorICAgICAg ICBDaGVjayBpZiB3ZSBoYXZlIGJvdGggYSBjdXJyZW50IGl0ZW0gYW5kIGEgcHJldmlvdXMgaXRl bSB3aGljaCBpbmRpY2F0ZXMgdGhhdCB3ZSd2ZSBuYXZpZ2F0ZWQgb25jZS4KKyAgICAgICAgVGhl IG9sZCBjb2RlIHdhcyBjYWxsZWQgYmVmb3JlIHRoZXJlIHdhcyBhIGN1cnJlbnQgaXRlbSBidXQg c2luY2UgdGhpcyBpcyBjYWxsZWQgZnJvbSBfZGlkQ29tbWl0TG9hZEZvckZyYW1lCisgICAgICAg IHdlIGhhdmUgdG8gY2hlY2sgdGhhdCB0aGVyZSdzIGEgY3VycmVudCBpdGVtIGFzIHdlbGwuCisK KyAgICAgICAgKC1bV2ViVmlldyBfZGlkQ29tbWl0TG9hZEZvckZyYW1lOl0pOgorICAgICAgICBD YWxsIF9kaWRDb21taXRMb2FkRm9yRnJhbWUuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXdE YXRhLmg6CisgICAgICAgIEFkZCBuZXcgaXZhci4KKwogMjAxNC0wMS0xNyAgQWxleGV5IFByb3Nr dXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3JlIGlPUyBidWlsZCBmaXguCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oCmluZGV4IDA5ZGMwNjIzZTNk MWM0ZmFlMDAwZTY0ZTZkYmMzNDI0NWNmZjBmMDMuLmRiNWExN2YzMDkzZDdmZWE0YTIwYzlkZGFh YWRjNjRjZjFlNThlOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVu dC5oCkBAIC0yODIsNyArMjgyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZp cnR1YWwgdm9pZCBkaXNwYXRjaERpZENsZWFyV2luZG93T2JqZWN0SW5Xb3JsZChET01XcmFwcGVy V29ybGQmKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkb2N1bWVudEVsZW1lbnRBdmFpbGFi bGUoKSA9IDA7Ci0gICAgICAgIHZpcnR1YWwgdm9pZCBkaWRQZXJmb3JtRmlyc3ROYXZpZ2F0aW9u KCkgY29uc3QgPSAwOyAvLyAiTmF2aWdhdGlvbiIgaGVyZSBtZWFucyBhIHRyYW5zaXRpb24gZnJv bSBvbmUgcGFnZSB0byBhbm90aGVyIHRoYXQgZW5kcyB1cCBpbiB0aGUgYmFjay9mb3J3YXJkIGxp c3QuCisgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRQZXJmb3JtRmlyc3ROYXZpZ2F0aW9uKCkgY29u c3QgeyB9CiAKICAgICAgICAgdmlydHVhbCB2b2lkIHJlZ2lzdGVyRm9ySWNvbk5vdGlmaWNhdGlv bihib29sIGxpc3RlbiA9IHRydWUpID0gMDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9t YWMvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQv bWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmgKaW5kZXggZjM2YzkyNjJk NTFhYzc4MDBiMzRhZTg2NjdiOTQ5MWQ3MDRkMGFjMy4uNGE0MWVjZjcxY2ZjZDE3ODdkMDk5NWQz ZjVlNmVkMGYxNmNlZjhmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1 cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5oCkBAIC0yMTcsNyArMjE3LDYgQEAgcHJp dmF0ZToKICAgICAKICAgICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2hEaWRDbGVhcldpbmRvd09iamVj dEluV29ybGQoV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkJikgb3ZlcnJpZGU7CiAgICAgdmlydHVh bCB2b2lkIGRvY3VtZW50RWxlbWVudEF2YWlsYWJsZSgpIG92ZXJyaWRlOwotICAgIHZpcnR1YWwg dm9pZCBkaWRQZXJmb3JtRmlyc3ROYXZpZ2F0aW9uKCkgY29uc3Qgb3ZlcnJpZGU7CiAKICAgICB2 aXJ0dWFsIHZvaWQgcmVnaXN0ZXJGb3JJY29uTm90aWZpY2F0aW9uKGJvb2wgbGlzdGVuKSBvdmVy cmlkZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9X ZWJGcmFtZUxvYWRlckNsaWVudC5tbQppbmRleCA0MThmYmQzMDVkZGU3NDZjYWZkNzgzNzBiMDVi MGY0ODg1MzY0YjY4Li44OTIyYzFhMmQzNzNkN2VhNDdhYTRhYmM3OTIzMzUxZTI3YWU3NTU0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRl ckNsaWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFt ZUxvYWRlckNsaWVudC5tbQpAQCAtMjM4MSwxMyArMjM4MSw2IEBAIHZvaWQgV2ViRnJhbWVMb2Fk ZXJDbGllbnQ6OnJlZ2lzdGVyRm9ySWNvbk5vdGlmaWNhdGlvbihib29sIGxpc3RlbikKICNlbmRp ZgogfQogCi12b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaWRQZXJmb3JtRmlyc3ROYXZpZ2F0 aW9uKCkgY29uc3QKLXsKLSAgICBXZWJQcmVmZXJlbmNlcyAqcHJlZmVyZW5jZXMgPSBbW21fd2Vi RnJhbWUuZ2V0KCkgd2ViVmlld10gcHJlZmVyZW5jZXNdOwotICAgIGlmIChbcHJlZmVyZW5jZXMg YXV0b21hdGljYWxseURldGVjdHNDYWNoZU1vZGVsXSAmJiBbcHJlZmVyZW5jZXMgY2FjaGVNb2Rl bF0gPCBXZWJDYWNoZU1vZGVsRG9jdW1lbnRCcm93c2VyKQotICAgICAgICBbcHJlZmVyZW5jZXMg c2V0Q2FjaGVNb2RlbDpXZWJDYWNoZU1vZGVsRG9jdW1lbnRCcm93c2VyXTsKLX0KLQogUGFzc1Jl ZlB0cjxGcmFtZU5ldHdvcmtpbmdDb250ZXh0PiBXZWJGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRl TmV0d29ya2luZ0NvbnRleHQoKQogewogICAgIHJldHVybiBXZWJGcmFtZU5ldHdvcmtpbmdDb250 ZXh0OjpjcmVhdGUoY29yZShtX3dlYkZyYW1lLmdldCgpKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYlZpZXcubW0KaW5kZXggYTg1ZDA1MGQzNDAwZWVmOWZmYjE2ZDAwYjk1M2I0OTRhYWQwYmIz Zi4uZmYzZTMwNGYwZDc5OWM4NmIxNDdhYzNjYjIxNGU3OWZlYzdlYTRkMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViVmlldy5tbQpAQCAtMTExLDYgKzExMSw3IEBACiAjaW1wb3J0IDxXZWJD b3JlL0FsdGVybmF0aXZlVGV4dFVJQ29udHJvbGxlci5oPgogI2ltcG9ydCA8V2ViQ29yZS9Bbmlt YXRpb25Db250cm9sbGVyLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0FwcGxpY2F0aW9uQ2FjaGVTdG9y YWdlLmg+CisjaW1wb3J0IDxXZWJDb3JlL0JhY2tGb3J3YXJkQ29udHJvbGxlci5oPgogI2ltcG9y dCA8V2ViQ29yZS9CYWNrRm9yd2FyZExpc3QuaD4KICNpbXBvcnQgPFdlYkNvcmUvTWVtb3J5Q2Fj aGUuaD4KICNpbXBvcnQgPFdlYkNvcmUvQ2hyb21lLmg+CkBAIC0yODU3LDExICsyODU4LDM3IEBA IHN0YXRpYyBpbmxpbmUgSU1QIGdldE1ldGhvZChpZCBvLCBTRUwgcykKICNlbmRpZgogfQogCist ICh2b2lkKV9jaGVja0RpZFBlcmZvcm1GaXJzdE5hdmlnYXRpb24KK3sKKyAgICBpZiAoX3ByaXZh dGUtPl9kaWRQZXJmb3JtRmlyc3ROYXZpZ2F0aW9uKQorICAgICAgICByZXR1cm47CisKKyAgICBQ YWdlKiBwYWdlID0gX3ByaXZhdGUtPnBhZ2U7CisgICAgaWYgKCFwYWdlKQorICAgICAgICByZXR1 cm47CisKKyAgICBhdXRvJiBiYWNrRm9yd2FyZENvbnRyb2xsZXIgPSBwYWdlLT5iYWNrRm9yd2Fy ZCgpOworCisgICAgaWYgKCFiYWNrRm9yd2FyZENvbnRyb2xsZXIuYmFja0l0ZW0oKSkKKyAgICAg ICAgcmV0dXJuOworCisgICAgX3ByaXZhdGUtPl9kaWRQZXJmb3JtRmlyc3ROYXZpZ2F0aW9uID0g WUVTOworCisgICAgaWYgKF9wcml2YXRlLT5wcmVmZXJlbmNlcy5hdXRvbWF0aWNhbGx5RGV0ZWN0 c0NhY2hlTW9kZWwgJiYgX3ByaXZhdGUtPnByZWZlcmVuY2VzLmNhY2hlTW9kZWwgPCBXZWJDYWNo ZU1vZGVsRG9jdW1lbnRCcm93c2VyKQorICAgICAgICBfcHJpdmF0ZS0+cHJlZmVyZW5jZXMuY2Fj aGVNb2RlbCA9IFdlYkNhY2hlTW9kZWxEb2N1bWVudEJyb3dzZXI7Cit9CisKIC0gKHZvaWQpX2Rp ZENvbW1pdExvYWRGb3JGcmFtZTooV2ViRnJhbWUgKilmcmFtZQogewogICAgIGlmIChmcmFtZSA9 PSBbc2VsZiBtYWluRnJhbWVdKQogICAgICAgICBbc2VsZiBfZGlkQ2hhbmdlVmFsdWVGb3JLZXk6 IF9XZWJNYWluRnJhbWVVUkxLZXldOworCisgICAgW3NlbGYgX2NoZWNrRGlkUGVyZm9ybUZpcnN0 TmF2aWdhdGlvbl07CisKICAgICBbTlNBcHAgc2V0V2luZG93c05lZWRVcGRhdGU6WUVTXTsKKwor ICAgIGlmIChfcHJpdmF0ZS0+X2RpZFBlcmZvcm1GaXJzdE5hdmlnYXRpb24pCisgICAgICAgIHJl dHVybjsKIH0KIAogLSAodm9pZClfZGlkRmluaXNoTG9hZEZvckZyYW1lOihXZWJGcmFtZSAqKWZy YW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXdEYXRhLmgg Yi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXdEYXRhLmgKaW5kZXggZDQzOWRjNDU0 MGI5YTk1MDYzMzg0OWU2MGE2NDg1NjNiYTRmMTAwNi4uNTdhMDdmMmVkMDU5NGFiZGNmMzVmYjQ5 YzA0YmI0NjNkMDFkYWNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJWaWV3RGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEu aApAQCAtMjg4LDUgKzI4OCw3IEBAIHByaXZhdGU6CiAjZW5kaWYKIAogICAgIFJldGFpblB0cjxO U0RhdGE+IHNvdXJjZUFwcGxpY2F0aW9uQXVkaXREYXRhOworCisgICAgQk9PTCBfZGlkUGVyZm9y bUZpcnN0TmF2aWdhdGlvbjsKIH0KIEBlbmQK