127169 2014-01-17 02:27:13 -0800 If not running on Mac, build-webkit should not print Safari related output 2014-02-10 05:11:05 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evab.u-szeged webkit-unassigned commit-queue darin dbates evab.u-szeged galpeter ossy oldest_to_newest 969091 0 evab.u-szeged 2014-01-17 02:27:13 -0800 If not runned on MAC, "Tools/Scripts/build-webkit" should not post Safari related informations. 969130 1 221463 evab.u-szeged 2014-01-17 06:56:47 -0800 Created attachment 221463 Patch 969160 2 221463 dbates 2014-01-17 09:55:20 -0800 Comment on attachment 221463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221463&action=review > Tools/ChangeLog:3 > + If not runned on MAC, "Tools/Scripts/build-webkit" should not post Safari related informations Nit: MAC => Mac Mac is not an acronym. It's shorthand for Macintosh. > Tools/Scripts/build-webkit:431 > + if ($launcherPath ne "0" && $launcherName ne "0") { Without loss of generality, take $launcherName to be undefined (say launcherName() falls off the end of the function) then evaluating the condition of this if statement will cause an uninitialized value warning because we run this script with -w (see the first line in this script). Moreover, it seems weird to define "0" as an invalid value and compare to it. It's sufficient to look at the truth value of the variables: if ($launcherPath && $launcherName) { ... } > Tools/Scripts/webkitdirs.pm:1290 > + } elsif (isDarwin()) { Can you elaborate on this change? > Tools/Scripts/webkitdirs.pm:1305 > + } elsif (isDarwin()) { Ditto. 970212 3 evab.u-szeged 2014-01-21 02:38:24 -0800 (In reply to comment #2) Thank you for your feedback. > Mac is not an acronym. It's shorthand for Macintosh. > if ($launcherPath && $launcherName) { ... } Thanks for noticing, you were absolutely right. I've modified the code. >> Tools/Scripts/webkitdirs.pm:1290 >> + } elsif (isDarwin()) { >Can you elaborate on this change? isAppleWebKit() gives back a value depending on the values of isGtk(), isEfl(), isWinCE(), isNix(). If we're using the script without any switch, each of these fuctions will give back a false value. But because of this, isAppleWebKit() will return as true, regardless of where we were running the script. This is why the Safari related output was given. isDarwin()'s value doesn't depend on any of the previously mentioned functions, that is why I thought it might be a good idea to use it instead of isAppleWebKit(). 973691 4 evab.u-szeged 2014-01-30 04:11:10 -0800 Ping? 973692 5 ossy 2014-01-30 04:14:06 -0800 (In reply to comment #4) > Ping? You turn now. :) Please fix what Daniel mentioned in https://bugs.webkit.org/show_bug.cgi?id=127169#c2 and then upload the fixed patch with r? 975848 6 222980 evab.u-szeged 2014-02-03 06:14:08 -0800 Created attachment 222980 Patch 975903 7 222980 darin 2014-02-03 09:55:56 -0800 Comment on attachment 222980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222980&action=review > Tools/Scripts/build-webkit:434 > + if ($launcherPath && $launcherName) { > + print " To run $launcherName with this newly-built code, use the\n"; > + print " \"$launcherPath\" script.\n"; > + } I understand this change. > Tools/Scripts/webkitdirs.pm:1290 > - } elsif (isAppleWebKit()) { > + } elsif (isDarwin()) { Why this change? Unclear how this relates to what the change log says. This makes it look like it will use run-safari more often, for anyone running on a Darwin system. That seems like the opposite of what the change log says this patch does. > Tools/Scripts/webkitdirs.pm:1307 > + } elsif (isDarwin()) { > + return "Safari"; > } Same comment here. 975904 8 darin 2014-02-03 09:57:04 -0800 (In reply to comment #3) > isAppleWebKit() gives back a value depending on the values of isGtk(), isEfl(), isWinCE(), isNix(). If we're using the script without any switch, each of these fuctions will give back a false value. But because of this, isAppleWebKit() will return as true, regardless of where we were running the script. If this is the problem, then we need to fix the isAppleWebKit function to correctly return false in these cases, rather than changing how it’s used. 977127 9 222980 bfulgham 2014-02-05 16:29:48 -0800 Comment on attachment 222980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222980&action=review > Tools/Scripts/webkitdirs.pm:-1300 > - return "Safari"; We should change this to WinLauncher. 977336 10 223332 evab.u-szeged 2014-02-06 07:35:14 -0800 Created attachment 223332 Patch 978799 11 223332 ossy 2014-02-10 02:47:33 -0800 Comment on attachment 223332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223332&action=review Please fix the typo before landing. > Tools/Scripts/webkitdirs.pm:1116 > + return return isDarwin() && !isGtk(); typo: return return > Tools/Scripts/webkitdirs.pm:1121 > + return return (isCygwin() || isWindows()) && !isWinCairo() && !isGtk() && !isWinCE(); ditto 978817 12 223692 evab.u-szeged 2014-02-10 04:11:40 -0800 Created attachment 223692 Patch 978827 13 223697 evab.u-szeged 2014-02-10 04:40:28 -0800 Created attachment 223697 patch for landing 978837 14 223697 commit-queue 2014-02-10 05:11:02 -0800 Comment on attachment 223697 patch for landing Clearing flags on attachment: 223697 Committed r163780: <http://trac.webkit.org/changeset/163780> 978838 15 commit-queue 2014-02-10 05:11:05 -0800 All reviewed patches have been landed. Closing bug. 221463 2014-01-17 06:56:47 -0800 2014-02-03 06:14:00 -0800 Patch bug-127169-20140117155646.patch text/plain 2564 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzFhYzk5YWM0MmE0MDk0YTRkMjRmNWEzYzBiMTNkZTNj YmY0NjA3Ny4uZjhjZjFiODhkNzFlOTY3MjZhMTUyMTNlZWFjMTAxNDY5MTMwZmMwNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTAxLTE3ICBFdmEgQmFsYXpzZmFsdmkgIDxiYWxhenNmYWx2aS5ldmFAc3R1ZC51 LXN6ZWdlZC5odT4KKworICAgICAgICBJZiBub3QgcnVubmVkIG9uIE1BQywgIlRvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0IiBzaG91bGQgbm90IHBvc3QgU2FmYXJpIHJlbGF0ZWQgaW5mb3JtYXRp b25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcx NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvYnVpbGQtd2Via2l0OgorICAgICAgICAod3JpdGVDb25ncmF0cyk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAobGF1bmNoZXJQYXRoKToKKyAgICAgICAg KGxhdW5jaGVyTmFtZSk6CisKIDIwMTQtMDEtMTUgIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vvay5v aEBjb2xsYWJvcmEuY29tPgogCiAgICAgICAgIFtFRkxdIENoYW5nZSB0ZXN0IGZvbnQgaW5zdGFs bGVkIHBhdGggdG8gd2Via2l0Z3RrLWZvbnQtdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggNWU0ZWM4 NDViNTdlZGQ1NDM3YWYyNTMwZGI2ZmFjNThiYTg3ZGM1NS4uOTRhNDkyOTY3OWY5N2VjMGNiZGIx MzRlMDgzMmFhZjM0Y2IxNzNlMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTQyNyw3ICs0MjcsMTEgQEAg c3ViIHdyaXRlQ29uZ3JhdHMoKQogICAgIHByaW50ICJcbiI7CiAgICAgcHJpbnQgIj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09XG4iOwogICAgIHByaW50ICIgV2ViS2l0IGlzIG5vdyBidWlsdCAoJGJ1aWxkVGltZSkuIFxu IjsKLSAgICBwcmludCAiIFRvIHJ1biAkbGF1bmNoZXJOYW1lIHdpdGggdGhpcyBuZXdseS1idWls dCBjb2RlLCB1c2UgdGhlXG4iOwotICAgIHByaW50ICIgXCIkbGF1bmNoZXJQYXRoXCIgc2NyaXB0 LlxuIjsKKworICAgIGlmICgkbGF1bmNoZXJQYXRoIG5lICIwIiAmJiAkbGF1bmNoZXJOYW1lIG5l ICIwIikgeworICAgICAgICBwcmludCAiIFRvIHJ1biAkbGF1bmNoZXJOYW1lIHdpdGggdGhpcyBu ZXdseS1idWlsdCBjb2RlLCB1c2UgdGhlXG4iOworICAgICAgICBwcmludCAiIFwiJGxhdW5jaGVy UGF0aFwiIHNjcmlwdC5cbiI7CisgICAgfQorCiAgICAgcHJpbnQgIj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09XG4iOwog fQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtCmluZGV4IDRkNGI2NGNiZGMxMmVmMmQxZWI3MWU0NDY3ZDFmOTNhOWEz ZDA2MjMuLmM4OTU5MTBiMWQ4ZTdmMWI5ZGEzZDI0NjU0ZDc4NmUwMmJkYWVkOGQgMTAwNzU1Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KQEAgLTEyODcsNyArMTI4Nyw3IEBAIHN1YiBsYXVuY2hlclBhdGgoKQogICAgIG15 ICRyZWxhdGl2ZVNjcmlwdHNQYXRoID0gcmVsYXRpdmVTY3JpcHRzRGlyKCk7CiAgICAgaWYgKGlz R3RrKCkgfHwgaXNFZmwoKSB8fCBpc1dpbkNFKCkgfHwgaXNOaXgoKSkgewogICAgICAgICByZXR1 cm4gIiRyZWxhdGl2ZVNjcmlwdHNQYXRoL3J1bi1sYXVuY2hlciI7Ci0gICAgfSBlbHNpZiAoaXNB cHBsZVdlYktpdCgpKSB7CisgICAgfSBlbHNpZiAoaXNEYXJ3aW4oKSkgewogICAgICAgICByZXR1 cm4gIiRyZWxhdGl2ZVNjcmlwdHNQYXRoL3J1bi1zYWZhcmkiOwogICAgIH0KIH0KQEAgLTEyOTYs MTQgKzEyOTYsMTQgQEAgc3ViIGxhdW5jaGVyTmFtZSgpCiB7CiAgICAgaWYgKGlzR3RrKCkpIHsK ICAgICAgICAgcmV0dXJuICJHdGtMYXVuY2hlciI7Ci0gICAgfSBlbHNpZiAoaXNBcHBsZVdlYktp dCgpKSB7Ci0gICAgICAgIHJldHVybiAiU2FmYXJpIjsKICAgICB9IGVsc2lmIChpc0VmbCgpKSB7 CiAgICAgICAgIHJldHVybiAiRVdlYkxhdW5jaGVyL01pbmlCcm93c2VyIjsKICAgICB9IGVsc2lm IChpc1dpbkNFKCkpIHsKICAgICAgICAgcmV0dXJuICJXaW5DRUxhdW5jaGVyIjsKICAgICB9IGVs c2lmIChpc05peCgpKSB7CiAgICAgICAgIHJldHVybiAiTWluaUJyb3dzZXIiOworICAgIH0gZWxz aWYgKGlzRGFyd2luKCkpIHsKKyAgICAgICAgcmV0dXJuICJTYWZhcmkiOwogICAgIH0KIH0KIAo= 222980 2014-02-03 06:14:08 -0800 2014-02-06 07:35:06 -0800 Patch bug-127169-20140203151406.patch text/plain 2530 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzFhYzk5YWM0MmE0MDk0YTRkMjRmNWEzYzBiMTNkZTNj YmY0NjA3Ny4uYTUxNzkzMjlkMTA2ODVhNzJlODRhYjk4Mzc2MDlmYmFjZGY5ODQ4MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTAyLTAzICBFdmEgQmFsYXpzZmFsdmkgIDxiYWxhenNmYWx2aS5ldmFAc3R1ZC51 LXN6ZWdlZC5odT4KKworICAgICAgICBJZiBub3QgcnVubmluZyBvbiBNYWMsIGJ1aWxkLXdlYmtp dCBzaG91bGQgbm90IHByaW50IFNhZmFyaSByZWxhdGVkIG91dHB1dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MTY5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoK KyAgICAgICAgKHdyaXRlQ29uZ3JhdHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKGxhdW5jaGVyUGF0aCk6CisgICAgICAgIChsYXVuY2hlck5hbWUpOgorCiAy MDE0LTAxLTE1ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAog ICAgICAgICBbRUZMXSBDaGFuZ2UgdGVzdCBmb250IGluc3RhbGxlZCBwYXRoIHRvIHdlYmtpdGd0 ay1mb250LXRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rv b2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDVlNGVjODQ1YjU3ZWRkNTQzN2FmMjUzMGRi NmZhYzU4YmE4N2RjNTUuLjJiN2VlN2ExODRmMDFmOWFmMmY1ZWJmMzU0ZWE2NmU4MGI1N2U0MGIg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0CkBAIC00MjcsNyArNDI3LDExIEBAIHN1YiB3cml0ZUNvbmdyYXRzKCkK ICAgICBwcmludCAiXG4iOwogICAgIHByaW50ICI9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PVxuIjsKICAgICBwcmludCAi IFdlYktpdCBpcyBub3cgYnVpbHQgKCRidWlsZFRpbWUpLiBcbiI7Ci0gICAgcHJpbnQgIiBUbyBy dW4gJGxhdW5jaGVyTmFtZSB3aXRoIHRoaXMgbmV3bHktYnVpbHQgY29kZSwgdXNlIHRoZVxuIjsK LSAgICBwcmludCAiIFwiJGxhdW5jaGVyUGF0aFwiIHNjcmlwdC5cbiI7CisKKyAgICBpZiAoJGxh dW5jaGVyUGF0aCAmJiAkbGF1bmNoZXJOYW1lKSB7CisgICAgICAgIHByaW50ICIgVG8gcnVuICRs YXVuY2hlck5hbWUgd2l0aCB0aGlzIG5ld2x5LWJ1aWx0IGNvZGUsIHVzZSB0aGVcbiI7CisgICAg ICAgIHByaW50ICIgXCIkbGF1bmNoZXJQYXRoXCIgc2NyaXB0LlxuIjsKKyAgICB9CisKICAgICBw cmludCAiPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT1cbiI7CiB9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNGQ0YjY0Y2JkYzEy ZWYyZDFlYjcxZTQ0NjdkMWY5M2E5YTNkMDYyMy4uYzg5NTkxMGIxZDhlN2YxYjlkYTNkMjQ2NTRk Nzg2ZTAyYmRhZWQ4ZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTI4Nyw3ICsxMjg3LDcgQEAgc3Vi IGxhdW5jaGVyUGF0aCgpCiAgICAgbXkgJHJlbGF0aXZlU2NyaXB0c1BhdGggPSByZWxhdGl2ZVNj cmlwdHNEaXIoKTsKICAgICBpZiAoaXNHdGsoKSB8fCBpc0VmbCgpIHx8IGlzV2luQ0UoKSB8fCBp c05peCgpKSB7CiAgICAgICAgIHJldHVybiAiJHJlbGF0aXZlU2NyaXB0c1BhdGgvcnVuLWxhdW5j aGVyIjsKLSAgICB9IGVsc2lmIChpc0FwcGxlV2ViS2l0KCkpIHsKKyAgICB9IGVsc2lmIChpc0Rh cndpbigpKSB7CiAgICAgICAgIHJldHVybiAiJHJlbGF0aXZlU2NyaXB0c1BhdGgvcnVuLXNhZmFy aSI7CiAgICAgfQogfQpAQCAtMTI5NiwxNCArMTI5NiwxNCBAQCBzdWIgbGF1bmNoZXJOYW1lKCkK IHsKICAgICBpZiAoaXNHdGsoKSkgewogICAgICAgICByZXR1cm4gIkd0a0xhdW5jaGVyIjsKLSAg ICB9IGVsc2lmIChpc0FwcGxlV2ViS2l0KCkpIHsKLSAgICAgICAgcmV0dXJuICJTYWZhcmkiOwog ICAgIH0gZWxzaWYgKGlzRWZsKCkpIHsKICAgICAgICAgcmV0dXJuICJFV2ViTGF1bmNoZXIvTWlu aUJyb3dzZXIiOwogICAgIH0gZWxzaWYgKGlzV2luQ0UoKSkgewogICAgICAgICByZXR1cm4gIldp bkNFTGF1bmNoZXIiOwogICAgIH0gZWxzaWYgKGlzTml4KCkpIHsKICAgICAgICAgcmV0dXJuICJN aW5pQnJvd3NlciI7CisgICAgfSBlbHNpZiAoaXNEYXJ3aW4oKSkgeworICAgICAgICByZXR1cm4g IlNhZmFyaSI7CiAgICAgfQogfQogCg== 223332 2014-02-06 07:35:14 -0800 2014-02-10 04:11:29 -0800 Patch bug-127169-20140206163513.patch text/plain 2723 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMzcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODdkZTY4YjIxY2VmNWI2N2VlZTA0ZGU4NDUzNzFlNDdi ZDA1YjU1ZS4uY2ExMDA5Nzk5Yjk4MzJjYTZjN2UxYzNlYzE4N2Q0YmNjYmQ0Mzg0NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAyLTA2ICBFdmEgQmFsYXpzZmFsdmkgIDxiYWxhenNmYWx2aS5ldmFAc3R1ZC51 LXN6ZWdlZC5odT4KKworICAgICAgICBJZiBub3QgcnVubmluZyBvbiBNYWMsIGJ1aWxkLXdlYmtp dCBzaG91bGQgbm90IHByaW50IFNhZmFyaSByZWxhdGVkIG91dHB1dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MTY5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoK KyAgICAgICAgKHdyaXRlQ29uZ3JhdHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKGlzQXBwbGVXZWJLaXQpOgorICAgICAgICAoaXNBcHBsZU1hY1dlYktpdCk6 CisgICAgICAgIChpc0FwcGxlV2luV2ViS2l0KToKKyAgICAgICAgKGxhdW5jaGVyTmFtZSk6CisK IDIwMTQtMDItMDMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg a2lsbC1vbGQtcHJvY2Vzc2VzIGRvZXNuJ3Qga2lsbCBwbHVnaW4gcHJvY2Vzc2VzCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CmluZGV4IDNjZmRjZjk1NWMyYjUyM2MwY2JkYmI2ODc5YzRiZGU3MzEyNmU4YzkuLmRmMWI1 ZTBhOGJjNDQ1YTg1NDY2YWEwMjNmZjgxZTliZGExNjQwMzcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC0z NzAsNyArMzcwLDkgQEAgc3ViIHdyaXRlQ29uZ3JhdHMoKQogICAgIHByaW50ICJcbiI7CiAgICAg cHJpbnQgIj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09XG4iOwogICAgIHByaW50ICIgV2ViS2l0IGlzIG5vdyBidWlsdCAo JGJ1aWxkVGltZSkuIFxuIjsKLSAgICBwcmludCAiIFRvIHJ1biAkbGF1bmNoZXJOYW1lIHdpdGgg dGhpcyBuZXdseS1idWlsdCBjb2RlLCB1c2UgdGhlXG4iOwotICAgIHByaW50ICIgXCIkbGF1bmNo ZXJQYXRoXCIgc2NyaXB0LlxuIjsKKyAgICBpZiAoJGxhdW5jaGVyUGF0aCAmJiAkbGF1bmNoZXJO YW1lKSB7CisgICAgICAgIHByaW50ICIgVG8gcnVuICRsYXVuY2hlck5hbWUgd2l0aCB0aGlzIG5l d2x5LWJ1aWx0IGNvZGUsIHVzZSB0aGVcbiI7CisgICAgICAgIHByaW50ICIgXCIkbGF1bmNoZXJQ YXRoXCIgc2NyaXB0LlxuIjsKKyAgICB9CiAgICAgcHJpbnQgIj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09XG4iOwogfQpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCmluZGV4IDRhMzM1NDRlYTkzMTEwYjczZjcxYzc4Y2IyN2MxYzQwNDE5NjE1 MGYuLmExYTUyN2Q2OTkzYzNmOWI2Yjk2N2IxODVlMGMxOGNjMzFjMzg5ODAgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KQEAgLTExMDgsMTcgKzExMDgsMTcgQEAgc3ViIGlzQ3Jvc3NDb21waWxhdGlvbigpCiAK IHN1YiBpc0FwcGxlV2ViS2l0KCkKIHsKLSAgICByZXR1cm4gIShpc0d0aygpIG9yIGlzRWZsKCkg b3IgaXNXaW5DRSgpKTsKKyAgICByZXR1cm4gaXNBcHBsZU1hY1dlYktpdCgpIHx8IGlzQXBwbGVX aW5XZWJLaXQoKTsKIH0KIAogc3ViIGlzQXBwbGVNYWNXZWJLaXQoKQogewotICAgIHJldHVybiBp c0FwcGxlV2ViS2l0KCkgJiYgaXNEYXJ3aW4oKTsKKyAgICByZXR1cm4gcmV0dXJuIGlzRGFyd2lu KCkgJiYgIWlzR3RrKCk7CiB9CiAKIHN1YiBpc0FwcGxlV2luV2ViS2l0KCkKIHsKLSAgICByZXR1 cm4gaXNBcHBsZVdlYktpdCgpICYmIChpc0N5Z3dpbigpIHx8IGlzV2luZG93cygpKSAmJiAhaXNX aW5DYWlybygpOworICAgIHJldHVybiByZXR1cm4gKGlzQ3lnd2luKCkgfHwgaXNXaW5kb3dzKCkp ICYmICFpc1dpbkNhaXJvKCkgJiYgIWlzR3RrKCkgJiYgIWlzV2luQ0UoKTsKIH0KIAogc3ViIHdp bGxVc2VJT1NEZXZpY2VTREtXaGVuQnVpbGRpbmcoKQpAQCAtMTMxMCw4ICsxMzEwLDEwIEBAIHN1 YiBsYXVuY2hlck5hbWUoKQogewogICAgIGlmIChpc0d0aygpKSB7CiAgICAgICAgIHJldHVybiAi R3RrTGF1bmNoZXIiOwotICAgIH0gZWxzaWYgKGlzQXBwbGVXZWJLaXQoKSkgeworICAgIH0gZWxz aWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgewogICAgICAgICByZXR1cm4gIlNhZmFyaSI7CisgICAg fSBlbHNpZiAoaXNBcHBsZVdpbldlYktpdCgpKSB7CisgICAgICAgIHJldHVybiAiV2luTGF1bmNo ZXIiOwogICAgIH0gZWxzaWYgKGlzRWZsKCkpIHsKICAgICAgICAgcmV0dXJuICJFV2ViTGF1bmNo ZXIvTWluaUJyb3dzZXIiOwogICAgIH0gZWxzaWYgKGlzV2luQ0UoKSkgewo= 223692 2014-02-10 04:11:40 -0800 2014-02-10 04:31:52 -0800 Patch bug-127169-20140210131138.patch text/plain 2709 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMzcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODdkZTY4YjIxY2VmNWI2N2VlZTA0ZGU4NDUzNzFlNDdi ZDA1YjU1ZS4uZWUwMTUzODU4Y2JjZDg3M2E4N2NmMDg0OTJiOTNmMTFhYjZhNTc1YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAyLTEwICBFdmEgQmFsYXpzZmFsdmkgIDxiYWxhenNmYWx2aS5ldmFAc3R1ZC51 LXN6ZWdlZC5odT4KKworICAgICAgICBJZiBub3QgcnVubmluZyBvbiBNYWMsIGJ1aWxkLXdlYmtp dCBzaG91bGQgbm90IHByaW50IFNhZmFyaSByZWxhdGVkIG91dHB1dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MTY5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoK KyAgICAgICAgKHdyaXRlQ29uZ3JhdHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKGlzQXBwbGVXZWJLaXQpOgorICAgICAgICAoaXNBcHBsZU1hY1dlYktpdCk6 CisgICAgICAgIChpc0FwcGxlV2luV2ViS2l0KToKKyAgICAgICAgKGxhdW5jaGVyTmFtZSk6CisK IDIwMTQtMDItMDMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg a2lsbC1vbGQtcHJvY2Vzc2VzIGRvZXNuJ3Qga2lsbCBwbHVnaW4gcHJvY2Vzc2VzCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CmluZGV4IDNjZmRjZjk1NWMyYjUyM2MwY2JkYmI2ODc5YzRiZGU3MzEyNmU4YzkuLmRmMWI1 ZTBhOGJjNDQ1YTg1NDY2YWEwMjNmZjgxZTliZGExNjQwMzcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC0z NzAsNyArMzcwLDkgQEAgc3ViIHdyaXRlQ29uZ3JhdHMoKQogICAgIHByaW50ICJcbiI7CiAgICAg cHJpbnQgIj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09XG4iOwogICAgIHByaW50ICIgV2ViS2l0IGlzIG5vdyBidWlsdCAo JGJ1aWxkVGltZSkuIFxuIjsKLSAgICBwcmludCAiIFRvIHJ1biAkbGF1bmNoZXJOYW1lIHdpdGgg dGhpcyBuZXdseS1idWlsdCBjb2RlLCB1c2UgdGhlXG4iOwotICAgIHByaW50ICIgXCIkbGF1bmNo ZXJQYXRoXCIgc2NyaXB0LlxuIjsKKyAgICBpZiAoJGxhdW5jaGVyUGF0aCAmJiAkbGF1bmNoZXJO YW1lKSB7CisgICAgICAgIHByaW50ICIgVG8gcnVuICRsYXVuY2hlck5hbWUgd2l0aCB0aGlzIG5l d2x5LWJ1aWx0IGNvZGUsIHVzZSB0aGVcbiI7CisgICAgICAgIHByaW50ICIgXCIkbGF1bmNoZXJQ YXRoXCIgc2NyaXB0LlxuIjsKKyAgICB9CiAgICAgcHJpbnQgIj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09XG4iOwogfQpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCmluZGV4IDRhMzM1NDRlYTkzMTEwYjczZjcxYzc4Y2IyN2MxYzQwNDE5NjE1 MGYuLjg0NGRjZmJkMzE1NzE3NGRmNjdmN2ZkNjEwNjA0OWI5OGQ5NGJmZWQgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KQEAgLTExMDgsMTcgKzExMDgsMTcgQEAgc3ViIGlzQ3Jvc3NDb21waWxhdGlvbigpCiAK IHN1YiBpc0FwcGxlV2ViS2l0KCkKIHsKLSAgICByZXR1cm4gIShpc0d0aygpIG9yIGlzRWZsKCkg b3IgaXNXaW5DRSgpKTsKKyAgICByZXR1cm4gaXNBcHBsZU1hY1dlYktpdCgpIHx8IGlzQXBwbGVX aW5XZWJLaXQoKTsKIH0KIAogc3ViIGlzQXBwbGVNYWNXZWJLaXQoKQogewotICAgIHJldHVybiBp c0FwcGxlV2ViS2l0KCkgJiYgaXNEYXJ3aW4oKTsKKyAgICByZXR1cm4gaXNEYXJ3aW4oKSAmJiAh aXNHdGsoKTsKIH0KIAogc3ViIGlzQXBwbGVXaW5XZWJLaXQoKQogewotICAgIHJldHVybiBpc0Fw cGxlV2ViS2l0KCkgJiYgKGlzQ3lnd2luKCkgfHwgaXNXaW5kb3dzKCkpICYmICFpc1dpbkNhaXJv KCk7CisgICAgcmV0dXJuIChpc0N5Z3dpbigpIHx8IGlzV2luZG93cygpKSAmJiAhaXNXaW5DYWly bygpICYmICFpc0d0aygpICYmICFpc1dpbkNFKCk7CiB9CiAKIHN1YiB3aWxsVXNlSU9TRGV2aWNl U0RLV2hlbkJ1aWxkaW5nKCkKQEAgLTEzMTAsOCArMTMxMCwxMCBAQCBzdWIgbGF1bmNoZXJOYW1l KCkKIHsKICAgICBpZiAoaXNHdGsoKSkgewogICAgICAgICByZXR1cm4gIkd0a0xhdW5jaGVyIjsK LSAgICB9IGVsc2lmIChpc0FwcGxlV2ViS2l0KCkpIHsKKyAgICB9IGVsc2lmIChpc0FwcGxlTWFj V2ViS2l0KCkpIHsKICAgICAgICAgcmV0dXJuICJTYWZhcmkiOworICAgIH0gZWxzaWYgKGlzQXBw bGVXaW5XZWJLaXQoKSkgeworICAgICAgICByZXR1cm4gIldpbkxhdW5jaGVyIjsKICAgICB9IGVs c2lmIChpc0VmbCgpKSB7CiAgICAgICAgIHJldHVybiAiRVdlYkxhdW5jaGVyL01pbmlCcm93c2Vy IjsKICAgICB9IGVsc2lmIChpc1dpbkNFKCkpIHsK 223697 2014-02-10 04:40:28 -0800 2014-02-10 05:11:02 -0800 patch for landing diff.diff text/plain 2480 evab.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4N2Rl NjhiLi40YzRhZDE0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDItMTAgIEV2YSBCYWxhenNmYWx2aSAgPGJh bGF6c2ZhbHZpLmV2YUBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIElmIG5vdCBydW5uaW5n IG9uIE1hYywgYnVpbGQtd2Via2l0IHNob3VsZCBub3QgcHJpbnQgU2FmYXJpIHJlbGF0ZWQgb3V0 cHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcx NjkKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICAqIFNjcmlw dHMvYnVpbGQtd2Via2l0OgorICAgICAgICAod3JpdGVDb25ncmF0cyk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoaXNBcHBsZVdlYktpdCk6CisgICAgICAgIChp c0FwcGxlTWFjV2ViS2l0KToKKyAgICAgICAgKGlzQXBwbGVXaW5XZWJLaXQpOgorICAgICAgICAo bGF1bmNoZXJOYW1lKToKKwogMjAxNC0wMi0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBraWxsLW9sZC1wcm9jZXNzZXMgZG9lc24ndCBraWxsIHBsdWdpbiBw cm9jZXNzZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvVG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggM2NmZGNmOS4uZGYxYjVlMCAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKQEAgLTM3MCw3ICszNzAsOSBAQCBzdWIgd3JpdGVDb25ncmF0cygpCiAgICAgcHJpbnQgIlxu IjsKICAgICBwcmludCAiPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT1cbiI7CiAgICAgcHJpbnQgIiBXZWJLaXQgaXMgbm93 IGJ1aWx0ICgkYnVpbGRUaW1lKS4gXG4iOwotICAgIHByaW50ICIgVG8gcnVuICRsYXVuY2hlck5h bWUgd2l0aCB0aGlzIG5ld2x5LWJ1aWx0IGNvZGUsIHVzZSB0aGVcbiI7Ci0gICAgcHJpbnQgIiBc IiRsYXVuY2hlclBhdGhcIiBzY3JpcHQuXG4iOworICAgIGlmICgkbGF1bmNoZXJQYXRoICYmICRs YXVuY2hlck5hbWUpIHsKKyAgICAgICAgcHJpbnQgIiBUbyBydW4gJGxhdW5jaGVyTmFtZSB3aXRo IHRoaXMgbmV3bHktYnVpbHQgY29kZSwgdXNlIHRoZVxuIjsKKyAgICAgICAgcHJpbnQgIiBcIiRs YXVuY2hlclBhdGhcIiBzY3JpcHQuXG4iOworICAgIH0KICAgICBwcmludCAiPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT1c biI7CiB9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNGEzMzU0NC4uODQ0ZGNmYiAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQpAQCAtMTEwOCwxNyArMTEwOCwxNyBAQCBzdWIgaXNDcm9zc0NvbXBpbGF0aW9uKCkKIAog c3ViIGlzQXBwbGVXZWJLaXQoKQogewotICAgIHJldHVybiAhKGlzR3RrKCkgb3IgaXNFZmwoKSBv ciBpc1dpbkNFKCkpOworICAgIHJldHVybiBpc0FwcGxlTWFjV2ViS2l0KCkgfHwgaXNBcHBsZVdp bldlYktpdCgpOwogfQogCiBzdWIgaXNBcHBsZU1hY1dlYktpdCgpCiB7Ci0gICAgcmV0dXJuIGlz QXBwbGVXZWJLaXQoKSAmJiBpc0RhcndpbigpOworICAgIHJldHVybiBpc0RhcndpbigpICYmICFp c0d0aygpOwogfQogCiBzdWIgaXNBcHBsZVdpbldlYktpdCgpCiB7Ci0gICAgcmV0dXJuIGlzQXBw bGVXZWJLaXQoKSAmJiAoaXNDeWd3aW4oKSB8fCBpc1dpbmRvd3MoKSkgJiYgIWlzV2luQ2Fpcm8o KTsKKyAgICByZXR1cm4gKGlzQ3lnd2luKCkgfHwgaXNXaW5kb3dzKCkpICYmICFpc1dpbkNhaXJv KCkgJiYgIWlzR3RrKCkgJiYgIWlzV2luQ0UoKTsKIH0KIAogc3ViIHdpbGxVc2VJT1NEZXZpY2VT REtXaGVuQnVpbGRpbmcoKQpAQCAtMTMxMCw4ICsxMzEwLDEwIEBAIHN1YiBsYXVuY2hlck5hbWUo KQogewogICAgIGlmIChpc0d0aygpKSB7CiAgICAgICAgIHJldHVybiAiR3RrTGF1bmNoZXIiOwot ICAgIH0gZWxzaWYgKGlzQXBwbGVXZWJLaXQoKSkgeworICAgIH0gZWxzaWYgKGlzQXBwbGVNYWNX ZWJLaXQoKSkgewogICAgICAgICByZXR1cm4gIlNhZmFyaSI7CisgICAgfSBlbHNpZiAoaXNBcHBs ZVdpbldlYktpdCgpKSB7CisgICAgICAgIHJldHVybiAiV2luTGF1bmNoZXIiOwogICAgIH0gZWxz aWYgKGlzRWZsKCkpIHsKICAgICAgICAgcmV0dXJuICJFV2ViTGF1bmNoZXIvTWluaUJyb3dzZXIi OwogICAgIH0gZWxzaWYgKGlzV2luQ0UoKSkgewo=