127140 2014-01-16 13:43:42 -0800 FrameView compile fix for non-accelerated-compositing 2014-01-16 17:47:10 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Trivial --- 1 alex.christensen webkit-unassigned bdakin commit-queue simon.fraser oldest_to_newest 968913 0 alex.christensen 2014-01-16 13:43:42 -0800 http://trac.webkit.org/changeset/162138 doesn't compile because RenderView:: backgroundRect requires a parameter. In RenderView::backgroundRect, unscaledDocumentRect() is used if hasColumns() and hasExtendedBackground() are both false. I'm not completely sure which rectangle to use. Is this correct? When I use accelerated compositing on WinCairo, will all ports use accelerated compositing? Then we could get rid of all the non-accelerated-compositing code, right? 968915 1 221410 alex.christensen 2014-01-16 13:46:32 -0800 Created attachment 221410 Patch 968977 2 221410 bdakin 2014-01-16 15:50:58 -0800 Comment on attachment 221410 Patch Thanks Alex! 969013 3 221410 commit-queue 2014-01-16 17:47:08 -0800 Comment on attachment 221410 Patch Clearing flags on attachment: 221410 Committed r162176: <http://trac.webkit.org/changeset/162176> 969014 4 commit-queue 2014-01-16 17:47:10 -0800 All reviewed patches have been landed. Closing bug. 221410 2014-01-16 13:46:32 -0800 2014-01-16 17:47:08 -0800 Patch bug-127140-20140116144631.patch text/plain 1148 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjE0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTE2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ29tcGlsZSBm aXggZm9yIFdpbkNhaXJvIGFmdGVyIHIxNjIxMzguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcxNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lVmlldzo6ZXh0ZW5kZWRCYWNrZ3JvdW5kUmVjdCk6CisgICAgICAgIFVzZSB1 bnNjYWxlZERvY3VtZW50UmVjdCBmb3IgZXh0ZW5kZWRCYWNrZ3JvdW5kUmVjdCB3aXRob3V0IGFj Y2VsZXJhdGVkIGNvbXBvc2l0aW5nLgorCiAyMDE0LTAxLTE2ICBCcmFkeSBFaWRzb24gIDxiZWlk c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgS2V5ZWRDb2RpbmcgYXMgYSBwZXJzaXN0ZW50 IHN0b3JhZ2UgbWVjaGFuaXNtIGZvciBibG9icwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAkocmV2aXNpb24gMTYyMTQ3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjc0LDcgKzI2NzQsNyBAQCBJbnRSZWN0IEZyYW1lVmll dzo6ZXh0ZW5kZWRCYWNrZ3JvdW5kUmVjCiAgICAgaWYgKCFyZW5kZXJWaWV3KQogICAgICAgICBy ZXR1cm4gSW50UmVjdCgpOwogCi0gICAgcmV0dXJuIHJlbmRlclZpZXctPmJhY2tncm91bmRSZWN0 KCk7CisgICAgcmV0dXJuIHJlbmRlclZpZXctPnVuc2NhbGVkRG9jdW1lbnRSZWN0KCk7CiAjZW5k aWYKIH0KIAo=