127137 2014-01-16 13:08:44 -0800 [iOS] HTMLMediaSession should set AudioSession category 2014-01-17 13:33:48 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue esprehn+autocc glenn gyuyoung.kim jer.noble oldest_to_newest 968894 0 eric.carlson 2014-01-16 13:08:44 -0800 On iOS, an HTMLMediaElement should always set the audio category to "media" so the ringer switch and volume controls do the right thing. 968903 1 221406 eric.carlson 2014-01-16 13:27:21 -0800 Created attachment 221406 Proposed patch 969042 2 221406 sam 2014-01-16 22:04:23 -0800 Comment on attachment 221406 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221406&action=review > Source/WebCore/html/HTMLMediaSession.cpp:58 > +#if PLATFORM(IOS) > +static void initializeAudioSession() > +{ > + static bool wasAudioSessionInitialized; > + if (wasAudioSessionInitialized) > + return; > + > + wasAudioSessionInitialized = true; > + if (!WebCore::applicationIsMobileSafari()) > + return; > + > + AudioSession::sharedSession().setCategory(AudioSession::MediaPlayback); > +} > +#endif Why do we only want to do this on iOS (and only in MobileSafari)? > Source/WebCore/html/HTMLMediaSession.cpp:71 > +#if PLATFORM(IOS) > + initializeAudioSession(); > +#endif I would rather we always call this, and have it do nothing on platforms that don't need it. 969165 3 eric.carlson 2014-01-17 10:28:28 -0800 (In reply to comment #2) > (From update of attachment 221406 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221406&action=review > > > Source/WebCore/html/HTMLMediaSession.cpp:58 > > +#if PLATFORM(IOS) > > +static void initializeAudioSession() > > +{ > > + static bool wasAudioSessionInitialized; > > + if (wasAudioSessionInitialized) > > + return; > > + > > + wasAudioSessionInitialized = true; > > + if (!WebCore::applicationIsMobileSafari()) > > + return; > > + > > + AudioSession::sharedSession().setCategory(AudioSession::MediaPlayback); > > +} > > +#endif > > Why do we only want to do this on iOS (and only in MobileSafari)? > AudioSession only has category support on iOS. We only set the category in MobileSafari because apps using a UIWebView may need to use another category, and can do so with the UIWebView. > > Source/WebCore/html/HTMLMediaSession.cpp:71 > > +#if PLATFORM(IOS) > > + initializeAudioSession(); > > +#endif > > I would rather we always call this, and have it do nothing on platforms that don't need it. > OK, I will fix this in a follow-up. 969178 4 eric.carlson 2014-01-17 11:34:02 -0800 (In reply to comment #3) > (In reply to comment #2) > > I would rather we always call this, and have it do nothing on platforms that don't need it. > > > OK, I will fix this in a follow-up. By which I meant "I will fix this when I check in". 969247 5 eric.carlson 2014-01-17 13:33:38 -0800 Committed r162221: http://trac.webkit.org/changeset/162221 221406 2014-01-16 13:27:21 -0800 2014-01-17 13:33:48 -0800 Proposed patch audio_session_2.txt text/plain 1947 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjE0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTE2ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEhUTUxNZWRp YVNlc3Npb24gc2hvdWxkIHNldCBBdWRpb1Nlc3Npb24gY2F0ZWdvcnkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzEzNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFTZXNzaW9u LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVBdWRpb1Nlc3Npb24pOiBOZXcsIHNl dCB0aGUgYXVkaW8gc2Vzc2lvbiB0byAibWVkaWEiLgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1l ZGlhU2Vzc2lvbjo6SFRNTE1lZGlhU2Vzc2lvbik6IENhbGwgaW5pdGlhbGl6ZUF1ZGlvU2Vzc2lv bi4KKwogMjAxNC0wMS0xNiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBBbGxvdyBNZWRpYVNlc3Npb25NYW5hZ2VyIHRvIHJlc3RyaWN0IGlubGluZSA8 dmlkZW8+IHBsYXliYWNrCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYVNlc3Np b24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhU2Vzc2lv bi5jcHAJKHJldmlzaW9uIDE2MjE0NSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh U2Vzc2lvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDExICszNiwyNyBAQAogI2luY2x1ZGUg IlNjcmlwdENvbnRyb2xsZXIuaCIKIAogI2lmIFBMQVRGT1JNKElPUykKKyNpbmNsdWRlICJBdWRp b1Nlc3Npb24uaCIKICNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVja3NJT1MuaCIKICNl bmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyNpZiBQTEFURk9STShJT1MpCitzdGF0aWMg dm9pZCBpbml0aWFsaXplQXVkaW9TZXNzaW9uKCkKK3sKKyAgICBzdGF0aWMgYm9vbCB3YXNBdWRp b1Nlc3Npb25Jbml0aWFsaXplZDsKKyAgICBpZiAod2FzQXVkaW9TZXNzaW9uSW5pdGlhbGl6ZWQp CisgICAgICAgIHJldHVybjsKKworICAgIHdhc0F1ZGlvU2Vzc2lvbkluaXRpYWxpemVkID0gdHJ1 ZTsKKyAgICBpZiAoIVdlYkNvcmU6OmFwcGxpY2F0aW9uSXNNb2JpbGVTYWZhcmkoKSkKKyAgICAg ICAgcmV0dXJuOworCisgICAgQXVkaW9TZXNzaW9uOjpzaGFyZWRTZXNzaW9uKCkuc2V0Q2F0ZWdv cnkoQXVkaW9TZXNzaW9uOjpNZWRpYVBsYXliYWNrKTsKK30KKyNlbmRpZgorCiBzdGQ6OnVuaXF1 ZV9wdHI8SFRNTE1lZGlhU2Vzc2lvbj4gSFRNTE1lZGlhU2Vzc2lvbjo6Y3JlYXRlKE1lZGlhU2Vz c2lvbkNsaWVudCYgY2xpZW50KQogewogICAgIHJldHVybiBzdGQ6Om1ha2VfdW5pcXVlPEhUTUxN ZWRpYVNlc3Npb24+KGNsaWVudCk7CkBAIC01MCw2ICs2Niw5IEBAIEhUTUxNZWRpYVNlc3Npb246 OkhUTUxNZWRpYVNlc3Npb24oTWVkaWEKICAgICA6IE1lZGlhU2Vzc2lvbihjbGllbnQpCiAgICAg LCBtX3Jlc3RyaWN0aW9ucyhOb1Jlc3RyaWN0aW9ucykKIHsKKyNpZiBQTEFURk9STShJT1MpCisg ICAgaW5pdGlhbGl6ZUF1ZGlvU2Vzc2lvbigpOworI2VuZGlmCiB9CiAKIHZvaWQgSFRNTE1lZGlh U2Vzc2lvbjo6YWRkQmVoYXZpb3JSZXN0cmljdGlvbihCZWhhdmlvclJlc3RyaWN0aW9ucyByZXN0 cmljdGlvbikK