127128 2014-01-16 11:58:59 -0800 Inspector scripts are not compatible with Python v3 2014-01-18 01:00:22 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 marcel.tiede zan joepeck timothy zan oldest_to_newest 968843 0 marcel.tiede 2014-01-16 11:58:59 -0800 Trying to build the current unstable release 2.3.4 under Archlinux fails. Archlinux is using python3 as "/usr/bin/python". --- File "./Source/JavaScriptCore/inspector/scripts/jsmin.py", line 33, in <module> from StringIO import StringIO ImportError: No module named 'StringIO' --- As I'm not a python developer I tried fixing this by simply loading the python3 Module io for StringIO, what revealed the next error: --- File "./Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py", line 32 print "usage: %s [json files or directory of json files ...]" % os.path.basename(sys.argv[0]) ^ SyntaxError: invalid syntax --- Using parentheses for all print commands in the file "generate-combined-inspector-json.py" fixed the compilation issue. 969101 1 221453 zan 2014-01-17 03:12:23 -0800 Created attachment 221453 Patch 969229 2 221453 benjamin 2014-01-17 13:06:56 -0800 Comment on attachment 221453 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221453&action=review cool! > Source/JavaScriptCore/inspector/scripts/jsmin.py:36 > +try: > + from StringIO import StringIO > +except ImportError: > + from io import StringIO Maybe add a Python3 comment here so that we know to remove it in the future? 969421 3 zan 2014-01-18 01:00:22 -0800 Committed r162250: <http://trac.webkit.org/changeset/162250> 221453 2014-01-17 03:12:23 -0800 2014-01-17 13:06:56 -0800 Patch bug-127128-20140117031221.patch text/plain 2717 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MzIzY2FkZDc2NDM5Njc5NzMyZmE1NTUwNmIxZWEyYzFjMDBlNjUxLi5mYTMzZGI1MjdiZDkzOTkw YjhmM2MxYTQ2OWM2ZWMxOTAzMzk1MDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNC0wMS0xNyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CisKKyAgICAgICAgSW5zcGVjdG9yIHNjcmlwdHMgYXJlIG5vdCBjb21wYXRpYmxlIHdpdGgg UHl0aG9uIHYzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjcxMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGluc3BlY3Rvci9zY3JpcHRzL2dlbmVyYXRlLWNvbWJpbmVkLWluc3BlY3Rvci1qc29uLnB5 OiBUdXJuIHByaW50IHN0YXRlbWVudHMgaW50byBwcmludCBmdW5jdGlvbiBjYWxscy4KKyAgICAg ICAgKiBpbnNwZWN0b3Ivc2NyaXB0cy9qc21pbi5weTogVHJ5IGltcG9ydGluZyB0aGUgU3RyaW5n SU8gY2xhc3MgZnJvbSB0aGUgU3RyaW5nSU8gbW9kdWxlICh3aGljaCB3aWxsIHdvcmsgZm9yCisg ICAgICAgIFB5dGhvbiB2Mikgb3IsIG9uIGltcG9ydCBlcnJvciwgaW1wb3J0IHRoZSBjbGFzcyBm cm9tIHRoZSBpbyBtb2R1bGUgKHdoaWNoIHdpbGwgd29yayBmb3IgUHl0aG9uIHYzKS4KKwogMjAx NC0wMS0xMCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAg ICAgIENvcHlpbmcgc2hvdWxkIGJlIGdlbmVyYXRpb25hbApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2dlbmVyYXRlLWNvbWJpbmVkLWluc3BlY3Rv ci1qc29uLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2dlbmVy YXRlLWNvbWJpbmVkLWluc3BlY3Rvci1qc29uLnB5CmluZGV4IGQ5OWJjZWU5ZWNhNzhmYzZiZTgw ZTAwYjVhNDBjODE5ZjVjZWYwZmYuLmRiMTYzYmZlNDE4MzhmNmJlYTNkNmViMDNjZGQ5MTYzMWYx MjgxODAgMTAwNzU1Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0 cy9nZW5lcmF0ZS1jb21iaW5lZC1pbnNwZWN0b3ItanNvbi5weQorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvZ2VuZXJhdGUtY29tYmluZWQtaW5zcGVjdG9yLWpz b24ucHkKQEAgLTI5LDcgKzI5LDcgQEAgaW1wb3J0IG9zCiBpbXBvcnQgc3lzCiAKIGlmIGxlbihz eXMuYXJndikgPCAyOgotICAgIHByaW50ICJ1c2FnZTogJXMgW2pzb24gZmlsZXMgb3IgZGlyZWN0 b3J5IG9mIGpzb24gZmlsZXMgLi4uXSIgJSBvcy5wYXRoLmJhc2VuYW1lKHN5cy5hcmd2WzBdKQor ICAgIHByaW50KCJ1c2FnZTogJXMgW2pzb24gZmlsZXMgb3IgZGlyZWN0b3J5IG9mIGpzb24gZmls ZXMgLi4uXSIgJSBvcy5wYXRoLmJhc2VuYW1lKHN5cy5hcmd2WzBdKSkKICAgICBzeXMuZXhpdCgx KQogCiBmaWxlcyA9IFtdCkBAIC00NywxMiArNDcsMTIgQEAgZmlsZXMuc29ydCgpCiAjIFZhbGlk YXRlIGVhY2ggZmlsZSBpcyB2YWxpZCBKU09OIGFuZCB0aGF0IHRoZXJlIGlzIGEgImRvbWFpbiIg a2V5LgogCiBmaXJzdCA9IFRydWUKLXByaW50ICJ7XCJkb21haW5zXCI6WyIKK3ByaW50KCJ7XCJk b21haW5zXCI6WyIpCiBmb3IgZmlsZSBpbiBmaWxlczoKICAgICBpZiBmaXJzdDoKICAgICAgICAg Zmlyc3QgPSBGYWxzZQogICAgIGVsc2U6Ci0gICAgICAgIHByaW50ICIsIgorICAgICAgICBwcmlu dCgiLCIpCiAKICAgICBzdHJpbmcgPSBvcGVuKGZpbGUpLnJlYWQoKQogCkBAIC02NCw1ICs2NCw1 IEBAIGZvciBmaWxlIGluIGZpbGVzOgogICAgICAgICBzeXMuc3RkZXJyLndyaXRlKCJGaWxlIFwi JXNcIiBkb2VzIG5vdCBjb250YWluIHZhbGlkIEpTT046XG4iICUgZmlsZSkKICAgICAgICAgcmFp c2UKIAotICAgIHByaW50IHN0cmluZy5yc3RyaXAoKQotcHJpbnQgIl19IgorICAgIHByaW50KHN0 cmluZy5yc3RyaXAoKSkKK3ByaW50KCJdfSIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvanNtaW4ucHkgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3NjcmlwdHMvanNtaW4ucHkKaW5kZXggMjMzOWY3ZDg3NzFhOGEyMWYzZDJmMzFh MjA0MmIzNDczZGM1NDc1ZC4uOGExNWI4YWY5MWI5ZDE2OGI5MjdmNGM4MWEzMGM2M2VmYWIyM2E1 ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2pz bWluLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9qc21p bi5weQpAQCAtMzAsNyArMzAsMTAgQEAKICMgU09GVFdBUkUuCiAjICovCiAKLWZyb20gU3RyaW5n SU8gaW1wb3J0IFN0cmluZ0lPCit0cnk6CisgICAgZnJvbSBTdHJpbmdJTyBpbXBvcnQgU3RyaW5n SU8KK2V4Y2VwdCBJbXBvcnRFcnJvcjoKKyAgICBmcm9tIGlvIGltcG9ydCBTdHJpbmdJTwogCiBk ZWYganNtaW4oanMpOgogICAgIGlucyA9IFN0cmluZ0lPKGpzKQo=