127110 2014-01-16 07:41:42 -0800 [WinCairo][Curl] Download request has incorrect user agent string. 2014-01-21 13:13:49 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned bfulgham commit-queue galpeter ossy oldest_to_newest 968754 0 peavo 2014-01-16 07:41:42 -0800 A download request initiated from WebView, will have the default Curl user agent string. I have experienced failing downloads because of this. We should use the same user agent as in other requests. 968755 1 221376 peavo 2014-01-16 07:49:20 -0800 Created attachment 221376 Patch 970331 2 221376 bfulgham 2014-01-21 11:19:39 -0800 Comment on attachment 221376 Patch r=me 970353 3 221376 commit-queue 2014-01-21 11:49:42 -0800 Comment on attachment 221376 Patch Clearing flags on attachment: 221376 Committed r162457: <http://trac.webkit.org/changeset/162457> 970354 4 commit-queue 2014-01-21 11:49:44 -0800 All reviewed patches have been landed. Closing bug. 970399 5 peavo 2014-01-21 13:13:49 -0800 (In reply to comment #2) > (From update of attachment 221376 [details]) > r=me Thanks for reviewing! 221376 2014-01-16 07:49:20 -0800 2014-01-21 11:49:42 -0800 Patch bug-127110-20140116164905.patch text/plain 2343 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjEyOCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTE2 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5D YWlyb11bQ3VybF0gRG93bmxvYWQgcmVxdWVzdCBoYXMgaW5jb3JyZWN0IHVzZXIgYWdlbnQgc3Ry aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3 MTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJEb3dubG9hZEN1cmwuY3BwOgorICAgICAgICAoV2ViRG93bmxvYWQ6OmluaXQpOiBTZXQgdXNl ciBhZ2VudCBzdHJpbmcgaW4gZG93bmxvYWQgcmVxdWVzdC4KKyAgICAgICAgKiBXZWJWaWV3LmNw cDoKKyAgICAgICAgKFdlYlZpZXc6OmRvd25sb2FkVVJMKTogQXZvaWQgZWFybHkgcmV0dXJuIGlm IG5vIFJlc291cmNlSGFuZGxlIGlzIHByb3ZpZGVkLgorCiAyMDE0LTAxLTEwICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgVHdlYWsgUHJvZ3Jlc3NUcmFj a2VyQ2xpZW50IGZ1bmN0aW9ucwpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViRG93bmxvYWRD dXJsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJEb3dubG9hZEN1cmwu Y3BwCShyZXZpc2lvbiAxNjIxMjcpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJEb3dubG9hZEN1 cmwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NywxMSArNTcsOSBAQCB1c2luZyBuYW1lc3BhY2Ug V2ViQ29yZTsKIAogdm9pZCBXZWJEb3dubG9hZDo6aW5pdChSZXNvdXJjZUhhbmRsZSogaGFuZGxl LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIGNvbnN0IFJlc291cmNlUmVzcG9uc2Um IHJlc3BvbnNlLCBJV2ViRG93bmxvYWREZWxlZ2F0ZSogZGVsZWdhdGUpCiB7Ci0gICAgaWYgKCFo YW5kbGUpCi0gICAgICAgIHJldHVybjsKLQogICAgIC8vIFN0b3AgcHJldmlvdXMgcmVxdWVzdAot ICAgIGhhbmRsZS0+c2V0RGVmZXJzTG9hZGluZyh0cnVlKTsKKyAgICBpZiAoaGFuZGxlKQorICAg ICAgICBoYW5kbGUtPnNldERlZmVyc0xvYWRpbmcodHJ1ZSk7CiAKICAgICBtX3JlcXVlc3QuYWRv cHRSZWYoV2ViTXV0YWJsZVVSTFJlcXVlc3Q6OmNyZWF0ZUluc3RhbmNlKHJlcXVlc3QpKTsKIApJ bmRleDogU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDE2MjEyNykKKysrIFNvdXJjZS9XZWJL aXQvd2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NTU0LDcgKzY1NTQsMTQgQEAg dm9pZCBXZWJWaWV3Ojpkb3dubG9hZFVSTChjb25zdCBVUkwmIHVybAogewogICAgIC8vIEl0J3Mg dGhlIGRlbGVnYXRlJ3Mgam9iIHRvIHJlZiB0aGUgV2ViRG93bmxvYWQgdG8ga2VlcCBpdCBhbGl2 ZSAtIG90aGVyd2lzZSBpdCB3aWxsIGJlCiAgICAgLy8gZGVzdHJveWVkIHdoZW4gdGhpcyBmdW5j dGlvbiByZXR1cm5zLgorI2lmIFVTRShDVVJMKQorICAgIC8vIEZvciBDdXJsIHdlIG5lZWQgdG8g c2V0IHRoZSB1c2VyIGFnZW50LCBvdGhlcndpc2UgdGhlIGRvd25sb2FkIHJlcXVlc3QgZ2V0cyB0 aGUgZGVmYXVsdCBDdXJsIHVzZXIgYWdlbnQgc3RyaW5nLgorICAgIFJlc291cmNlUmVxdWVzdCBy ZXF1ZXN0KHVybCk7CisgICAgcmVxdWVzdC5zZXRIVFRQVXNlckFnZW50KHVzZXJBZ2VudEZvcktV UkwodXJsKSk7CisgICAgQ09NUHRyPFdlYkRvd25sb2FkPiBkb3dubG9hZChBZG9wdENPTSwgV2Vi RG93bmxvYWQ6OmNyZWF0ZUluc3RhbmNlKDAsIHJlcXVlc3QsIFJlc291cmNlUmVzcG9uc2UoKSwg bV9kb3dubG9hZERlbGVnYXRlLmdldCgpKSk7CisjZWxzZQogICAgIENPTVB0cjxXZWJEb3dubG9h ZD4gZG93bmxvYWQoQWRvcHRDT00sIFdlYkRvd25sb2FkOjpjcmVhdGVJbnN0YW5jZSh1cmwsIG1f ZG93bmxvYWREZWxlZ2F0ZS5nZXQoKSkpOworI2VuZGlmCiAgICAgZG93bmxvYWQtPnN0YXJ0KCk7 CiB9CiAK