127101 2014-01-16 05:26:32 -0800 [CSS Regions] Fix selection and hover effect of content in region with overflow:hidden 2014-02-03 23:27:15 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 1 mmaerean mmaerean commit-queue esprehn+autocc glenn kondapallykalyan mihnea simon.fraser WebkitBugTracker oldest_to_newest 968711 0 221368 mmaerean 2014-01-16 05:26:32 -0800 Created attachment 221368 sample html file The content that's flowed into a region with overflow:hidden can't be selected and the hover css class is not activated. 968717 1 221370 mmaerean 2014-01-16 05:40:32 -0800 Created attachment 221370 sample html file 972439 2 222331 mmaerean 2014-01-27 09:56:44 -0800 Created attachment 222331 patch 973350 3 mihnea 2014-01-29 05:29:34 -0800 I am not a big fan of the proposed solution. The function isHitCandidate was added for https://bugs.webkit.org/show_bug.cgi?id=24686 in a different context. This function is run after the hit testing was done for a layer, but in the case of RenderNamedFlowFragment, we know upfront that is not a hit candidate. I would like you to investigate other options that would skip calling hit testing methods for this case before settling for this solution (or if you did investigate other options, i think it is worth mentioning here). 974252 4 mmaerean 2014-01-31 01:25:43 -0800 (In reply to comment #3) > I am not a big fan of the proposed solution. The function isHitCandidate was added for https://bugs.webkit.org/show_bug.cgi?id=24686 in a different context. This function is run after the hit testing was done for a layer, but in the case of RenderNamedFlowFragment, we know upfront that is not a hit candidate. I would like you to investigate other options that would skip calling hit testing methods for this case before settling for this solution (or if you did investigate other options, i think it is worth mentioning here). This is how the tree looks like for the layout test: Named flows Named flow 'flow' layer 0x7fd410e582c0 at (0,0) size 991x38 RenderNamedFlowThread 0x7fd410e6b5a0 at (0,0) size 991x38 RenderBlock 0x7fd410e4eb50 {DIV} at (10,10) size 971x18 class="content" (layout overflow 0,0 971x18) (visual overflow -10,-10 991x38) RenderText 0x7fd410e4ec50 {#text} at (0,0) size 60x18 text run at (0,0) width 60: "hover me" The proposed fix for this bug is called from the last if(isSelfPaintingLayer()) instruction in RenderLayer::hitTestLayer. Moving the check more up front would make it less intuitive (than returning false when asked if it's a hit candidate) or just incorrect because the code wouldn't hit the contents of the region any more. Also, isHitCandidate is called in 4 different places so RenderNamedFlowThread will be skipped in all those situations too. 974932 5 222331 mihnea 2014-02-02 22:32:22 -0800 Comment on attachment 222331 patch r=me 974976 6 222973 mmaerean 2014-02-03 02:25:15 -0800 Created attachment 222973 patch for landing 975840 7 222973 commit-queue 2014-02-03 05:10:27 -0800 Comment on attachment 222973 patch for landing Rejecting attachment 222973 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 222973, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ubmit return self.open(self.click(*args, **kwds)) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://webkit-queues.appspot.com/results/4876789134393344 975842 8 222973 mihnea 2014-02-03 05:20:21 -0800 Comment on attachment 222973 patch for landing Retrying... 975843 9 222973 commit-queue 2014-02-03 05:49:45 -0800 Comment on attachment 222973 patch for landing Clearing flags on attachment: 222973 Committed r163302: <http://trac.webkit.org/changeset/163302> 221368 2014-01-16 05:26:32 -0800 2014-01-16 05:40:32 -0800 sample html file hover-select-in-region-overflow-hidden.html text/html 322 mmaerean PHN0eWxlPgogICAgLmNvbnRlbnQgewogICAgICAgIC13ZWJraXQtZmxvdy1pbnRvOiBmbG93Owog ICAgfQogICAgLmNvbnRlbnQ6aG92ZXIgewogICAgICAgIGJveC1zaGFkb3c6IDBweCAwcHggMHB4 IDEwcHggR3JlZW47CiAgICB9CiAgICAucmVnaW9uIHsKICAgICAgICAtd2Via2l0LWZsb3ctZnJv bTogZmxvdzsKICAgICAgICBvdmVyZmxvdzogaGlkZGVuOwogICAgICAgIGJvcmRlcjogc29saWQg MXB4ICNiYmI7CiAgICB9Cjwvc3R5bGU+CjxkaXYgY2xhc3M9ImNvbnRlbnQiPnNlbGVjdCBtZTwv ZGl2Pgo8ZGl2IGNsYXNzPSJyZWdpb24iPnJlZ2lvbjwvZGl2Pg== 221370 2014-01-16 05:40:32 -0800 2014-01-16 05:40:32 -0800 sample html file hover-select-in-region-overflow-hidden.html text/html 344 mmaerean PHN0eWxlPgogICAgLmNvbnRlbnQgewogICAgICAgIC13ZWJraXQtZmxvdy1pbnRvOiBmbG93Owog ICAgICAgIG1hcmdpbjogMTBweDsKICAgIH0KICAgIC5jb250ZW50OmhvdmVyIHsKICAgICAgICBi b3gtc2hhZG93OiAwcHggMHB4IDBweCAxMHB4IEdyZWVuOwogICAgfQogICAgLnJlZ2lvbiB7CiAg ICAgICAgLXdlYmtpdC1mbG93LWZyb206IGZsb3c7CiAgICAgICAgb3ZlcmZsb3c6IGhpZGRlbjsK ICAgICAgICBib3JkZXI6IHNvbGlkIDFweCAjYmJiOwogICAgfQo8L3N0eWxlPgo8ZGl2IGNsYXNz PSJjb250ZW50Ij5zZWxlY3QgbWU8L2Rpdj4KPGRpdiBjbGFzcz0icmVnaW9uIj5yZWdpb248L2Rp dj4= 222331 2014-01-27 09:56:44 -0800 2014-02-02 22:32:22 -0800 patch patch127101SelectionHoverOverflowHidden.diff text/plain 4201 mmaerean ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxOGNkMmI2Li5mZTRkNWE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDEt MjcgIE1paGFpIE1hZXJlYW4gIDxtbWFlcmVhbkBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBS ZWdpb25zXSBGaXggc2VsZWN0aW9uIGFuZCBob3ZlciBlZmZlY3Qgb2YgY29udGVudCBpbiByZWdp b24gd2l0aCBvdmVyZmxvdzpoaWRkZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNzEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmFzdC9yZWdpb25zL2hvdmVyLW92ZXJmbG93LWhpZGRlbi5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlZ2lvbnMvaG92ZXItb3ZlcmZsb3ctaGlkZGVuLWV4 cGVjdGVkLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAxLTI3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxv c3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVHlwbyBmaXggYWZ0ZXIgcjE2MjgzOC4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9ob3Zlci1vdmVyZmxvdy1oaWRkZW4tZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9ob3Zlci1vdmVyZmxvdy1oaWRk ZW4tZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jM2Vl YWM5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2hvdmVyLW92 ZXJmbG93LWhpZGRlbi1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMTkgQEAKKzwhZG9jdHlwZSBo dG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8dGl0bGU+RXhwZWN0ZWQgcmVzdWx0IC0gQnVnIDEy NzEwMTogW0NTUyBSZWdpb25zXSBGaXggc2VsZWN0aW9uIGFuZCBob3ZlciBlZmZlY3Qgb2YgY29u dGVudCBpbiByZWdpb24gd2l0aCBvdmVyZmxvdzpoaWRkZW48L3RpdGxlPgorICAgIDxzdHlsZT4K KyAgICAgICAgLmNvbnRlbnQgeworICAgICAgICAgICAgbWFyZ2luOiAxMHB4OworICAgICAgICAg ICAgYm94LXNoYWRvdzogMHB4IDBweCAwcHggMTBweCBHcmVlbjsKKyAgICAgICAgfQorICAgICAg ICBib2R5IHsKKyAgICAgICAgICAgIG1hcmdpbjogMDsKKyAgICAgICAgICAgIHBhZGRpbmc6IDA7 CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBjbGFz cz0iY29udGVudCI+aG92ZXIgbWU8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5l IGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvaG92 ZXItb3ZlcmZsb3ctaGlkZGVuLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvaG92ZXIt b3ZlcmZsb3ctaGlkZGVuLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u NmQ5OTVhYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9ob3Zl ci1vdmVyZmxvdy1oaWRkZW4uaHRtbApAQCAtMCwwICsxLDM1IEBACis8IWRvY3R5cGUgaHRtbD4K KzxodG1sPgorPGhlYWQ+CisgICAgPHRpdGxlPlRlc3QgLSBCdWcgMTI3MTAxOiBbQ1NTIFJlZ2lv bnNdIEZpeCBzZWxlY3Rpb24gYW5kIGhvdmVyIGVmZmVjdCBvZiBjb250ZW50IGluIHJlZ2lvbiB3 aXRoIG92ZXJmbG93OmhpZGRlbjwvdGl0bGU+CisgICAgPHN0eWxlPgorICAgICAgICAuY29udGVu dCB7CisgICAgICAgICAgICAtd2Via2l0LWZsb3ctaW50bzogZmxvdzsKKyAgICAgICAgICAgIGJv eC1zaGFkb3c6IDBweCAwcHggMHB4IDEwcHggUmVkOworICAgICAgICAgICAgbWFyZ2luOiAxMHB4 OworICAgICAgICB9CisgICAgICAgIC5jb250ZW50OmhvdmVyIHsKKyAgICAgICAgICAgIGJveC1z aGFkb3c6IDBweCAwcHggMHB4IDEwcHggR3JlZW47CisgICAgICAgIH0KKyAgICAgICAgLnJlZ2lv biB7CisgICAgICAgICAgICAtd2Via2l0LWZsb3ctZnJvbTogZmxvdzsKKyAgICAgICAgICAgIG92 ZXJmbG93OiBoaWRkZW47CisgICAgICAgIH0KKyAgICAgICAgYm9keSB7CisgICAgICAgICAgICBt YXJnaW46IDA7CisgICAgICAgICAgICBwYWRkaW5nOiAwOworICAgICAgICB9CisgICAgPC9zdHls ZT4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxkaXYgY2xhc3M9ImNvbnRlbnQiPmhvdmVyIG1lPC9k aXY+CisgICAgPGRpdiBjbGFzcz0icmVnaW9uIj5yZWdpb248L2Rpdj4KKworICAgIDxzY3JpcHQg dHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRlcikg eworICAgICAgICAgICAgdmFyIGJveCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIi5jb250ZW50 IikuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CisgICAgICAgICAgICB3aW5kb3cuZXZlbnRTZW5k ZXIubW91c2VNb3ZlVG8oKGJveC5yaWdodCArIGJveC5sZWZ0KSAvIDIsIChib3gudG9wICsgYm94 LmJvdHRvbSkgLyAyKTsKKyAgICAgICAgfQorICAgIDwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4OWVjNmQxLi44NmZh NjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDEtMjcgIE1paGFpIE1hZXJl YW4gIDxtbWFlcmVhbkBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBSZWdpb25zXSBGaXggc2Vs ZWN0aW9uIGFuZCBob3ZlciBlZmZlY3Qgb2YgY29udGVudCBpbiByZWdpb24gd2l0aCBvdmVyZmxv dzpoaWRkZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNzEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbmRlck5hbWVkRmxvd0ZyYWdtZW50cyBhcmUgbm90IGhpdCBjYW5kaWRhdGVzLiBUaGUgaGl0 IHRlc3QgYWxnb3JpdGhtIHdpbGwgcGljayB0aGUKKyAgICAgICAgcGFyZW50IGxheWVyLCB0aGUg b25lIG9mIHRoZSByZWdpb24uCisKKyAgICAgICAgVGVzdDogZmFzdC9yZWdpb25zL2hvdmVyLW92 ZXJmbG93LWhpZGRlbi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6aXNIaXRDYW5kaWRhdGUpOgorCiAyMDE0LTAxLTI3ICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxMzMy MTQpOiBEb24ndCBpbnZhbGlkYXRlIHN0eWxlIHdoZW4gYWRkaW5nIGNsYXNzZXMgdGhhdCBkb24n dCBtYXRjaCBydWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5k ZXggNjVlMGQyMy4uM2E2ZmE2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwCkBAIC00NzQ3LDYgKzQ3NDcsMTEgQEAgc3RhdGljIGJvb2wgaXNIaXRDYW5kaWRhdGUo Y29uc3QgUmVuZGVyTGF5ZXIqIGhpdExheWVyLCBib29sIGNhbkRlcHRoU29ydCwgZG91YmwKIHsK ICAgICBpZiAoIWhpdExheWVyKQogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgCisgICAgLy8g UmVuZGVyTmFtZWRGbG93RnJhZ21lbnRzIGFyZSBub3QgaGl0IGNhbmRpZGF0ZXMuIFRoZSBoaXQg dGVzdCBhbGdvcml0aG0gd2lsbCBwaWNrIHRoZSBwYXJlbnQKKyAgICAvLyBsYXllciwgdGhlIG9u ZSBvZiB0aGUgcmVnaW9uLgorICAgIGlmIChoaXRMYXllci0+cmVuZGVyZXIoKS5pc1JlbmRlck5h bWVkRmxvd0ZyYWdtZW50KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIFRoZSBo aXQgbGF5ZXIgaXMgZGVwdGgtc29ydGluZyB3aXRoIG90aGVyIGxheWVycywgc28ganVzdCBzYXkg dGhhdCBpdCB3YXMgaGl0LgogICAgIGlmIChjYW5EZXB0aFNvcnQpCg== 222973 2014-02-03 02:25:15 -0800 2014-02-03 05:49:45 -0800 patch for landing patch127101SelectionHoverOverflowHidden.diff text/plain 4256 mmaerean ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMzAxMWU3Li4zMWMxMDMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDIt MDMgIE1paGFpIE1hZXJlYW4gIDxtbWFlcmVhbkBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBS ZWdpb25zXSBGaXggc2VsZWN0aW9uIGFuZCBob3ZlciBlZmZlY3Qgb2YgY29udGVudCBpbiByZWdp b24gd2l0aCBvdmVyZmxvdzpoaWRkZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNzEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE1paG5lYSBPdmlk ZW5pZS4KKworICAgICAgICAqIGZhc3QvcmVnaW9ucy9ob3Zlci1vdmVyZmxvdy1oaWRkZW4uaHRt bDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZWdpb25zL2hvdmVyLW92ZXJmbG93LWhpZGRlbi1l eHBlY3RlZC5odG1sOiBBZGRlZC4KKwogMjAxNC0wMS0zMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJA YXBwbGUuY29tPgogICAgICAgICBQdXNoIERPTSBhdHRyaWJ1dGVzIGludG8gdGhlIHByb3RvdHlw ZSBjaGFpbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI3OTY5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvaG92ZXItb3ZlcmZs b3ctaGlkZGVuLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvaG92ZXIt b3ZlcmZsb3ctaGlkZGVuLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uYzNlZWFjOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVn aW9ucy9ob3Zlci1vdmVyZmxvdy1oaWRkZW4tZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE5IEBA Cis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPHRpdGxlPkV4cGVjdGVkIHJl c3VsdCAtIEJ1ZyAxMjcxMDE6IFtDU1MgUmVnaW9uc10gRml4IHNlbGVjdGlvbiBhbmQgaG92ZXIg ZWZmZWN0IG9mIGNvbnRlbnQgaW4gcmVnaW9uIHdpdGggb3ZlcmZsb3c6aGlkZGVuPC90aXRsZT4K KyAgICA8c3R5bGU+CisgICAgICAgIC5jb250ZW50IHsKKyAgICAgICAgICAgIG1hcmdpbjogMTBw eDsKKyAgICAgICAgICAgIGJveC1zaGFkb3c6IDBweCAwcHggMHB4IDEwcHggR3JlZW47CisgICAg ICAgIH0KKyAgICAgICAgYm9keSB7CisgICAgICAgICAgICBtYXJnaW46IDA7CisgICAgICAgICAg ICBwYWRkaW5nOiAwOworICAgICAgICB9CisgICAgPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5Pgor ICAgIDxkaXYgY2xhc3M9ImNvbnRlbnQiPmhvdmVyIG1lPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+ ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9yZWdpb25zL2hvdmVyLW92ZXJmbG93LWhpZGRlbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9y ZWdpb25zL2hvdmVyLW92ZXJmbG93LWhpZGRlbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLjZkOTk1YWMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L3JlZ2lvbnMvaG92ZXItb3ZlcmZsb3ctaGlkZGVuLmh0bWwKQEAgLTAsMCArMSwzNSBAQAorPCFk b2N0eXBlIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDx0aXRsZT5UZXN0IC0gQnVnIDEyNzEw MTogW0NTUyBSZWdpb25zXSBGaXggc2VsZWN0aW9uIGFuZCBob3ZlciBlZmZlY3Qgb2YgY29udGVu dCBpbiByZWdpb24gd2l0aCBvdmVyZmxvdzpoaWRkZW48L3RpdGxlPgorICAgIDxzdHlsZT4KKyAg ICAgICAgLmNvbnRlbnQgeworICAgICAgICAgICAgLXdlYmtpdC1mbG93LWludG86IGZsb3c7Cisg ICAgICAgICAgICBib3gtc2hhZG93OiAwcHggMHB4IDBweCAxMHB4IFJlZDsKKyAgICAgICAgICAg IG1hcmdpbjogMTBweDsKKyAgICAgICAgfQorICAgICAgICAuY29udGVudDpob3ZlciB7CisgICAg ICAgICAgICBib3gtc2hhZG93OiAwcHggMHB4IDBweCAxMHB4IEdyZWVuOworICAgICAgICB9Cisg ICAgICAgIC5yZWdpb24geworICAgICAgICAgICAgLXdlYmtpdC1mbG93LWZyb206IGZsb3c7Cisg ICAgICAgICAgICBvdmVyZmxvdzogaGlkZGVuOworICAgICAgICB9CisgICAgICAgIGJvZHkgewor ICAgICAgICAgICAgbWFyZ2luOiAwOworICAgICAgICAgICAgcGFkZGluZzogMDsKKyAgICAgICAg fQorICAgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGNsYXNzPSJjb250ZW50 Ij5ob3ZlciBtZTwvZGl2PgorICAgIDxkaXYgY2xhc3M9InJlZ2lvbiI+cmVnaW9uPC9kaXY+CisK KyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgICAgIGlmICh3aW5kb3cu ZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgICAgIHZhciBib3ggPSBkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCIuY29udGVudCIpLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICAgICAgICAgICAgd2lu ZG93LmV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKChib3gucmlnaHQgKyBib3gubGVmdCkgLyAyLCAo Ym94LnRvcCArIGJveC5ib3R0b20pIC8gMik7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwv Ym9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTc3OGI2OS4uMjA3YmY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAyLTAz ICBNaWhhaSBNYWVyZWFuICA8bW1hZXJlYW5AYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVn aW9uc10gRml4IHNlbGVjdGlvbiBhbmQgaG92ZXIgZWZmZWN0IG9mIGNvbnRlbnQgaW4gcmVnaW9u IHdpdGggb3ZlcmZsb3c6aGlkZGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjcxMDEKKworICAgICAgICBSZXZpZXdlZCBieSBNaWhuZWEgT3ZpZGVu aWUuCisKKyAgICAgICAgUmVuZGVyTmFtZWRGbG93RnJhZ21lbnRzIGFyZSBub3QgaGl0IGNhbmRp ZGF0ZXMuIFRoZSBoaXQgdGVzdCBhbGdvcml0aG0gd2lsbCBwaWNrIHRoZQorICAgICAgICBwYXJl bnQgbGF5ZXIsIHRoZSBvbmUgb2YgdGhlIHJlZ2lvbi4KKworICAgICAgICBUZXN0OiBmYXN0L3Jl Z2lvbnMvaG92ZXItb3ZlcmZsb3ctaGlkZGVuLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0hpdENhbmRpZGF0ZSk6CisKIDIw MTQtMDItMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJl bmRlclNWR1Jlc291cmNlOjpyZW1vdmVDbGllbnRGcm9tQ2FjaGUoKSBzaG91bGQgdGFrZSBSZW5k ZXJFbGVtZW50Ji4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4 IDM2MmI3NWQuLmRhNjFlNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmNwcApAQCAtNDY2MSw2ICs0NjYxLDExIEBAIHN0YXRpYyBib29sIGlzSGl0Q2FuZGlkYXRlKGNv bnN0IFJlbmRlckxheWVyKiBoaXRMYXllciwgYm9vbCBjYW5EZXB0aFNvcnQsIGRvdWJsCiB7CiAg ICAgaWYgKCFoaXRMYXllcikKICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAorICAgIC8vIFJl bmRlck5hbWVkRmxvd0ZyYWdtZW50cyBhcmUgbm90IGhpdCBjYW5kaWRhdGVzLiBUaGUgaGl0IHRl c3QgYWxnb3JpdGhtIHdpbGwgcGljayB0aGUgcGFyZW50CisgICAgLy8gbGF5ZXIsIHRoZSBvbmUg b2YgdGhlIHJlZ2lvbi4KKyAgICBpZiAoaGl0TGF5ZXItPnJlbmRlcmVyKCkuaXNSZW5kZXJOYW1l ZEZsb3dGcmFnbWVudCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAvLyBUaGUgaGl0 IGxheWVyIGlzIGRlcHRoLXNvcnRpbmcgd2l0aCBvdGhlciBsYXllcnMsIHNvIGp1c3Qgc2F5IHRo YXQgaXQgd2FzIGhpdC4KICAgICBpZiAoY2FuRGVwdGhTb3J0KQo=