127098 2014-01-16 03:26:17 -0800 [GTK] Remove the weak pointer added to the web view in WebKitPrintOperation 2014-01-16 23:15:51 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue gustavo mrobinson oldest_to_newest 968688 0 cgarcia 2014-01-16 03:26:17 -0800 If the print operation finishes and the web view is still alive, the weak pointer added to the view should be removed. 968689 1 221357 cgarcia 2014-01-16 03:27:43 -0800 Created attachment 221357 Patch 968691 2 commit-queue 2014-01-16 03:28:52 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 969062 3 cgarcia 2014-01-16 23:15:51 -0800 Committed r162188: <http://trac.webkit.org/changeset/162188> 221357 2014-01-16 03:27:43 -0800 2014-01-16 07:50:58 -0800 Patch wk2-print-weak-pointer.diff text/plain 2295 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2NzY4MGFlLi42YTAyZTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDEtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFJlbW92ZSB0aGUgd2VhayBwb2ludGVyIGFkZGVkIHRvIHRoZSB3 ZWIgdmlldyBpbiBXZWJLaXRQcmludE9wZXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MDk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIHByaW50IG9wZXJhdGlvbiBmaW5pc2hlcyBh bmQgdGhlIHdlYiB2aWV3IGlzIHN0aWxsIGFsaXZlLAorICAgICAgICB0aGUgd2VhayBwb2ludGVy IGFkZGVkIHRvIHRoZSB2aWV3IHNob3VsZCBiZSByZW1vdmVkLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0UHJpbnRPcGVyYXRpb24uY3BwOgorICAgICAgICAoX1dlYktpdFBy aW50T3BlcmF0aW9uUHJpdmF0ZTo6fl9XZWJLaXRQcmludE9wZXJhdGlvblByaXZhdGUpOgorCiAy MDE0LTAxLTE2ICBJYW4gSGVuZGVyc29uICA8aWFuaEBhcHBsZS5jb20+CiAKICAgICAgICAgRXhw b3NlIHNjcm9sbFZpZXcgb24gV0tWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRQcmludE9wZXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQcmludE9wZXJhdGlvbi5jcHAKaW5kZXggNTMxOGRkMC4u MzU1MTNjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0UHJpbnRPcGVyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFByaW50T3BlcmF0aW9uLmNwcApAQCAtNjUsNiArNjUsMTIgQEAgZW51bSB7CiB9 OwogCiBzdHJ1Y3QgX1dlYktpdFByaW50T3BlcmF0aW9uUHJpdmF0ZSB7CisgICAgfl9XZWJLaXRQ cmludE9wZXJhdGlvblByaXZhdGUoKQorICAgIHsKKyAgICAgICAgaWYgKHdlYlZpZXcpCisgICAg ICAgICAgICBnX29iamVjdF9yZW1vdmVfd2Vha19wb2ludGVyKEdfT0JKRUNUKHdlYlZpZXcpLCBy ZWludGVycHJldF9jYXN0PHZvaWQqKj4oJndlYlZpZXcpKTsKKyAgICB9CisKICAgICBXZWJLaXRX ZWJWaWV3KiB3ZWJWaWV3OwogICAgIFByaW50SW5mbzo6UHJpbnRNb2RlIHByaW50TW9kZTsKIApA QCAtNzgsMTMgKzg0LDEwIEBAIFdFQktJVF9ERUZJTkVfVFlQRShXZWJLaXRQcmludE9wZXJhdGlv biwgd2Via2l0X3ByaW50X29wZXJhdGlvbiwgR19UWVBFX09CSkVDVCkKIAogc3RhdGljIHZvaWQg d2Via2l0UHJpbnRPcGVyYXRpb25Db25zdHJ1Y3RlZChHT2JqZWN0KiBvYmplY3QpCiB7Ci0gICAg V2ViS2l0UHJpbnRPcGVyYXRpb24qIHByaW50T3BlcmF0aW9uID0gV0VCS0lUX1BSSU5UX09QRVJB VElPTihvYmplY3QpOwotICAgIFdlYktpdFByaW50T3BlcmF0aW9uUHJpdmF0ZSogcHJpdiA9IHBy aW50T3BlcmF0aW9uLT5wcml2OwotCi0gICAgaWYgKEdfT0JKRUNUX0NMQVNTKHdlYmtpdF9wcmlu dF9vcGVyYXRpb25fcGFyZW50X2NsYXNzKS0+Y29uc3RydWN0ZWQpCi0gICAgICAgIEdfT0JKRUNU X0NMQVNTKHdlYmtpdF9wcmludF9vcGVyYXRpb25fcGFyZW50X2NsYXNzKS0+Y29uc3RydWN0ZWQo b2JqZWN0KTsKKyAgICBHX09CSkVDVF9DTEFTUyh3ZWJraXRfcHJpbnRfb3BlcmF0aW9uX3BhcmVu dF9jbGFzcyktPmNvbnN0cnVjdGVkKG9iamVjdCk7CiAKLSAgICBnX29iamVjdF9hZGRfd2Vha19w b2ludGVyKEdfT0JKRUNUKHByaXYtPndlYlZpZXcpLCAoZ3BvaW50ZXIqKSZwcml2LT53ZWJWaWV3 KTsKKyAgICBXZWJLaXRQcmludE9wZXJhdGlvblByaXZhdGUqIHByaXYgPSBXRUJLSVRfUFJJTlRf T1BFUkFUSU9OKG9iamVjdCktPnByaXY7CisgICAgZ19vYmplY3RfYWRkX3dlYWtfcG9pbnRlcihH X09CSkVDVChwcml2LT53ZWJWaWV3KSwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKio+KCZwcml2LT53 ZWJWaWV3KSk7CiB9CiAKIHN0YXRpYyB2b2lkIHdlYmtpdFByaW50T3BlcmF0aW9uR2V0UHJvcGVy dHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wSWQsIEdWYWx1ZSogdmFsdWUsIEdQYXJhbVNw ZWMqIHBhcmFtU3BlYykK