127093 2014-01-16 02:58:45 -0800 Change default setting of run-javascriptcore-tests not to build JSC by default 2014-01-21 06:26:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 pmolnar.u-szeged webkit-unassigned ap dbates dfarler eric fpizlo ggaren lforschler rniwa oldest_to_newest 968675 0 pmolnar.u-szeged 2014-01-16 02:58:45 -0800 This script is ran most of the time on buildbots, in these cases there's no need to build JSC, as it is built right before running this script. When running these tests manually on a device (like dev boards where we only run tests, and we build with cross-compile), it's quite an annoyance to specify the --no-build option every time we do that. It may be wise to change this behavior, to make the script build JSC only if the --build option is specified explicitly. This will cover those few cases when we want to run the build from this script. 968676 1 221353 pmolnar.u-szeged 2014-01-16 02:59:42 -0800 Created attachment 221353 patch 968828 2 lforschler 2014-01-16 11:29:11 -0800 The Apple webkit testers pass the --no-build flag to the script already. So, I think this will not cause any problems. 968834 3 ggaren 2014-01-16 11:35:25 -0800 Phil, will this affect your JSC bots? 968862 4 fpizlo 2014-01-16 12:36:45 -0800 (In reply to comment #0) > This script is ran most of the time on buildbots, in these cases there's no need to build JSC, as it is built right before running this script. > When running these tests manually on a device (like dev boards where we only run tests, and we build with cross-compile), it's quite an annoyance to specify the --no-build option every time we do that. > > It may be wise to change this behavior, to make the script build JSC only if the --build option is specified explicitly. This will cover those few cases when we want to run the build from this script. For me, I always use run-javascriptcore-tests to build JSC and I never use build-jsc directly. This change would be a huge annoyance for me. I can also see this leading to problems if someone reruns tests after making changes but forgets to pass --build. I don't like that prospect. Since this appears to be an annoyance to one person no matter what the default is, I think the wisest thing to do is to not change anything. 221353 2014-01-16 02:59:42 -0800 2014-01-16 12:36:58 -0800 patch run-jsctests-default-no-build.patch text/plain 947 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MTFl ZWEwLi5jNGViMWFiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDEtMTYgIFBldGVyIE1vbG5hciAgPHBtb2xu YXIudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBDaGFuZ2UgZGVmYXVs dCBzZXR0aW5nIG9mIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBub3QgdG8gYnVpbGQgSlNDIGJ5 IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNzA5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6CisKIDIwMTQtMDEtMTUgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgRHVtcFJlbmRlclRyZWUg ZG9lc24ndCBkaXNhYmxlIHdlYiBwcmVmZXJlbmNlcyBhdXRvc2F2ZQpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1q YXZhc2NyaXB0Y29yZS10ZXN0cwppbmRleCBiNTI0MTYwLi4yNjFkMGFmIDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cworKysgYi9Ub29scy9TY3JpcHRz L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwpAQCAtNjcsNyArNjcsNyBAQCBteSAkcm9vdDsKIG15 ICRzaG93SGVscDsKIG15ICRleHRyYVRlc3RzOwogCi1teSAkYnVpbGRKU0MgPSAxOworbXkgJGJ1 aWxkSlNDID0gMDsKIAogbXkgJHJ1blRlc3RBUEkgPSBpc0FwcGxlTWFjV2ViS2l0KCkgfHwgaXNB cHBsZVdpbldlYktpdCgpIHx8IGlzV2luQ2Fpcm8oKTsKIAo=