127090 2014-01-16 02:16:30 -0800 [WK2] Setting m_pageScaleFactor directly in WebPageProxy::scalePage 2014-01-20 15:34:56 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thiago.lacerda thiago.lacerda benjamin commit-queue jinwoo7.song simon.fraser thorton oldest_to_newest 968658 0 thiago.lacerda 2014-01-16 02:16:30 -0800 When the client side sets the scale factor, the UIProcess will send the message to WebProcess and only after WebPageProxy::pageScaleFactorDidChange is called the desired scale factor is returned correctly by WebPageProxy::pageScaleFactor. This will avoid the client side retrieve a wrong scale factor while UIProcess and WebProcess gets synchronized. 968662 1 thiago.lacerda 2014-01-16 02:19:35 -0800 *** Bug 126261 has been marked as a duplicate of this bug. *** 968702 2 221363 thiago.lacerda 2014-01-16 04:07:17 -0800 Created attachment 221363 Patch 969940 3 simon.fraser 2014-01-20 11:36:49 -0800 (In reply to comment #0) > When the client side sets the scale factor, the UIProcess will send the message to WebProcess and only after WebPageProxy::pageScaleFactorDidChange is called the desired scale factor is returned correctly by WebPageProxy::pageScaleFactor. > This will avoid the client side retrieve a wrong scale factor while UIProcess and WebProcess gets synchronized. What's the user-visible symptom of getting the wrong scale factor in the UI process? 969978 4 thiago.lacerda 2014-01-20 13:18:52 -0800 (In reply to comment #3) > (In reply to comment #0) > > When the client side sets the scale factor, the UIProcess will send the message to WebProcess and only after WebPageProxy::pageScaleFactorDidChange is called the desired scale factor is returned correctly by WebPageProxy::pageScaleFactor. > > This will avoid the client side retrieve a wrong scale factor while UIProcess and WebProcess gets synchronized. > > What's the user-visible symptom of getting the wrong scale factor in the UI process? I can imagine a scenario that the user double clicks the WebView, in order to zoom the page, then WKViewSetContentScaleFactor gets called. Right after that it may need to set the position of the contents inside the view, so it gets centralized where the user has clicked. Without this patch he will not get the correct scale factor and the position may not be set correctly, unless the user caches the scale, which in my opinion is just an unnecessary duplication of information. Besides that, I think is not good to have the UIProcess in a inconsistent state with the WebProcess, even for a short period of time. 970044 5 221363 commit-queue 2014-01-20 15:34:53 -0800 Comment on attachment 221363 Patch Clearing flags on attachment: 221363 Committed r162382: <http://trac.webkit.org/changeset/162382> 970045 6 commit-queue 2014-01-20 15:34:56 -0800 All reviewed patches have been landed. Closing bug. 221363 2014-01-16 04:07:17 -0800 2014-01-20 15:34:53 -0800 Patch bug-127090-20140116090716.patch text/plain 1606 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjc2ODBhZTNmM2EyNGZl NzcxMjBiNTRmNjZmYWNmOTQwMmY1MGY2Zi4uZjQ1Mzg4MDMzZDdiMGNiZGU0MzI2ZTY0NWI4ZWJm ZGRiMTY0YTMzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTE2ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtXSzJdIFNldHRpbmcgbV9wYWdlU2NhbGVGYWN0b3IgZGlyZWN0bHkgaW4gV2ViUGFn ZVByb3h5OjpzY2FsZVBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNzA5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdoZW4gdGhlIGNsaWVudCBzaWRlIHNldHMgdGhlIHNjYWxlIGZhY3RvciwgdGhl IFVJUHJvY2VzcyB3aWxsIHNlbmQgdGhlIG1lc3NhZ2UgdG8gV2ViUHJvY2VzcyBhbmQgb25seSBh ZnRlcgorICAgICAgICBXZWJQYWdlUHJveHk6OnBhZ2VTY2FsZUZhY3RvckRpZENoYW5nZSBpcyBj YWxsZWQgdGhlIGRlc2lyZWQgc2NhbGUgZmFjdG9yIGlzIHJldHVybmVkIGNvcnJlY3RseSBieQor ICAgICAgICBXZWJQYWdlUHJveHk6OnBhZ2VTY2FsZUZhY3Rvci4KKyAgICAgICAgVGhpcyB3aWxs IGF2b2lkIHRoZSBjbGllbnQgc2lkZSByZXRyaWV2ZSBhIHdyb25nIHNjYWxlIGZhY3RvciB3aGls ZSBVSVByb2Nlc3MgYW5kIFdlYlByb2Nlc3MgZ2V0cyBzeW5jaHJvbml6ZWQuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVBy b3h5OjpzY2FsZVBhZ2UpOgorCiAyMDE0LTAxLTE2ICBJYW4gSGVuZGVyc29uICA8aWFuaEBhcHBs ZS5jb20+CiAKICAgICAgICAgRXhwb3NlIHNjcm9sbFZpZXcgb24gV0tWaWV3CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGM5OWM4YjQ0MDJiNmUxYmZhMGYz NWE4ZDkwZmI2ZmRkOGM3NmQ4NDUuLmMwYjRjZmE4YWI3MDRmMWIyOGY2ODA4MTAyNjk3NjczODUx YWQ3NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0x NTk0LDYgKzE1OTQsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2NhbGVQYWdlKGRvdWJsZSBzY2Fs ZSwgY29uc3QgSW50UG9pbnQmIG9yaWdpbikKICAgICBpZiAoIWlzVmFsaWQoKSkKICAgICAgICAg cmV0dXJuOwogCisgICAgbV9wYWdlU2NhbGVGYWN0b3IgPSBzY2FsZTsKICAgICBtX3Byb2Nlc3Mt PnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OlNjYWxlUGFnZShzY2FsZSwgb3JpZ2luKSwgbV9wYWdl SUQpOwogfQogCg==