<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>127086</bug_id>
          
          <creation_ts>2014-01-16 00:46:53 -0800</creation_ts>
          <short_desc>CStack: Fix 32-bit C loop LLINT.</short_desc>
          <delta_ts>2014-01-17 23:23:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>127071</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>msaboff</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>968638</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2014-01-16 00:46:53 -0800</bug_when>
    <thetext>Patch coming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>968640</commentid>
    <comment_count>1</comment_count>
      <attachid>221343</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2014-01-16 01:01:29 -0800</bug_when>
    <thetext>Created attachment 221343
the patch.

This patch builds and passes run-javascriptcore-tests --debug --32-bit --cloop --no-jsc-stress.  This is the minimum patch that will build and run the 32-bit C loop LLINT.  Since the C loop is based on ARM, this patch also fixes part of the ARMv7 LLINT implementation.  There is still more to do for ARM (e.g. alignment issues) but I didn’t want to overlap with the work in Michael’s patch.  There is still necessarily some minimal overlap with Michael’s patch.  I’ll rebase this patch after Michael’s 32-bit patch is finalized.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>968773</commentid>
    <comment_count>2</comment_count>
      <attachid>221343</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2014-01-16 08:50:30 -0800</bug_when>
    <thetext>Comment on attachment 221343
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=221343&amp;action=review

&gt; Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:315
&gt; +    addp 8, sp

prior code didn&apos;t increment sp prior to the call, should this be in the CLOOP block?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>968774</commentid>
    <comment_count>3</comment_count>
      <attachid>221343</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2014-01-16 08:53:06 -0800</bug_when>
    <thetext>Comment on attachment 221343
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=221343&amp;action=review

&gt;&gt; Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:315
&gt;&gt; +    addp 8, sp
&gt; 
&gt; prior code didn&apos;t increment sp prior to the call, should this be in the CLOOP block?

No, the sp adjustment (before and after the call) is needed for all 32-bit ports, and Michael’s patch will make that change.  I have to make the same change here or the C loop code won’t work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>968787</commentid>
    <comment_count>4</comment_count>
      <attachid>221343</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-01-16 09:25:16 -0800</bug_when>
    <thetext>Comment on attachment 221343
the patch.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>969409</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2014-01-17 23:23:27 -0800</bug_when>
    <thetext>Landed in r162248 on the jsCStack branch: &lt;http://trac.webkit.org/r162248&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>221343</attachid>
            <date>2014-01-16 01:01:29 -0800</date>
            <delta_ts>2014-01-16 09:25:16 -0800</delta_ts>
            <desc>the patch.</desc>
            <filename>bug-127086.patch</filename>
            <type>text/plain</type>
            <size>11073</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyMTE4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA
CisyMDE0LTAxLTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG
aXggMzItYml0IEMgbG9vcCBMTElOVC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTEyNzA4Ni4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIGxsaW50L0xMSW50RGF0YS5jcHA6CisgICAgICAgIChKU0M6OkxM
SW50OjpEYXRhOjpwZXJmb3JtQXNzZXJ0aW9ucyk6CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJ
bnRlcnByZXRlci5hc206CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0
LmFzbToKKwogMjAxNC0wMS0xNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAg
ICAgICAgIHJlZW50cmFudC1jYWNoaW5nIHNvbWV0aW1lcyBmYWlscyB3aXRoIExMSW50IGRpc2Fi
bGVkCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmNwcAkocmV2
aXNpb24gMTYyMTA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5j
cHAJKHdvcmtpbmcgY29weSkKQEAgLTg4LDcgKzg4LDcgQEAgdm9pZCBEYXRhOjpwZXJmb3JtQXNz
ZXJ0aW9ucyhWTSYgdm0pCiAgICAgQVNTRVJUKEpTU3RhY2s6OkNhbGxGcmFtZUhlYWRlclNpemUg
PT0gQ2FsbEZyYW1lSGVhZGVyU2xvdHMpOwogCiAgICAgQVNTRVJUKCFDYWxsRnJhbWU6OmNhbGxl
ckZyYW1lT2Zmc2V0KCkpOwotICAgIEFTU0VSVChKU1N0YWNrOjpDYWxsZXJGcmFtZUFuZFBDU2l6
ZSA9PSAyKTsKKyAgICBBU1NFUlQoSlNTdGFjazo6Q2FsbGVyRnJhbWVBbmRQQ1NpemUgPT0gKFB0
clNpemUgKiAyKSAvIFNsb3RTaXplKTsKICAgICBBU1NFUlQoQ2FsbEZyYW1lOjpyZXR1cm5QQ09m
ZnNldCgpID09IENhbGxGcmFtZTo6Y2FsbGVyRnJhbWVPZmZzZXQoKSArIFB0clNpemUpOwogICAg
IEFTU0VSVChKU1N0YWNrOjpDb2RlQmxvY2sgKiBzaXplb2YoUmVnaXN0ZXIpID09IENhbGxGcmFt
ZTo6cmV0dXJuUENPZmZzZXQoKSArIFB0clNpemUpOwogICAgIEFTU0VSVChKU1N0YWNrOjpTY29w
ZUNoYWluICogc2l6ZW9mKFJlZ2lzdGVyKSA9PSBKU1N0YWNrOjpDb2RlQmxvY2sgKiBzaXplb2Yo
UmVnaXN0ZXIpICsgU2xvdFNpemUpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50
L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT
Y3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHJldmlzaW9uIDE2
MjEwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy
MzJfNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotIyBDb3B5cmlnaHQgKEMp
IDIwMTEsIDIwMTIsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIyBDb3B5
cmlnaHQgKEMpIDIwMTEsIDIwMTIsIDIwMTMsIDIwMTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl
c2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5
IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy
b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xNDIsNyArMTQyLDYgQEAg
ZW5kCiBtYWNybyBjYWxsU2xvd1BhdGgoc2xvd1BhdGgpCiAgICAgY0NhbGwyKHNsb3dQYXRoLCBj
ZnIsIFBDKQogICAgIG1vdmUgdDAsIFBDCi0gICAgbW92ZSB0MSwgY2ZyCiBlbmQKIAogbWFjcm8g
ZG9DYWxsVG9KYXZhU2NyaXB0KG1ha2VDYWxsKQpAQCAtMTU1LDIwICsxNTQsOSBAQCBtYWNybyBk
b0NhbGxUb0phdmFTY3JpcHQobWFrZUNhbGwpCiAgICAgICAgIGNvbnN0IHByZXZpb3VzUEMgPSB0
MQogICAgICAgICBjb25zdCB0ZW1wMSA9IHQwICMgU2FtZSBhcyBwcmV2aW91c0NGUgogICAgICAg
ICBjb25zdCB0ZW1wMiA9IHQxICMgU2FtZSBhcyBwcmV2aW91c1BDCi0gICAgICAgIGNvbnN0IHRl
bXAzID0gdDIgIyBzYW1lIGFzIHZtVG9wQ2FsbEZyYW1lCisgICAgICAgIGNvbnN0IHRlbXAzID0g
dDIKICAgICAgICAgY29uc3QgdGVtcDQgPSB0MwotICAgIGVsc2lmIEFSTSBvciBBUk12N19UUkFE
SVRJT05BTAotICAgICAgICBjb25zdCBlbnRyeSA9IGEwCi0gICAgICAgIGNvbnN0IHZtID0gYTEK
LSAgICAgICAgY29uc3QgcHJvdG9DYWxsRnJhbWUgPSBhMgotCi0gICAgICAgIGNvbnN0IHByZXZp
b3VzQ0ZSID0gdDMKLSAgICAgICAgY29uc3QgcHJldmlvdXNQQyA9IGxyCi0gICAgICAgIGNvbnN0
IHRlbXAxID0gdDMgIyBTYW1lIGFzIHByZXZpb3VzQ0ZSCi0gICAgICAgIGNvbnN0IHRlbXAyID0g
YTMgIyBTYW1lIGFzIHRvcE9mU3RhY2sKLSAgICAgICAgY29uc3QgdGVtcDMgPSB0NQotICAgICAg
ICBjb25zdCB0ZW1wNCA9IHQ0Ci0gICAgZWxzaWYgQVJNdjcKKyAgICBlbHNpZiBBUk12NyBvciBB
Uk0gb3IgQVJNdjdfVFJBRElUSU9OQUwgb3IgQ19MT09QCiAgICAgICAgIGNvbnN0IGVudHJ5ID0g
YTAKICAgICAgICAgY29uc3Qgdm0gPSBhMQogICAgICAgICBjb25zdCBwcm90b0NhbGxGcmFtZSA9
IGEyCkBAIC0xNzYsOSArMTY0LDkgQEAgbWFjcm8gZG9DYWxsVG9KYXZhU2NyaXB0KG1ha2VDYWxs
KQogICAgICAgICBjb25zdCBwcmV2aW91c0NGUiA9IHQzCiAgICAgICAgIGNvbnN0IHByZXZpb3Vz
UEMgPSBscgogICAgICAgICBjb25zdCB0ZW1wMSA9IHQzICMgU2FtZSBhcyBwcmV2aW91c0NGUgot
ICAgICAgICBjb25zdCB0ZW1wMiA9IGEzICMgU2FtZSBhcyB0b3BPZlN0YWNrCisgICAgICAgIGNv
bnN0IHRlbXAyID0gdDQKICAgICAgICAgY29uc3QgdGVtcDMgPSB0NQotICAgICAgICBjb25zdCB0
ZW1wNCA9IHQ0CisgICAgICAgIGNvbnN0IHRlbXA0ID0gdDQgIyBTYW1lIGFzIHRlbXAyCiAgICAg
ZWxzaWYgTUlQUwogICAgICAgICBjb25zdCBlbnRyeSA9IGEwCiAgICAgICAgIGNvbnN0IHZtVG9w
Q2FsbEZyYW1lID0gYTEKQEAgLTIwNSw2ICsxOTMsOCBAQCBtYWNybyBkb0NhbGxUb0phdmFTY3Jp
cHQobWFrZUNhbGwpCiAgICAgICAgIGNvbnN0IHRlbXA0ID0gdDkKICAgICBlbmQKIAorICAgIGNh
bGxUb0phdmFTY3JpcHRQcm9sb2d1ZSgpCisKICAgICBpZiBYODYKICAgICAgICAgbG9hZHAgW3Nw
XSwgcHJldmlvdXNQQwogICAgICAgICBtb3ZlIGNmciwgcHJldmlvdXNDRlIKQEAgLTIxNSwyMCAr
MjA1LDkgQEAgbWFjcm8gZG9DYWxsVG9KYXZhU2NyaXB0KG1ha2VDYWxsKQogICAgICAgICBsb2Fk
cCAyOFtzcF0sIHByb3RvQ2FsbEZyYW1lCiAgICAgZWxzZQogICAgICAgICBtb3ZlIGNmciwgcHJl
dmlvdXNDRlIKLSAgICAgICAgbW92ZSB0b3BPZlN0YWNrLCBjZnIKICAgICBlbmQKLSAgICBjYWxs
VG9KYXZhU2NyaXB0UHJvbG9ndWUoKQotICAgIAotICAgIGNoZWNrU3RhY2tQb2ludGVyQWxpZ25t
ZW50KHRlbXAyLCAweGJhZDBkYzAxKQogCi0gICAgIyBUaGUganNTdGFja0xpbWl0IHdhcyBwcmV2
aW91c2x5IGNvbXB1dGVkIGluIFZNRW50cnlTY29wZSB1c2luZyBhbgotICAgICMgZXN0aW1hdGVk
IHN0YWNrUG9pbnRlckF0Vk1FbnRyeSB2YWx1ZS4gQWRqdXN0IHRoZSBqc1N0YWNrTGltaXQgYnkK
LSAgICAjIHRoZSBkZWx0YSBiZXR3ZWVuIHRoZSBhY3R1YWwgc3RhY2tQb2ludGVyQXRWTUVudHJ5
IGFuZCB0aGUgZXN0aW1hdGUKLSAgICAjIHRoYXQgd2UgdXNlZCBwcmV2aW91c2x5LgotICAgIHN1
YnAgVk06OnN0YWNrUG9pbnRlckF0Vk1FbnRyeVt2bV0sIHNwLCB0ZW1wMgotICAgIHN1YnAgVk06
Om1fanNTdGFja0xpbWl0W3ZtXSwgdGVtcDIsIHRlbXAyCi0gICAgc3RvcmVwIHRlbXAyLCBWTTo6
bV9qc1N0YWNrTGltaXRbdm1dCi0gICAgc3RvcmVwIHNwLCBWTTo6c3RhY2tQb2ludGVyQXRWTUVu
dHJ5W3ZtXQorICAgIGNoZWNrU3RhY2tQb2ludGVyQWxpZ25tZW50KHRlbXAyLCAweGJhZDBkYzAx
KQogCiAgICAgIyBUaGUgc3RhY2sgcmVzZXJ2ZWQgem9uZSBlbnN1cmVzIHRoYXQgd2UgaGF2ZSBh
ZGVxdWF0ZSBzcGFjZSBmb3IgdGhlCiAgICAgIyBWTUVudHJ5U2VudGluZWxGcmFtZS4gUHJvY2Vl
ZCB3aXRoIGFsbG9jYXRpbmcgYW5kIGluaXRpYWxpemluZyB0aGUKQEAgLTI1NiwxMiArMjM1LDE5
IEBAIG1hY3JvIGRvQ2FsbFRvSmF2YVNjcmlwdChtYWtlQ2FsbCkKICAgICBtb3ZlIGNmciwgc3AK
IAogICAgIGlmIENfTE9PUAotICAgICMgRklYTUU6IE5lZWQgdG8gY2FsbCBzdGFjayBjaGVjayBo
ZXJlIHRvIHNlZSBpZiB3ZSBjYW4gZ3JvdyB0aGUgc3RhY2suCi0gICAgIyBXaWxsIG5lZWQgdG8g
cHJlc2VydmUgcmVnaXN0ZXJzIHNvIHRoYXQgd2UgY2FuIHJlY292ZXIgaWYgd2UgZG8gbm90IGVu
ZAotICAgICMgdXAgdGhyb3dpbmcgYSBTdGFja092ZXJmbG93RXJyb3IuCisgICAgICAgIG1vdmUg
ZW50cnksIHRlbXAyCisgICAgICAgIG1vdmUgdm0sIHRlbXAzCisgICAgICAgIGNsb29wQ2FsbFNs
b3dQYXRoIF9sbGludF9zdGFja19jaGVja19hdF92bV9lbnRyeSwgdm0sIHRlbXAxCisgICAgICAg
IGJwZXEgdDAsIDAsIC5zdGFja0NoZWNrRmFpbGVkCisgICAgICAgIG1vdmUgdGVtcDIsIGVudHJ5
CisgICAgICAgIG1vdmUgdGVtcDMsIHZtCisgICAgICAgIGptcCAuc3RhY2tIZWlnaHRPSworCisu
c3RhY2tDaGVja0ZhaWxlZDoKKyAgICAgICAgbW92ZSB0ZW1wMiwgZW50cnkKKyAgICAgICAgbW92
ZSB0ZW1wMywgdm0KICAgICBlbmQKIAotICAgIHN0b3JlcCAwLCBWTTo6c3RhY2tQb2ludGVyQXRW
TUVudHJ5W3ZtXQogICAgIGNDYWxsMihfbGxpbnRfdGhyb3dfc3RhY2tfb3ZlcmZsb3dfZXJyb3Is
IHZtLCBwcm90b0NhbGxGcmFtZSkKICAgICBjYWxsVG9KYXZhU2NyaXB0RXBpbG9ndWUoKQogICAg
IHJldApAQCAtMzE1LDkgKzMwMSw5IEBAIG1hY3JvIGRvQ2FsbFRvSmF2YVNjcmlwdChtYWtlQ2Fs
bCkKICAgICBsb2FkcCBDYWxsZXJGcmFtZVtjZnJdLCBjZnIKIAogLmNhbGxlZUZyYW1lUG9wcGVk
OgotICAgIGxvYWRwIENhbGxlZVtjZnJdLCB0ZW1wMiAjIFZNCi0gICAgbG9hZHAgU2NvcGVDaGFp
bltjZnJdLCB0ZW1wMyAjIHByZXZpb3VzIHRvcENhbGxGcmFtZQotICAgIHN0b3JlcCB0ZW1wMywg
Vk06OnRvcENhbGxGcmFtZVt0ZW1wMl0KKyAgICBsb2FkcCBDYWxsZWVbY2ZyXSwgdGVtcDMgIyBW
TQorICAgIGxvYWRwIFNjb3BlQ2hhaW5bY2ZyXSwgdGVtcDQgIyBwcmV2aW91cyB0b3BDYWxsRnJh
bWUKKyAgICBzdG9yZXAgdGVtcDQsIFZNOjp0b3BDYWxsRnJhbWVbdGVtcDNdCiAKICAgICBjaGVj
a1N0YWNrUG9pbnRlckFsaWdubWVudCh0ZW1wMywgMHhiYWQwZGMwNCkKIApAQCAtMzI2LDE5ICsz
MTIsNDAgQEAgbWFjcm8gZG9DYWxsVG9KYXZhU2NyaXB0KG1ha2VDYWxsKQogZW5kCiAKIG1hY3Jv
IG1ha2VKYXZhU2NyaXB0Q2FsbChlbnRyeSwgdGVtcCkKLSAgICBjYWxsIGVudHJ5CisgICAgYWRk
cCA4LCBzcAorICAgIGlmIENfTE9PUAorICAgICAgICBjbG9vcENhbGxKU0Z1bmN0aW9uIGVudHJ5
CisgICAgZWxzZQorICAgICAgICBjYWxsIGVudHJ5CisgICAgZW5kCisgICAgc3VicCA4LCBzcAog
ZW5kCiAKIG1hY3JvIG1ha2VIb3N0RnVuY3Rpb25DYWxsKGVudHJ5LCB0ZW1wKQogICAgIG1vdmUg
ZW50cnksIHRlbXAKLSAgICBpZiBYODYKLSAgICAgICAgIyBQdXQgY2ZyIG9uIHN0YWNrIGFzIGFy
ZzAsIGFsc28gcHV0IGl0IGluIGVjeCBmb3IgImZhc3RjYWxsIiB0YXJnZXRzCi0gICAgICAgIHBv
a2UgY2ZyLCAwCi0gICAgICAgIG1vdmUgY2ZyLCB0MgorICAgIGlmIENfTE9PUAorICAgICAgICBt
b3ZlIHNwLCBhMAorICAgICAgICBzdG9yZXAgY2ZyLCBbc3BdCisgICAgICAgIHN0b3JlcCBsciwg
NFtzcF0KKyAgICAgICAgY2xvb3BDYWxsTmF0aXZlIHRlbXAKICAgICBlbHNlCi0gICAgICAgIG1v
dmUgY2ZyLCBhMAorICAgICAgICBpZiBYODYKKyAgICAgICAgICAgICMgUHV0IGNhbGxlZSBmcmFt
ZSBwb2ludGVyIG9uIHN0YWNrIGFzIGFyZzAsIGFsc28gcHV0IGl0IGluIGVjeCBmb3IgImZhc3Rj
YWxsIiB0YXJnZXRzCisgICAgICAgICAgICBtb3ZlIHNwLCB0MiAjIHQyIGlzIGVjeAorICAgICAg
ICAgICAgbW92ZSBjZnIsIFtzcF0gIyBwdXQgY2FsbGVyIGZyYW1lIHBvaW50ZXIgaW50byBjYWxs
ZWUgZnJhbWUgc2luY2UgY2FsbGVlIHByb2xvZ3VlIGNhbid0CisgICAgICAgICAgICBzdWJwIDEy
LCBzcAorICAgICAgICAgICAgcHVzaCB0MgorICAgICAgICBlbHNlCisgICAgICAgICAgICBtb3Zl
IHNwLCBhMAorICAgICAgICAgICAgYWRkcCA4LCBzcAorICAgICAgICBlbmQKKyAgICAgICAgY2Fs
bCB0ZW1wCisgICAgICAgIGlmIFg4NgorICAgICAgICAgICAgYWRkcCAxNiwgc3AKKyAgICAgICAg
ZWxzZQorICAgICAgICAgICAgc3VicCA4LCBzcAorICAgICAgICBlbmQKICAgICBlbmQKLSAgICBj
YWxsIHRlbXAKIGVuZAogCiBfaGFuZGxlVW5jYXVnaHRFeGNlcHRpb246CkBAIC0zNTIsOSArMzU5
LDkgQEAgX2hhbmRsZVVuY2F1Z2h0RXhjZXB0aW9uOgogICAgICMgcmV0dXJuaW5nIHRvIHRoZSBj
YWxsZXIgQyBmcmFtZS4KICAgICBsb2FkcCBDYWxsZXJGcmFtZSArIFBheWxvYWRPZmZzZXRbY2Zy
XSwgY2ZyCiAKLSAgICBsb2FkcCBDYWxsZWUgKyBQYXlsb2FkT2Zmc2V0W2Nmcl0sIHQzICMgVk0u
dG9wQ2FsbEZyYW1lCi0gICAgbG9hZHAgU2NvcGVDaGFpbiArIFBheWxvYWRPZmZzZXRbY2ZyXSwg
dDUKLSAgICBzdG9yZXAgdDUsIFt0M10KKyAgICBsb2FkcCBDYWxsZWUgKyBQYXlsb2FkT2Zmc2V0
W2Nmcl0sIHQzICMgVk0KKyAgICBsb2FkcCBTY29wZUNoYWluICsgUGF5bG9hZE9mZnNldFtjZnJd
LCB0NSAjIHByZXZpb3VzIHRvcENhbGxGcmFtZQorICAgIHN0b3JlcCB0NSwgVk06OnRvcENhbGxG
cmFtZVt0M10KIAogICAgIGNhbGxUb0phdmFTY3JpcHRFcGlsb2d1ZSgpCiAgICAgcmV0CkBAIC0z
ODcsMTQgKzM5NCwxMiBAQCBlbmQKIG1hY3JvIGNhbGxDYWxsU2xvd1BhdGgoc2xvd1BhdGgsIGFj
dGlvbikKICAgICBzdG9yZXAgUEMsIEFyZ3VtZW50Q291bnQgKyBUYWdPZmZzZXRbY2ZyXQogICAg
IGNDYWxsMihzbG93UGF0aCwgY2ZyLCBQQykKLSAgICBtb3ZlIHQxLCBjZnIKICAgICBhY3Rpb24o
dDApCiBlbmQKIAogbWFjcm8gY2FsbFdhdGNoZG9nVGltZXJIYW5kbGVyKHRocm93SGFuZGxlcikK
ICAgICBzdG9yZWkgUEMsIEFyZ3VtZW50Q291bnQgKyBUYWdPZmZzZXRbY2ZyXQogICAgIGNDYWxs
MihfbGxpbnRfc2xvd19wYXRoX2hhbmRsZV93YXRjaGRvZ190aW1lciwgY2ZyLCBQQykKLSAgICBt
b3ZlIHQxLCBjZnIKICAgICBidHBueiB0MCwgdGhyb3dIYW5kbGVyCiAgICAgbG9hZGkgQXJndW1l
bnRDb3VudCArIFRhZ09mZnNldFtjZnJdLCBQQwogZW5kCkBAIC0yMTE1LDM5ICsyMTIwLDI3IEBA
IG1hY3JvIG5hdGl2ZUNhbGxUcmFtcG9saW5lKGV4ZWN1dGFibGVPZmYKICAgICAgICAgbG9hZHAg
U2NvcGVDaGFpbltjZnJdLCB0MwogICAgICAgICBhbmRwIE1hcmtlZEJsb2NrTWFzaywgdDMKICAg
ICAgICAgbG9hZHAgTWFya2VkQmxvY2s6Om1fd2Vha1NldCArIFdlYWtTZXQ6Om1fdm1bdDNdLCB0
MwotICAgIGVsc2lmIEFSTSBvciBBUk12NyBvciBBUk12N19UUkFESVRJT05BTCBvciBNSVBTIG9y
IFNINAotICAgICAgICBsb2FkcCBTY29wZUNoYWluW2Nmcl0sIHQzCi0gICAgICAgIGFuZHAgTWFy
a2VkQmxvY2tNYXNrLCB0MwotICAgICAgICBsb2FkcCBNYXJrZWRCbG9jazo6bV93ZWFrU2V0ICsg
V2Vha1NldDo6bV92bVt0M10sIHQzCi0gICAgICAgIHN0b3JlcCBjZnIsIFZNOjp0b3BDYWxsRnJh
bWVbdDNdCi0gICAgICAgIG1vdmUgdDAsIHQyCisgICAgZWxzaWYgQVJNIG9yIEFSTXY3IG9yIEFS
TXY3X1RSQURJVElPTkFMIG9yIENfTE9PUCBvciBNSVBTIG9yIFNINAorICAgICAgICAjIHQxIGFs
cmVhZHkgY29udGFpbnMgdGhlIFNjb3BlQ2hhaW4uCisgICAgICAgIGFuZHAgTWFya2VkQmxvY2tN
YXNrLCB0MQorICAgICAgICBsb2FkcCBNYXJrZWRCbG9jazo6bV93ZWFrU2V0ICsgV2Vha1NldDo6
bV92bVt0MV0sIHQxCisgICAgICAgIHN0b3JlcCBjZnIsIFZNOjp0b3BDYWxsRnJhbWVbdDFdCisg
ICAgICAgIG1vdmUgdDAsIHQyICMgdDAgY29udGFpbnMgY2FsbGVyRnJhbWUKICAgICAgICAgcHJl
c2VydmVSZXR1cm5BZGRyZXNzQWZ0ZXJDYWxsKHQzKQogICAgICAgICBzdG9yZXAgdDMsIFJldHVy
blBDW2Nmcl0KLSAgICAgICAgbW92ZSBjZnIsIHQwCi0gICAgICAgIGxvYWRpIENhbGxlZSArIFBh
eWxvYWRPZmZzZXRbY2ZyXSwgdDEKLSAgICAgICAgbG9hZHAgSlNGdW5jdGlvbjo6bV9leGVjdXRh
YmxlW3QxXSwgdDEKLSAgICAgICAgbW92ZSB0MiwgY2ZyCiAgICAgICAgIGlmIE1JUFMgb3IgU0g0
Ci0gICAgICAgICAgICBtb3ZlIHQwLCBhMAorICAgICAgICAgICAgbW92ZSBjZnIsIGEwCisgICAg
ICAgIGVsc2UKKyAgICAgICAgICAgIG1vdmUgY2ZyLCB0MAogICAgICAgICBlbmQKLSAgICAgICAg
Y2FsbCBleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvblt0MV0KLSAgICAgICAgcmVzdG9yZVJldHVy
bkFkZHJlc3NCZWZvcmVSZXR1cm4odDMpCi0gICAgICAgIGxvYWRwIFNjb3BlQ2hhaW5bY2ZyXSwg
dDMKLSAgICAgICAgYW5kcCBNYXJrZWRCbG9ja01hc2ssIHQzCi0gICAgICAgIGxvYWRwIE1hcmtl
ZEJsb2NrOjptX3dlYWtTZXQgKyBXZWFrU2V0OjptX3ZtW3QzXSwgdDMKLSAgICBlbHNpZiBDX0xP
T1AKLSAgICAgICAgbG9hZHAgU2NvcGVDaGFpbltjZnJdLCB0MwotICAgICAgICBhbmRwIE1hcmtl
ZEJsb2NrTWFzaywgdDMKLSAgICAgICAgbG9hZHAgTWFya2VkQmxvY2s6Om1fd2Vha1NldCArIFdl
YWtTZXQ6Om1fdm1bdDNdLCB0MwotICAgICAgICBzdG9yZXAgY2ZyLCBWTTo6dG9wQ2FsbEZyYW1l
W3QzXQotICAgICAgICBtb3ZlIHQwLCB0MgotICAgICAgICBwcmVzZXJ2ZVJldHVybkFkZHJlc3NB
ZnRlckNhbGwodDMpCi0gICAgICAgIHN0b3JlcCB0MywgUmV0dXJuUENbY2ZyXQotICAgICAgICBt
b3ZlIGNmciwgdDAKICAgICAgICAgbG9hZGkgQ2FsbGVlICsgUGF5bG9hZE9mZnNldFtjZnJdLCB0
MQogICAgICAgICBsb2FkcCBKU0Z1bmN0aW9uOjptX2V4ZWN1dGFibGVbdDFdLCB0MQogICAgICAg
ICBtb3ZlIHQyLCBjZnIKLSAgICAgICAgY2xvb3BDYWxsTmF0aXZlIGV4ZWN1dGFibGVPZmZzZXRU
b0Z1bmN0aW9uW3QxXQorICAgICAgICBpZiBDX0xPT1AKKyAgICAgICAgICAgIGNsb29wQ2FsbE5h
dGl2ZSBleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvblt0MV0KKyAgICAgICAgZWxzZQorICAgICAg
ICAgICAgY2FsbCBleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvblt0MV0KKyAgICAgICAgZW5kCiAg
ICAgICAgIHJlc3RvcmVSZXR1cm5BZGRyZXNzQmVmb3JlUmV0dXJuKHQzKQogICAgICAgICBsb2Fk
cCBTY29wZUNoYWluW2Nmcl0sIHQzCiAgICAgICAgIGFuZHAgTWFya2VkQmxvY2tNYXNrLCB0MwpJ
bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNt
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy
cHJldGVyLmFzbQkocmV2aXNpb24gMTYyMTA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xs
aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBA
QAotIyBDb3B5cmlnaHQgKEMpIDIwMTEsIDIwMTIsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRz
IHJlc2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTEsIDIwMTIsIDIwMTMsIDIwMTQgQXBwbGUg
SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGlu
IHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9u
LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBA
IC0zMzYsMTUgKzMzNiwxNSBAQCBtYWNybyBjYWxsVG9KYXZhU2NyaXB0RXBpbG9ndWUoKQogZW5k
CiAKIG1hY3JvIG1vdmVTdGFja1BvaW50ZXJGb3JDb2RlQmxvY2soY29kZUJsb2NrLCBzY3JhdGNo
KQotICAgIGxvYWRpIENvZGVCbG9jazo6bV9udW1DYWxsZWVSZWdpc3RlcnNbY29kZUJsb2NrXSwg
dDIKLSAgICBsc2hpZnRwIDMsIHQyCi0gICAgYWRkcCBtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRo
Q2FsbCwgdDIKLSAgICBzdWJwIGNmciwgdDIsIHNwCisgICAgbG9hZGkgQ29kZUJsb2NrOjptX251
bUNhbGxlZVJlZ2lzdGVyc1tjb2RlQmxvY2tdLCBzY3JhdGNoCisgICAgbHNoaWZ0cCAzLCBzY3Jh
dGNoCisgICAgYWRkcCBtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRoQ2FsbCwgc2NyYXRjaAorICAg
IHN1YnAgY2ZyLCBzY3JhdGNoLCBzcAogZW5kCiAKIG1hY3JvIHJlc3RvcmVTdGFja1BvaW50ZXJB
ZnRlckNhbGwoKQotICAgIGxvYWRwIENvZGVCbG9ja1tjZnJdLCB0MQotICAgIG1vdmVTdGFja1Bv
aW50ZXJGb3JDb2RlQmxvY2sodDEsIHQyKQorICAgIGxvYWRwIENvZGVCbG9ja1tjZnJdLCB0Mgor
ICAgIG1vdmVTdGFja1BvaW50ZXJGb3JDb2RlQmxvY2sodDIsIHQ0KQogZW5kCiAKIG1hY3JvIHRy
YWNlRXhlY3V0aW9uKCkK
</data>
<flag name="review"
          id="245240"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>