127079 2014-01-15 20:28:00 -0800 EWS shouldn't comment on Bugzilla for failing builds or style errors 2019-09-19 10:39:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201993 P2 Normal --- 1 rniwa rniwa commit-queue glenn sam oldest_to_newest 968580 0 rniwa 2014-01-15 20:28:00 -0800 EWS shouldn't comment on Bugzilla for failing builds or style errors 968581 1 221326 rniwa 2014-01-15 20:29:05 -0800 Created attachment 221326 Fixes the bug 968582 2 sam 2014-01-15 20:32:55 -0800 I will r+ this as soon as we let more people chime in on the thread on webkit-dev. 968583 3 rniwa 2014-01-15 20:33:24 -0800 Per https://lists.webkit.org/pipermail/webkit-dev/2014-January/026068.html. I'll wait one business day to see what others think of this proposal. 968865 4 221404 rniwa 2014-01-16 12:39:16 -0800 Created attachment 221404 Post style errors 968963 5 221404 rniwa 2014-01-16 15:10:50 -0800 Comment on attachment 221404 Post style errors Clearing flags on attachment: 221404 Committed r162159: <http://trac.webkit.org/changeset/162159> 968964 6 rniwa 2014-01-16 15:10:52 -0800 All reviewed patches have been landed. Closing bug. 221326 2014-01-15 20:29:05 -0800 2014-01-16 12:39:14 -0800 Fixes the bug bug-127079-20140115202905.patch text/plain 2589 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MjExMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE0LTAxLTE1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEVXUyBzaG91bGRuJ3QgY29tbWVudCBvbiBCdWd6aWxsYSBmb3IgZmFpbGluZyBi dWlsZHMgb3Igc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjcwNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW5jZSBwYXRjaCBhdXRob3JzIGFuZCByZXZpZXdlcnMgY291bGQgcmV0 cmlldmUgdGhpcyBpbmZvcm1hdGlvbiBmcm9tIGJ1YmJsZXMsCisgICAgICAgIHdlIHNob3VsZG4n dCBzcGFtIHRoZSBCdWd6aWxsYSB3aXRoIHVzZWxlc3MgY29tbWVudHMuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5OgorICAg ICAgICAoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0uX3Bvc3RfcmVqZWN0X21lc3NhZ2Vfb25f YnVnKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5 OgorICAgICAgICAoU3R5bGVRdWV1ZS5yZXZpZXdfcGF0Y2gpOgorCiAyMDE0LTAxLTE1ICBBbGV4 ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIER1bXBSZW5kZXJUcmVl IGRvZXNuJ3QgZGlzYWJsZSB3ZWIgcHJlZmVyZW5jZXMgYXV0b3NhdmUKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2Fybmlu Z3N5c3RlbS5weQkocmV2aXNpb24gMTU1MTk2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQkod29ya2luZyBjb3B5KQpAQCAtNjYs NiArNjYsOSBAQCBjbGFzcyBBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbShBYnN0cmFjCiAgICAg ICAgIHJldHVybiAiTmV3IGZhaWxpbmcgdGVzdHM6XG4lcyIgJSAiXG4iLmpvaW4odW5leHBlY3Rl ZF9mYWlsdXJlcykKIAogICAgIGRlZiBfcG9zdF9yZWplY3RfbWVzc2FnZV9vbl9idWcoc2VsZiwg dG9vbCwgcGF0Y2gsIHN0YXR1c19pZCwgZXh0cmFfbWVzc2FnZV90ZXh0PU5vbmUpOgorICAgICAg ICBpZiBub3QgZXh0cmFfbWVzc2FnZV90ZXh0OgorICAgICAgICAgICAgcmV0dXJuICAjIERvbid0 IGNvbW1lbnQgb24gQnVnemlsbGEgaWYgd2UgZG9uJ3QgaGF2ZSBmYWlsaW5nIHRlc3RzLgorCiAg ICAgICAgIHJlc3VsdHNfbGluayA9IHRvb2wuc3RhdHVzX3NlcnZlci5yZXN1bHRzX3VybF9mb3Jf c3RhdHVzKHN0YXR1c19pZCkKICAgICAgICAgbWVzc2FnZSA9ICJBdHRhY2htZW50ICVzIGRpZCBu b3QgcGFzcyAlcyAoJXMpOlxuT3V0cHV0OiAlcyIgJSAocGF0Y2guaWQoKSwgc2VsZi5uYW1lLCBz ZWxmLnBvcnRfbmFtZSwgcmVzdWx0c19saW5rKQogICAgICAgICBpZiBleHRyYV9tZXNzYWdlX3Rl eHQ6CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1 ZXMucHkJKHJldmlzaW9uIDE1NTE5NikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9xdWV1ZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ2NSw4ICs0NjUsNiBAQCBjbGFz cyBTdHlsZVF1ZXVlKEFic3RyYWN0UmV2aWV3UXVldWUsIFN0CiAgICAgICAgICAgICBzZWxmLl9k aWRfZXJyb3IocGF0Y2gsICIlcyB1bmFibGUgdG8gYXBwbHkgcGF0Y2guIiAlIHNlbGYubmFtZSkK ICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6 Ci0gICAgICAgICAgICBtZXNzYWdlID0gIkF0dGFjaG1lbnQgJXMgZGlkIG5vdCBwYXNzICVzOlxu XG4lc1xuXG5JZiBhbnkgb2YgdGhlc2UgZXJyb3JzIGFyZSBmYWxzZSBwb3NpdGl2ZXMsIHBsZWFz ZSBmaWxlIGEgYnVnIGFnYWluc3QgY2hlY2std2Via2l0LXN0eWxlLiIgJSAocGF0Y2guaWQoKSwg c2VsZi5uYW1lLCBlLm91dHB1dCkKLSAgICAgICAgICAgIHNlbGYuX3Rvb2wuYnVncy5wb3N0X2Nv bW1lbnRfdG9fYnVnKHBhdGNoLmJ1Z19pZCgpLCBtZXNzYWdlLCBjYz1zZWxmLndhdGNoZXJzKQog ICAgICAgICAgICAgc2VsZi5fZGlkX2ZhaWwocGF0Y2gpCiAgICAgICAgICAgICByZXR1cm4gRmFs c2UKICAgICAgICAgcmV0dXJuIFRydWUK 221404 2014-01-16 12:39:16 -0800 2014-01-16 15:10:50 -0800 Post style errors bug-127079-20140116123915.patch text/plain 3040 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MjExMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE0LTAxLTE1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEVXUyBzaG91bGRuJ3QgY29tbWVudCBvbiBCdWd6aWxsYSBmb3IgZmFpbGluZyBi dWlsZHMgb3Igc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjcwNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW5jZSBwYXRjaCBhdXRob3JzIGFuZCByZXZpZXdlcnMgY291bGQgcmV0 cmlldmUgdGhpcyBpbmZvcm1hdGlvbiBmcm9tIGJ1YmJsZXMsCisgICAgICAgIHdlIHNob3VsZG4n dCBzcGFtIHRoZSBCdWd6aWxsYSB3aXRoIHVzZWxlc3MgY29tbWVudHMuCisKKyAgICAgICAgV2Ug c3RpbGwgcG9zdCBzdHlsZSBlcnJvcnMgYnV0IG5vdCBweXRob24gcGF0aHMgd2UgdXNlZCBzaW5j ZSBpdCdzIGEgcHVyZSBub2lzZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHk6CisgICAgICAgIChBYnN0cmFjdEVhcmx5V2Fy bmluZ1N5c3RlbS5fcG9zdF9yZWplY3RfbWVzc2FnZV9vbl9idWcpOgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHk6CisgICAgICAgIChTdHlsZVF1ZXVl LnJldmlld19wYXRjaCk6CisKIDIwMTQtMDEtMTUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgRHVtcFJlbmRlclRyZWUgZG9lc24ndCBkaXNhYmxlIHdlYiBw cmVmZXJlbmNlcyBhdXRvc2F2ZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CShyZXZpc2lvbiAx NTUxOTYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJu aW5nc3lzdGVtLnB5CSh3b3JraW5nIGNvcHkpCkBAIC02Niw2ICs2Niw5IEBAIGNsYXNzIEFic3Ry YWN0RWFybHlXYXJuaW5nU3lzdGVtKEFic3RyYWMKICAgICAgICAgcmV0dXJuICJOZXcgZmFpbGlu ZyB0ZXN0czpcbiVzIiAlICJcbiIuam9pbih1bmV4cGVjdGVkX2ZhaWx1cmVzKQogCiAgICAgZGVm IF9wb3N0X3JlamVjdF9tZXNzYWdlX29uX2J1ZyhzZWxmLCB0b29sLCBwYXRjaCwgc3RhdHVzX2lk LCBleHRyYV9tZXNzYWdlX3RleHQ9Tm9uZSk6CisgICAgICAgIGlmIG5vdCBleHRyYV9tZXNzYWdl X3RleHQ6CisgICAgICAgICAgICByZXR1cm4gICMgRG9uJ3QgY29tbWVudCBvbiBCdWd6aWxsYSBp ZiB3ZSBkb24ndCBoYXZlIGZhaWxpbmcgdGVzdHMuCisKICAgICAgICAgcmVzdWx0c19saW5rID0g dG9vbC5zdGF0dXNfc2VydmVyLnJlc3VsdHNfdXJsX2Zvcl9zdGF0dXMoc3RhdHVzX2lkKQogICAg ICAgICBtZXNzYWdlID0gIkF0dGFjaG1lbnQgJXMgZGlkIG5vdCBwYXNzICVzICglcyk6XG5PdXRw dXQ6ICVzIiAlIChwYXRjaC5pZCgpLCBzZWxmLm5hbWUsIHNlbGYucG9ydF9uYW1lLCByZXN1bHRz X2xpbmspCiAgICAgICAgIGlmIGV4dHJhX21lc3NhZ2VfdGV4dDoKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQkocmV2aXNpb24gMTU1MTk2 KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQkod29y a2luZyBjb3B5KQpAQCAtMzAsNiArMzAsNyBAQAogaW1wb3J0IGNvZGVjcwogaW1wb3J0IGxvZ2dp bmcKIGltcG9ydCBvcworaW1wb3J0IHJlCiBpbXBvcnQgc3lzCiBpbXBvcnQgdGltZQogaW1wb3J0 IHRyYWNlYmFjawpAQCAtNDY1LDcgKzQ2Niw4IEBAIGNsYXNzIFN0eWxlUXVldWUoQWJzdHJhY3RS ZXZpZXdRdWV1ZSwgU3QKICAgICAgICAgICAgIHNlbGYuX2RpZF9lcnJvcihwYXRjaCwgIiVzIHVu YWJsZSB0byBhcHBseSBwYXRjaC4iICUgc2VsZi5uYW1lKQogICAgICAgICAgICAgcmV0dXJuIEZh bHNlCiAgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKLSAgICAgICAgICAgIG1lc3NhZ2Ug PSAiQXR0YWNobWVudCAlcyBkaWQgbm90IHBhc3MgJXM6XG5cbiVzXG5cbklmIGFueSBvZiB0aGVz ZSBlcnJvcnMgYXJlIGZhbHNlIHBvc2l0aXZlcywgcGxlYXNlIGZpbGUgYSBidWcgYWdhaW5zdCBj aGVjay13ZWJraXQtc3R5bGUuIiAlIChwYXRjaC5pZCgpLCBzZWxmLm5hbWUsIGUub3V0cHV0KQor ICAgICAgICAgICAgb3V0cHV0ID0gcmUuc3ViKHInRmFpbGVkIHRvIHJ1biAuKyBleGl0X2NvZGU6 IDEnLCAnJywgZS5vdXRwdXQpCisgICAgICAgICAgICBtZXNzYWdlID0gIkF0dGFjaG1lbnQgJXMg ZGlkIG5vdCBwYXNzICVzOlxuXG4lc1xuXG5JZiBhbnkgb2YgdGhlc2UgZXJyb3JzIGFyZSBmYWxz ZSBwb3NpdGl2ZXMsIHBsZWFzZSBmaWxlIGEgYnVnIGFnYWluc3QgY2hlY2std2Via2l0LXN0eWxl LiIgJSAocGF0Y2guaWQoKSwgc2VsZi5uYW1lLCBvdXRwdXQpCiAgICAgICAgICAgICBzZWxmLl90 b29sLmJ1Z3MucG9zdF9jb21tZW50X3RvX2J1ZyhwYXRjaC5idWdfaWQoKSwgbWVzc2FnZSwgY2M9 c2VsZi53YXRjaGVycykKICAgICAgICAgICAgIHNlbGYuX2RpZF9mYWlsKHBhdGNoKQogICAgICAg ICAgICAgcmV0dXJuIEZhbHNlCg==