127076 2014-01-15 16:57:01 -0800 check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp 2014-03-03 05:27:46 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg webkit-unassigned bfulgham commit-queue darin gbalogh.u-szeged glenn llango.u-szeged lvidacs.u-szeged ossy rniwa oldest_to_newest 968528 0 bburg 2014-01-15 16:57:01 -0800 Found in patch here: https://bugs.webkit.org/show_bug.cgi?id=127068 980782 1 ossy 2014-02-14 07:32:39 -0800 The problem is that style-checker thinks if it is a part of a member initialization. similar problem occured in https://bugs.webkit.org/show_bug.cgi?id=128579 Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:239 ... ::glResolveMultisampleFramebufferAPPLE(); ... https://bugs.webkit.org/show_bug.cgi?id=127068 Source/WebKit/win/WebNodeHighlight.cpp:168: ... ::SelectObject(hdc.get(), hbmp.get()); ... 981520 2 224394 lvidacs.u-szeged 2014-02-17 10:29:13 -0800 Created attachment 224394 Patch 984962 3 224394 rniwa 2014-02-26 15:51:23 -0800 Comment on attachment 224394 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224394&action=review > Tools/ChangeLog:8 > + Avoid match for :: Could you describe what the false positive was and what you're changing? This is too terse of a description. 984966 4 225315 lvidacs.u-szeged 2014-02-26 16:06:44 -0800 Created attachment 225315 Patch 985185 5 225315 commit-queue 2014-02-27 08:56:43 -0800 Comment on attachment 225315 Patch Clearing flags on attachment: 225315 Committed r164806: <http://trac.webkit.org/changeset/164806> 985186 6 commit-queue 2014-02-27 08:56:46 -0800 All reviewed patches have been landed. Closing bug. 986322 7 ossy 2014-03-03 05:27:46 -0800 *** Bug 126554 has been marked as a duplicate of this bug. *** 224394 2014-02-17 10:29:13 -0800 2014-02-26 16:06:36 -0800 Patch bug-127076-20140217192911.patch text/plain 2398 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MDI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmZhMWRjMjM2OGY2YzkwOGNmMWMyOTU0YWFhNzU5MDli ZGJiODM5MS4uZDI1NDQ2Y2E3YTRjMDNjN2YxY2Y3Y2U4YzE3NmFkZDJjOWFjZWI2YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTAyLTE3ICBMYXN6bG8gVmlkYWNzICA8bHZpZGFjcy51LXN6ZWdlZEBwYXJ0bmVy LnNhbXN1bmcuY29tPgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBpbmRlbnRhdGlvbiBm YWxzZSBhbGFybSBpbiBXZWJLaXQvd2luL1dlYk5vZGVIaWdobGlnaHQuY3BwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcwNzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCBtYXRjaCBmb3IgOjoK KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAg ICAgICAoY2hlY2tfbWVtYmVyX2luaXRpYWxpemF0aW9uX2xpc3QpOgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2Vi S2l0U3R5bGVUZXN0LnRlc3RfbWVtYmVyX2luaXRpYWxpemF0aW9uX2xpc3QpOgorCiAyMDE0LTAy LTEzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIE1vdmVkIG15c2VsZiB0byB0aGUgbGlzdCBvZiByZXZpZXdlcnMuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IDc3NDE3Mzk5 YzNhOTMzZTA4NGI4ODNjMTMzMTQ5OTdiN2E1ZThkMTYuLjlkMTI0ZWQ4ZDlhY2IxM2EyZDVmZTBl NjI5MWYzMmZhZmFhZGNiN2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5CkBAIC0yMDA2LDcgKzIwMDYsNyBAQCBkZWYgY2hlY2tfbWVtYmVyX2luaXRp YWxpemF0aW9uX2xpc3QoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgIyB3 aXRoIHRoZSBjb2xvbiBvciBjb21tYSBwcmVjZWRpbmcgdGhlIG1lbWJlciBvbiB0aGF0IGxpbmUu CiAgICAgYmVnaW5fbGluZSA9IGxpbmUKICAgICAjIG1hdGNoIHRoZSBzdGFydCBvZiBpbml0aWFs aXphdGlvbiBsaXN0Ci0gICAgaWYgc2VhcmNoKHInXig/UDxpbmRlbnRhdGlvbj5ccyopKChleHBs aWNpdFxzKyk/W14oXHN8XD8pXStcKFteXD9dKlwpXHM/XDp8Xihcc3xcPykqXDopLipbXjtdKiQn LCBsaW5lKToKKyAgICBpZiBzZWFyY2gocideKD9QPGluZGVudGF0aW9uPlxzKikoKGV4cGxpY2l0 XHMrKT9bXihcc3xcPyldK1woW15cP10qXClccz9cOnxeKFxzfFw/KSpcOikoW15cOl18XFopW147 XSokJywgbGluZSk6CiAgICAgICAgIGlmIHNlYXJjaChyJ1teOl1cOlteXDpcc10rJywgbGluZSk6 CiAgICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvaW5pdCcsIDQsCiAg ICAgICAgICAgICAgICAgJ01pc3Npbmcgc3BhY2VzIGFyb3VuZCA6JykKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXgg YzRjZjAxMDhmNGU1OGY2YTA4MzRlMzI3MDA4MTBkN2U5N2UzODAzMi4uZDI2MGI1YmZkMGU2YzBl ZDY2NzI0MjAwZmFhYmRjM2YxOTc1NWUyOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTUwMTksNiArNTAxOSw3 IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAg IDogTXlTdXBlckNsYXNzKGRvYywgZG9jKQogICAgICAgICB7IH0nJycsCiAgICAgICAgICcnKQor ICAgICAgICBzZWxmLmFzc2VydF9saW50KCc6OlNob3dXaW5kb3cobV9vdmVybGF5KTsnLCAnJykK ICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnbyA9IGZvbyhiID8gYmFyKCkgOiBiYXooKSk7Jywg JycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ01ZTUFDUk8oYSA/IGIoKSA6IGMpOycsICcn KQogCg== 225315 2014-02-26 16:06:44 -0800 2014-02-27 08:56:42 -0800 Patch bug-127076-20140227010643.patch text/plain 2609 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NzUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmNmNmVjY2MzYjI2YjRiNjg3NzkwMTM1NWM5OGE1YmQx NGRjOGFkZi4uZTFhYTE1NGFlMmFjODg5NTE5MWQyODMzNWViMTk3MmVjYTQxMmM5MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDE0LTAyLTI2ICBMYXN6bG8gVmlkYWNzICA8bHZpZGFjcy51LXN6ZWdlZEBwYXJ0bmVy LnNhbXN1bmcuY29tPgogCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBpbmRlbnRhdGlvbiBm YWxzZSBhbGFybSBpbiBXZWJLaXQvd2luL1dlYk5vZGVIaWdobGlnaHQuY3BwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcwNzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCBtYXRjaCBmb3IgOjog YXMgc3RhcnQgb2YgYSBtZW1iZXIgaW5pdGlhbGl6YXRpb24gbGlzdC4gTW9kaWZ5IGV4cHJlc3Np b24gdG8gbWF0Y2gKKyAgICAgICAgYWZ0ZXIgYSBjb2xvbiBlaXRoZXIgbm9uLWNvbG9uIGNoYXJh Y3RlciBvciBlbmQgb2YgbGluZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfbWVtYmVyX2luaXRpYWxpemF0aW9uX2xp c3QpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0 ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfbWVtYmVyX2luaXRpYWxpemF0 aW9uX2xpc3QpOgorCisyMDE0LTAyLTI2ICBMYXN6bG8gVmlkYWNzICA8bHZpZGFjcy51LXN6ZWdl ZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQuIE1vdmVkIG15c2Vs ZiB0byB0aGUgbGlzdCBvZiBjb21taXR0ZXJzLgogCiAgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA3NzQxNzM5OWMzYTkzM2UwODRiODgzYzEz MzE0OTk3YjdhNWU4ZDE2Li45ZDEyNGVkOGQ5YWNiMTNhMmQ1ZmUwZTYyOTFmMzJmYWZhYWRjYjdh IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAt MjAwNiw3ICsyMDA2LDcgQEAgZGVmIGNoZWNrX21lbWJlcl9pbml0aWFsaXphdGlvbl9saXN0KGNs ZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICMgd2l0aCB0aGUgY29sb24gb3Ig Y29tbWEgcHJlY2VkaW5nIHRoZSBtZW1iZXIgb24gdGhhdCBsaW5lLgogICAgIGJlZ2luX2xpbmUg PSBsaW5lCiAgICAgIyBtYXRjaCB0aGUgc3RhcnQgb2YgaW5pdGlhbGl6YXRpb24gbGlzdAotICAg IGlmIHNlYXJjaChyJ14oP1A8aW5kZW50YXRpb24+XHMqKSgoZXhwbGljaXRccyspP1teKFxzfFw/ KV0rXChbXlw/XSpcKVxzP1w6fF4oXHN8XD8pKlw6KS4qW147XSokJywgbGluZSk6CisgICAgaWYg c2VhcmNoKHInXig/UDxpbmRlbnRhdGlvbj5ccyopKChleHBsaWNpdFxzKyk/W14oXHN8XD8pXStc KFteXD9dKlwpXHM/XDp8Xihcc3xcPykqXDopKFteXDpdfFxaKVteO10qJCcsIGxpbmUpOgogICAg ICAgICBpZiBzZWFyY2gocidbXjpdXDpbXlw6XHNdKycsIGxpbmUpOgogICAgICAgICAgICAgZXJy b3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2luaXQnLCA0LAogICAgICAgICAgICAgICAgICdN aXNzaW5nIHNwYWNlcyBhcm91bmQgOicpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IGM0Y2YwMTA4ZjRlNThmNmEw ODM0ZTMyNzAwODEwZDdlOTdlMzgwMzIuLmQyNjBiNWJmZDBlNmMwZWQ2NjcyNDIwMGZhYWJkYzNm MTk3NTVlMjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC01MDE5LDYgKzUwMTksNyBAQCBjbGFzcyBXZWJLaXRT dHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICA6IE15U3VwZXJDbGFzcyhk b2MsIGRvYykKICAgICAgICAgeyB9JycnLAogICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgnOjpTaG93V2luZG93KG1fb3ZlcmxheSk7JywgJycpCiAgICAgICAgIHNlbGYuYXNz ZXJ0X2xpbnQoJ28gPSBmb28oYiA/IGJhcigpIDogYmF6KCkpOycsICcnKQogICAgICAgICBzZWxm LmFzc2VydF9saW50KCdNWU1BQ1JPKGEgPyBiKCkgOiBjKTsnLCAnJykKIAo=