127062 2014-01-15 12:56:55 -0800 DumpRenderTree doesn't disable web preferences autosave 2014-01-15 14:39:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue mitz thorton oldest_to_newest 968439 0 ap 2014-01-15 12:56:55 -0800 Didn't we all assume that it disabled autosave? I observed that running http/tests/security tests changed the value of -[WebPreferences privateBrowsingEnabled] in parallel DRT processes, which is horrible, because it could then easily get picked up by -[WebView _preferencesChanged:] any time it's called for any reason. 968440 1 221298 ap 2014-01-15 12:58:33 -0800 Created attachment 221298 proposed fix 968475 2 221298 commit-queue 2014-01-15 14:39:16 -0800 Comment on attachment 221298 proposed fix Clearing flags on attachment: 221298 Committed r162092: <http://trac.webkit.org/changeset/162092> 968476 3 commit-queue 2014-01-15 14:39:17 -0800 All reviewed patches have been landed. Closing bug. 221298 2014-01-15 12:58:33 -0800 2014-01-15 14:39:16 -0800 proposed fix Autosave.txt text/plain 1308 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MjA4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE0LTAxLTE1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIER1bXBSZW5kZXJUcmVlIGRvZXNuJ3QgZGlzYWJsZSB3ZWIgcHJlZmVyZW5j ZXMgYXV0b3NhdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNzA2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOiAocHJlcGFyZUNvbnNp c3RlbnRUZXN0aW5nRW52aXJvbm1lbnQpOgorICAgICAgICBEbyBpdC4KKwogMjAxNC0wMS0xNSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gV2ViIHByb2Nlc3Mgc29tZXRpbWVzIGNyYXNoZXMgd2hlbiBwcmludGluZyBpbiBzeW5jaHJv bm91cyBtb2RlCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVl Lm1tCShyZXZpc2lvbiAxNjIwODMpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJl bmRlclRyZWUubW0JKHdvcmtpbmcgY29weSkKQEAgLTgzNyw2ICs4MzcsOCBAQCBzdGF0aWMgdm9p ZCBwcmVwYXJlQ29uc2lzdGVudFRlc3RpbmdFbnZpCiAgICAgcG9zZUFzQ2xhc3MoIkR1bXBSZW5k ZXJUcmVlUGFzdGVib2FyZCIsICJOU1Bhc3RlYm9hcmQiKTsKICAgICBwb3NlQXNDbGFzcygiRHVt cFJlbmRlclRyZWVFdmVudCIsICJOU0V2ZW50Iik7CiAKKyAgICBbW1dlYlByZWZlcmVuY2VzIHN0 YW5kYXJkUHJlZmVyZW5jZXNdIHNldEF1dG9zYXZlczpOT107CisKICAgICAvLyBGSVhNRTogV2Un ZCBsaWtlIHRvIHN0YXJ0IHdpdGggYSBjbGVhbiBzdGF0ZSBmb3IgZXZlcnkgdGVzdCwgYnV0IHRo aXMgZnVuY3Rpb24gY2FuJ3QgYmUgdXNlZCBtb3JlIHRoYW4gb25jZSB5ZXQuCiAgICAgW1dlYlBy ZWZlcmVuY2VzIF9zd2l0Y2hOZXR3b3JrTG9hZGVyVG9OZXdUZXN0aW5nU2Vzc2lvbl07CiAK