127059 2014-01-15 12:27:43 -0800 [GTK] Fails to link JavaScriptCore in OS X, missing symbols add_history and readline 2015-10-12 10:04:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126492 1 jeremyhu webkit-unassigned achristensen andersca berto cgarcia commit-queue ossy philip.chimento pnormand oldest_to_newest 968427 0 jeremyhu 2014-01-15 12:27:43 -0800 darwin/gtk2/x11, webkit-gtk-2.3.4 fails to link. 2.3.3 was ok: libtool: link: /usr/bin/clang -arch x86_64 -ansi -fno-strict-aliasing -pipe -Os -ftemplate-depth=256 -arch x86_64 -pthread -std=c99 -Qunused-arguments -O2 -Wl,-headerpad_max_install_names -arch x86_64 -Wl,--no-demangle -o Programs/.libs/minidom Source/JavaScriptCore/API/tests/Programs_minidom-JSNode.o Source/JavaScriptCore/API/tests/Programs_minidom-JSNodeList.o Source/JavaScriptCore/API/tests/Programs_minidom-Node.o Source/JavaScriptCore/API/tests/Programs_minidom-NodeList.o Source/JavaScriptCore/API/tests/Programs_minidom-minidom.o -L/opt/local/lib ./.libs/libjavascriptcoregtk-1.0.dylib -lz -lgmodule-2.0 -lgthread-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl -licui18n -licuuc -licudata -lm -lpthread -lstdc++ -pthread libtool: link: /usr/bin/clang++ -fno-strict-aliasing -fno-rtti -I/opt/local/include -pipe -Os -ftemplate-depth=256 -Wno-c++11-extensions -arch x86_64 -stdlib=libc++ -pthread -std=c++11 -Wno-c++11-compat -Qunused-arguments -O2 -Wl,-headerpad_max_install_names -arch x86_64 -Wl,--no-demangle -o Programs/.libs/jsc-1 Source/JavaScriptCore/Programs_jsc_1-jsc.o -L/opt/local/lib ./.libs/libjavascriptcoregtk-1.0.dylib -lpthread -lz -lgmodule-2.0 -lgthread-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl -licui18n -licuuc -licudata -pthread Undefined symbols for architecture x86_64: "_add_history", referenced from: __Z7jscmainiPPc in Programs_jsc_1-jsc.o "_readline", referenced from: __Z7jscmainiPPc in Programs_jsc_1-jsc.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) 968429 1 jeremyhu 2014-01-15 12:30:21 -0800 You're missing a link against libedit. 971278 2 berto 2014-01-23 12:18:23 -0800 Ok, I see the problem, this was r161853. It's probably enough with something like this in Source/JavaScriptCore/GNUmakefile.am if OS_DARWIN Programs_jsc_LDADD += -ledit endif Can you give it a try and upload the patch if it works? 1039148 3 239185 philip.chimento 2014-10-03 00:36:45 -0700 Created attachment 239185 Patch Worked for me, with the addition of @WEBKITGTK_API_MAJOR_VERSION@. Here's the patch. 1039149 4 239186 philip.chimento 2014-10-03 00:43:43 -0700 Created attachment 239186 Patch 1039151 5 philip.chimento 2014-10-03 00:49:49 -0700 I'm guessing the patch doesn't apply to trunk because trunk doesn't use automake anymore :-/ Can it be committed to the 2.4 stable branch though? 1039796 6 239350 philip.chimento 2014-10-06 13:00:16 -0700 Created attachment 239350 Patch for 2.4.x stable branch 1039798 7 philip.chimento 2014-10-06 13:05:42 -0700 Here's an updated patch with changelog. 1046719 8 philip.chimento 2014-11-05 22:06:49 -0800 Would it be possible to get this reviewed for 2.4.8? 1046760 9 berto 2014-11-06 00:55:11 -0800 I believe the patch is fine, I just added it to the list of changes to merge for 2.4.8: http://trac.webkit.org/wiki/WebKitGTK/2.4.x Carlos will take care of it before the next release. Isn't webkitgtk 2.6 affected by this problem? 1046822 10 philip.chimento 2014-11-06 08:57:51 -0800 (In reply to comment #9) > I believe the patch is fine, I just added it to the list of changes > to merge for 2.4.8: > > http://trac.webkit.org/wiki/WebKitGTK/2.4.x > > Carlos will take care of it before the next release. > > Isn't webkitgtk 2.6 affected by this problem? This only affects the Automake build system, I think, which is defunct in 2.6. 1058498 11 philip.chimento 2015-01-02 20:11:16 -0800 I was wrong; -ledit is also missing in cmake in 2.6. I'll add a patch for that as well. Thanks for the review for 2.4.8, by the way. 1058518 12 243919 philip.chimento 2015-01-03 12:17:24 -0800 Created attachment 243919 Patch 1058543 13 philip.chimento 2015-01-04 09:10:18 -0800 Anyone know why -ledit would fail the "mac" EWS build? Do I need to check for PORT=GTK as well? 1058680 14 239350 cgarcia 2015-01-05 02:13:16 -0800 Comment on attachment 239350 Patch for 2.4.x stable branch Committed to 2.4 branch, thanks. <http://trac.webkit.org/changeset/177899> 1058681 15 cgarcia 2015-01-05 02:15:14 -0800 (In reply to comment #9) > I believe the patch is fine, I just added it to the list of changes > to merge for 2.4.8: > > http://trac.webkit.org/wiki/WebKitGTK/2.4.x > > Carlos will take care of it before the next release. > > Isn't webkitgtk 2.6 affected by this problem? Do we even support building wk2 in MAC OSX? 1058758 16 philip.chimento 2015-01-05 12:18:40 -0800 I don't know if you support it as such, but I have recently succeeded in building WebKitGTK 2.6.4 on OSX and would like to contribute all the fixes that I made. 1058929 17 pnormand 2015-01-06 01:02:44 -0800 The Mac EWS failure seems unrelated with this patch. Moreover the Mac port doesn't use CMake so I think this is safe for landing. 1094864 18 achristensen 2015-05-14 12:07:04 -0700 (In reply to comment #17) > The Mac EWS failure seems unrelated with this patch. I agree. > Moreover the Mac port doesn't use CMake so I think this is safe for landing. I think this is safe for landing, but I would have to change it to (WTF_OS_MAC_OS_X && GTK) or whatever the CMake equivalent is once I get back to getting CMake working on Mac for the non-GTK Mac port, which I assume does not use libedit (I'm not familiar with libedit). I'm ok with this patch with or without this change. 1095511 19 philip.chimento 2015-05-17 11:59:39 -0700 libedit is a BSD-licensed replacement for the GNU readline library. I assume JSC uses it in its REPL. 1132335 20 243919 commit-queue 2015-10-12 10:04:23 -0700 Comment on attachment 243919 Patch Clearing flags on attachment: 243919 Committed r190857: <http://trac.webkit.org/changeset/190857> 1132336 21 commit-queue 2015-10-12 10:04:32 -0700 All reviewed patches have been landed. Closing bug. 239185 2014-10-03 00:36:45 -0700 2014-10-03 00:43:43 -0700 Patch 127059-link-libedit.patch text/plain 537 philip.chimento SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0gICAgKHJldmlzaW9uIDE3NDI1 OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5hbSAgICAod29ya2luZyBj b3B5KQpAQCAtMTkzLDYgKzE5MywxMCBAQAogICAgbGliamF2YXNjcmlwdGNvcmVndGstQFdFQktJ VEdUS19BUElfTUFKT1JfVkVSU0lPTkAuQFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkAubGEg XAogICAgJChXSU5NTV9MSUJTKQogCitpZiBPU19EQVJXSU4KK1Byb2dyYW1zX2pzY19AV0VCS0lU R1RLX0FQSV9NQUpPUl9WRVJTSU9OQF9MREFERCArPSAtbGVkaXQKK2VuZGlmCisKIEVYVFJBX0RJ U1QgKz0gXAogICAgU291cmNlL0phdmFTY3JpcHRDb3JlL0FVVEhPUlMgXAogICAgU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBc 239186 2014-10-03 00:43:43 -0700 2014-10-06 13:00:11 -0700 Patch 127059-link-libedit.patch text/plain 642 philip.chimento ZGlmZiAtLWdpdCBhL3JlbGVhc2VzL1dlYktpdEdUSy93ZWJraXQtMi40LjYvU291cmNlL0phdmFT Y3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtIGIvcmVsZWFzZXMvV2ViS2l0R1RLL3dlYmtpdC0yLjQu Ni9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0KLS0tIGEvcmVsZWFzZXMvV2Vi S2l0R1RLL3dlYmtpdC0yLjQuNi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0g IChyZXZpc2lvbiAxNzQyNTgpCisrKyBiL3JlbGVhc2VzL1dlYktpdEdUSy93ZWJraXQtMi40LjYv U291cmNlL0phdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtICAod29ya2luZyBjb3B5KQpAQCAt MTkzLDYgKzE5MywxMCBAQAogICAgbGliamF2YXNjcmlwdGNvcmVndGstQFdFQktJVEdUS19BUElf TUFKT1JfVkVSU0lPTkAuQFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkAubGEgXAogICAgJChX SU5NTV9MSUJTKQogCitpZiBPU19EQVJXSU4KK1Byb2dyYW1zX2pzY19AV0VCS0lUR1RLX0FQSV9N QUpPUl9WRVJTSU9OQF9MREFERCArPSAtbGVkaXQKK2VuZGlmCisKIEVYVFJBX0RJU1QgKz0gXAog ICAgU291cmNlL0phdmFTY3JpcHRDb3JlL0FVVEhPUlMgXAogICAgU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZyBc 239350 2014-10-06 13:00:16 -0700 2015-01-05 02:13:16 -0800 Patch for 2.4.x stable branch bug-127059-20141006130017.patch text/plain 1264 philip.chimento SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0MzQ1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE0LTEwLTA2ICBQaGlsaXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29t PgorCisgICAgICAgIHdlYmtpdC1ndGsgZmFpbHMgdG8gbGluayBKYXZhU2NyaXB0Q29yZSwgbWlz c2luZyBzeW1ib2xzIGFkZF9oaXN0b3J5IGFuZCByZWFkbGluZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MDU5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogYWRkIC1sZWRp dCB0byBqc2MgbGluayBhcmdzIG9uIE9TX0RBUldJTi4KKwogMjAxNC0wOC0xOCAgRGllZ28gUGlu byBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIENvbXBsZXRlZCBpdGVyYXRv ciBjYW4gYmUgcmV2aXZlZCBieSBhZGRpbmcgbW9yZSB0aGFuIG9uZSBuZXcgZW50cnkgdG8gdGhl IHRhcmdldCBvYmplY3QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5h bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0JKHJl dmlzaW9uIDE3NDMwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5hbQko d29ya2luZyBjb3B5KQpAQCAtMTkzLDYgKzE5MywxMCBAQCBQcm9ncmFtc19qc2NfQFdFQktJVEdU S19BUElfTUFKT1JfVkVSU0lPCiAJbGliamF2YXNjcmlwdGNvcmVndGstQFdFQktJVEdUS19BUElf TUFKT1JfVkVSU0lPTkAuQFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkAubGEgXAogCSQoV0lO TU1fTElCUykKIAoraWYgT1NfREFSV0lOCitQcm9ncmFtc19qc2NfQFdFQktJVEdUS19BUElfTUFK T1JfVkVSU0lPTkBfTERBREQgKz0gLWxlZGl0CitlbmRpZgorCiBFWFRSQV9ESVNUICs9IFwKIAlT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVVUSE9SUyBcCiAJU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZyBcCg== 243919 2015-01-03 12:17:24 -0800 2015-10-12 10:04:23 -0700 Patch bug-127059-20150103131726.patch text/plain 1308 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NDlmMmI4YThlMThiOTFkNmU0ZDY0M2U0ZmVjODQ1MGI5MzhiYjIwLi5hMThhZWJiZGQyNTM2Mzhk ZDBmNDVhMTk5ZGM5ZTM1NWYzYzMwOTg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0wMS0wMyAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRv QGdtYWlsLmNvbT4KKworICAgICAgICB3ZWJraXQtZ3RrLTIuMy40IGZhaWxzIHRvIGxpbmsgSmF2 YVNjcmlwdENvcmUsIG1pc3Npbmcgc3ltYm9scyBhZGRfaGlzdG9yeSBhbmQgcmVhZGxpbmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzA1OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc2hlbGwvQ01h a2VMaXN0cy50eHQ6IExpbmsgSlNDIHdpdGggLWxlZGl0IG9uIE1hYyBPU1guCisKIDIwMTUtMDEt MDEgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgU3Ry aW5nIGluY2x1ZGVzIG1ldGhvZHMgcGVyZm9ybSB0b1N0cmluZyBvbiBzZWFyY2hTdHJpbmcgYmVm b3JlIHRvSW50MzIgb24gYSBvZmZzZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9zaGVsbC9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFr ZUxpc3RzLnR4dAppbmRleCA1OWFjYTcyYTNkNDI5NzE1MmJlZDBhMTUyOGFiYmRlOTRlMmYxYzMx Li5hN2RjMzA3ZDA4OWEwNjE0NzEwMTI5MTFlZTFjNDM4Y2ZlNTMwZmZjIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvc2hlbGwvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3NoZWxsL0NNYWtlTGlzdHMudHh0CkBAIC04LDYgKzgsMTAgQEAgc2V0KEpT Q19MSUJSQVJJRVMKICAgICBXVEYKICkKIAoraWYgKFdURl9PU19NQUNfT1NfWCkKKyAgICBsaXN0 KEFQUEVORCBKU0NfTElCUkFSSUVTIGVkaXQpCitlbmRpZiAoKQorCiBpZiAoIiR7SmF2YVNjcmlw dENvcmVfTElCUkFSWV9UWVBFfSIgTUFUQ0hFUyAiU1RBVElDIikKICAgICBhZGRfZGVmaW5pdGlv bnMoLURTVEFUSUNBTExZX0xJTktFRF9XSVRIX0phdmFTY3JpcHRDb3JlKQogZW5kaWYgKCkK