127036 2014-01-15 02:05:21 -0800 [EFL][WK2] Implement TestController::setHidden 2014-01-16 06:09:56 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mpakulavelrutka webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 968231 0 mpakulavelrutka 2014-01-15 02:05:21 -0800 After r161105 four fast/events/page-visibility* tests started to fail. To fix them we need to implement TestController::setHidden. 968244 1 221251 mpakulavelrutka 2014-01-15 02:37:07 -0800 Created attachment 221251 proposed patch 968533 2 ryuan.choi 2014-01-15 17:05:11 -0800 Looks good to me. 968574 3 221251 gyuyoung.kim 2014-01-15 20:05:50 -0800 Comment on attachment 221251 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review > Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110 > + if (!view) Is there any possibility that platformView() is null ? Looks unneeded check. 968575 4 221251 gyuyoung.kim 2014-01-15 20:18:57 -0800 Comment on attachment 221251 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review >> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110 >> + if (!view) > > Is there any possibility that platformView() is null ? Looks unneeded check. I find a possibility platformView() can return null. It would be good if you print a log when view is null. 968715 5 221369 mpakulavelrutka 2014-01-16 05:34:32 -0800 Created attachment 221369 added error log 968721 6 221369 commit-queue 2014-01-16 06:09:52 -0800 Comment on attachment 221369 added error log Clearing flags on attachment: 221369 Committed r162123: <http://trac.webkit.org/changeset/162123> 968722 7 commit-queue 2014-01-16 06:09:56 -0800 All reviewed patches have been landed. Closing bug. 221251 2014-01-15 02:37:07 -0800 2014-01-16 05:34:32 -0800 proposed patch set-hidden.diff text/plain 1620 mpakulavelrutka ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMWFj OTlhLi5jNjlmNTU1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDEtMTUgIE1pY2hhxYIgUGFrdcWCYSB2ZWwg UnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxl bWVudCBUZXN0Q29udHJvbGxlcjo6c2V0SGlkZGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcwMzYKKworICAgICAgICBXZWJLaXRUZXN0UnVubmVy IG5lZWRzIFRlc3RDb250cm9sbGVyOjpzZXRIaWRkZW4gaW1wbGVtZW50YXRpb24gdG8KKyAgICAg ICAgcHJvcGVybHkgaGFuZGxlIHBhZ2UgdmlzaWJpbGl0eSBBUEkgbGF5b3V0IHRlc3RzIGFmdGVy IHIxNjExMDUuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9UZXN0Q29udHJvbGxl ckVmbC5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpzZXRIaWRkZW4pOgorCiAy MDE0LTAxLTE1ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAog ICAgICAgICBbRUZMXSBDaGFuZ2UgdGVzdCBmb250IGluc3RhbGxlZCBwYXRoIHRvIHdlYmtpdGd0 ay1mb250LXRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9UZXN0 Q29udHJvbGxlckVmbC5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9UZXN0Q29udHJv bGxlckVmbC5jcHAKaW5kZXggNzUwYmMyMS4uYmNmMWVmMyAxMDA2NDQKLS0tIGEvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9lZmwvVGVzdENvbnRyb2xsZXJFZmwuY3BwCisrKyBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNwcApAQCAtMjAsNyArMjAsOSBAQAog I2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRlc3RDb250cm9sbGVyLmgiCiAKKyNpbmNs dWRlICJQbGF0Zm9ybVdlYlZpZXcuaCIKICNpbmNsdWRlIDxFY29yZS5oPgorI2luY2x1ZGUgPEV2 YXMuaD4KICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGxpYi5oPgogI2luY2x1ZGUg PHVuaXN0ZC5oPgpAQCAtMTAxLDkgKzEwMywxNyBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0 Zm9ybUluaXRpYWxpemVDb250ZXh0KCkKIHsKIH0KIAotdm9pZCBUZXN0Q29udHJvbGxlcjo6c2V0 SGlkZGVuKGJvb2wpCit2b2lkIFRlc3RDb250cm9sbGVyOjpzZXRIaWRkZW4oYm9vbCBoaWRkZW4p CiB7Ci0gICAgLy8gRklYTUU6IE5lZWQgdG8gaW1wbGVtZW50IHRoaXMgdG8gdGVzdCB2aXNpYmls aXR5U3RhdGUuCisgICAgUGxhdGZvcm1XS1ZpZXcgdmlldyA9IG1haW5XZWJWaWV3KCktPnBsYXRm b3JtVmlldygpOworCisgICAgaWYgKCF2aWV3KQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAo aGlkZGVuKQorICAgICAgICBldmFzX29iamVjdF9oaWRlKHZpZXcpOworICAgIGVsc2UKKyAgICAg ICAgZXZhc19vYmplY3Rfc2hvdyh2aWV3KTsKIH0KIAogdm9pZCBUZXN0Q29udHJvbGxlcjo6cnVu TW9kYWwoUGxhdGZvcm1XZWJWaWV3KikK 221369 2014-01-16 05:34:32 -0800 2014-01-16 06:09:52 -0800 added error log set-hidden2.diff text/plain 1753 mpakulavelrutka ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NDg4 Zjg1Li45ZjAyYzlhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDEtMTYgIE1pY2hhxYIgUGFrdcWCYSB2ZWwg UnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxl bWVudCBUZXN0Q29udHJvbGxlcjo6c2V0SGlkZGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcwMzYKKworICAgICAgICBSZXZpZXdlZCBieSBHeXV5 b3VuZyBLaW0uCisKKyAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyBUZXN0Q29udHJvbGxl cjo6c2V0SGlkZGVuIGltcGxlbWVudGF0aW9uIHRvCisgICAgICAgIHByb3Blcmx5IGhhbmRsZSBw YWdlIHZpc2liaWxpdHkgQVBJIGxheW91dCB0ZXN0cyBhZnRlciByMTYxMTA1LgorCisgICAgICAg ICogV2ViS2l0VGVzdFJ1bm5lci9lZmwvVGVzdENvbnRyb2xsZXJFZmwuY3BwOgorICAgICAgICAo V1RSOjpUZXN0Q29udHJvbGxlcjo6c2V0SGlkZGVuKToKKwogMjAxNC0wMS0xNiAgWmFuIERvYmVy c2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bTWluaUJyb3dzZXJd IFRoZSBwcm9ncmVzcyBlbnRyeSByZXNldCBjYWxsYmFjayBjYW4gYmUgZmlyZWQgYWZ0ZXIgdGhl IEJyb3dzZXJXaW5kb3cgaXMgZGVzdHJveWVkCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHAKaW5kZXggNzUwYmMyMS4uZGY4ZGNkOSAxMDA2NDQK LS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvVGVzdENvbnRyb2xsZXJFZmwuY3BwCisr KyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNwcApAQCAt MjAsNyArMjAsOSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRlc3RDb250cm9s bGVyLmgiCiAKKyNpbmNsdWRlICJQbGF0Zm9ybVdlYlZpZXcuaCIKICNpbmNsdWRlIDxFY29yZS5o PgorI2luY2x1ZGUgPEV2YXMuaD4KICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGxp Yi5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgpAQCAtMTAxLDkgKzEwMywxOSBAQCB2b2lkIFRlc3RD b250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCkKIHsKIH0KIAotdm9pZCBUZXN0 Q29udHJvbGxlcjo6c2V0SGlkZGVuKGJvb2wpCit2b2lkIFRlc3RDb250cm9sbGVyOjpzZXRIaWRk ZW4oYm9vbCBoaWRkZW4pCiB7Ci0gICAgLy8gRklYTUU6IE5lZWQgdG8gaW1wbGVtZW50IHRoaXMg dG8gdGVzdCB2aXNpYmlsaXR5U3RhdGUuCisgICAgUGxhdGZvcm1XS1ZpZXcgdmlldyA9IG1haW5X ZWJWaWV3KCktPnBsYXRmb3JtVmlldygpOworCisgICAgaWYgKCF2aWV3KSB7CisgICAgICAgIGZw cmludGYoc3RkZXJyLCAiRVJST1I6IHZpZXcgaXMgbnVsbC5cbiIpOworICAgICAgICByZXR1cm47 CisgICAgfQorCisgICAgaWYgKGhpZGRlbikKKyAgICAgICAgZXZhc19vYmplY3RfaGlkZSh2aWV3 KTsKKyAgICBlbHNlCisgICAgICAgIGV2YXNfb2JqZWN0X3Nob3codmlldyk7CiB9CiAKIHZvaWQg VGVzdENvbnRyb2xsZXI6OnJ1bk1vZGFsKFBsYXRmb3JtV2ViVmlldyopCg==