127028 2014-01-14 18:38:13 -0800 [iOS] Crash in NavigatorBase::vendor loading apple.com 2014-01-14 20:22:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue dbates ddkilzer simon.fraser oldest_to_newest 968139 0 joepeck 2014-01-14 18:38:13 -0800 iOS crash loading apple.com. -- NavigatorBase.cpp String NavigatorBase::vendor() const { return WEBCORE_NAVIGATOR_VENDOR; } -- config.h #if PLATFORM(IOS) #define WEBCORE_NAVIGATOR_PLATFORM wkGetPlatformNameForNavigator(); #define WEBCORE_NAVIGATOR_VENDOR wkGetVendorNameForNavigator(); #endif -- Looks like we're missing calls to fill in these WKSI functions. 968141 1 221224 joepeck 2014-01-14 18:41:40 -0800 Created attachment 221224 [PATCH] Proposed Fix 968154 2 221224 commit-queue 2014-01-14 20:22:08 -0800 Comment on attachment 221224 [PATCH] Proposed Fix Clearing flags on attachment: 221224 Committed r162043: <http://trac.webkit.org/changeset/162043> 968155 3 commit-queue 2014-01-14 20:22:10 -0800 All reviewed patches have been landed. Closing bug. 221224 2014-01-14 18:41:40 -0800 2014-01-14 20:22:08 -0800 [PATCH] Proposed Fix ios.patch text/plain 2447 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZDNhODc0Li45ZGIyNGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDEtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbaU9TXSBDcmFzaCBpbiBOYXZpZ2F0b3JCYXNlOjp2ZW5kb3IgbG9hZGluZyBhcHBs ZS5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NzAyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4 cG9ydCBmdW5jdGlvbiBwb2ludGVycyB0byBiZSBmaWxsZWQgaW4gd2l0aCBXZWJLaXRTeXN0ZW1J bnRlcmZhY2UgZnVuY3Rpb25zLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisKIDIwMTQt MDEtMTQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg QXZvaWQgUExBVEZPUk0oKSBtYWNyb3MgaW4gZXhwb3J0ZWQgaGVhZGVycy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5l eHAuaW4KaW5kZXggOThkYmQwNy4uMDkwMDZmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv V2ViQ29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KQEAgLTI1 MjQsNyArMjUyNCwxMCBAQCBfX1pOSzdXZWJDb3JlOVJlbmRlckJveDExYm9yZGVyUmFkaWlFdgog X3dlYlRocmVhZFNob3VsZFlpZWxkCiBfd2tFeGVjdXRhYmxlV2FzTGlua2VkT25PckFmdGVySU9T VmVyc2lvbgogX3drR2V0RGV2aWNlQ2xhc3MKK193a0dldFBsYXRmb3JtTmFtZUZvck5hdmlnYXRv cgogX3drR2V0U2NyZWVuU2NhbGVGYWN0b3IKK193a0dldFVzZXJBZ2VudAorX3drR2V0VmVuZG9y TmFtZUZvck5hdmlnYXRvcgogX3drR2V0VmVydGljYWxHbHlwaHNGb3JDaGFyYWN0ZXJzCiBfd2tH ZXRWaWV3cG9ydFNjcmVlblNpemUKIF93a0lzR0IxODAzMENvbXBsaWFuY2VSZXF1aXJlZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9tYWMv Q2hhbmdlTG9nCmluZGV4IDhmNjRlMWUuLjNjY2NlMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMS0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFtpT1NdIENyYXNoIGluIE5hdmlnYXRvckJhc2U6OnZlbmRvciBsb2Fk aW5nIGFwcGxlLmNvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI3MDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlsbCBpbiBpT1MgV2ViS2l0U3lzdGVtSW50ZXJmYWNlIGZ1bmN0aW9ucy4KKworICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYlN5c3RlbUludGVyZmFjZS5tbToKKyAgICAgICAgKElu aXRXZWJDb3JlU3lzdGVtSW50ZXJmYWNlKToKKwogMjAxNC0wMS0xNCAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICAjZGVmaW5lIEVOQUJMRV9EQVNIQk9B UkRfU1VQUE9SVCBmb3IgaU9TLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29y ZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNlLm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29y ZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNlLm1tCmluZGV4IGEyNmU1NzYuLjUzMGRhYjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlN5c3RlbUludGVy ZmFjZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJTeXN0ZW1J bnRlcmZhY2UubW0KQEAgLTIzNSw2ICsyMzUsMTIgQEAgdm9pZCBJbml0V2ViQ29yZVN5c3RlbUlu dGVyZmFjZSh2b2lkKQogCiAgICAgSU5JVChDRlVSTFJlcXVlc3RBbGxvd0FsbFBvc3RDYWNoaW5n KTsKIAorI2lmIFBMQVRGT1JNKElPUykKKyAgICBJTklUKEdldFVzZXJBZ2VudCk7CisgICAgSU5J VChHZXRQbGF0Zm9ybU5hbWVGb3JOYXZpZ2F0b3IpOworICAgIElOSVQoR2V0VmVuZG9yTmFtZUZv ck5hdmlnYXRvcik7CisjZW5kaWYKKwogI2lmICFQTEFURk9STShJT1MpICYmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA4MAogICAgIElOSVQoTlNFbGFzdGljRGVsdGFGb3JU aW1lRGVsdGEpOwogICAgIElOSVQoTlNFbGFzdGljRGVsdGFGb3JSZWJvdW5kRGVsdGEpOwo=