127005 2014-01-14 13:29:03 -0800 Pack ResourceResponse harder. 2014-01-14 22:47:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kling oldest_to_newest 968005 0 kling 2014-01-14 13:29:03 -0800 Pack ResourceResponse harder. 968008 1 221196 kling 2014-01-14 13:30:03 -0800 Created attachment 221196 Patch 968010 2 221196 andersca 2014-01-14 13:31:24 -0800 Comment on attachment 221196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221196&action=review > Source/WebCore/platform/network/ResourceResponseBase.cpp:53 > + , m_cacheControlMaxAge(0.0) > + , m_age(0.0) > + , m_date(0.0) > + , m_expires(0.0) > + , m_lastModified(0.0) I'd change all these to say 0. > Source/WebCore/platform/network/ResourceResponseBase.cpp:80 > + , m_cacheControlMaxAge(0.0) > + , m_age(0.0) > + , m_date(0.0) > + , m_expires(0.0) > + , m_lastModified(0.0) Ditto. 968183 3 kling 2014-01-14 22:47:37 -0800 Committed r162052: <http://trac.webkit.org/changeset/162052> 221196 2014-01-14 13:30:03 -0800 2014-01-14 13:31:24 -0800 Patch bug-127005.diff text/plain 6075 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMTRkMGJiLi45MmQ1ZjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTQtMDEtMTQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFBhY2sgUmVzb3VyY2VSZXNwb25zZSBoYXJkZXIuCisgICAgICAgIDxodHRwczovL3dlYmtp dC5vcmcvYi8xMjcwMDU+CisKKyAgICAgICAgUmUtYXJyYW5nZSB0aGUgbWVtYmVycyBvZiBSZXNv dXJjZVJlc3BvbnNlIHRvIHJlZHVjZSBwYWRkaW5nLAorICAgICAgICBzaHJpbmtpbmcgaXQgYnkg OCBieXRlcy4KKworICAgICAgICBUaGlzIG51ZGdlcyBDYWNoZWRSZXNvdXJjZSBhbmQgQ2FjaGVk SW1hZ2UgaW50byBzbWFsbGVyIHNpemUKKyAgICAgICAgY2xhc3NlcywgeWllbGRpbmcgYSB+NzAw IGtCIHByb2dyZXNzaW9uIG9uIE1lbWJ1c3RlcjMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9u c2VCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2VCYXNlOjpSZXNv dXJjZVJlc3BvbnNlQmFzZSk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJl c3BvbnNlQmFzZS5oOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXNw b25zZS5oOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZTo6UmVzb3VyY2VSZXNw b25zZSk6CisKKzIwMTQtMDEtMTQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgor CiAgICAgICAgIFBhY2sgUmVzb3VyY2VSZXF1ZXN0IGhhcmRlci4KICAgICAgICAgPGh0dHBzOi8v d2Via2l0Lm9yZy9iLzEyNjk4Mj4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcAppbmRleCA4MTdhYThmLi4wMWIw ZGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNl UmVzcG9uc2VCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jl c291cmNlUmVzcG9uc2VCYXNlLmNwcApAQCAtNDUsOCArNDUsMTMgQEAgaW5saW5lIGNvbnN0IFJl c291cmNlUmVzcG9uc2UmIFJlc291cmNlUmVzcG9uc2VCYXNlOjphc1Jlc291cmNlUmVzcG9uc2Uo KSBjb25zdAogUmVzb3VyY2VSZXNwb25zZUJhc2U6OlJlc291cmNlUmVzcG9uc2VCYXNlKCkgIAog ICAgIDogbV9leHBlY3RlZENvbnRlbnRMZW5ndGgoMCkKICAgICAsIG1faHR0cFN0YXR1c0NvZGUo MCkKLSAgICAsIG1fd2FzQ2FjaGVkKGZhbHNlKQogICAgICwgbV9jb25uZWN0aW9uSUQoMCkKKyAg ICAsIG1fY2FjaGVDb250cm9sTWF4QWdlKDAuMCkKKyAgICAsIG1fYWdlKDAuMCkKKyAgICAsIG1f ZGF0ZSgwLjApCisgICAgLCBtX2V4cGlyZXMoMC4wKQorICAgICwgbV9sYXN0TW9kaWZpZWQoMC4w KQorICAgICwgbV93YXNDYWNoZWQoZmFsc2UpCiAgICAgLCBtX2Nvbm5lY3Rpb25SZXVzZWQoZmFs c2UpCiAgICAgLCBtX2lzTnVsbCh0cnVlKQogICAgICwgbV9oYXZlUGFyc2VkQ2FjaGVDb250cm9s SGVhZGVyKGZhbHNlKQpAQCAtNTcsMTEgKzYyLDYgQEAgUmVzb3VyY2VSZXNwb25zZUJhc2U6OlJl c291cmNlUmVzcG9uc2VCYXNlKCkKICAgICAsIG1fY2FjaGVDb250cm9sQ29udGFpbnNOb0NhY2hl KGZhbHNlKQogICAgICwgbV9jYWNoZUNvbnRyb2xDb250YWluc05vU3RvcmUoZmFsc2UpCiAgICAg LCBtX2NhY2hlQ29udHJvbENvbnRhaW5zTXVzdFJldmFsaWRhdGUoZmFsc2UpCi0gICAgLCBtX2Nh Y2hlQ29udHJvbE1heEFnZSgwLjApCi0gICAgLCBtX2FnZSgwLjApCi0gICAgLCBtX2RhdGUoMC4w KQotICAgICwgbV9leHBpcmVzKDAuMCkKLSAgICAsIG1fbGFzdE1vZGlmaWVkKDAuMCkKIHsKIH0K IApAQCAtNzIsOCArNzIsMTMgQEAgUmVzb3VyY2VSZXNwb25zZUJhc2U6OlJlc291cmNlUmVzcG9u c2VCYXNlKGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmIG1pbWVUeXAKICAgICAsIG1fdGV4 dEVuY29kaW5nTmFtZSh0ZXh0RW5jb2RpbmdOYW1lKQogICAgICwgbV9zdWdnZXN0ZWRGaWxlbmFt ZShmaWxlbmFtZSkKICAgICAsIG1faHR0cFN0YXR1c0NvZGUoMCkKLSAgICAsIG1fd2FzQ2FjaGVk KGZhbHNlKQogICAgICwgbV9jb25uZWN0aW9uSUQoMCkKKyAgICAsIG1fY2FjaGVDb250cm9sTWF4 QWdlKDAuMCkKKyAgICAsIG1fYWdlKDAuMCkKKyAgICAsIG1fZGF0ZSgwLjApCisgICAgLCBtX2V4 cGlyZXMoMC4wKQorICAgICwgbV9sYXN0TW9kaWZpZWQoMC4wKQorICAgICwgbV93YXNDYWNoZWQo ZmFsc2UpCiAgICAgLCBtX2Nvbm5lY3Rpb25SZXVzZWQoZmFsc2UpCiAgICAgLCBtX2lzTnVsbChm YWxzZSkKICAgICAsIG1faGF2ZVBhcnNlZENhY2hlQ29udHJvbEhlYWRlcihmYWxzZSkKQEAgLTg0 LDExICs4OSw2IEBAIFJlc291cmNlUmVzcG9uc2VCYXNlOjpSZXNvdXJjZVJlc3BvbnNlQmFzZShj b25zdCBVUkwmIHVybCwgY29uc3QgU3RyaW5nJiBtaW1lVHlwCiAgICAgLCBtX2NhY2hlQ29udHJv bENvbnRhaW5zTm9DYWNoZShmYWxzZSkKICAgICAsIG1fY2FjaGVDb250cm9sQ29udGFpbnNOb1N0 b3JlKGZhbHNlKQogICAgICwgbV9jYWNoZUNvbnRyb2xDb250YWluc011c3RSZXZhbGlkYXRlKGZh bHNlKQotICAgICwgbV9jYWNoZUNvbnRyb2xNYXhBZ2UoMC4wKQotICAgICwgbV9hZ2UoMC4wKQot ICAgICwgbV9kYXRlKDAuMCkKLSAgICAsIG1fZXhwaXJlcygwLjApCi0gICAgLCBtX2xhc3RNb2Rp ZmllZCgwLjApCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaAppbmRleCAyY2ZiNTNhLi45ZDgzOGFjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VC YXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3Bv bnNlQmFzZS5oCkBAIC0xNDUsMTMgKzE0NSwyMyBAQCBwcm90ZWN0ZWQ6CiAgICAgbG9uZyBsb25n IG1fZXhwZWN0ZWRDb250ZW50TGVuZ3RoOwogICAgIFN0cmluZyBtX3RleHRFbmNvZGluZ05hbWU7 CiAgICAgU3RyaW5nIG1fc3VnZ2VzdGVkRmlsZW5hbWU7Ci0gICAgaW50IG1faHR0cFN0YXR1c0Nv ZGU7CiAgICAgU3RyaW5nIG1faHR0cFN0YXR1c1RleHQ7CiAgICAgSFRUUEhlYWRlck1hcCBtX2h0 dHBIZWFkZXJGaWVsZHM7Ci0gICAgYm9vbCBtX3dhc0NhY2hlZCA6IDE7CisgICAgUmVmUHRyPFJl c291cmNlTG9hZFRpbWluZz4gbV9yZXNvdXJjZUxvYWRUaW1pbmc7CisKKyAgICBpbnQgbV9odHRw U3RhdHVzQ29kZTsKICAgICB1bnNpZ25lZCBtX2Nvbm5lY3Rpb25JRDsKKworcHJpdmF0ZToKKyAg ICBtdXRhYmxlIGRvdWJsZSBtX2NhY2hlQ29udHJvbE1heEFnZTsKKyAgICBtdXRhYmxlIGRvdWJs ZSBtX2FnZTsKKyAgICBtdXRhYmxlIGRvdWJsZSBtX2RhdGU7CisgICAgbXV0YWJsZSBkb3VibGUg bV9leHBpcmVzOworICAgIG11dGFibGUgZG91YmxlIG1fbGFzdE1vZGlmaWVkOworCitwdWJsaWM6 CisgICAgYm9vbCBtX3dhc0NhY2hlZCA6IDE7CiAgICAgYm9vbCBtX2Nvbm5lY3Rpb25SZXVzZWQg OiAxOwotICAgIFJlZlB0cjxSZXNvdXJjZUxvYWRUaW1pbmc+IG1fcmVzb3VyY2VMb2FkVGltaW5n OwogCiAgICAgYm9vbCBtX2lzTnVsbCA6IDE7CiAgICAgCkBAIC0xNjksMTIgKzE3OSw2IEBAIHBy aXZhdGU6CiAgICAgbXV0YWJsZSBib29sIG1fY2FjaGVDb250cm9sQ29udGFpbnNOb0NhY2hlIDog MTsKICAgICBtdXRhYmxlIGJvb2wgbV9jYWNoZUNvbnRyb2xDb250YWluc05vU3RvcmUgOiAxOwog ICAgIG11dGFibGUgYm9vbCBtX2NhY2hlQ29udHJvbENvbnRhaW5zTXVzdFJldmFsaWRhdGUgOiAx OwotICAgIG11dGFibGUgZG91YmxlIG1fY2FjaGVDb250cm9sTWF4QWdlOwotCi0gICAgbXV0YWJs ZSBkb3VibGUgbV9hZ2U7Ci0gICAgbXV0YWJsZSBkb3VibGUgbV9kYXRlOwotICAgIG11dGFibGUg ZG91YmxlIG1fZXhwaXJlczsKLSAgICBtdXRhYmxlIGRvdWJsZSBtX2xhc3RNb2RpZmllZDsKIH07 CiAKIGlubGluZSBib29sIG9wZXJhdG9yPT0oY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgYSwgY29u c3QgUmVzb3VyY2VSZXNwb25zZSYgYikgeyByZXR1cm4gUmVzb3VyY2VSZXNwb25zZUJhc2U6OmNv bXBhcmUoYSwgYik7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VSZXNwb25zZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jZi9SZXNvdXJjZVJlc3BvbnNlLmgKaW5kZXggMTNhNTgxMS4uYmY3ZDMyOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNl LmgKQEAgLTQ3LDkgKzQ3LDkgQEAgcHVibGljOgogCiAjaWYgVVNFKENGTkVUV09SSykKICAgICBS ZXNvdXJjZVJlc3BvbnNlKENGVVJMUmVzcG9uc2VSZWYgY2ZSZXNwb25zZSkKLSAgICAgICAgOiBt X2NmUmVzcG9uc2UoY2ZSZXNwb25zZSkKLSAgICAgICAgLCBtX2luaXRMZXZlbChVbmluaXRpYWxp emVkKQorICAgICAgICA6IG1faW5pdExldmVsKFVuaW5pdGlhbGl6ZWQpCiAgICAgICAgICwgbV9w bGF0Zm9ybVJlc3BvbnNlSXNVcFRvRGF0ZSh0cnVlKQorICAgICAgICAsIG1fY2ZSZXNwb25zZShj ZlJlc3BvbnNlKQogICAgIHsKICAgICAgICAgbV9pc051bGwgPSAhY2ZSZXNwb25zZTsKICAgICB9 CkBAIC01OCw5ICs1OCw5IEBAIHB1YmxpYzoKICNlbmRpZgogI2Vsc2UKICAgICBSZXNvdXJjZVJl c3BvbnNlKE5TVVJMUmVzcG9uc2UgKm5zUmVzcG9uc2UpCi0gICAgICAgIDogbV9uc1Jlc3BvbnNl KG5zUmVzcG9uc2UpCi0gICAgICAgICwgbV9pbml0TGV2ZWwoVW5pbml0aWFsaXplZCkKKyAgICAg ICAgOiBtX2luaXRMZXZlbChVbmluaXRpYWxpemVkKQogICAgICAgICAsIG1fcGxhdGZvcm1SZXNw b25zZUlzVXBUb0RhdGUodHJ1ZSkKKyAgICAgICAgLCBtX25zUmVzcG9uc2UobnNSZXNwb25zZSkK ICAgICB7CiAgICAgICAgIG1faXNOdWxsID0gIW5zUmVzcG9uc2U7CiAgICAgfQpAQCAtMTExLDYg KzExMSw5IEBAIHByaXZhdGU6CiAKICAgICBzdGF0aWMgYm9vbCBwbGF0Zm9ybUNvbXBhcmUoY29u c3QgUmVzb3VyY2VSZXNwb25zZSYgYSwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgYik7CiAKKyAg ICBJbml0TGV2ZWwgbV9pbml0TGV2ZWwgOiAzOworICAgIGJvb2wgbV9wbGF0Zm9ybVJlc3BvbnNl SXNVcFRvRGF0ZSA6IDE7CisKICNpZiBVU0UoQ0ZORVRXT1JLKQogICAgIG11dGFibGUgUmV0YWlu UHRyPENGVVJMUmVzcG9uc2VSZWY+IG1fY2ZSZXNwb25zZTsKICNlbmRpZgpAQCAtMTIxLDggKzEy NCw2IEBAIHByaXZhdGU6CiAgICAgLy8gQ2VydGlmaWNhdGUgY2hhaW4gaXMgbm9ybWFsbHkgcGFy dCBvZiBOUy9DRlVSTFJlc3BvbnNlLCBidXQgdGhlcmUgaXMgbm8gd2F5IHRvIHJlLWFkZCBpdCB0 byBhIGRlc2VyaWFsaXplZCByZXNwb25zZSBhZnRlciBJUEMuCiAgICAgUmV0YWluUHRyPENGQXJy YXlSZWY+IG1fZXh0ZXJuYWxDZXJ0aWZpY2F0ZUNoYWluOwogI2VuZGlmCi0gICAgSW5pdExldmVs IG1faW5pdExldmVsOwotICAgIGJvb2wgbV9wbGF0Zm9ybVJlc3BvbnNlSXNVcFRvRGF0ZTsKIH07 CiAKIHN0cnVjdCBDcm9zc1RocmVhZFJlc291cmNlUmVzcG9uc2VEYXRhIDogcHVibGljIENyb3Nz VGhyZWFkUmVzb3VyY2VSZXNwb25zZURhdGFCYXNlIHsK