127003 2014-01-14 13:26:27 -0800 MediaSessionManager shouldn't use std::map 2014-01-15 19:36:22 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble sam oldest_to_newest 968003 0 eric.carlson 2014-01-14 13:26:27 -0800 Just don't do it! 968007 1 221195 eric.carlson 2014-01-14 13:30:01 -0800 Created attachment 221195 Proposed patch 968123 2 221195 sam 2014-01-14 18:01:08 -0800 Comment on attachment 221195 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221195&action=review > Source/WebCore/platform/audio/MediaSessionManager.h:71 > + typedef HashMap<MediaSession::MediaType, SessionRestrictions, WTF::IntHash<unsigned>, WTF::HashTraits<unsigned>> RestrictionsMap; I think you can actually do much better than a HashMap. How about something like an array of SessionRestrictions of size == LagestValueOfMediaType + 1: SessionRestrictions[WebAudio + 1]; But, if you use the HashMap, you need to use traits that allow for a 0 value key (e.g. UnsignedWithZeroKeyHashTraits). 968538 3 221320 eric.carlson 2014-01-15 17:21:00 -0800 Created attachment 221320 Another patch. 968559 4 221320 sam 2014-01-15 18:51:57 -0800 Comment on attachment 221320 Another patch. Nice. 968561 5 eric.carlson 2014-01-15 19:09:51 -0800 (In reply to comment #4) > (From update of attachment 221320 [details]) > Nice. Thanks for the suggestion, my first and second versions were definitely over engineered :-) 968563 6 221320 commit-queue 2014-01-15 19:36:19 -0800 Comment on attachment 221320 Another patch. Clearing flags on attachment: 221320 Committed r162108: <http://trac.webkit.org/changeset/162108> 968564 7 commit-queue 2014-01-15 19:36:22 -0800 All reviewed patches have been landed. Closing bug. 221195 2014-01-14 13:30:01 -0800 2014-01-15 17:21:00 -0800 Proposed patch std_map_bad_patch.txt text/plain 4318 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTk5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAxLTE0ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhU2Vzc2lvbk1h bmFnZXIgc2hvdWxkbid0IHVzZSBzdGQ6Om1hcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MDAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBmdW5jdGlvbmFsIGNoYW5nZS4K KworICAgICAgICBVc2UgSGFzaE1hcCBpbnN0ZWFkIG9mIHN0ZDo6bWFwLgorICAgICAgICAqIHBs YXRmb3JtL2F1ZGlvL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFTZXNzaW9uTWFuYWdlcjo6TWVkaWFTZXNzaW9uTWFuYWdlcik6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyOjphZGRSZXN0cmljdGlvbik6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyOjpyZW1vdmVSZXN0cmljdGlvbik6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyOjpyZXN0cmljdGlvbnMpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlcjo6c2Vzc2lvbldpbGxCZWdpblBsYXliYWNrKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmg6CisKIDIwMTQtMDEt MTQgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIERp cmVjdGx5IGFsbG9jYXRlIE5TTXV0YWJsZURpY3Rpb25hcnkgaW4gUUxQcmV2aWV3Q29udmVydGVy RGljdGlvbmFyeSgpIGFuZCBRTENvbnRlbnREaWN0aW9uYXJ5KCkKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2F1ZGlvL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCShy ZXZpc2lvbiAxNjE5NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNl c3Npb25NYW5hZ2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsOSArNDEsOSBAQCBNZWRpYVNl c3Npb25NYW5hZ2VyJiBNZWRpYVNlc3Npb25NYW5hZ2VyCiBNZWRpYVNlc3Npb25NYW5hZ2VyOjpN ZWRpYVNlc3Npb25NYW5hZ2VyKCkKICAgICA6IG1faW50ZXJydXB0aW9ucygwKQogewotICAgIG1f cmVzdHJpY3Rpb25zW01lZGlhU2Vzc2lvbjo6VmlkZW9dID0gTm9SZXN0cmljdGlvbnM7Ci0gICAg bV9yZXN0cmljdGlvbnNbTWVkaWFTZXNzaW9uOjpBdWRpb10gPSBOb1Jlc3RyaWN0aW9uczsKLSAg ICBtX3Jlc3RyaWN0aW9uc1tNZWRpYVNlc3Npb246OldlYkF1ZGlvXSA9IE5vUmVzdHJpY3Rpb25z OworICAgIG1fcmVzdHJpY3Rpb25zLmFkZChNZWRpYVNlc3Npb246OlZpZGVvLCBOb1Jlc3RyaWN0 aW9ucyk7CisgICAgbV9yZXN0cmljdGlvbnMuYWRkKE1lZGlhU2Vzc2lvbjo6QXVkaW8sIE5vUmVz dHJpY3Rpb25zKTsKKyAgICBtX3Jlc3RyaWN0aW9ucy5hZGQoTWVkaWFTZXNzaW9uOjpXZWJBdWRp bywgTm9SZXN0cmljdGlvbnMpOwogfQogCiBib29sIE1lZGlhU2Vzc2lvbk1hbmFnZXI6OmhhcyhN ZWRpYVNlc3Npb246Ok1lZGlhVHlwZSB0eXBlKSBjb25zdApAQCAtMTExLDI0ICsxMTEsMzAgQEAg dm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyOjpyZW1vdmVTZXNzaW9uKAogdm9pZCBNZWRpYVNlc3Np b25NYW5hZ2VyOjphZGRSZXN0cmljdGlvbihNZWRpYVNlc3Npb246Ok1lZGlhVHlwZSB0eXBlLCBT ZXNzaW9uUmVzdHJpY3Rpb25zIHJlc3RyaWN0aW9uKQogewogICAgIEFTU0VSVCh0eXBlID4gTWVk aWFTZXNzaW9uOjpOb25lICYmIHR5cGUgPD0gTWVkaWFTZXNzaW9uOjpXZWJBdWRpbyk7Ci0gICAg bV9yZXN0cmljdGlvbnNbdHlwZV0gPSBtX3Jlc3RyaWN0aW9uc1t0eXBlXSB8IHJlc3RyaWN0aW9u OworCisgICAgU2Vzc2lvblJlc3RyaWN0aW9ucyBjdXJyZW50UmVzdHJpY3Rpb25zID0gbV9yZXN0 cmljdGlvbnMuZ2V0KHR5cGUpOworICAgIG1fcmVzdHJpY3Rpb25zLnNldCh0eXBlLCBjdXJyZW50 UmVzdHJpY3Rpb25zIHwgcmVzdHJpY3Rpb24pOwogfQogCiB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFn ZXI6OnJlbW92ZVJlc3RyaWN0aW9uKE1lZGlhU2Vzc2lvbjo6TWVkaWFUeXBlIHR5cGUsIFNlc3Np b25SZXN0cmljdGlvbnMgcmVzdHJpY3Rpb24pCiB7CiAgICAgQVNTRVJUKHR5cGUgPiBNZWRpYVNl c3Npb246Ok5vbmUgJiYgdHlwZSA8PSBNZWRpYVNlc3Npb246OldlYkF1ZGlvKTsKLSAgICBtX3Jl c3RyaWN0aW9uc1t0eXBlXSA9IG1fcmVzdHJpY3Rpb25zW3R5cGVdICYgfnJlc3RyaWN0aW9uOwor CisgICAgU2Vzc2lvblJlc3RyaWN0aW9ucyBjdXJyZW50UmVzdHJpY3Rpb25zID0gbV9yZXN0cmlj dGlvbnMuZ2V0KHR5cGUpOworICAgIG1fcmVzdHJpY3Rpb25zLnNldCh0eXBlLCBjdXJyZW50UmVz dHJpY3Rpb25zICYgfnJlc3RyaWN0aW9uKTsKIH0KIAotTWVkaWFTZXNzaW9uTWFuYWdlcjo6U2Vz c2lvblJlc3RyaWN0aW9ucyBNZWRpYVNlc3Npb25NYW5hZ2VyOjpyZXN0cmljdGlvbnMoTWVkaWFT ZXNzaW9uOjpNZWRpYVR5cGUgc2Vzc2lvblR5cGUpCitNZWRpYVNlc3Npb25NYW5hZ2VyOjpTZXNz aW9uUmVzdHJpY3Rpb25zIE1lZGlhU2Vzc2lvbk1hbmFnZXI6OnJlc3RyaWN0aW9ucyhNZWRpYVNl c3Npb246Ok1lZGlhVHlwZSB0eXBlKQogewotICAgIHJldHVybiBtX3Jlc3RyaWN0aW9uc1tzZXNz aW9uVHlwZV07CisgICAgQVNTRVJUKHR5cGUgPiBNZWRpYVNlc3Npb246Ok5vbmUgJiYgdHlwZSA8 PSBNZWRpYVNlc3Npb246OldlYkF1ZGlvKTsKKyAgICAKKyAgICByZXR1cm4gbV9yZXN0cmljdGlv bnMuZ2V0KHR5cGUpOwogfQogCiB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNlc3Npb25XaWxs QmVnaW5QbGF5YmFjayhNZWRpYVNlc3Npb24mIHNlc3Npb24pCiB7CiAgICAgTWVkaWFTZXNzaW9u OjpNZWRpYVR5cGUgc2Vzc2lvblR5cGUgPSBzZXNzaW9uLm1lZGlhVHlwZSgpOwotICAgIFNlc3Np b25SZXN0cmljdGlvbnMgcmVzdHJpY3Rpb25zID0gbV9yZXN0cmljdGlvbnNbc2Vzc2lvblR5cGVd OworICAgIFNlc3Npb25SZXN0cmljdGlvbnMgcmVzdHJpY3Rpb25zID0gbV9yZXN0cmljdGlvbnMu Z2V0KHNlc3Npb25UeXBlKTsKICAgICBpZiAocmVzdHJpY3Rpb25zID09IE5vUmVzdHJpY3Rpb25z KQogICAgICAgICByZXR1cm47CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L01lZGlhU2Vzc2lvbk1hbmFnZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmgJKHJldmlzaW9uIDE2MTk3NSkKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL01lZGlhU2Vzc2lvbk1hbmFnZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtMjgsNyArMjgsNyBAQAogCiAjaW5jbHVkZSAiTWVkaWFTZXNzaW9uLmgiCiAj aW5jbHVkZSAiU2V0dGluZ3MuaCIKLSNpbmNsdWRlIDxtYXA+CisjaW5jbHVkZSA8d3RmL0hhc2hN YXAuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAg LTY4LDcgKzY4LDggQEAgcHJvdGVjdGVkOgogcHJpdmF0ZToKICAgICB2b2lkIHVwZGF0ZVNlc3Np b25TdGF0ZSgpOwogCi0gICAgc3RkOjptYXA8TWVkaWFTZXNzaW9uOjpNZWRpYVR5cGUsIFNlc3Np b25SZXN0cmljdGlvbnM+IG1fcmVzdHJpY3Rpb25zOworICAgIHR5cGVkZWYgSGFzaE1hcDxNZWRp YVNlc3Npb246Ok1lZGlhVHlwZSwgU2Vzc2lvblJlc3RyaWN0aW9ucywgV1RGOjpJbnRIYXNoPHVu c2lnbmVkPiwgV1RGOjpIYXNoVHJhaXRzPHVuc2lnbmVkPj4gUmVzdHJpY3Rpb25zTWFwOworICAg IFJlc3RyaWN0aW9uc01hcCBtX3Jlc3RyaWN0aW9uczsKIAogICAgIFZlY3RvcjxNZWRpYVNlc3Np b24qPiBtX3Nlc3Npb25zOwogICAgIGludCBtX2ludGVycnVwdGlvbnM7Cg== 221320 2014-01-15 17:21:00 -0800 2014-01-15 19:36:19 -0800 Another patch. std_map_bad_patch_3.txt text/plain 3381 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjA4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAxLTE1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhU2Vzc2lvbk1h bmFnZXIgc2hvdWxkbid0IHVzZSBzdGQ6Om1hcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MDAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBmdW5jdGlvbmFsIGNoYW5nZS4K KworICAgICAgICBVc2UgYW4gYXJyYXkgaW5zdGVhZCBvZiBzdGQ6Om1hcC4KKyAgICAgICAgKiBw bGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhU2Vzc2lvbk1hbmFnZXI6Ok1lZGlhU2Vzc2lvbk1hbmFnZXIpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlcjo6YWRkUmVzdHJpY3Rpb24pOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlcjo6cmVtb3ZlUmVzdHJpY3Rpb24pOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlcjo6cmVzdHJpY3Rpb25zKToKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNlc3Npb25XaWxsQmVnaW5QbGF5YmFjayk6Cisg ICAgICAgICogcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdlci5oOgorCiAyMDE0LTAx LTE1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJH TF0gVmFsaWRhdGlvbiBmdW5jdGlvbiBmb3IgY29tcHJlc3NlZCBmb3JtYXRzIGluY29ycmVjdApJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uLmgJKHJl dmlzaW9uIDE2MTk5OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL01lZGlhU2Vz c2lvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0 dWFsIH5NZWRpYVNlc3Npb24oKTsKIAogICAgIGVudW0gTWVkaWFUeXBlIHsKLSAgICAgICAgTm9u ZSwKKyAgICAgICAgTm9uZSA9IDAsCiAgICAgICAgIFZpZGVvLAogICAgICAgICBBdWRpbywKICAg ICAgICAgV2ViQXVkaW8sCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRp YVNlc3Npb25NYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAkocmV2aXNpb24gMTYxOTk4KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTExMSwxOCArMTExLDE5IEBAIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlcjo6 cmVtb3ZlU2Vzc2lvbigKIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlcjo6YWRkUmVzdHJpY3Rpb24o TWVkaWFTZXNzaW9uOjpNZWRpYVR5cGUgdHlwZSwgU2Vzc2lvblJlc3RyaWN0aW9ucyByZXN0cmlj dGlvbikKIHsKICAgICBBU1NFUlQodHlwZSA+IE1lZGlhU2Vzc2lvbjo6Tm9uZSAmJiB0eXBlIDw9 IE1lZGlhU2Vzc2lvbjo6V2ViQXVkaW8pOwotICAgIG1fcmVzdHJpY3Rpb25zW3R5cGVdID0gbV9y ZXN0cmljdGlvbnNbdHlwZV0gfCByZXN0cmljdGlvbjsKKyAgICBtX3Jlc3RyaWN0aW9uc1t0eXBl XSB8PSByZXN0cmljdGlvbjsKIH0KIAogdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyOjpyZW1vdmVS ZXN0cmljdGlvbihNZWRpYVNlc3Npb246Ok1lZGlhVHlwZSB0eXBlLCBTZXNzaW9uUmVzdHJpY3Rp b25zIHJlc3RyaWN0aW9uKQogewogICAgIEFTU0VSVCh0eXBlID4gTWVkaWFTZXNzaW9uOjpOb25l ICYmIHR5cGUgPD0gTWVkaWFTZXNzaW9uOjpXZWJBdWRpbyk7Ci0gICAgbV9yZXN0cmljdGlvbnNb dHlwZV0gPSBtX3Jlc3RyaWN0aW9uc1t0eXBlXSAmIH5yZXN0cmljdGlvbjsKKyAgICBtX3Jlc3Ry aWN0aW9uc1t0eXBlXSAmPSB+cmVzdHJpY3Rpb247CiB9CiAKLU1lZGlhU2Vzc2lvbk1hbmFnZXI6 OlNlc3Npb25SZXN0cmljdGlvbnMgTWVkaWFTZXNzaW9uTWFuYWdlcjo6cmVzdHJpY3Rpb25zKE1l ZGlhU2Vzc2lvbjo6TWVkaWFUeXBlIHNlc3Npb25UeXBlKQorTWVkaWFTZXNzaW9uTWFuYWdlcjo6 U2Vzc2lvblJlc3RyaWN0aW9ucyBNZWRpYVNlc3Npb25NYW5hZ2VyOjpyZXN0cmljdGlvbnMoTWVk aWFTZXNzaW9uOjpNZWRpYVR5cGUgdHlwZSkKIHsKLSAgICByZXR1cm4gbV9yZXN0cmljdGlvbnNb c2Vzc2lvblR5cGVdOworICAgIEFTU0VSVCh0eXBlID4gTWVkaWFTZXNzaW9uOjpOb25lICYmIHR5 cGUgPD0gTWVkaWFTZXNzaW9uOjpXZWJBdWRpbyk7CisgICAgcmV0dXJuIG1fcmVzdHJpY3Rpb25z W3R5cGVdOwogfQogCiB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNlc3Npb25XaWxsQmVnaW5Q bGF5YmFjayhNZWRpYVNlc3Npb24mIHNlc3Npb24pCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdlci5oCShyZXZpc2lvbiAxNjE5 OTgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2Vy LmgJKHdvcmtpbmcgY29weSkKQEAgLTY4LDcgKzY4LDcgQEAgcHJvdGVjdGVkOgogcHJpdmF0ZToK ICAgICB2b2lkIHVwZGF0ZVNlc3Npb25TdGF0ZSgpOwogCi0gICAgc3RkOjptYXA8TWVkaWFTZXNz aW9uOjpNZWRpYVR5cGUsIFNlc3Npb25SZXN0cmljdGlvbnM+IG1fcmVzdHJpY3Rpb25zOworICAg IFNlc3Npb25SZXN0cmljdGlvbnMgbV9yZXN0cmljdGlvbnNbTWVkaWFTZXNzaW9uOjpXZWJBdWRp byArIDFdOwogCiAgICAgVmVjdG9yPE1lZGlhU2Vzc2lvbio+IG1fc2Vzc2lvbnM7CiAgICAgaW50 IG1faW50ZXJydXB0aW9uczsK