127002 2014-01-14 13:15:09 -0800 [Win] Set MSBUILD environment variable to avoid long-lived processes locking log files 2014-01-14 14:29:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham commit-queue dbates oldest_to_newest 968000 0 bfulgham 2014-01-14 13:15:09 -0800 We have encountered a number of cases where long running MSBUILD processes can hold onto log files, preventing later build requests from completing. According to: http://stackoverflow.com/questions/3919892/msbuild-exe-staying-open-locking-files and: http://stackoverflow.com/questions/13510465/the-mystery-of-stuck-inactive-msbuild-exe-processes-locked-stylecop-dll-nuget ... you can control MSBUILD's launch behavior by passing a flag at startup, or setting an environment variable. Since our build infrastructure does not launch MSBUILD directly, we should just set the environment variable: MSBUILDDISABLENODEREUSE=1 This tells MSBUILD to terminate after the build has completed, avoiding the locked log file. 968001 1 bfulgham 2014-01-14 13:17:43 -0800 See also: http://connect.microsoft.com/VisualStudio/feedback/details/737860/msbuild-and-msbuildtaskhost-processes-proliferate-after-exiting-vs11-beta 968002 2 221194 bfulgham 2014-01-14 13:20:25 -0800 Created attachment 221194 Patch 968024 3 221194 ddkilzer 2014-01-14 13:58:54 -0800 Comment on attachment 221194 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221194&action=review r=me > Tools/Scripts/webkitdirs.pm:1461 > + if (!$ENV{'MSBUILDDISABLENODEREUSE'}) { If it's not set, this may produce a benign (but annoying) error message about using an undefined value. This check may be slightly better: if (!defined $ENV{'MSBUILDDISABLENODEREUSE'} || !$ENV{'MSBUILDDISABLENODEREUSE'}) { 968039 4 bfulgham 2014-01-14 14:29:47 -0800 Committed r162010: <http://trac.webkit.org/changeset/162010> 221194 2014-01-14 13:20:25 -0800 2014-01-14 13:58:54 -0800 Patch bug-127002-20140114132025.patch text/plain 2139 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTk5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE0LTAxLTE0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXSU5dIFNldCBNU0J1aWxkIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIGF2 b2lkIGxvbmctbGl2ZWQgcHJvY2Vzc2VzIGxvY2tpbmcgbG9nIGZpbGVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcwMDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKHNldHVwQXBwbGVXaW5FbnYpOiBFeHBvcnQgTVNCVUlMRERJU0FCTEVOT0RF UkVVU0U9MSB0byB0aGUgZW52aXJvbm1lbnQuCisKIDIwMTQtMDEtMTQgIFphbiBEb2JlcnNlayAg PHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFNraXAgRm9udENvbmZpZyBp bml0aWFsaXphdGlvbiBpbiBXZWJLaXRUZXN0UnVubmVyIGlmIHJlcXVlc3RlZApJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQkocmV2aXNpb24gMTYxOTk1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xNDM2LDYgKzE0MzYsNyBAQCBzdWIgc2V0dXBBcHBsZVdp bkVudigpCiAgICAgICAgICMgVGhvc2UgZW52aXJvbm1lbnQgdmFyaWFibGVzIG11c3QgYmUgc2V0 IHRvIGJlIGFibGUgdG8gYnVpbGQgaW5zaWRlIFZpc3VhbCBTdHVkaW8uCiAgICAgICAgICR2YXJp YWJsZXNUb1NldHtXRUJLSVRfTElCUkFSSUVTfSA9IHdpbmRvd3NMaWJyYXJpZXNEaXIoKSB1bmxl c3MgJEVOVntXRUJLSVRfTElCUkFSSUVTfTsKICAgICAgICAgJHZhcmlhYmxlc1RvU2V0e1dFQktJ VF9PVVRQVVRESVJ9ID0gd2luZG93c091dHB1dERpcigpIHVubGVzcyAkRU5We1dFQktJVF9PVVRQ VVRESVJ9OworICAgICAgICAkdmFyaWFibGVzVG9TZXR7TVNCVUlMRERJU0FCTEVOT0RFUkVVU0V9 ID0gIjEiIHVubGVzcyAkRU5We01TQlVJTERESVNBQkxFTk9ERVJFVVNFfTsKIAogICAgICAgICBm b3JlYWNoIG15ICR2YXJpYWJsZSAoa2V5cyAldmFyaWFibGVzVG9TZXQpIHsKICAgICAgICAgICAg IHByaW50ICJTZXR0aW5nIHRoZSBFbnZpcm9ubWVudCBWYXJpYWJsZSAnIiAuICR2YXJpYWJsZSAu ICInIHRvICciIC4gJHZhcmlhYmxlc1RvU2V0eyR2YXJpYWJsZX0gLiAiJ1xuXG4iOwpAQCAtMTQ1 Nyw2ICsxNDU4LDEwIEBAIHN1YiBzZXR1cEFwcGxlV2luRW52KCkKICAgICAgICAgICAgIHByaW50 ICJXYXJuaW5nOiBZb3UgbXVzdCBzZXQgdGhlICdXZWJLaXRfT3V0cHV0RGlyJyBlbnZpcm9ubWVu dCB2YXJpYWJsZVxuIjsKICAgICAgICAgICAgIHByaW50ICIgICAgICAgICB0byBiZSBhYmxlIGJ1 aWxkIFdlYktpdCBmcm9tIHdpdGhpbiBWaXN1YWwgU3R1ZGlvIDIwMTMgYW5kIG5ld2VyLlxuXG4i OwogICAgICAgICB9CisgICAgICAgIGlmICghJEVOVnsnTVNCVUlMRERJU0FCTEVOT0RFUkVVU0Un fSkgeworICAgICAgICAgICAgcHJpbnQgIldhcm5pbmc6IFlvdSBzaG91bGQgc2V0IHRoZSAnTVNC VUlMRERJU0FCTEVOT0RFUkVVU0UnIGVudmlyb25tZW50IHZhcmlhYmxlIHRvICcxJ1xuIjsKKyAg ICAgICAgICAgIHByaW50ICIgICAgICAgICB0byBhdm9pZCBwZXJpb2RpYyBsb2NrZWQgbG9nIGZp bGVzIHdoZW4gYnVpbGRpbmcuXG5cbiI7CisgICAgICAgIH0KICAgICB9CiAgICAgIyBGSVhNRSAo MTI1MTgwKTogUmVtb3ZlIHRoZSBmb2xsb3dpbmcgdGVtcG9yYXJ5IDY0LWJpdCBzdXBwb3J0IG9u Y2Ugb2ZmaWNpYWwgc3VwcG9ydCBpcyBhdmFpbGFibGUuCiAgICAgaWYgKGlzV2luNjQoKSBhbmQg ISRFTlZ7J1dFQktJVF82NF9TVVBQT1JUJ30pIHsK