127000 2014-01-14 12:51:50 -0800 Remove unnecessary call to webGLContextCreated 2014-01-15 16:02:54 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham commit-queue dino esprehn+autocc gyuyoung.kim japhet jonlee roger_fong oldest_to_newest 967983 0 roger_fong 2014-01-14 12:51:50 -0800 If the WebKit client hasn't implemented webGLContextCreated then we don't want to return early and we want to continue execution as usual. This is causing 7 tests to fail which I will skip for now. http/tests/canvas/webgl/origin-clean-conformance.html http/tests/webgl/1.0.2/texSubImage2DHTML.html http/tests/security/webgl-remote-read-remote-image-allowed.html http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html http/tests/webgl/1.0.2/texImage2DHTML.html http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html Note that other webgl tests aren't failing because those tests are local files, not hosted from a server like these http tests are. 968016 1 roger_fong 2014-01-14 13:42:27 -0800 tests skipped r162002 968023 2 roger_fong 2014-01-14 13:58:32 -0800 One way to do this would be to use a sendSync and wait for webGLContextCreated to return true or false based on whether or not we want the dialog to show up. It will return false if the method has not implemented in the WebKit client. Perhaps another way is upon initialization of the client, have the client send a message to webkit that sets a flag saying whether or not we need to call webGLContextCreated. 968064 3 roger_fong 2014-01-14 14:55:53 -0800 <rdar://problem/15818843> 968461 4 roger_fong 2014-01-15 13:59:41 -0800 I just need the default load policy to be set to allowing. If the client does not have the method implemented then by default the returned policy will be to allow and everything will run as expected. Keeping this bug open to land unskips 968485 5 221310 roger_fong 2014-01-15 15:06:56 -0800 Created attachment 221310 patch 968488 6 roger_fong 2014-01-15 15:07:48 -0800 This patch will resolve the issue of other ports breaking. It also will eliminate WebGLContextCreated, which means one less message to send to the UIProcess. 968490 7 roger_fong 2014-01-15 15:13:23 -0800 O it also resolves the issue in http://trac.webkit.org/changeset/162002 where I had to skip a bunch of WebGL Http tests 968500 8 221310 bfulgham 2014-01-15 15:33:32 -0800 Comment on attachment 221310 patch r=me 968507 9 221310 commit-queue 2014-01-15 16:02:51 -0800 Comment on attachment 221310 patch Clearing flags on attachment: 221310 Committed r162099: <http://trac.webkit.org/changeset/162099> 968508 10 commit-queue 2014-01-15 16:02:54 -0800 All reviewed patches have been landed. Closing bug. 221310 2014-01-15 15:06:56 -0800 2014-01-15 16:02:51 -0800 patch patch.patch text/plain 5810 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2MjA5NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAxLTE1ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IGNhbGwgdG8g d2ViR0xDb250ZXh0Q3JlYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI3MDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczogVW5za2lwcGluZyB0 ZXN0cyBza2lwcGVkIGluIHIxNjIwMDIuCisKIDIwMTQtMDEtMTUgIEdhdmluIEJhcnJhY2xvdWdo ICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTgzNjkp OiBTb21lIHBvcC11cCB3aW5kb3dzIG9wZW4gYXQgaW5jb3JyZWN0IHNpemUgKGFmZmVjdHMgR01h aWwsIHRoZWJsYXplLmNvbSkKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zCShyZXZpc2lvbiAxNjIwMzUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv VGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtNzI2LDE0ICs3MjYsNiBAQAogd2Vi Z2wvMS4wLjIvY29uZm9ybWFuY2UvY29udGV4dC9jb250ZXh0LWF0dHJpYnV0ZS1wcmVzZXJ2ZS1k cmF3aW5nLWJ1ZmZlci5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIGh0dHAvdGVzdHMvd2ViZ2wvMS4w LjIvb3JpZ2luLWNsZWFuLWNvbmZvcm1hbmNlLmh0bWwgWyBTa2lwIF0KIAotIyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MDAwCi1odHRwL3Rlc3RzL2NhbnZhcy93 ZWJnbC9vcmlnaW4tY2xlYW4tY29uZm9ybWFuY2UuaHRtbAotaHR0cC90ZXN0cy93ZWJnbC8xLjAu Mi90ZXhTdWJJbWFnZTJESFRNTC5odG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L3dlYmdsLXJlbW90 ZS1yZWFkLXJlbW90ZS1pbWFnZS1hbGxvd2VkLmh0bWwKLWh0dHAvdGVzdHMvc2VjdXJpdHkvd2Vi Z2wtcmVtb3RlLXJlYWQtcmVtb3RlLWltYWdlLWFsbG93ZWQtd2l0aC1jcmVkZW50aWFscy5odG1s Ci1odHRwL3Rlc3RzL3dlYmdsLzEuMC4yL3RleEltYWdlMkRIVE1MLmh0bWwKLWh0dHAvdGVzdHMv c2VjdXJpdHkvd2ViZ2wtcmVtb3RlLXJlYWQtcmVtb3RlLWltYWdlLWJsb2NrZWQtbm8tY3Jvc3Nv cmlnaW4uaHRtbAotCiAjIFNlbmRpbmcgdGhlIG1vdXNlIGRvd24gZXZlbnQgdG8gdGhlIHNjcm9s bGJhciBzdGFydHMgYSBuZXN0ZWQgcnVuIGxvb3Agd2hpY2ggY2F1c2VzIGEgaGFuZy4KIGZhc3Qv ZXZlbnRzL21vdXNlZG93bi1pbi1zdWJmcmFtZS1zY3JvbGxiYXIuaHRtbAogCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNjIwOTQpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwyMyBAQAorMjAxNC0wMS0xNSAgUm9nZXIgRm9uZyAgPHJvZ2Vy X2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBjYWxsIHRvIHdl YkdMQ29udGV4dENyZWF0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNzAwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vdGUgdGhhdCB0aGUgZnVuY3Rpb25hbGl0eSBvZiB3ZWJHTENvbnRleHRDcmVh dGVkIHdpbGwgYmUgaGFuZGxlZCBieSB3ZWJHTFBvbGljeUZvclNpdGUgbm93LgorCisgICAgICAg IFRlc3RzOiBVbnNraXBwaW5nIHRlc3RzIHNraXBwZWQgaW4gcjE2MjAwMi4KKworICAgICAgICAq IGh0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwOiBSZW1vdmUgd2ViR0xDb250ZXh0Q3JlYXRlZCBj YWxsLgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1lbnQ6OmdldENvbnRleHQpOgor ICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oOgorICAgICAgICBIYXZlIHRoZSBy ZXR1cm5lZCBsb2FkIHBvbGljeSBkZWZhdWx0IHRvIFdlYkdMQWxsb3cgc28gYXMgdG8gbm90IGJy ZWFrIGNsaWVudHMgdGhhdCBkb24ndCBpbXBsZW1lbnQgdGhlIG1ldGhvZC4KKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50Ojp3ZWJHTFBvbGljeUZvclNpdGUpOgorICAgICAgICB3 ZWJHTFBvbGljeUZvclNpdGUgaXMgbm93IGFzc3VtaW5nIHRoZSByb2xlIG9mIHdlYkdMQ29udGV4 dENyZWF0ZWQgYXMgd2VsbCwgcGFzcyBpbiB0aGUgd2hvbGUgc2l0ZSBVUkwgaW5zdGVhZCBvZiBq dXN0IHRoZSBob3N0LgorICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6IFJlbW92ZSB3ZWJH TENvbnRleHRDcmVhdGVkIG1ldGhvZC4KKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudDo6 ZGVjcmVtZW50QWN0aXZlUGFnZUNvdW50KToKKwogMjAxNC0wMS0xNSAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViR0xdIFZhbGlkYXRpb24gZnVuY3Rp b24gZm9yIGNvbXByZXNzZWQgZm9ybWF0cyBpbmNvcnJlY3QKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjIwNzgpCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI4 LDE1ICsyMjgsMTEgQEAKICAgICAgICAgICAgIGlmICghbV9jb250ZXh0KSB7CiAgICAgICAgICAg ICAgICAgUGFnZSogcGFnZSA9IGRvY3VtZW50KCkucGFnZSgpOwogICAgICAgICAgICAgICAgIGlm IChwYWdlICYmICFkb2N1bWVudCgpLnVybCgpLmlzTG9jYWxGaWxlKCkpIHsKLSAgICAgICAgICAg ICAgICAgICAgV2ViR0xMb2FkUG9saWN5IHBvbGljeSA9IHBhZ2UtPm1haW5GcmFtZSgpLmxvYWRl cigpLmNsaWVudCgpLndlYkdMUG9saWN5Rm9ySG9zdChkb2N1bWVudCgpLnVybCgpLmhvc3QoKSk7 Ci0gICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGJyZWFrcyBtb3N0IGNsaWVudHMg YmVjYXVzZSB0aGV5IHdpbGwgbm90IGltcGxlbWVudCB3ZWJHTENvbnRleHRDcmVhdGVkIGluIHRo ZSB3YXkgd2FudCB0aGVtIHRvCi0gICAgICAgICAgICAgICAgICAgIC8vICAgICAgICBub3Igc2hv dWxkIHRoZXkgYmUgZXhwZWN0ZWQgdG8uIFdlIG5lZWQgdG8gZmluZCBhIHdheSB0byBub3QgcnVu IHRoaXMgY29kZSBpZiB0aGUgY2xpZW50IGhhc24ndCBpbXBsZW1lbnRlZAotICAgICAgICAgICAg ICAgICAgICAvLyAgICAgICAgd2ViR0xDb250ZXh0Q3JlYXRlZC4gSXQgbWlnaHQgYWxzbyBtYWtl IHNlbnNlIGZvciB0aGUgbWV0aG9kIHRvIHJldHVybiB0cnVlIG9yIGZhbHNlIGRlcGVuZGluZyBv bgotICAgICAgICAgICAgICAgICAgICAvLyAgICAgICAgd2hldGhlciBvciBub3QgdGhlIGNsaWVu dCB3YW50cyB0aGUgcGFnZSB0byBjb250aW51ZSBsb2FkaW5nIGFmdGVyIHRoZSBjYWxsLgotICAg ICAgICAgICAgICAgICAgICAvLyBpZiAocG9saWN5ID09IFdlYkdMQXNrKSB7Ci0gICAgICAgICAg ICAgICAgICAgIC8vICAgIHBhZ2UtPmNocm9tZSgpLmNsaWVudCgpLndlYkdMQ29udGV4dENyZWF0 ZWQodGhpcyk7Ci0gICAgICAgICAgICAgICAgICAgIC8vICAgIHJldHVybiBudWxscHRyOwotICAg ICAgICAgICAgICAgICAgICAvLyB9CisgICAgICAgICAgICAgICAgICAgIFdlYkdMTG9hZFBvbGlj eSBwb2xpY3kgPSBwYWdlLT5tYWluRnJhbWUoKS5sb2FkZXIoKS5jbGllbnQoKS53ZWJHTFBvbGlj eUZvclNpdGUoZG9jdW1lbnQoKS51cmwoKSk7CisKKyAgICAgICAgICAgICAgICAgICAgaWYgKHBv bGljeSA9PSBXZWJHTEFzaykKKyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBudWxscHRy OworCiAgICAgICAgICAgICAgICAgICAgIGlmIChwb2xpY3kgPT0gV2ViR0xCbG9jaykKICAgICAg ICAgICAgICAgICAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgICAgICAgICAgICAgIH0KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oCShyZXZpc2lvbiAx NjIwMzYpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaAkod29y a2luZyBjb3B5KQpAQCAtMzMxLDcgKzMzMSw3IEBACiAgICAgICAgIC8vIEluZm9ybXMgdGhlIGVt YmVkZGVyIHRoYXQgYSBXZWJHTCBjYW52YXMgaW5zaWRlIHRoaXMgZnJhbWUgcmVjZWl2ZWQgYSBs b3N0IGNvbnRleHQKICAgICAgICAgLy8gbm90aWZpY2F0aW9uIHdpdGggdGhlIGdpdmVuIEdMX0FS Ql9yb2J1c3RuZXNzIGd1aWx0L2lubm9jZW5jZSBjb2RlIChzZWUgRXh0ZW5zaW9uczNELmgpLgog ICAgICAgICB2aXJ0dWFsIHZvaWQgZGlkTG9zZVdlYkdMQ29udGV4dChpbnQpIHsgfQotICAgICAg ICB2aXJ0dWFsIFdlYkdMTG9hZFBvbGljeSB3ZWJHTFBvbGljeUZvckhvc3QoY29uc3QgU3RyaW5n JikgY29uc3QgeyByZXR1cm4gV2ViR0xBc2s7IH0KKyAgICAgICAgdmlydHVhbCBXZWJHTExvYWRQ b2xpY3kgd2ViR0xQb2xpY3lGb3JTaXRlKGNvbnN0IFN0cmluZyYpIGNvbnN0IHsgcmV0dXJuIFdl YkdMQWxsb3c7IH0KICNlbmRpZgogCiAgICAgICAgIHZpcnR1YWwgdm9pZCBmb3JjZVBhZ2VUcmFu c2l0aW9uSWZOZWVkZWQoKSB7IH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xp ZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAko cmV2aXNpb24gMTYyMDM2KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAko d29ya2luZyBjb3B5KQpAQCAtNDI4LDEwICs0MjgsNiBAQAogICAgIC8vIHdvdWxkIGxpa2VseSB3 YW50IHRoZSBwYWdlIHRvIHJlbWFpbiBydW5uaW5nIHVuaW50ZXJydXB0ZWQuCiAgICAgdmlydHVh bCB2b2lkIGluY3JlbWVudEFjdGl2ZVBhZ2VDb3VudCgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBk ZWNyZW1lbnRBY3RpdmVQYWdlQ291bnQoKSB7IH0KLSAgICAKLSNpZiBFTkFCTEUoV0VCR0wpCi0g ICAgdmlydHVhbCB2b2lkIHdlYkdMQ29udGV4dENyZWF0ZWQoRWxlbWVudCopIGNvbnN0IHsgfQot I2VuZGlmCiAKIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5DaHJvbWVDbGllbnQoKSB7IH0=