126999 2014-01-14 11:29:47 -0800 [iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary() 2014-01-14 12:55:38 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates ddkilzer joepeck oldest_to_newest 967945 0 dbates 2014-01-14 11:29:47 -0800 We should retain the NSMutableDictionary dictionary returned by [NSMutableDictionary dictionary] in WebCore::QLPreviewConverterDictionary() and WebCore::QLContentDictionary(). 967951 1 221185 dbates 2014-01-14 11:32:05 -0800 Created attachment 221185 Patch 967952 2 221185 joepeck 2014-01-14 11:34:46 -0800 Comment on attachment 221185 Patch r=me How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release? 967954 3 dbates 2014-01-14 11:35:54 -0800 (In reply to comment #2) > (From update of attachment 221185 [details]) > r=me > > How about just [[NSMutableDictionary alloc] init]? Avoiding an extra retain/release? Will change before landing. 967986 4 dbates 2014-01-14 12:54:02 -0800 <rdar://problem/15810305> 967987 5 dbates 2014-01-14 12:55:38 -0800 Committed r161997: <http://trac.webkit.org/changeset/161997> 221185 2014-01-14 11:32:05 -0800 2014-01-14 11:34:46 -0800 Patch bug-126999-20140114113204.patch text/plain 2023 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxOTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDBiMTA4ZTA3OWE5YjNl YTE1NzYxNjQ4OTEzNGJiMWQ2YThhMzQ4OC4uNDk0NjBlZjE1NjBhZjZlMmIzMmQ4Y2RlMWVkMjBl YjdjZGYzOTBlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTE0ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSZXRhaW4gW05T TXV0YWJsZURpY3Rpb25hcnkgZGljdGlvbmFyeV0gaW4gUUxQcmV2aWV3Q29udmVydGVyRGljdGlv bmFyeSgpIGFuZCBRTENvbnRlbnREaWN0aW9uYXJ5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjk5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGFuIGlzc3VlIHdoZXJlIHdlIG1heSBjcmFz aCB3aGVuIHN1YnNlcXVlbnRseSBhY2Nlc3NpbmcgV2ViQ29yZTo6UUxQcmV2aWV3Q29udmVydGVy RGljdGlvbmFyeSgpCisgICAgICAgIG9yIFdlYkNvcmU6OlFMQ29udGVudERpY3Rpb25hcnkoKSBh cyBuZWl0aGVyIG9mIHRoZXNlIGZ1bmN0aW9ucyByZXRhaW4nZWQgdGhlIE5TTXV0YWJsZSBkaWN0 aW9uYXJ5CisgICAgICAgIHJldHVybmVkIGJ5IFtOU011dGFibGVEaWN0aW9uYXJ5IGRpY3Rpb25h cnldLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9pb3MvUXVpY2tMb29rLm1tOgorICAg ICAgICAoUUxQcmV2aWV3Q29udmVydGVyRGljdGlvbmFyeSk6CisgICAgICAgIChRTENvbnRlbnRE aWN0aW9uYXJ5KToKKwogMjAxNC0wMS0xMyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVXBkYXRlIHRoZSBTZWxlY3RvclF1ZXJ5IGNvZGUgdXNpbmcg Y29tcGlsZWQgc2VsZWN0b3IgYWZ0ZXIgcjE2MTE5NgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9pb3MvUXVpY2tMb29rLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9pb3MvUXVpY2tMb29rLm1tCmluZGV4IDdlNzY5MDkxMWUxN2QyMDAzMWQ4 OTdlMTllNjZhNGQ0YWQ2NWVmZGYuLjIwNjQzZGE0NWFlZTUwYTdmNjNjMTIxYjNjYjQzZmRiNWVl MmQxOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvaW9zL1F1 aWNrTG9vay5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlj a0xvb2subW0KQEAgLTEzOCwxMyArMTM4LDEzIEBAIHN0YXRpYyBNdXRleCYgcWxQcmV2aWV3Q29u dmVydGVyRGljdGlvbmFyeU11dGV4KCkKIAogc3RhdGljIE5TTXV0YWJsZURpY3Rpb25hcnkgKlFM UHJldmlld0NvbnZlcnRlckRpY3Rpb25hcnkoKQogewotICAgIHN0YXRpYyBOU011dGFibGVEaWN0 aW9uYXJ5ICpkaWN0aW9uYXJ5ID0gYWRvcHROUyhbTlNNdXRhYmxlRGljdGlvbmFyeSBkaWN0aW9u YXJ5XSkubGVha1JlZigpOworICAgIHN0YXRpYyBOU011dGFibGVEaWN0aW9uYXJ5ICpkaWN0aW9u YXJ5ID0gW1tOU011dGFibGVEaWN0aW9uYXJ5IGRpY3Rpb25hcnldIHJldGFpbl07CiAgICAgcmV0 dXJuIGRpY3Rpb25hcnk7CiB9CiAKIHN0YXRpYyBOU011dGFibGVEaWN0aW9uYXJ5ICpRTENvbnRl bnREaWN0aW9uYXJ5KCkKIHsKLSAgICBzdGF0aWMgTlNNdXRhYmxlRGljdGlvbmFyeSAqY29udGVu dERpY3Rpb25hcnkgPSBhZG9wdE5TKFtOU011dGFibGVEaWN0aW9uYXJ5IGRpY3Rpb25hcnldKS5s ZWFrUmVmKCk7CisgICAgc3RhdGljIE5TTXV0YWJsZURpY3Rpb25hcnkgKmNvbnRlbnREaWN0aW9u YXJ5ID0gW1tOU011dGFibGVEaWN0aW9uYXJ5IGRpY3Rpb25hcnldIHJldGFpbl07CiAgICAgcmV0 dXJuIGNvbnRlbnREaWN0aW9uYXJ5OwogfQogCg==