126986 2014-01-14 09:37:00 -0800 build.webkit.org/dashboard should have diff links in test results popovers 2014-01-17 18:04:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue thorton timothy oldest_to_newest 967868 0 ap 2014-01-14 09:37:00 -0800 We have crash log links, but opening diffs is also something one would want to easily do. And image links for image failures, I guess. 969240 1 221489 ap 2014-01-17 13:25:34 -0800 Created attachment 221489 proposed patch proposed patch 969350 2 221489 commit-queue 2014-01-17 18:04:35 -0800 Comment on attachment 221489 proposed patch Clearing flags on attachment: 221489 Committed r162236: <http://trac.webkit.org/changeset/162236> 969351 3 commit-queue 2014-01-17 18:04:36 -0800 All reviewed patches have been landed. Closing bug. 221489 2014-01-17 13:25:34 -0800 2014-01-17 18:04:34 -0800 proposed patch diff.txt text/plain 6864 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MjIxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE0LTAxLTE3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkIHNob3VsZCBoYXZlIGRpZmYg bGlua3MgaW4gdGVzdCByZXN1bHRzIHBvcG92ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY5ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzOgorICAg ICAgICAoQnVpbGRib3QucHJvdG90eXBlLmxheW91dFRlc3RDcmFzaExvZ1VSTEZvckl0ZXJhdGlv bik6CisgICAgICAgIChCdWlsZGJvdC5wcm90b3R5cGUubGF5b3V0VGVzdFN0ZGVyclVSTEZvckl0 ZXJhdGlvbik6CisgICAgICAgIChCdWlsZGJvdC5wcm90b3R5cGUubGF5b3V0VGVzdERpZmZVUkxG b3JJdGVyYXRpb24pOgorICAgICAgICAoQnVpbGRib3QucHJvdG90eXBlLmxheW91dFRlc3RQcmV0 dHlEaWZmVVJMRm9ySXRlcmF0aW9uKToKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJv dEl0ZXJhdGlvbi5qczoKKyAgICAgICAgKEJ1aWxkYm90SXRlcmF0aW9uLnByb3RvdHlwZS5sb2Fk TGF5b3V0VGVzdFJlc3VsdHMpOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90VGVz dGVyUXVldWVWaWV3LmpzOgorICAgICAgICAoQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcucHJvdG90 eXBlLl9wb3BvdmVyQ29udGVudEZvckxheW91dFRlc3RSZWdyZXNzaW9ucyk6CisKIDIwMTQtMDEt MTcgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBU ZXN0IC93ZWJraXQvZG93bmxvYWQvbm90LWZvdW5kIGZhaWxzIGluIEdUSyBMaW51eCA2NC1iaXQg UmVsZWFzZSBib3QKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCShyZXZpc2lvbiAxNjIy MDUpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdC5qcwkod29ya2luZyBjb3B5KQpA QCAtMTAzLDEzICsxMDMsMjYgQEAgQnVpbGRib3QucHJvdG90eXBlID0gewogCiAgICAgbGF5b3V0 VGVzdENyYXNoTG9nVVJMRm9ySXRlcmF0aW9uOiBmdW5jdGlvbihpdGVyYXRpb24sIHRlc3RQYXRo KQogICAgIHsKLSAgICAgICAgdmFyIGNyYXNoTG9nUGF0aCA9IHRlc3RQYXRoLnJlcGxhY2UoL14o LiopXC4oPzouKikkLywgIiQxLWNyYXNoLWxvZy50eHQiKTsKLSAgICAgICAgcmV0dXJuIHRoaXMu bGF5b3V0VGVzdFJlc3VsdHNEaXJlY3RvcnlVUkxGb3JJdGVyYXRpb24oaXRlcmF0aW9uKSArICIv IiArIGNyYXNoTG9nUGF0aDsKKyAgICAgICAgdmFyIHBhdGggPSB0ZXN0UGF0aC5yZXBsYWNlKC9e KC4qKVwuKD86LiopJC8sICIkMS1jcmFzaC1sb2cudHh0Iik7CisgICAgICAgIHJldHVybiB0aGlz LmxheW91dFRlc3RSZXN1bHRzRGlyZWN0b3J5VVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbikgKyAi LyIgKyBwYXRoOwogICAgIH0sCiAKICAgICBsYXlvdXRUZXN0U3RkZXJyVVJMRm9ySXRlcmF0aW9u OiBmdW5jdGlvbihpdGVyYXRpb24sIHRlc3RQYXRoKQogICAgIHsKLSAgICAgICAgdmFyIGNyYXNo TG9nUGF0aCA9IHRlc3RQYXRoLnJlcGxhY2UoL14oLiopXC4oPzouKikkLywgIiQxLXN0ZGVyci50 eHQiKTsKLSAgICAgICAgcmV0dXJuIHRoaXMubGF5b3V0VGVzdFJlc3VsdHNEaXJlY3RvcnlVUkxG b3JJdGVyYXRpb24oaXRlcmF0aW9uKSArICIvIiArIGNyYXNoTG9nUGF0aDsKKyAgICAgICAgdmFy IHBhdGggPSB0ZXN0UGF0aC5yZXBsYWNlKC9eKC4qKVwuKD86LiopJC8sICIkMS1zdGRlcnIudHh0 Iik7CisgICAgICAgIHJldHVybiB0aGlzLmxheW91dFRlc3RSZXN1bHRzRGlyZWN0b3J5VVJMRm9y SXRlcmF0aW9uKGl0ZXJhdGlvbikgKyAiLyIgKyBwYXRoOworICAgIH0sCisKKyAgICBsYXlvdXRU ZXN0RGlmZlVSTEZvckl0ZXJhdGlvbjogZnVuY3Rpb24oaXRlcmF0aW9uLCB0ZXN0UGF0aCkKKyAg ICB7CisgICAgICAgIHZhciBwYXRoID0gdGVzdFBhdGgucmVwbGFjZSgvXiguKilcLig/Oi4qKSQv LCAiJDEtZGlmZi50eHQiKTsKKyAgICAgICAgcmV0dXJuIHRoaXMubGF5b3V0VGVzdFJlc3VsdHNE aXJlY3RvcnlVUkxGb3JJdGVyYXRpb24oaXRlcmF0aW9uKSArICIvIiArIHBhdGg7CisgICAgfSwK KworICAgIGxheW91dFRlc3RQcmV0dHlEaWZmVVJMRm9ySXRlcmF0aW9uOiBmdW5jdGlvbihpdGVy YXRpb24sIHRlc3RQYXRoKQorICAgIHsKKyAgICAgICAgLy8gcHJldHR5LXBhdGNoIG1heSBub3Qg YmUgYXZhaWxhYmxlLCBjYWxsZXIgc2hvdWxkIGNoZWNrIEpTT04gcmVzdWx0cyBmb3IgaGFzX3By ZXR0eV9wYXRjaCBhdHRyaWJ1dGUuCisgICAgICAgIHZhciBwYXRoID0gdGVzdFBhdGgucmVwbGFj ZSgvXiguKilcLig/Oi4qKSQvLCAiJDEtcHJldHR5LWRpZmYuaHRtbCIpOworICAgICAgICByZXR1 cm4gdGhpcy5sYXlvdXRUZXN0UmVzdWx0c0RpcmVjdG9yeVVSTEZvckl0ZXJhdGlvbihpdGVyYXRp b24pICsgIi8iICsgcGF0aDsKICAgICB9CiB9OwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMv QnVpbGRib3RJdGVyYXRpb24uanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMv QnVpbGRib3RJdGVyYXRpb24uanMJKHJldmlzaW9uIDE2MjIwNSkKKysrIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL0J1aWxkYm90SXRlcmF0aW9uLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNzQsMTIgKzI3 NCwyMiBAQCBCdWlsZGJvdEl0ZXJhdGlvbi5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgICAgICAg ICAgICAgaWYgKHByZWRpY2F0ZSh2YWx1ZSkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIHZh ciBpdGVtID0ge3BhdGg6IGtleX07CisKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1F IChidWcgMTI3MTg2KTogQ3Jhc2ggbG9nIFVSTCB3aWxsIGJlIGluY29ycmVjdCBpZiBjcmFzaCBv bmx5IGhhcHBlbmVkIG9uIHJldHJ5IChlLmcuICJURVhUIENSQVNIIikuCisgICAgICAgICAgICAg ICAgICAgICAgICAvLyBJdCBzaG91bGQgcG9pbnQgdG8gcmV0cmllcyBzdWJkaXJlY3RvcnksIGJ1 dCB0aGUgaW5mb3JtYXRpb24gYWJvdXQgd2hpY2ggYXR0ZW1wdCBmYWlsZWQgZ2V0cyBsb3N0IGhl cmUuCiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAodmFsdWUuYWN0dWFsLmNvbnRhaW5zKCJD UkFTSCIpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl0ZW0uY3Jhc2ggPSB0cnVlOwog ICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbHVlLmFjdHVhbC5jb250YWlucygiVElNRU9V VCIpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl0ZW0udGltZW91dCA9IHRydWU7CisK KyAgICAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FIChidWcgMTI3MTg2KTogU2ltaWxhcmx5 LCB3ZSBkb24ndCBoYXZlIGEgZ29vZCB3YXkgdG8gcHJlc2VudCByZXN1bHRzIGZvciBzb21ldGhp bmcgbGlrZSAiVElNRU9VVCBURVhUIiwKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIG5vdCBl dmVuIFVJIHdpc2UuIEZvciBub3csIG9ubHkgc2hvdyBhIGRpZmYgbGluayBpZiB0aGUgZmlyc3Qg YXR0ZW1wdCBoYXMgdGhlIGRpZmYuCisgICAgICAgICAgICAgICAgICAgICAgICBpZiAodmFsdWUu YWN0dWFsLnNwbGl0KCIgIilbMF0uY29udGFpbnMoIlRFWFQiKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpdGVtLmhhc19kaWZmID0gdHJ1ZTsKKwogICAgICAgICAgICAgICAgICAgICAg ICAgaWYgKHZhbHVlLmhhc19zdGRlcnIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXRl bS5oYXNfc3RkZXJyID0gdHJ1ZTsKKwogICAgICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LnB1 c2goaXRlbSk7CiAgICAgICAgICAgICAgICAgICAgIH0KIApAQCAtMzAxLDYgKzMxMSw4IEBAIEJ1 aWxkYm90SXRlcmF0aW9uLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgICAgICB9CiAKKyAgICAgICAgICAgIHRoaXMuaGFzUHJldHR5UGF0Y2ggPSBkYXRhLmhh c19wcmV0dHlfcGF0Y2g7CisKICAgICAgICAgICAgIHRoaXMubGF5b3V0VGVzdFJlc3VsdHMucmVn cmVzc2lvbnMgPSBjb2xsZWN0UmVzdWx0cyhkYXRhLnRlc3RzLCBmdW5jdGlvbihpbmZvKSB7IHJl dHVybiBpbmZvWyJyZXBvcnQiXSA9PT0gIlJFR1JFU1NJT04iIH0pOwogICAgICAgICAgICAgY29u c29sZS5hc3NlcnQoZGF0YS5udW1fcmVncmVzc2lvbnMgPT09IHRoaXMubGF5b3V0VGVzdFJlc3Vs dHMucmVncmVzc2lvbnMubGVuZ3RoKTsKIApJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVp bGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Njcmlw dHMvQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMJKHJldmlzaW9uIDE2MjIwNSkKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TY3JpcHRzL0J1aWxkYm90VGVzdGVyUXVldWVWaWV3LmpzCSh3b3JraW5nIGNvcHkp CkBAIC0xNzksNiArMTc5LDI0IEBAIEJ1aWxkYm90VGVzdGVyUXVldWVWaWV3LnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgICAgICByb3dFbGVtZW50LmFwcGVuZENoaWxkKGZhaWx1cmVLaW5kRWxl bWVudCk7CiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAgIGlmICh0ZXN0Lmhhc19kaWZmKSB7 CisgICAgICAgICAgICAgICAgdmFyIGRpZmZFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiYSIpOworICAgICAgICAgICAgICAgIGRpZmZFbGVtZW50LmNsYXNzTmFtZSA9ICJhZGRpdGlv bmFsLWxpbmsiCisgICAgICAgICAgICAgICAgZGlmZkVsZW1lbnQudGV4dENvbnRlbnQgPSAiZGlm ZiI7CisgICAgICAgICAgICAgICAgZGlmZkVsZW1lbnQuaHJlZiA9IGl0ZXJhdGlvbi5xdWV1ZS5i dWlsZGJvdC5sYXlvdXRUZXN0RGlmZlVSTEZvckl0ZXJhdGlvbihpdGVyYXRpb24sIHRlc3QucGF0 aCk7CisgICAgICAgICAgICAgICAgZGlmZkVsZW1lbnQudGFyZ2V0ID0gIl9ibGFuayI7CisgICAg ICAgICAgICAgICAgcm93RWxlbWVudC5hcHBlbmRDaGlsZChkaWZmRWxlbWVudCk7CisKKyAgICAg ICAgICAgICAgICBpZiAoaXRlcmF0aW9uLmhhc1ByZXR0eVBhdGNoKSB7CisgICAgICAgICAgICAg ICAgICAgIHZhciBwcmV0dHlEaWZmRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImEi KTsKKyAgICAgICAgICAgICAgICAgICAgcHJldHR5RGlmZkVsZW1lbnQuY2xhc3NOYW1lID0gImFk ZGl0aW9uYWwtbGluayIKKyAgICAgICAgICAgICAgICAgICAgcHJldHR5RGlmZkVsZW1lbnQudGV4 dENvbnRlbnQgPSAicHJldHR5XHhhMGRpZmYiOworICAgICAgICAgICAgICAgICAgICBwcmV0dHlE aWZmRWxlbWVudC5ocmVmID0gaXRlcmF0aW9uLnF1ZXVlLmJ1aWxkYm90LmxheW91dFRlc3RQcmV0 dHlEaWZmVVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbiwgdGVzdC5wYXRoKTsKKyAgICAgICAgICAg ICAgICAgICAgcHJldHR5RGlmZkVsZW1lbnQudGFyZ2V0ID0gIl9ibGFuayI7CisgICAgICAgICAg ICAgICAgICAgIHJvd0VsZW1lbnQuYXBwZW5kQ2hpbGQocHJldHR5RGlmZkVsZW1lbnQpOworICAg ICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgaWYgKHRlc3QuaGFz X3N0ZGVycikgewogICAgICAgICAgICAgICAgIHZhciBzdGRlcnJFbGVtZW50ID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgiYSIpOwogICAgICAgICAgICAgICAgIHN0ZGVyckVsZW1lbnQuY2xhc3NO YW1lID0gImFkZGl0aW9uYWwtbGluayIK