126978 2014-01-14 05:12:42 -0800 [CSSRegions] The list of fixed positioned layers in named flows should be sorted by z-index 2014-01-14 06:46:57 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 mihnea webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser WebkitBugTracker oldest_to_newest 967766 0 mihnea 2014-01-14 05:12:42 -0800 Return the list of fixed positioned layers sorted by z-index from FlowThreadController::collectFixedPositionedLayers instead of manually sort it every time we need it (RenderLayer::paintFixedLayersInNamedFlows, RenderLayer::hitTestFixedLayersInNamedFlows). 967769 1 221146 mihnea 2014-01-14 05:16:52 -0800 Created attachment 221146 Patch 967774 2 221146 mmaerean 2014-01-14 05:24:06 -0800 Comment on attachment 221146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221146&action=review > Source/WebCore/rendering/FlowThreadController.cpp:282 > +static inline bool compareZIndex(RenderLayer* first, RenderLayer* second) Rather than having this method in both FlowThreadController and RenderLayer object files, maybe it should be a public static method of the RenderLayer class. 967790 3 mihnea 2014-01-14 06:04:34 -0800 (In reply to comment #2) > (From update of attachment 221146 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221146&action=review > > > Source/WebCore/rendering/FlowThreadController.cpp:282 > > +static inline bool compareZIndex(RenderLayer* first, RenderLayer* second) > > Rather than having this method in both FlowThreadController and RenderLayer object files, maybe it should be a public static method of the RenderLayer class. I thought about that but i decided not to add another method to the public interface of RenderLayer since it is just a very simple comparison function. 967792 4 221146 koivisto 2014-01-14 06:12:23 -0800 Comment on attachment 221146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221146&action=review > Source/WebCore/rendering/RenderLayer.cpp:4062 > renderer().view().flowThreadController().collectFixedPositionedLayers(fixedLayers); Maybe call it collectSortedFixedPositionedLayers or similar? We nowadays prefer collection functions to return the vector normally instead of passing an argument since rvalue references make it copy-free. 967802 5 221146 commit-queue 2014-01-14 06:46:55 -0800 Comment on attachment 221146 Patch Clearing flags on attachment: 221146 Committed r161960: <http://trac.webkit.org/changeset/161960> 967803 6 commit-queue 2014-01-14 06:46:57 -0800 All reviewed patches have been landed. Closing bug. 221146 2014-01-14 05:16:52 -0800 2014-01-14 06:46:55 -0800 Patch 126978.patch text/plain 3542 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlYTI1ZjM1Li41ODY0NGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMDEtMTQgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIFRoZSBsaXN0IG9mIGZpeGVkIHBvc2l0aW9uZWQgbGF5ZXJzIGlu IG5hbWVkIGZsb3dzIHNob3VsZCBiZSBzb3J0ZWQgYnkgei1pbmRleAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTc4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIHRoZSBsaXN0IG9mIGZpeGVk IHBvc2l0aW9uZWQgbGF5ZXJzIHNvcnRlZCBieSB6LWluZGV4IGZyb20KKyAgICAgICAgRmxvd1Ro cmVhZENvbnRyb2xsZXI6OmNvbGxlY3RGaXhlZFBvc2l0aW9uZWRMYXllcnMgaW5zdGVhZCBvZiBt YW51YWxseSBzb3J0IGl0CisgICAgICAgIGV2ZXJ5IHRpbWUgd2UgbmVlZCBpdCAoUmVuZGVyTGF5 ZXI6OnBhaW50Rml4ZWRMYXllcnNJbk5hbWVkRmxvd3MsIFJlbmRlckxheWVyOjpoaXRUZXN0Rml4 ZWRMYXllcnNJbk5hbWVkRmxvd3MpLgorICAgICAgICBSZWZhY3RvcmluZyBjb3ZlcmVkIGJ5IGV4 aXN0aW5nIHJlZ2lvbnMgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvRmxvd1RocmVhZENv bnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29tcGFyZVpJbmRleCk6CisgICAgICAg IChXZWJDb3JlOjpGbG93VGhyZWFkQ29udHJvbGxlcjo6Y29sbGVjdEZpeGVkUG9zaXRpb25lZExh eWVycyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckxheWVyOjpwYWludEZpeGVkTGF5ZXJzSW5OYW1lZEZsb3dzKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpoaXRUZXN0Rml4ZWRMYXllcnNJbk5hbWVkRmxvd3Mp OgorCiAyMDE0LTAxLTEzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgog CiAgICAgICAgIGlPUyBXZWJDb3JlIGJ1aWxkIGZpeGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvRmxvd1RocmVhZENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0Zsb3dUaHJlYWRDb250cm9sbGVyLmNwcAppbmRleCA3NThlYzJkLi4xY2Y2OTQ0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvd1RocmVhZENvbnRyb2xs ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG93VGhyZWFkQ29udHJvbGxl ci5jcHAKQEAgLTI4LDcgKzI4LDYgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCi0KICNp bmNsdWRlICJGbG93VGhyZWFkQ29udHJvbGxlci5oIgogCiAjaW5jbHVkZSAiTmFtZWRGbG93Q29s bGVjdGlvbi5oIgpAQCAtMjgwLDYgKzI3OSwxMSBAQCBib29sIEZsb3dUaHJlYWRDb250cm9sbGVy Ojppc0NvbnRlbnRFbGVtZW50UmVnaXN0ZXJlZFdpdGhBbnlOYW1lZEZsb3coY29uc3QgRWxlbQog ICAgIHJldHVybiBtX21hcE5hbWVkRmxvd0NvbnRlbnRFbGVtZW50LmNvbnRhaW5zKCZjb250ZW50 RWxlbWVudCk7CiB9CiAKK3N0YXRpYyBpbmxpbmUgYm9vbCBjb21wYXJlWkluZGV4KFJlbmRlckxh eWVyKiBmaXJzdCwgUmVuZGVyTGF5ZXIqIHNlY29uZCkKK3sKKyAgICByZXR1cm4gZmlyc3QtPnpJ bmRleCgpIDwgc2Vjb25kLT56SW5kZXgoKTsKK30KKwogLy8gQ29sbGVjdCB0aGUgZml4ZWQgcG9z aXRpb25lZCBsYXllcnMgdGhhdCBoYXZlIHRoZSBuYW1lZCBmbG93cyBhcyBjb250YWluaW5nIGJs b2NrCiAvLyBUaGVzZSBsYXllcnMgYXJlIHBhaW50ZWQgYW5kIGhpdC10ZXN0ZWQgc3RhcnRpbmcg ZnJvbSBSZW5kZXJWaWV3IG5vdCBmcm9tIHJlZ2lvbnMuCiB2b2lkIEZsb3dUaHJlYWRDb250cm9s bGVyOjpjb2xsZWN0Rml4ZWRQb3NpdGlvbmVkTGF5ZXJzKFZlY3RvcjxSZW5kZXJMYXllcio+JiBm aXhlZFBvc0xheWVycykgY29uc3QKQEAgLTMwMyw2ICszMDcsOCBAQCB2b2lkIEZsb3dUaHJlYWRD b250cm9sbGVyOjpjb2xsZWN0Rml4ZWRQb3NpdGlvbmVkTGF5ZXJzKFZlY3RvcjxSZW5kZXJMYXll cio+JiBmaQogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQorCisgICAgc3RkOjpzdGFi bGVfc29ydChmaXhlZFBvc0xheWVycy5iZWdpbigpLCBmaXhlZFBvc0xheWVycy5lbmQoKSwgY29t cGFyZVpJbmRleCk7CiB9CiAKICNpZm5kZWYgTkRFQlVHCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcAppbmRleCBmNDJhNjcyLi5kMmE2OGI0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTQwNjEsOSArNDA2MSw2IEBAIHZvaWQgUmVu ZGVyTGF5ZXI6OnBhaW50Rml4ZWRMYXllcnNJbk5hbWVkRmxvd3MoR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0LCBjb25zdCBMCiAgICAgVmVjdG9yPFJlbmRlckxheWVyKj4gZml4ZWRMYXllcnM7CiAg ICAgcmVuZGVyZXIoKS52aWV3KCkuZmxvd1RocmVhZENvbnRyb2xsZXIoKS5jb2xsZWN0Rml4ZWRQ b3NpdGlvbmVkTGF5ZXJzKGZpeGVkTGF5ZXJzKTsKIAotICAgIC8vIFNvcnQgdGhlIGZpeGVkIGxh eWVycyBsaXN0Ci0gICAgc3RkOjpzdGFibGVfc29ydChmaXhlZExheWVycy5iZWdpbigpLCBmaXhl ZExheWVycy5lbmQoKSwgY29tcGFyZVpJbmRleCk7Ci0KICAgICAvLyBQYWludCB0aGUgbGF5ZXJz CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBmaXhlZExheWVycy5zaXplKCk7ICsraSkgewog ICAgICAgICBSZW5kZXJMYXllciogZml4ZWRMYXllciA9IGZpeGVkTGF5ZXJzLmF0KGkpOwpAQCAt NDgxMSw5ICs0ODA4LDYgQEAgUmVuZGVyTGF5ZXIqIFJlbmRlckxheWVyOjpoaXRUZXN0Rml4ZWRM YXllcnNJbk5hbWVkRmxvd3MoUmVuZGVyTGF5ZXIqIC8qcm9vdExheWUKICAgICBWZWN0b3I8UmVu ZGVyTGF5ZXIqPiBmaXhlZExheWVyczsKICAgICByZW5kZXJlcigpLnZpZXcoKS5mbG93VGhyZWFk Q29udHJvbGxlcigpLmNvbGxlY3RGaXhlZFBvc2l0aW9uZWRMYXllcnMoZml4ZWRMYXllcnMpOwog Ci0gICAgLy8gU29ydCB0aGUgZml4ZWQgbGF5ZXJzIGxpc3QKLSAgICBzdGQ6OnN0YWJsZV9zb3J0 KGZpeGVkTGF5ZXJzLmJlZ2luKCksIGZpeGVkTGF5ZXJzLmVuZCgpLCBjb21wYXJlWkluZGV4KTsK LQogICAgIC8vIEhpdCB0ZXN0IHRoZSBsYXllcnMKICAgICBSZW5kZXJMYXllciogcmVzdWx0TGF5 ZXIgPSAwOwogICAgIGZvciAoaW50IGkgPSBmaXhlZExheWVycy5zaXplKCkgLSAxOyBpID49IDA7 IC0taSkgewo=