<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126966</bug_id>
          
          <creation_ts>2014-01-14 00:32:47 -0800</creation_ts>
          <short_desc>[SOUP] SoupNetworkSession::setAcceptLanguages should receive a const reference</short_desc>
          <delta_ts>2014-01-14 08:58:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Soup</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>126130</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>danw</cc>
    
    <cc>gustavo</cc>
    
    <cc>mrobinson</cc>
    
    <cc>rakuco</cc>
    
    <cc>svillar</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>967702</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-01-14 00:32:47 -0800</bug_when>
    <thetext>We don&apos;t really need to modify the Vector just ro ignore the C locale.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967706</commentid>
    <comment_count>1</comment_count>
      <attachid>221117</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-01-14 00:40:33 -0800</bug_when>
    <thetext>Created attachment 221117
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967848</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-01-14 08:58:37 -0800</bug_when>
    <thetext>Committed r161974: &lt;http://trac.webkit.org/changeset/161974&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>221117</attachid>
            <date>2014-01-14 00:40:33 -0800</date>
            <delta_ts>2014-01-14 06:40:11 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-languages-const-vector.diff</filename>
            <type>text/plain</type>
            <size>4861</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBlYTI1ZjM1Li5hZjUyMTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg
QEAKKzIwMTQtMDEtMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgorCisgICAgICAgIFtTT1VQXSBTb3VwTmV0d29ya1Nlc3Npb246OnNldEFjY2VwdExhbmd1YWdl
cyBzaG91bGQgcmVjZWl2ZSBhIGNvbnN0IHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3QgcmVhbGx5IG5lZWQgdG8gbW9kaWZ5
IHRoZSBWZWN0b3IganVzdCB0byBpZ25vcmUgdGhlIEMKKyAgICAgICAgbG9jYWxlLgorCisgICAg
ICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpidWlsZEFjY2VwdExhbmd1YWdlcyk6IFJld29yayBpdCB0byBub3QgbW9k
aWZ5IHRoZQorICAgICAgICBwYXNzZWQgdmVjdG9yIHRvIGlnbm9yZSB0aGUgQyBsb2NhbGUgd2hl
biBpdCdzIHByZXNlbnQuCisgICAgICAgIChXZWJDb3JlOjpTb3VwTmV0d29ya1Nlc3Npb246OnNl
dEFjY2VwdExhbmd1YWdlcyk6IFVzZSBjb25zdCBWZWN0b3I8U3RyaW5nPiYuCisgICAgICAgICog
cGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5oOgorCiAyMDE0LTAxLTEz
ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIGlPUyBX
ZWJDb3JlIGJ1aWxkIGZpeGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u
ZXR3b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwCmluZGV4IDk0NDgzOTQuLjRm
ODM3OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9T
b3VwTmV0d29ya1Nlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv
cmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwCkBAIC0yMjgsMjIgKzIyOCwyNCBAQCB2b2lk
IFNvdXBOZXR3b3JrU2Vzc2lvbjo6c2V0dXBIVFRQUHJveHlGcm9tRW52aXJvbm1lbnQoKQogI2Vu
ZGlmCiB9CiAKLXN0YXRpYyBDU3RyaW5nIGJ1aWxkQWNjZXB0TGFuZ3VhZ2VzKFZlY3RvcjxTdHJp
bmc+IGxhbmd1YWdlcykKK3N0YXRpYyBDU3RyaW5nIGJ1aWxkQWNjZXB0TGFuZ3VhZ2VzKGNvbnN0
IFZlY3RvcjxTdHJpbmc+JiBsYW5ndWFnZXMpCiB7CisgICAgc2l6ZV90IGxhbmd1YWdlc0NvdW50
ID0gbGFuZ3VhZ2VzLnNpemUoKTsKKwogICAgIC8vIElnbm9yZSAiQyIgbG9jYWxlLgotICAgIHNp
emVfdCBwb3NpdGlvbiA9IGxhbmd1YWdlcy5maW5kKCJjIik7Ci0gICAgaWYgKHBvc2l0aW9uICE9
IG5vdEZvdW5kKQotICAgICAgICBsYW5ndWFnZXMucmVtb3ZlKHBvc2l0aW9uKTsKKyAgICBzaXpl
X3QgY0xvY2FsZVBvc2l0aW9uID0gbGFuZ3VhZ2VzLmZpbmQoImMiKTsKKyAgICBpZiAoY0xvY2Fs
ZVBvc2l0aW9uICE9IG5vdEZvdW5kKQorICAgICAgICBsYW5ndWFnZXNDb3VudC0tOwogCiAgICAg
Ly8gRmFsbGJhY2sgdG8gImVuIiBpZiB0aGUgbGlzdCBpcyBlbXB0eS4KLSAgICBpZiAobGFuZ3Vh
Z2VzLmlzRW1wdHkoKSkKKyAgICBpZiAoIWxhbmd1YWdlc0NvdW50KQogICAgICAgICByZXR1cm4g
ImVuIjsKIAogICAgIC8vIENhbGN1bGF0ZSBkZWx0YXMgZm9yIHRoZSBxdWFsaXR5IHZhbHVlcy4K
ICAgICBpbnQgZGVsdGE7Ci0gICAgaWYgKGxhbmd1YWdlcy5zaXplKCkgPCAxMCkKKyAgICBpZiAo
bGFuZ3VhZ2VzQ291bnQgPCAxMCkKICAgICAgICAgZGVsdGEgPSAxMDsKLSAgICBlbHNlIGlmIChs
YW5ndWFnZXMuc2l6ZSgpIDwgMjApCisgICAgZWxzZSBpZiAobGFuZ3VhZ2VzQ291bnQgPCAyMCkK
ICAgICAgICAgZGVsdGEgPSA1OwogICAgIGVsc2UKICAgICAgICAgZGVsdGEgPSAxOwpAQCAtMjUx
LDggKzI1MywxMSBAQCBzdGF0aWMgQ1N0cmluZyBidWlsZEFjY2VwdExhbmd1YWdlcyhWZWN0b3I8
U3RyaW5nPiBsYW5ndWFnZXMpCiAgICAgLy8gU2V0IHF1YWxpdHkgdmFsdWVzIGZvciBlYWNoIGxh
bmd1YWdlLgogICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsKICAgICBmb3IgKHNpemVfdCBpID0g
MDsgaSA8IGxhbmd1YWdlcy5zaXplKCk7ICsraSkgeworICAgICAgICBpZiAoaSA9PSBjTG9jYWxl
UG9zaXRpb24pCisgICAgICAgICAgICBjb250aW51ZTsKKwogICAgICAgICBpZiAoaSkKLSAgICAg
ICAgICAgIGJ1aWxkZXIuYXBwZW5kKCIsICIpOworICAgICAgICAgICAgYnVpbGRlci5hcHBlbmRM
aXRlcmFsKCIsICIpOwogCiAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKGxhbmd1YWdlc1tpXSk7CiAK
QEAgLTI2Nyw3ICsyNzIsNyBAQCBzdGF0aWMgQ1N0cmluZyBidWlsZEFjY2VwdExhbmd1YWdlcyhW
ZWN0b3I8U3RyaW5nPiBsYW5ndWFnZXMpCiAgICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJpbmcoKS51
dGY4KCk7CiB9CiAKLXZvaWQgU291cE5ldHdvcmtTZXNzaW9uOjpzZXRBY2NlcHRMYW5ndWFnZXMo
VmVjdG9yPFN0cmluZz4gbGFuZ3VhZ2VzKQordm9pZCBTb3VwTmV0d29ya1Nlc3Npb246OnNldEFj
Y2VwdExhbmd1YWdlcyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgbGFuZ3VhZ2VzKQogewogICAgIGdf
b2JqZWN0X3NldChtX3NvdXBTZXNzaW9uLmdldCgpLCAiYWNjZXB0LWxhbmd1YWdlIiwgYnVpbGRB
Y2NlcHRMYW5ndWFnZXMobGFuZ3VhZ2VzKS5kYXRhKCksIG51bGxwdHIpOwogfQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lv
bi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vz
c2lvbi5oCmluZGV4IDE3OWQyMmUuLjIzNTgxNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uaAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmgKQEAgLTcw
LDcgKzcwLDcgQEAgcHVibGljOgogICAgIGNoYXIqIGh0dHBQcm94eSgpIGNvbnN0OwogICAgIHZv
aWQgc2V0dXBIVFRQUHJveHlGcm9tRW52aXJvbm1lbnQoKTsKIAotICAgIHZvaWQgc2V0QWNjZXB0
TGFuZ3VhZ2VzKFZlY3RvcjxTdHJpbmc+KTsKKyAgICB2b2lkIHNldEFjY2VwdExhbmd1YWdlcyhj
b25zdCBWZWN0b3I8U3RyaW5nPiYpOwogCiBwcml2YXRlOgogICAgIFNvdXBOZXR3b3JrU2Vzc2lv
bihTb3VwQ29va2llSmFyKik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg
Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2M0OGY0My4uYWI5MjkzOSAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg
PGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0gU291cE5ldHdvcmtTZXNzaW9u
OjpzZXRBY2NlcHRMYW5ndWFnZXMgc2hvdWxkIHJlY2VpdmUgYSBjb25zdCByZWZlcmVuY2UKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjk2NgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vz
cy9zb3VwL1dlYlByb2Nlc3NTb3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6c2V0U291cFNlc3Np
b25BY2NlcHRMYW5ndWFnZSk6IFVzZSBjb25zdCBWZWN0b3I8U3RyaW5nPiYuCisKIDIwMTQtMDEt
MTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg
IFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0V2ViQ29udGV4dC9sYW5ndWFnZXMgY3Jhc2hlcyB3
aXRoIG5ldHdvcmsgcHJvY2VzcyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X
ZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv
Y2Vzcy9zb3VwL1dlYlByb2Nlc3NTb3VwLmNwcAppbmRleCA4MDlhYmY2Li5hYjgxOTM0IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3Bw
CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAK
QEAgLTEyNCw3ICsxMjQsNyBAQCB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtQ2xlYXJSZXNvdXJj
ZUNhY2hlcyhSZXNvdXJjZUNhY2hlc1RvQ2xlYXIgY2FjaGVzVG9DbGVhcgogICAgIHNvdXBfY2Fj
aGVfY2xlYXIoV2ViQ29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLmNh
Y2hlKCkpOwogfQogCi1zdGF0aWMgdm9pZCBzZXRTb3VwU2Vzc2lvbkFjY2VwdExhbmd1YWdlKFZl
Y3RvcjxTdHJpbmc+IGxhbmd1YWdlcykKK3N0YXRpYyB2b2lkIHNldFNvdXBTZXNzaW9uQWNjZXB0
TGFuZ3VhZ2UoY29uc3QgVmVjdG9yPFN0cmluZz4mIGxhbmd1YWdlcykKIHsKICAgICBXZWJDb3Jl
OjpTb3VwTmV0d29ya1Nlc3Npb246OmRlZmF1bHRTZXNzaW9uKCkuc2V0QWNjZXB0TGFuZ3VhZ2Vz
KGxhbmd1YWdlcyk7CiB9Cg==
</data>
<flag name="review"
          id="244972"
          type_id="1"
          status="+"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>