126965 2014-01-13 22:35:15 -0800 Web Inspector: RemoteInspector::updateDebuggable may miss a push 2014-01-14 00:31:34 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 967670 0 joepeck 2014-01-13 22:35:15 -0800 If a debuggable just changed from allowed -> not allowed, then RemoteInspector::updateDebuggable would bail pushing an update. updateDebuggable should always push an update. 967671 1 webkit-bug-importer 2014-01-13 22:35:35 -0800 <rdar://problem/15812218> 967672 2 221106 joepeck 2014-01-13 22:36:26 -0800 Created attachment 221106 [PATCH] Proposed Fix 967700 3 221106 commit-queue 2014-01-14 00:31:32 -0800 Comment on attachment 221106 [PATCH] Proposed Fix Clearing flags on attachment: 221106 Committed r161953: <http://trac.webkit.org/changeset/161953> 967701 4 commit-queue 2014-01-14 00:31:34 -0800 All reviewed patches have been landed. Closing bug. 221106 2014-01-13 22:36:26 -0800 2014-01-14 00:31:32 -0800 [PATCH] Proposed Fix update.patch text/plain 1527 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDI0MjczMTYuLjlmNjdjOWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Rl SW5zcGVjdG9yOjp1cGRhdGVEZWJ1Z2dhYmxlIG1heSBtaXNzIGEgcHVzaAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTY1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcmVtb3RlL1Jl bW90ZUluc3BlY3Rvci5tbToKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yOjp1 cGRhdGVEZWJ1Z2dhYmxlKToKKyAgICAgICAgQWx3YXlzIHB1c2ggYW4gdXBkYXRlLiBJZiBhIGRl YnVnZ2FibGUgd2VudCBmcm9tIGFsbG93ZWQgdG8KKyAgICAgICAgbm90IGFsbG93ZWQsIHdlIHdv dWxkIGhhdmUgbWlzc2VkIHB1c2hpbmcgYW4gdXBkYXRlLgorCiAyMDE0LTAxLTEzICBNYXJrIEhh aG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUGVyZm9ybWFuY2Ug cmVncmVzc2lvbiBvbiBkcm9tYWVvIGR1ZSB0byBnZW5lcmF0aW9uYWwgbWFya2luZwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVj dG9yLm1tIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5z cGVjdG9yLm1tCmluZGV4IDQ5OWJjOTUuLmFiMzU1YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbQorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IubW0KQEAg LTEzMSw4ICsxMzEsNyBAQCB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6dXBkYXRlRGVidWdnYWJsZShS ZW1vdGVJbnNwZWN0b3JEZWJ1Z2dhYmxlKiBkZWJ1Z2dhYmxlKQogICAgIGF1dG8gcmVzdWx0ID0g bV9kZWJ1Z2dhYmxlTWFwLnNldChpZGVudGlmaWVyLCBzdGQ6Om1ha2VfcGFpcihkZWJ1Z2dhYmxl LCBkZWJ1Z2dhYmxlLT5pbmZvKCkpKTsKICAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgIXJlc3Vs dC5pc05ld0VudHJ5KTsKIAotICAgIGlmIChkZWJ1Z2dhYmxlLT5yZW1vdGVEZWJ1Z2dpbmdBbGxv d2VkKCkpCi0gICAgICAgIHB1c2hMaXN0aW5nU29vbigpOworICAgIHB1c2hMaXN0aW5nU29vbigp OwogfQogCiB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6c2VuZE1lc3NhZ2VUb1JlbW90ZUZyb250ZW5k KHVuc2lnbmVkIGlkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYgbWVzc2FnZSkK