126959 2014-01-13 21:04:18 -0800 CStack: Fix 64-bit C Loop LLINT for !ENABLE(COMPUTED_GOTO_OPCODES) 2014-01-14 09:12:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 967643 0 mark.lam 2014-01-13 21:04:18 -0800 The !ENABLE(COMPUTED_GOTO_OPCODES) build of the C loop LLINT reveals the unused piece of LLINT code for sanitizeStackForVM() was still being built in. In the computed got case, the sanitizeStackForVM() code only results in some unused code in CLoop::execute() and an extra local label which is harmless. In the non-computed goto case, it results in a case statement for an unknown opcode named "sanitizeStackForVM". This results in a build failure. The fix is simply to exclude the unused LLINT sanitizeStackForVM() from the C loop build. Patch coming. 967648 1 221102 mark.lam 2014-01-13 21:15:44 -0800 Created attachment 221102 the patch. 967859 2 mark.lam 2014-01-14 09:12:44 -0800 Thanks for the review. Landed in r161975 on the jsCStack branch: <http://trac.webkit.org/r161975>. 221102 2014-01-13 21:15:44 -0800 2014-01-14 08:39:14 -0800 the patch. bug-126959.patch text/plain 1471 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxOTQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAxLTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggNjQtYml0IEMgTG9vcCBMTElOVCBmb3IgIUVOQUJMRShDT01QVVRFRF9HT1RPX09QQ09ERVMp LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTU5 LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206CisgICAgICAgIC0gVGhlIExMSU5UIHNhbml0aXpl U3RhY2tGb3JWTSgpIGlzIG5vdCBuZWVkZWQgYnkgdGhlIEMgbG9vcCwgYW5kIHdpbGwKKyAgICAg ICAgICBjYXVzZSBhIGJ1aWxkIGZhaWx1cmUgaW4gdGhlIG5vbi1jb21wdXRlZCBnb3RvIEMgbG9v cCBidWlsZC4gVGhpcyBpcworICAgICAgICAgIG5vdyBmaXhlZCBieSBleGNsdWRpbmcgdGhlIExM SU5UIHNhbml0aXplU3RhY2tGb3JWTSgpIGZyb20gdGhlIEMgbG9vcAorICAgICAgICAgIGJ1aWxk LgorCiAyMDE0LTAxLTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBHYXJkZW5pbmc6IGZpeCBiYWQgbWVyZ2Ugb2YgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNjc5MApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xv d0xldmVsSW50ZXJwcmV0ZXIuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkocmV2aXNpb24gMTYxOTQyKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5n IGNvcHkpCkBAIC01NzIsNiArNTcyLDggQEAgZW5kCiAgICAgZG9DYWxsVG9KYXZhU2NyaXB0KG1h a2VIb3N0RnVuY3Rpb25DYWxsKQogCiAKK2lmIENfTE9PUAorZWxzZQogIyB2b2lkIHNhbml0aXpl U3RhY2tGb3JWTShWTSogdm0pCiBfc2FuaXRpemVTdGFja0ZvclZNOgogICAgIGlmIFg4Nl82NApA QCAtNjAxLDYgKzYwMyw3IEBAIF9zYW5pdGl6ZVN0YWNrRm9yVk06CiAgICAgbW92ZSBzcCwgYWRk cmVzcwogICAgIHN0b3JlcCBhZGRyZXNzLCBWTTo6bV9sYXN0U3RhY2tUb3Bbdm1dCiAgICAgcmV0 CitlbmQKIAogCiAjIEluZGljYXRlIHRoZSBiZWdpbm5pbmcgb2YgTExJbnQuCg==