126954 2014-01-13 18:33:47 -0800 [iOS] Enable QuickLook 2014-01-15 09:42:53 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser dbates aestes benjamin cmarcelo commit-queue dbates ddkilzer oldest_to_newest 967597 0 simon.fraser 2014-01-13 18:33:47 -0800 WTF_USE_QUICK_LOOK is missing from Platform.h 968062 1 221208 dbates 2014-01-14 14:53:38 -0800 Created attachment 221208 Patch 968063 2 221208 ddkilzer 2014-01-14 14:54:31 -0800 Comment on attachment 221208 Patch r=me 968065 3 dbates 2014-01-14 14:57:28 -0800 Committed r162016: <http://trac.webkit.org/changeset/162016> 968373 4 221208 darin 2014-01-15 09:42:53 -0800 Comment on attachment 221208 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221208&action=review > Source/WebKit/mac/WebView/WebView.mm:3635 > +#if TARGET_OS_IPHONE && USE(QUICK_LOOK) Doesn’t seem like we need the USE(QUICK_LOOK) conditional here. Unless we plan to support building for IOS with it turned off. 221208 2014-01-14 14:53:38 -0800 2014-01-15 09:42:53 -0800 Patch bug-126954-20140114145338.patch text/plain 2756 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYxMDlkZDY5ZDcwZmQ2NDc4MzE3ODA2 NWJmYTZhOTlmNDU3OGYwZTYuLjA2ODVmNjJlZTYyMDY2YjZhNTY3YTE4NjdjNzVjNzNiMzJmMzA5 MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDEtMTQgIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEVuYWJsZSBRdWlja0xvb2sKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjk1NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6 CisKIDIwMTQtMDEtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBHZXQgcmlkIG9mIFRocmVhZFJlc3RyaWN0aW9uVmVyaWZpZXIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxv ZwppbmRleCBmYmFjOTIwNmVjMmQ5NWE5ZDc5ZWVjZDg3YTU5MjdjNjQ3ODUyY2U3Li41YjU3NDY2 NWE1MzU3YTI1ODU0ZTBmMDBlMWZlNGE2YmViZDkxYjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTQtMDEtMTQgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29t PgorCisgICAgICAgIFtpT1NdIEVuYWJsZSBRdWlja0xvb2sKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjk1NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBlbXB0eSBpbXBsZW1lbnRhdGlvbiBm b3IgcXVpY2tMb29rQ29udGVudEZvclVSTDogc2luY2Ugd2UgYWx3YXlzIGVuYWJsZSBRdWlja0xv b2sgb24gaU9TLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtX ZWJWaWV3IHF1aWNrTG9va0NvbnRlbnRGb3JVUkw6XSk6CisKIDIwMTQtMDEtMTQgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBzb21lIE1hYy1v bmx5IGV4cG9ydHMgdG8gV2ViS2l0Lm1hYy5leHAgZm9yIGlPUyBidWlsZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmlu ZGV4IDgwMDUzNjllYWI4OGI4OGFiMzM3NTBmYTgwNzNkNjA3YzY1ZWRiZjAuLjE3OGY4YTIxYzBh OWNhNzA1M2U3NzQ1YThlZTZiYmZkYzg2NGVkMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtNTE3LDYgKzUx Nyw3IEBACiAjZGVmaW5lIFdURl9VU0VfQ0ZORVRXT1JLIDEKICNkZWZpbmUgV1RGX1VTRV9ORVRX T1JLX0NGREFUQV9BUlJBWV9DQUxMQkFDSyAxCiAjZGVmaW5lIFdURl9VU0VfV0VCX1RIUkVBRCAx CisjZGVmaW5lIFdURl9VU0VfUVVJQ0tfTE9PSyAxCiAKICNpZiBDUFUoQVJNNjQpCiAjZGVmaW5l IEVOQUJMRV9KSVRfQ09OU1RBTlRfQkxJTkRJTkcgMApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJW aWV3Lm1tCmluZGV4IDNkN2Y0YzViMzE0MjExZGU2ZTRiMTMzZDdlYmExMzE0MTA2OWVlZjQuLmZl NTMyMmNhOGVlZjE0M2FkYmI0NDQ2MWIwNjZkNTBjYzcyZGNiZTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYlZpZXcubW0KQEAgLTM2MzIsOCArMzYzMiw3IEBAIHN0YXRpYyBpbmxpbmUgSU1Q IGdldE1ldGhvZChpZCBvLCBTRUwgcykKICAgICByZXR1cm4gX3ByaXZhdGUtPnBhZ2UtPnNldERl ZmVyc0xvYWRpbmcoZGVmZXIpOwogfQogCi0jaWYgVEFSR0VUX09TX0lQSE9ORQotI2lmIFVTRShR VUlDS19MT09LKQorI2lmIFRBUkdFVF9PU19JUEhPTkUgJiYgVVNFKFFVSUNLX0xPT0spCiAtIChO U0RpY3Rpb25hcnkgKilxdWlja0xvb2tDb250ZW50Rm9yVVJMOihOU1VSTCAqKXVybAogewogICAg IE5TU3RyaW5nICp1dGkgPSBxbFByZXZpZXdDb252ZXJ0ZXJVVElGb3JVUkwodXJsKTsKQEAgLTM2 NDYsMTMgKzM2NDUsNiBAQCBzdGF0aWMgaW5saW5lIElNUCBnZXRNZXRob2QoaWQgbywgU0VMIHMp CiAKICAgICByZXR1cm4gW05TRGljdGlvbmFyeSBkaWN0aW9uYXJ5V2l0aE9iamVjdHNBbmRLZXlz OiBmaWxlTmFtZSwgV2ViUXVpY2tMb29rRmlsZU5hbWVLZXksIHV0aSwgV2ViUXVpY2tMb29rVVRJ S2V5LCBuaWxdOwogfQotI2Vsc2UKLS8vIEZJWE1FOiBVU0UoUVVJQ0tfTE9PSykgaXMgbm90IGRl ZmluZWQgZm9yIGlPUyBidXQgc2hvdWxkIGJlOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI2OTU0Ci0tIChOU0RpY3Rpb25hcnkgKilxdWlja0xvb2tDb250ZW50Rm9y VVJMOihOU1VSTCAqKXVybAotewotICAgIHJldHVybiBuaWw7Ci19Ci0jZW5kaWYKICNlbmRpZgog CiAjaWYgUExBVEZPUk0oSU9TKQo=