126947 2014-01-13 16:30:15 -0800 [WebGL] Crash due to forceLostContext 2014-01-13 16:57:01 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 104733 1 bfulgham bfulgham bfulgham commit-queue dino esprehn+autocc gyuyoung.kim kondapallykalyan roger_fong oldest_to_newest 967532 0 bfulgham 2014-01-13 16:30:15 -0800 When a frame containing a WebGL context is detached, the WebGL context receives a call to stopActiveDOMObjects, which results in the WebGLRenderingContext::stop() method being called. This causes the underlying OpenGL context to be destroyed. If this destruction takes place as part of the replacement of a node with new HTML, this "in-destruction" node can be asked to adjust its style as part of layout. This causes RenderLayerBacking::updateGraphicsLayerConfiguration() to attempt to use the underlying OpenGL context, causing a crash. The simplest resolution would be the following change: Index: html/canvas/WebGLRenderingContext.cpp =================================================================== --- html/canvas/WebGLRenderingContext.cpp (revision 161907) +++ html/canvas/WebGLRenderingContext.cpp (working copy) @@ -4733,7 +4733,7 @@ #if USE(ACCELERATED_COMPOSITING) PlatformLayer* WebGLRenderingContext::platformLayer() const { - return m_context->platformLayer(); + return (m_context) ? m_context->platformLayer() : 0; } #endif However, this additional null check for every "platformLayer()" access might be too expensive. 967546 1 bfulgham 2014-01-13 16:43:34 -0800 Test coverage in webgl/conformance/textures/origin-clean-conformance.html. 967547 2 bfulgham 2014-01-13 16:43:45 -0800 <rdar://problem/8622625> 967550 3 221089 bfulgham 2014-01-13 16:46:03 -0800 Created attachment 221089 Patch 967557 4 bfulgham 2014-01-13 16:57:01 -0800 Committed r161924: <http://trac.webkit.org/changeset/161924> 221089 2014-01-13 16:46:03 -0800 2014-01-13 16:47:44 -0800 Patch bug-126947-20140113164602.patch text/plain 2607 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTkyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTEzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJHTF0gQ3Jhc2ggZHVl IHRvIGZvcmNlTG9zdENvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNjk0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvdmVyZWQgYnkgd2ViZ2wvY29uZm9ybWFuY2UvdGV4dHVyZXMvb3JpZ2lu LWNsZWFuLWNvbmZvcm1hbmNlLmh0bWwuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250 ZXh0Ojppc0NvbnRleHRMb3N0KTogTWFrZSBjb25zdC4KKyAgICAgICAgKFdlYkNvcmU6OldlYkdM UmVuZGVyaW5nQ29udGV4dDo6cGxhdGZvcm1MYXllcik6IERvbid0IGF0dGVtcHQgdG8gdXNlCisg ICAgICAgIGEgbG9zdCBjb250ZXh0LgorICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVy aW5nQ29udGV4dC5oOiBpc0NvbnRleHRMb3N0IHNob3VsZCBiZSBjb25zdC4KKwogMjAxNC0wMS0x MyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S11bQ01ha2VdIFdlYkNvcmVQbGF0Zm9ybSBidWlsZCBjYW4gc29tZXRpbWVzIGZhaWwgZHVlIHRv IG1pc3NpbmcgZ2VuZXJhdGVkIGhlYWRlcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkocmV2aXNpb24gMTYxOTA3 KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzI4NSw3ICszMjg1LDcgQEAgR0MzRGJvb2xlYW4gV2ViR0xS ZW5kZXJpbmdDb250ZXh0Ojppc0J1ZgogICAgIHJldHVybiBtX2NvbnRleHQtPmlzQnVmZmVyKGJ1 ZmZlci0+b2JqZWN0KCkpOwogfQogCi1ib29sIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6aXNDb250 ZXh0TG9zdCgpCitib29sIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6aXNDb250ZXh0TG9zdCgpIGNv bnN0CiB7CiAgICAgcmV0dXJuIG1fY29udGV4dExvc3Q7CiB9CkBAIC00NzMzLDcgKzQ3MzMsNyBA QCB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Zm9yY2VSZXN0b3JlCiAjaWYgVVNFKEFDQ0VM RVJBVEVEX0NPTVBPU0lUSU5HKQogUGxhdGZvcm1MYXllciogV2ViR0xSZW5kZXJpbmdDb250ZXh0 OjpwbGF0Zm9ybUxheWVyKCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9jb250ZXh0LT5wbGF0Zm9y bUxheWVyKCk7CisgICAgcmV0dXJuICghaXNDb250ZXh0TG9zdCgpKSA/IG1fY29udGV4dC0+cGxh dGZvcm1MYXllcigpIDogMDsKIH0KICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaAkocmV2aXNpb24gMTYxOTA2 KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmgJ KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA5 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOSwg MjAxNCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRp b24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAg KiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMKQEAgLTE4Nyw3ICsxODcsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGhpbnQo R0MzRGVudW0gdGFyZ2V0LCBHQzNEZW51bSBtb2RlKTsKICAgICBHQzNEYm9vbGVhbiBpc0J1ZmZl cihXZWJHTEJ1ZmZlciopOwotICAgIGJvb2wgaXNDb250ZXh0TG9zdCgpOworICAgIGJvb2wgaXND b250ZXh0TG9zdCgpIGNvbnN0OwogICAgIEdDM0Rib29sZWFuIGlzRW5hYmxlZChHQzNEZW51bSBj YXApOwogICAgIEdDM0Rib29sZWFuIGlzRnJhbWVidWZmZXIoV2ViR0xGcmFtZWJ1ZmZlciopOwog ICAgIEdDM0Rib29sZWFuIGlzUHJvZ3JhbShXZWJHTFByb2dyYW0qKTsK