126933 2014-01-13 14:50:06 -0800 Update WebPageProxyIOS's user agent string 2014-01-13 19:48:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 967487 0 benjamin 2014-01-13 14:50:06 -0800 Update WebPageProxyIOS's user agent string 967488 1 221080 benjamin 2014-01-13 14:51:08 -0800 Created attachment 221080 Patch 967553 2 221080 darin 2014-01-13 16:50:06 -0800 Comment on attachment 221080 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221080&action=review > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51 > + return (NSString *)overrideUserAgent; I think you can remove that typecast. 967619 3 benjamin 2014-01-13 19:39:21 -0800 (In reply to comment #2) > (From update of attachment 221080 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221080&action=review > > > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51 > > + return (NSString *)overrideUserAgent; > > I think you can remove that typecast. Good catch. 967622 4 benjamin 2014-01-13 19:48:51 -0800 Committed r161940: <http://trac.webkit.org/changeset/161940> 221080 2014-01-13 14:51:08 -0800 2014-01-13 16:50:06 -0800 Patch bug-126933-20140113145107.patch text/plain 1878 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxOTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTAyMWU3YmYyM2NiNjdk MDUxYjY3YTg3OGQxMGM4NmQ4YTFjYTM0MC4uNWQzOWY3NjUwODk2YTc0NDA0MjFjOWUyY2YyZjgx YTVlNWE2YjZlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTEzICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBXZWJQ YWdlUHJveHlJT1MncyB1c2VyIGFnZW50IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5t bToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzdGFuZGFyZFVzZXJBZ2VudCk6Cisg ICAgICAgIFNlbmQgYSBtb3JlIHJlYXNvbmFibGUgdXNlciBhZ2VudC4gVGhlIHByZXZpb3VzIG9u ZSB3YXMgZm9yY2luZworICAgICAgICBpT1MgNS4xJ3MgaVBhZCB1c2VyLWFnZW50LgorCiAyMDE0 LTAxLTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbU09VUF0gQWRkIFNvdXBOZXR3b3JrU2Vzc2lvbiBjbGFzcyB0byB3cmFwIGEgU291cFNl c3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVBy b3h5SU9TLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1Mu bW0KaW5kZXggNGEyZjFhZTc0ZWE1MzQ4Mjk2YWYzYzAzMDUwOWRmMDI2MGEzNzFmZS4uMWU2ZTQ1 ZWM2MDUzMmZmMTJkZWMyOWEyNjU2YjQ5MmI2OTYyYWIzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KQEAgLTQ3LDEwICs0NywxMyBAQCB2 b2lkIFdlYlBhZ2VQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplKCkKIAogU3RyaW5nIFdlYlBhZ2VQ cm94eTo6c3RhbmRhcmRVc2VyQWdlbnQoY29uc3QgU3RyaW5nJikKIHsKKyAgICBpZiAoQ0ZTdHJp bmdSZWYgb3ZlcnJpZGVVc2VyQWdlbnQgPSBXS0dldFVzZXJBZ2VudCgpKQorICAgICAgICByZXR1 cm4gKE5TU3RyaW5nICopb3ZlcnJpZGVVc2VyQWdlbnQ7CisKICAgICBub3RJbXBsZW1lbnRlZCgp OwogCi0gICAgLy8gSnVzdCByZXR1cm4gdGhlIGlPUyA1LjEgdXNlciBhZ2VudCBmb3Igbm93Lgot ICAgIHJldHVybiAiTW96aWxsYS81LjAgKGlQYWQ7IENQVSBPUyA1XzEgbGlrZSBNYWMgT1MgWCkg QXBwbGVXZWJLaXQvNTM0LjQ2IChLSFRNTCwgbGlrZSBHZWNrbykgVmVyc2lvbi81LjEgTW9iaWxl LzlCMTc2IFNhZmFyaS83NTM0LjQ4LjMiOworICAgIC8vIEp1c3QgcmV0dXJuIHRoZSBpT1MgNyB1 c2VyIGFnZW50IGZvciBub3cuCisgICAgcmV0dXJuIFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0 OkAiTW96aWxsYS81LjAgKCVAOyBDUFUgJUAgN18wXzIgbGlrZSBNYWMgT1MgWCkgQXBwbGVXZWJL aXQvNTM3LjUxLjEgKEtIVE1MLCBsaWtlIEdlY2tvKSBWZXJzaW9uLzcuMCBNb2JpbGUvMTFCNDg5 IFNhZmFyaS85NTM3LjUzIiwgV0tHZXREZXZpY2VOYW1lKCksIFdLR2V0T1NOYW1lRm9yVXNlckFn ZW50KCldOwogfQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6Z2V0SXNTcGVha2luZyhib29sJikK