126924 2014-01-13 11:53:25 -0800 Add uint8_t specialization for WebCore::writeLittleEndian() 2014-01-13 12:52:02 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates aestes alecflett commit-queue darin ddkilzer fpizlo ggaren jsbell mhahnenberg oliver oldest_to_newest 967434 0 dbates 2014-01-13 11:53:25 -0800 When I ran Tools/Scripts/build-webkit --debug --device, the build failed to compile SerializedScriptValue.cpp with the following error: /OpenSource/Source/WebCore/bindings/js/SerializedScriptValue.cpp:421:19: error: shift count >= width of type [-Werror,-Wshift-count-overflow] /OpenSource/Source/WebCore/bindings/js/SerializedScriptValue.cpp:967:9: note: in instantiation of function template specialization 'WebCore::writeLittleEndian<unsigned char>' requested here 1 error generated. 967435 1 221069 dbates 2014-01-13 11:54:13 -0800 Created attachment 221069 Patch 967436 2 221069 darin 2014-01-13 11:58:52 -0800 Comment on attachment 221069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221069&action=review > Source/WebCore/bindings/js/SerializedScriptValue.cpp:431 > + if (length > std::numeric_limits<uint32_t>::max()) > + return false; This can’t happen. A uint32_t can’t be higher than the maximum. 967437 3 221070 dbates 2014-01-13 12:01:16 -0800 Created attachment 221070 Patch 967438 4 dbates 2014-01-13 12:02:22 -0800 (In reply to comment #2) > (From update of attachment 221069 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221069&action=review > > > Source/WebCore/bindings/js/SerializedScriptValue.cpp:431 > > + if (length > std::numeric_limits<uint32_t>::max()) > > + return false; > > This can’t happen. A uint32_t can’t be higher than the maximum. You're right! I removed this conditional. 967456 5 dbates 2014-01-13 12:52:02 -0800 Committed r161903: <http://trac.webkit.org/changeset/161903> 221069 2014-01-13 11:54:13 -0800 2014-01-13 12:01:13 -0800 Patch bug-126924-20140113115413.patch text/plain 1721 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRmMWMyYmZkZWIxNDMy NWRkMDQ4ZDczMWU3MGJjOTcyZWUzY2ZiZC4uYzEyZDEwNDY4NDgwMTZjNWZlOWZjZDExODIyNTdk MWIzMzEyY2JmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTEzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgdWludDhfdCBzcGVj aWFsaXphdGlvbiBmb3IgV2ViQ29yZTo6d3JpdGVMaXR0bGVFbmRpYW4oKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTI0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlY2lhbGl6ZSBXZWJDb3JlOjp3 cml0ZUxpdHRsZUVuZGlhbigpIGZvciBkYXRhdHlwZSB1aW50OF90IHNvIGFzIHRvIGF2b2lkCisg ICAgICAgIGEgY29tcGlsZXIgd2FybmluZyB3aGVuIHJpZ2h0IHNoaWZ0aW5nIGEgdWludDhfdCBi eSA4IGJlY2F1c2UgdGhlIHJlc3VsdCBvZgorICAgICAgICBzdWNoIGEgY29tcHV0YXRpb24gaXMg dW5kZWZpbmVkLgorCisgICAgICAgICogYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndyaXRlTGl0dGxlRW5kaWFuPHVpbnQ4X3Q+KTogQWRk ZWQuCisKIDIwMTQtMDEtMTMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IHRoZSBidWlsZCBtb3JlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggMWZkMDY0MDVlMzI4MDg1 YTQzOWJkNDkzMjNhM2JiNWMzMmM0ZTgzZC4uYWQ0Zjk0MjYzYzhmZTI4YTY4MjUzMjFjZjdjNTkz ODgxZmI3NDlkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFs aXplZFNjcmlwdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJp YWxpemVkU2NyaXB0VmFsdWUuY3BwCkBAIC00MjUsNiArNDI1LDE1IEBAIHRlbXBsYXRlIDx0eXBl bmFtZSBUPiBzdGF0aWMgYm9vbCB3cml0ZUxpdHRsZUVuZGlhbihWZWN0b3I8dWludDhfdD4mIGJ1 ZmZlciwgY29uCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK3RlbXBsYXRlIDw+IGJvb2wgd3JpdGVM aXR0bGVFbmRpYW48dWludDhfdD4oVmVjdG9yPHVpbnQ4X3Q+JiBidWZmZXIsIGNvbnN0IHVpbnQ4 X3QqIHZhbHVlcywgdWludDMyX3QgbGVuZ3RoKQoreworICAgIGlmIChsZW5ndGggPiBzdGQ6Om51 bWVyaWNfbGltaXRzPHVpbnQzMl90Pjo6bWF4KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwor ICAgIGJ1ZmZlci5hcHBlbmQodmFsdWVzLCBsZW5ndGgpOworICAgIHJldHVybiB0cnVlOworfQor CiBjbGFzcyBDbG9uZVNlcmlhbGl6ZXIgOiBDbG9uZUJhc2UgewogcHVibGljOgogICAgIHN0YXRp YyBTZXJpYWxpemF0aW9uUmV0dXJuQ29kZSBzZXJpYWxpemUoRXhlY1N0YXRlKiBleGVjLCBKU1Zh bHVlIHZhbHVlLAo= 221070 2014-01-13 12:01:16 -0800 2014-01-13 12:38:48 -0800 Patch bug-126924-20140113120116.patch text/plain 1640 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRmMWMyYmZkZWIxNDMy NWRkMDQ4ZDczMWU3MGJjOTcyZWUzY2ZiZC4uYzEyZDEwNDY4NDgwMTZjNWZlOWZjZDExODIyNTdk MWIzMzEyY2JmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTEzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgdWludDhfdCBzcGVj aWFsaXphdGlvbiBmb3IgV2ViQ29yZTo6d3JpdGVMaXR0bGVFbmRpYW4oKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2OTI0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlY2lhbGl6ZSBXZWJDb3JlOjp3 cml0ZUxpdHRsZUVuZGlhbigpIGZvciBkYXRhdHlwZSB1aW50OF90IHNvIGFzIHRvIGF2b2lkCisg ICAgICAgIGEgY29tcGlsZXIgd2FybmluZyB3aGVuIHJpZ2h0IHNoaWZ0aW5nIGEgdWludDhfdCBi eSA4IGJlY2F1c2UgdGhlIHJlc3VsdCBvZgorICAgICAgICBzdWNoIGEgY29tcHV0YXRpb24gaXMg dW5kZWZpbmVkLgorCisgICAgICAgICogYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndyaXRlTGl0dGxlRW5kaWFuPHVpbnQ4X3Q+KTogQWRk ZWQuCisKIDIwMTQtMDEtMTMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IHRoZSBidWlsZCBtb3JlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggMWZkMDY0MDVlMzI4MDg1 YTQzOWJkNDkzMjNhM2JiNWMzMmM0ZTgzZC4uNjk2OGEyOTA1YTliMDJiYzY5NzcyOTYwNDZiOWZh MGU2MGU0NzAzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFs aXplZFNjcmlwdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJp YWxpemVkU2NyaXB0VmFsdWUuY3BwCkBAIC00MjUsNiArNDI1LDEyIEBAIHRlbXBsYXRlIDx0eXBl bmFtZSBUPiBzdGF0aWMgYm9vbCB3cml0ZUxpdHRsZUVuZGlhbihWZWN0b3I8dWludDhfdD4mIGJ1 ZmZlciwgY29uCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK3RlbXBsYXRlIDw+IGJvb2wgd3JpdGVM aXR0bGVFbmRpYW48dWludDhfdD4oVmVjdG9yPHVpbnQ4X3Q+JiBidWZmZXIsIGNvbnN0IHVpbnQ4 X3QqIHZhbHVlcywgdWludDMyX3QgbGVuZ3RoKQoreworICAgIGJ1ZmZlci5hcHBlbmQodmFsdWVz LCBsZW5ndGgpOworICAgIHJldHVybiB0cnVlOworfQorCiBjbGFzcyBDbG9uZVNlcmlhbGl6ZXIg OiBDbG9uZUJhc2UgewogcHVibGljOgogICAgIHN0YXRpYyBTZXJpYWxpemF0aW9uUmV0dXJuQ29k ZSBzZXJpYWxpemUoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHZhbHVlLAo=