<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126916</bug_id>
          
          <creation_ts>2014-01-13 10:11:03 -0800</creation_ts>
          <short_desc>r161638 broke the Windows build</short_desc>
          <delta_ts>2014-01-13 12:33:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>126698</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>dbates</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>ossy</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>967385</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-01-13 10:11:03 -0800</bug_when>
    <thetext>Apple Windows build is broken after a clean build triggered with the following error:

     1&gt;c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\bindings\js\JSDocumentCustom.cpp(34): fatal error C1083: Cannot open include file: &apos;JSTouch.h&apos;: No such file or directory (..\bindings\js\JSBindingsAllInOne.cpp)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967393</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-01-13 10:32:00 -0800</bug_when>
    <thetext>The culprit is between r161565 - r161638, because Touch.idl was
processed at r161565, but not on r161638.

I assume r161638 is the culprit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967402</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-01-13 10:42:31 -0800</bug_when>
    <thetext>fix is coming</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967411</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-01-13 10:55:46 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; fix is coming

As I mentioned in https://bugs.webkit.org/show_bug.cgi?id=126698#c15
the mentioned idl files should be added for non IOS platforms, but
after r161638 they are added if MACOS and !IOS.

I don&apos;t have Windows to validate a fix and Windows EWS bots are out
of order, so I&apos;m not going to fix it blindly with GNU makefile magic.
Feel free to pick it up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967450</commentid>
    <comment_count>4</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-01-13 12:33:59 -0800</bug_when>
    <thetext>Fixed in http://trac.webkit.org/changeset/161901</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>