126901 2014-01-13 07:49:49 -0800 Performance regression on dromaeo due to generational marking 2015-10-06 18:21:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue koivisto oldest_to_newest 967306 0 mhahnenberg 2014-01-13 07:49:49 -0800 Generational marking is off in ToT, but some of the machinery to make it work isn't fully disabled which is causing regressions on dromaeo. We should disable more things to get to a point where the patch is no regression when ENABLE_GGC == 0 because it would be nice to have the option to disable generational collection for diagnosing any potential GGC bugs. 967461 1 221075 mhahnenberg 2014-01-13 12:58:26 -0800 Created attachment 221075 Patch 967492 2 mhahnenberg 2014-01-13 15:11:52 -0800 I ran dromaeo and it looks like this patch fixes the obvious regressions. 967512 3 221075 commit-queue 2014-01-13 15:46:51 -0800 Comment on attachment 221075 Patch Clearing flags on attachment: 221075 Committed r161914: <http://trac.webkit.org/changeset/161914> 967513 4 commit-queue 2014-01-13 15:46:52 -0800 All reviewed patches have been landed. Closing bug. 1131186 5 joepeck 2015-10-06 18:21:09 -0700 *** Bug 126902 has been marked as a duplicate of this bug. *** 221075 2014-01-13 12:58:26 -0800 2014-01-13 15:46:50 -0800 Patch bug-126901-20140113125827.patch text/plain 5690 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxOTAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE0LTAxLTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUGVyZm9ybWFuY2UgcmVncmVzc2lvbiBvbiBkcm9tYWVvIGR1ZSB0byBnZW5lcmF0 aW9uYWwgbWFya2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI2OTAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2Ugd2VyZSBzZWVpbmcgc29tZSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIHdpdGggRU5B QkxFX0dHQyA9PSAwLCBzbyB0aGlzIHBhdGNoCisgICAgICAgIGlmZGVmcyBvdXQgbW9yZSB0aGlu Z3MgdG8gZ2V0IHJpZCBvZiB0aGUgYWRkaXRpb25hbCBvdmVyaGVhZC4KKworICAgICAgICAqIGhl YXAvSGVhcC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6Om1hcmtSb290cyk6CisgICAgICAgIChK U0M6OkhlYXA6OndyaXRlQmFycmllcik6CisgICAgICAgICogaGVhcC9NYXJrZWRCbG9jay5jcHA6 CisgICAgICAgIChKU0M6Ok1hcmtlZEJsb2NrOjpjbGVhck1hcmtzKToKKyAgICAgICAgKEpTQzo6 TWFya2VkQmxvY2s6OmNsZWFyTWFya3NXaXRoQ29sbGVjdGlvblR5cGUpOgorICAgICAgICAqIGhl YXAvTWFya2VkU3BhY2UuY3BwOgorICAgICAgICAoSlNDOjpNYXJrZWRTcGFjZTo6cmVzZXRBbGxv Y2F0b3JzKToKKyAgICAgICAgKiBoZWFwL01hcmtlZFNwYWNlLmg6CisgICAgICAgIChKU0M6Ok1h cmtlZFNwYWNlOjpkaWRBbGxvY2F0ZUluQmxvY2spOgorICAgICAgICAqIGhlYXAvU2xvdFZpc2l0 b3JJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OlNsb3RWaXNpdG9yOjppbnRlcm5hbEFwcGVuZCk6 CisgICAgICAgIChKU0M6OlNsb3RWaXNpdG9yOjpyZXBvcnRFeHRyYU1lbW9yeVVzYWdlKToKKwog MjAxNC0wMS0xMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBwcm90b2NvbCBnZW5lcmF0b3Igc2hvdWxkIHN1cHBvcnQgaW50ZWdlci10eXBl ZCBkZWNsYXJhdGlvbnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCShyZXZp c2lvbiAxNjE4ODYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDg5LDggKzQ4OSwxMCBAQCB2b2lkIEhlYXA6Om1hcmtSb290cygpCiAg ICAgdmlzaXRvci5zZXR1cCgpOwogICAgIEhlYXBSb290VmlzaXRvciBoZWFwUm9vdFZpc2l0b3Io dmlzaXRvcik7CiAKKyNpZiBFTkFCTEUoR0dDKQogICAgIFZlY3Rvcjxjb25zdCBKU0NlbGwqPiBy ZW1lbWJlcmVkU2V0KG1fc2xvdFZpc2l0b3IubWFya1N0YWNrKCkuc2l6ZSgpKTsKICAgICBtX3Ns b3RWaXNpdG9yLm1hcmtTdGFjaygpLmZpbGxWZWN0b3IocmVtZW1iZXJlZFNldCk7CisjZW5kaWYK IAogICAgIHsKICAgICAgICAgUGFyYWxsZWxNb2RlRW5hYmxlciBlbmFibGVyKHZpc2l0b3IpOwpA QCAtNTk1LDYgKzU5Nyw3IEBAIHZvaWQgSGVhcDo6bWFya1Jvb3RzKCkKICAgICAgICAgfQogICAg IH0KIAorI2lmIEVOQUJMRShHR0MpCiAgICAgewogICAgICAgICBHQ1BIQVNFKENsZWFyUmVtZW1i ZXJlZFNldCk7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCByZW1lbWJlcmVkU2V0 LnNpemUoKTsgKytpKSB7CkBAIC02MDIsNiArNjA1LDcgQEAgdm9pZCBIZWFwOjptYXJrUm9vdHMo KQogICAgICAgICAgICAgTWFya2VkQmxvY2s6OmJsb2NrRm9yKGNlbGwpLT5jbGVhclJlbWVtYmVy ZWQoY2VsbCk7CiAgICAgICAgIH0KICAgICB9CisjZW5kaWYKIAogICAgIEdDQ09VTlRFUihWaXNp dGVkVmFsdWVDb3VudCwgdmlzaXRvci52aXNpdENvdW50KCkpOwogCkBAIC0xMDc2LDExICsxMDgw LDE1IEBAIHZvaWQgSGVhcDo6ZGVjcmVtZW50RGVmZXJyYWxEZXB0aEFuZEdDSWYKIAogdm9pZCBI ZWFwOjp3cml0ZUJhcnJpZXIoY29uc3QgSlNDZWxsKiBmcm9tKQogeworI2lmIEVOQUJMRShHR0Mp CiAgICAgQVNTRVJUX0dDX09CSkVDVF9MT09LU19WQUxJRChjb25zdF9jYXN0PEpTQ2VsbCo+KGZy b20pKTsKICAgICBpZiAoIWZyb20gfHwgIWlzTWFya2VkKGZyb20pKQogICAgICAgICByZXR1cm47 CiAgICAgSGVhcCogaGVhcCA9IEhlYXA6OmhlYXAoZnJvbSk7CiAgICAgaGVhcC0+YWRkVG9SZW1l bWJlcmVkU2V0KGZyb20pOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZnJvbSk7CisjZW5kaWYK IH0KIAogdm9pZCBIZWFwOjpmbHVzaFdyaXRlQmFycmllckJ1ZmZlcihKU0NlbGwqIGNlbGwpCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suY3BwCShyZXZpc2lv biAxNjE4ODYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE5OSwxMCArMTk5LDE0IEBAIHZvaWQgTWFya2VkQmxvY2s6OnN0 b3BBbGxvY2F0aW5nKGNvbnN0IEYKIAogdm9pZCBNYXJrZWRCbG9jazo6Y2xlYXJNYXJrcygpCiB7 CisjaWYgRU5BQkxFKEdHQykKICAgICBpZiAoaGVhcCgpLT5vcGVyYXRpb25JblByb2dyZXNzKCkg PT0gSlNDOjpFZGVuQ29sbGVjdGlvbikKICAgICAgICAgdGhpcy0+Y2xlYXJNYXJrc1dpdGhDb2xs ZWN0aW9uVHlwZTxFZGVuQ29sbGVjdGlvbj4oKTsKICAgICBlbHNlCiAgICAgICAgIHRoaXMtPmNs ZWFyTWFya3NXaXRoQ29sbGVjdGlvblR5cGU8RnVsbENvbGxlY3Rpb24+KCk7CisjZWxzZQorICAg IHRoaXMtPmNsZWFyTWFya3NXaXRoQ29sbGVjdGlvblR5cGU8RnVsbENvbGxlY3Rpb24+KCk7Cisj ZW5kaWYKIH0KIAogdm9pZCBNYXJrZWRCbG9jazo6Y2xlYXJSZW1lbWJlcmVkU2V0KCkKQEAgLTIx OSw3ICsyMjMsOSBAQCB2b2lkIE1hcmtlZEJsb2NrOjpjbGVhck1hcmtzV2l0aENvbGxlY3RpCiAg ICAgQVNTRVJUKG1fc3RhdGUgIT0gTmV3ICYmIG1fc3RhdGUgIT0gRnJlZUxpc3RlZCk7CiAgICAg aWYgKGNvbGxlY3Rpb25UeXBlID09IEZ1bGxDb2xsZWN0aW9uKSB7CiAgICAgICAgIG1fbWFya3Mu Y2xlYXJBbGwoKTsKKyNpZiBFTkFCTEUoR0dDKQogICAgICAgICBtX3JlbWVtYmVyZWRTZXQuY2xl YXJBbGwoKTsKKyNlbmRpZgogICAgIH0KIAogICAgIC8vIFRoaXMgd2lsbCBiZWNvbWUgdHJ1ZSBh dCB0aGUgZW5kIG9mIHRoZSBtYXJrIHBoYXNlLiBXZSBzZXQgaXQgbm93IHRvCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRTcGFjZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkU3BhY2UuY3BwCShyZXZpc2lvbiAxNjE4ODYp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRTcGFjZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTE0NSw3ICsxNDUsOSBAQCB2b2lkIE1hcmtlZFNwYWNlOjpyZXNldEFsbG9jYXRv cnMoKQogICAgIG1fbm9ybWFsRGVzdHJ1Y3RvclNwYWNlLmxhcmdlQWxsb2NhdG9yLnJlc2V0KCk7 CiAgICAgbV9pbW1vcnRhbFN0cnVjdHVyZURlc3RydWN0b3JTcGFjZS5sYXJnZUFsbG9jYXRvci5y ZXNldCgpOwogCisjaWYgRU5BQkxFKEdHQykKICAgICBtX2Jsb2Nrc1dpdGhOZXdPYmplY3RzLmNs ZWFyKCk7CisjZW5kaWYKIH0KIAogdm9pZCBNYXJrZWRTcGFjZTo6dmlzaXRXZWFrU2V0cyhIZWFw Um9vdFZpc2l0b3ImIGhlYXBSb290VmlzaXRvcikKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL01hcmtlZFNwYWNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvTWFya2VkU3BhY2UuaAkocmV2aXNpb24gMTYxODg2KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvTWFya2VkU3BhY2UuaAkod29ya2luZyBjb3B5KQpAQCAtMjc3LDcgKzI3Nywx MSBAQCBpbmxpbmUgdm9pZCBNYXJrZWRTcGFjZTo6ZGlkQWRkQmxvY2soTWFyCiAKIGlubGluZSB2 b2lkIE1hcmtlZFNwYWNlOjpkaWRBbGxvY2F0ZUluQmxvY2soTWFya2VkQmxvY2sqIGJsb2NrKQog eworI2lmIEVOQUJMRShHR0MpCiAgICAgbV9ibG9ja3NXaXRoTmV3T2JqZWN0cy5hcHBlbmQoYmxv Y2spOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oYmxvY2spOworI2VuZGlmCiB9CiAKIGlubGlu ZSB2b2lkIE1hcmtlZFNwYWNlOjpjbGVhclJlbWVtYmVyZWRTZXQoKQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvU2xvdFZpc2l0b3JJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU2xvdFZpc2l0b3JJbmxpbmVzLmgJKHJldmlzaW9uIDE2 MTg4NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1Nsb3RWaXNpdG9ySW5saW5lcy5o CSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsNyArMTAxLDYgQEAgQUxXQVlTX0lOTElORSB2b2lkIFNs b3RWaXNpdG9yOjppbnRlcm5hbAogICAgICAgICByZXR1cm47CiAKICAgICBtX2J5dGVzVmlzaXRl ZCArPSBNYXJrZWRCbG9jazo6YmxvY2tGb3IoY2VsbCktPmNlbGxTaXplKCk7Ci0gICAgbV92aXNp dENvdW50Kys7CiAgICAgICAgIAogICAgIE1BUktfTE9HX0NISUxEKCp0aGlzLCBjZWxsKTsKIApA QCAtMjQyLDkgKzI0MSwxMyBAQCBpbmxpbmUgdm9pZCBTbG90VmlzaXRvcjo6Y29weUxhdGVyKEpT Q2VsCiAgICAgCiBpbmxpbmUgdm9pZCBTbG90VmlzaXRvcjo6cmVwb3J0RXh0cmFNZW1vcnlVc2Fn ZShKU0NlbGwqIG93bmVyLCBzaXplX3Qgc2l6ZSkKIHsKKyNpZiBFTkFCTEUoR0dDKQogICAgIC8v IFdlIGRvbid0IHdhbnQgdG8gZG91YmxlLWNvdW50IHRoZSBleHRyYSBtZW1vcnkgdGhhdCB3YXMg cmVwb3J0ZWQgaW4gcHJldmlvdXMgY29sbGVjdGlvbnMuCiAgICAgaWYgKGhlYXAoKS0+b3BlcmF0 aW9uSW5Qcm9ncmVzcygpID09IEVkZW5Db2xsZWN0aW9uICYmIE1hcmtlZEJsb2NrOjpibG9ja0Zv cihvd25lciktPmlzUmVtZW1iZXJlZChvd25lcikpCiAgICAgICAgIHJldHVybjsKKyNlbHNlCisg ICAgVU5VU0VEX1BBUkFNKG93bmVyKTsKKyNlbmRpZgogCiAgICAgc2l6ZV90KiBjb3VudGVyID0g Jm1fc2hhcmVkLm1fdm0tPmhlYXAubV9leHRyYU1lbW9yeVVzYWdlOwogICAgIAo=