126898 2014-01-13 07:36:01 -0800 Subpixel layout: -webkit-flex pushes content off of-by-one pixel. 2022-02-15 17:19:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=236680 InRadar P2 Normal --- 126283 1 zalan zalan changseok esprehn+autocc ews-watchlist glenn jbedard jonlee kondapallykalyan pdr rbuis webkit-bug-importer oldest_to_newest 967301 0 zalan 2014-01-13 07:36:01 -0800 LayoutTests/css3/flexbox/image-percent-max-height.html 968573 1 zalan 2014-01-15 20:05:23 -0800 The flexbox layout ends up with different value for the available space (compared to the default layout flow) -> centering the content results in different x pos. 968577 2 zalan 2014-01-15 20:21:46 -0800 this double rounding is probably unnecessary. The reason why it works when subpixel is off is in that case both layout paths round, one is explicitly while the other is implicitly (due to using only integral px positions). diff --git a/Source/WebCore/rendering/RenderReplaced.cpp b/Source/WebCore/rendering/RenderReplaced.cpp index d81b6cb..c0dc7a4 100644 --- a/Source/WebCore/rendering/RenderReplaced.cpp +++ b/Source/WebCore/rendering/RenderReplaced.cpp @@ -388,7 +388,7 @@ LayoutUnit RenderReplaced::computeReplacedLogicalWidth(ShouldComputePreferred sh // of 'width' is: (used height) * (intrinsic ratio) if (intrinsicRatio && ((heightIsAuto && !hasIntrinsicWidth && hasIntrinsicHeight) || !heightIsAuto)) { LayoutUnit logicalHeight = computeReplacedLogicalHeight(); - return computeReplacedLogicalWidthRespectingMinMaxWidth(roundToInt(round(logicalHeight * intrinsicRatio)), shouldComputePreferred); + return computeReplacedLogicalWidthRespectingMinMaxWidth(logicalHeight * intrinsicRatio, shouldComputePreferred); } 969668 3 zalan 2014-01-19 17:59:00 -0800 <rdar://problem/15855716> 1315425 4 jbedard 2017-06-03 08:27:10 -0700 This is only an issue in simulators, this test passes on device. Moved the expectation in <https://trac.webkit.org/changeset/217757/webkit>. 1746460 5 425009 rbuis 2021-04-02 05:18:03 -0700 Created attachment 425009 Patch 425009 2021-04-02 05:18:03 -0700 2021-04-02 06:51:31 -0700 Patch bug-126898-20210402141801.patch text/plain 1846 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjMyMDQ1YTI3ZTFjYTZi ZDk3MjdhNzQxMTFhOTk0ZjBkNGVmYjQ2Zi4uZmY4YjNmOTMxZWJkYzYzMmE1YzgwN2QzN2I2YjE5 YTlmMTNlZmE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA0LTAyICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgbGF5b3V0OiAtd2Vi a2l0LWZsZXggcHVzaGVzIGNvbnRlbnQgb2ZmIG9mLWJ5LW9uZSBwaXhlbC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjg5OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdJUC4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJSZXBsYWNlZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXNvbHZlV2lk dGhGb3JSYXRpbyk6CisKIDIwMjEtMDQtMDIgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2ODE3Nik6IFtHU3RyZWFtZXJdIG1l ZGlhL3ZpZGVvLW9yaWVudGF0aW9uLWNhbnZhcy5odG1sIGZhaWxzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcAppbmRleCA2ZmY0NjcwNDQ0YWY0OTUyOTFlNDM1 OTBlYzEwNjhjYzg3MzYzMzkyLi5hNzU5OGI3YzAxODgwNjNlNWEyYzljZjdlYzQ3YTA1Mjg2ZmUx MDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBsYWNlZC5jcHAKQEAg LTUzNSw4ICs1MzUsOCBAQCBMYXlvdXRVbml0IFJlbmRlclJlcGxhY2VkOjpjb21wdXRlQ29uc3Ry YWluZWRMb2dpY2FsV2lkdGgoU2hvdWxkQ29tcHV0ZVByZWZlcnJlZAogc3RhdGljIGlubGluZSBM YXlvdXRVbml0IHJlc29sdmVXaWR0aEZvclJhdGlvKExheW91dFVuaXQgYm9yZGVyQW5kUGFkZGlu Z0xvZ2ljYWxIZWlnaHQsIExheW91dFVuaXQgYm9yZGVyQW5kUGFkZGluZ0xvZ2ljYWxXaWR0aCwg TGF5b3V0VW5pdCBsb2dpY2FsSGVpZ2h0LCBkb3VibGUgYXNwZWN0UmF0aW8sIEJveFNpemluZyBi b3hTaXppbmcpCiB7CiAgICAgaWYgKGJveFNpemluZyA9PSBCb3hTaXppbmc6OkJvcmRlckJveCkK LSAgICAgICAgcmV0dXJuIExheW91dFVuaXQocm91bmQoKGxvZ2ljYWxIZWlnaHQgKyBib3JkZXJB bmRQYWRkaW5nTG9naWNhbEhlaWdodCkgKiBhc3BlY3RSYXRpbykpIC0gYm9yZGVyQW5kUGFkZGlu Z0xvZ2ljYWxXaWR0aDsKLSAgICByZXR1cm4gTGF5b3V0VW5pdChyb3VuZChsb2dpY2FsSGVpZ2h0 ICogYXNwZWN0UmF0aW8pKTsKKyAgICAgICAgcmV0dXJuIExheW91dFVuaXQoKGxvZ2ljYWxIZWln aHQgKyBib3JkZXJBbmRQYWRkaW5nTG9naWNhbEhlaWdodCkgKiBhc3BlY3RSYXRpbykgLSBib3Jk ZXJBbmRQYWRkaW5nTG9naWNhbFdpZHRoOworICAgIHJldHVybiBMYXlvdXRVbml0KGxvZ2ljYWxI ZWlnaHQgKiBhc3BlY3RSYXRpbyk7CiB9CiAKIExheW91dFVuaXQgUmVuZGVyUmVwbGFjZWQ6OmNv bXB1dGVSZXBsYWNlZExvZ2ljYWxXaWR0aChTaG91bGRDb21wdXRlUHJlZmVycmVkIHNob3VsZENv bXB1dGVQcmVmZXJyZWQpIGNvbnN0Cg==