126881 2014-01-13 02:57:19 -0800 [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser 2014-01-13 03:46:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez webkit-unassigned andersca cgarcia commit-queue mrobinson oldest_to_newest 967227 0 aperez 2014-01-13 02:57:19 -0800 [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser 967228 1 221021 aperez 2014-01-13 02:59:44 -0800 Created attachment 221021 Patch 967230 2 221021 cgarcia 2014-01-13 03:04:47 -0800 Comment on attachment 221021 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221021&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:710 > - g_object_add_weak_pointer(G_OBJECT(parent), &window->parentWindow); > + g_object_add_weak_pointer(G_OBJECT(parent), (gpointer*) &window->parentWindow); Add a space between the gpointer and the * and remove the space between the parentheses and the & g_object_add_weak_pointer(G_OBJECT(parent), (gpointer *)&window->parentWindow); 967231 3 221023 aperez 2014-01-13 03:11:36 -0800 Created attachment 221023 Patch 967236 4 221023 commit-queue 2014-01-13 03:46:51 -0800 Comment on attachment 221023 Patch Clearing flags on attachment: 221023 Committed r161875: <http://trac.webkit.org/changeset/161875> 967237 5 commit-queue 2014-01-13 03:46:52 -0800 All reviewed patches have been landed. Closing bug. 221021 2014-01-13 02:59:44 -0800 2014-01-13 03:11:22 -0800 Patch bug-126881-20140113130007.patch text/plain 1437 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjYzNmI4ODE4MDkxZGM3ZTgwZGU3ZWNkMWY3N2MxZWQz MjQzMWQzMy4uODdjY2FiYjFhNWNhMGIzYzIzYmFhYmQ0MWY5ZDljNzk4NjNhZGQ4NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTAxLTEzICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gQWRkIGNhc3QgaW4gY2FsbCB0byBnX29iamVjdF9hZGRfd2Vh a19wb2ludGVyIGluIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjY4ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAg ICAgIChicm93c2VyX3dpbmRvd19uZXcpOgorICAgICAgICBFeHBsaWNpdGx5IGNhc3QgR3RrV2lu ZG93KiogdG8gZ3BvaW50ZXIqIGluIGNhbGwgdG8KKyAgICAgICAgZ19vYmplY3RfYWRkX3dlYWtf cG9pbnRlciB0byBhdm9pZCBjb21waWxlciB3YXJuaW5ncy4KKwogMjAxNC0wMS0xMyAgUGV0ZXIg TW9sbmFyICA8cG1vbG5hci51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAgICAg IFJlbW92ZSBwYXJzaW5nIG9mIG9sZC1ydW4td2Via2l0LXRlc3RzIG91dHB1dCBmcm9tIG1hc3Rl ci5jZmcKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMg Yi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IDlhMDM5ZGVjZjRh NjRlNTA4MGVlNTY5Yzk5NGQzNWE1N2E0MWM0N2UuLjU1MTI4ZWZkYjgxZDAwZDEyM2IxYjliM2Rh OTQ3MjI3ZmM3MGEwNjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAt NzA3LDcgKzcwNyw3IEBAIEd0a1dpZGdldCAqYnJvd3Nlcl93aW5kb3dfbmV3KFdlYktpdFdlYlZp ZXcgKnZpZXcsIEd0a1dpbmRvdyAqcGFyZW50KQogCiAgICAgaWYgKHBhcmVudCkgewogICAgICAg ICB3aW5kb3ctPnBhcmVudFdpbmRvdyA9IHBhcmVudDsKLSAgICAgICAgZ19vYmplY3RfYWRkX3dl YWtfcG9pbnRlcihHX09CSkVDVChwYXJlbnQpLCAmd2luZG93LT5wYXJlbnRXaW5kb3cpOworICAg ICAgICBnX29iamVjdF9hZGRfd2Vha19wb2ludGVyKEdfT0JKRUNUKHBhcmVudCksIChncG9pbnRl ciopICZ3aW5kb3ctPnBhcmVudFdpbmRvdyk7CiAgICAgfQogCiAgICAgcmV0dXJuIEdUS19XSURH RVQod2luZG93KTsK 221023 2014-01-13 03:11:36 -0800 2014-01-13 03:46:50 -0800 Patch bug-126881-20140113131200.patch text/plain 1437 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjYzNmI4ODE4MDkxZGM3ZTgwZGU3ZWNkMWY3N2MxZWQz MjQzMWQzMy4uODdjY2FiYjFhNWNhMGIzYzIzYmFhYmQ0MWY5ZDljNzk4NjNhZGQ4NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTAxLTEzICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gQWRkIGNhc3QgaW4gY2FsbCB0byBnX29iamVjdF9hZGRfd2Vh a19wb2ludGVyIGluIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjY4ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAg ICAgIChicm93c2VyX3dpbmRvd19uZXcpOgorICAgICAgICBFeHBsaWNpdGx5IGNhc3QgR3RrV2lu ZG93KiogdG8gZ3BvaW50ZXIqIGluIGNhbGwgdG8KKyAgICAgICAgZ19vYmplY3RfYWRkX3dlYWtf cG9pbnRlciB0byBhdm9pZCBjb21waWxlciB3YXJuaW5ncy4KKwogMjAxNC0wMS0xMyAgUGV0ZXIg TW9sbmFyICA8cG1vbG5hci51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAgICAg IFJlbW92ZSBwYXJzaW5nIG9mIG9sZC1ydW4td2Via2l0LXRlc3RzIG91dHB1dCBmcm9tIG1hc3Rl ci5jZmcKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMg Yi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IDlhMDM5ZGVjZjRh NjRlNTA4MGVlNTY5Yzk5NGQzNWE1N2E0MWM0N2UuLjAxYTFjYjgyYzkxNmQ5NmExMzc5ZjVkMjZh ZWVjMTI1ZGNiN2RhMmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAt NzA3LDcgKzcwNyw3IEBAIEd0a1dpZGdldCAqYnJvd3Nlcl93aW5kb3dfbmV3KFdlYktpdFdlYlZp ZXcgKnZpZXcsIEd0a1dpbmRvdyAqcGFyZW50KQogCiAgICAgaWYgKHBhcmVudCkgewogICAgICAg ICB3aW5kb3ctPnBhcmVudFdpbmRvdyA9IHBhcmVudDsKLSAgICAgICAgZ19vYmplY3RfYWRkX3dl YWtfcG9pbnRlcihHX09CSkVDVChwYXJlbnQpLCAmd2luZG93LT5wYXJlbnRXaW5kb3cpOworICAg ICAgICBnX29iamVjdF9hZGRfd2Vha19wb2ludGVyKEdfT0JKRUNUKHBhcmVudCksIChncG9pbnRl ciAqKSZ3aW5kb3ctPnBhcmVudFdpbmRvdyk7CiAgICAgfQogCiAgICAgcmV0dXJuIEdUS19XSURH RVQod2luZG93KTsK