126867 2014-01-12 19:46:56 -0800 Fix build warnings by unused parameter 2014-01-12 22:14:12 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song alecflett bunhere cdumez commit-queue gyuyoung.kim jsbell rakuco oldest_to_newest 967131 0 jinwoo7.song 2014-01-12 19:46:56 -0800 In file included from /home/jinwoo/opensource/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:37:0: /home/jinwoo/opensource/WebKit/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h:151:40: warning: unused parameter ‘checkingTypes’ [-Wunused-parameter] virtual Vector<TextCheckingResult> checkTextOfParagraph(StringView, TextCheckingTypeMask checkingTypes) { return Vector<TextCheckingResult>(); } /home/jinwoo/opensource/WebKit/Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:558:6: warning: unused parameter ‘operation’ [-Wunused-parameter] void IDBServerConnectionLevelDB::changeDatabaseVersion(IDBTransactionBackend& transaction, const IDBDatabaseBackend::VersionChangeOperation& operation, std::function<void(PassRefPtr<IDBDatabaseError>)> completionCallback) 967137 1 221001 jinwoo7.song 2014-01-12 20:49:31 -0800 Created attachment 221001 Patch 967146 2 221001 gyuyoung.kim 2014-01-12 21:43:23 -0800 Comment on attachment 221001 Patch In this case, I think variable type isn't primitive. Thus, we're able to know the meaning of removing parameters after this patch. Looks fine. 967151 3 221001 commit-queue 2014-01-12 22:14:08 -0800 Comment on attachment 221001 Patch Clearing flags on attachment: 221001 Committed r161860: <http://trac.webkit.org/changeset/161860> 967152 4 commit-queue 2014-01-12 22:14:12 -0800 All reviewed patches have been landed. Closing bug. 221001 2014-01-12 20:49:31 -0800 2014-01-12 22:14:07 -0800 Patch bug-126867-20140113134925.patch text/plain 3515 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmViMjU2YzU4Y2E3MmY4 MDJlOGQwNTliMTZmZWMwNTYzYjViMzZjMy4uYWZhNzNhYzUyZTU1ZDg5MWI2ODM4NTllMjFjYjk5 NWZjMTZiNDFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTEyICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQg d2FybmluZ3MgYnkgdW51c2VkIHBhcmFtZXRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9sZXZlbGRiL0lEQlNlcnZl ckNvbm5lY3Rpb25MZXZlbERCLmNwcDogCisgICAgICAgIChXZWJDb3JlOjpJREJTZXJ2ZXJDb25u ZWN0aW9uTGV2ZWxEQjo6Y2hhbmdlRGF0YWJhc2VWZXJzaW9uKTogUmVtb3ZlIHVudXNlZCBwYXJh bWV0ZXIgJ29wZXJhdGlvbicuCisKIDIwMTQtMDEtMTIgIE1hY2llaiBTdGFjaG93aWFrICA8bWpz QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggaU9TIGJ1aWxkIGJyZWFrYWdlIGZyb20gaHR0cDov L3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTYxODQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZmY0 NzNmMjA0OGE1YzRjYTQzZjczYzJiYjQwYzljZmEzYjViYWNlZi4uZmQyOTIyM2I5ZjJjNjZkMmZh ZWYzN2JjNTYzMTgzOGQ4MmFhNzNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAxLTEyICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBGaXggYnVpbGQgd2FybmluZ3MgYnkgdW51c2VkIHBhcmFtZXRlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODY3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRFZmwuaDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvckNsaWVudEVmbDo6Y2hl Y2tUZXh0T2ZQYXJhZ3JhcGgpOiBSZW1vdmUgdW51c2VkIHBhcmFtZXRlciAnY2hlY2tpbmdUeXBl cycuCisKIDIwMTQtMDEtMTEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBCdWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9sZXZlbGRiL0lEQlNlcnZlckNvbm5lY3Rpb25MZXZlbERCLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2xldmVsZGIvSURCU2VydmVyQ29ubmVjdGlvbkxl dmVsREIuY3BwCmluZGV4IGI4ZjQ1ZDhlMTdmYTQ4NTViOGM4Y2E4ZDQ0MTA1ZTU2MTVhMDcwYzUu LjQzN2JkM2E0Mzc2NjZmOGU2MzI0YTRiYmJkZDcwZDNjNThlYjM2OWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2xldmVsZGIvSURCU2VydmVyQ29ubmVjdGlv bkxldmVsREIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2xldmVs ZGIvSURCU2VydmVyQ29ubmVjdGlvbkxldmVsREIuY3BwCkBAIC01NTUsNyArNTU1LDcgQEAgdm9p ZCBJREJTZXJ2ZXJDb25uZWN0aW9uTGV2ZWxEQjo6ZGVsZXRlT2JqZWN0U3RvcmUoSURCVHJhbnNh Y3Rpb25CYWNrZW5kJiB0cmFuc2EKICAgICBBU1lOQ19DT01QTEVUSU9OX0NBTExCQUNLX1dJVEhf TlVMTF9BUkcoY29tcGxldGlvbkNhbGxiYWNrKTsKIH0KIAotdm9pZCBJREJTZXJ2ZXJDb25uZWN0 aW9uTGV2ZWxEQjo6Y2hhbmdlRGF0YWJhc2VWZXJzaW9uKElEQlRyYW5zYWN0aW9uQmFja2VuZCYg dHJhbnNhY3Rpb24sIGNvbnN0IElEQkRhdGFiYXNlQmFja2VuZDo6VmVyc2lvbkNoYW5nZU9wZXJh dGlvbiYgb3BlcmF0aW9uLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoUGFzc1JlZlB0cjxJREJEYXRhYmFz ZUVycm9yPik+IGNvbXBsZXRpb25DYWxsYmFjaykKK3ZvaWQgSURCU2VydmVyQ29ubmVjdGlvbkxl dmVsREI6OmNoYW5nZURhdGFiYXNlVmVyc2lvbihJREJUcmFuc2FjdGlvbkJhY2tlbmQmIHRyYW5z YWN0aW9uLCBjb25zdCBJREJEYXRhYmFzZUJhY2tlbmQ6OlZlcnNpb25DaGFuZ2VPcGVyYXRpb24m LCBzdGQ6OmZ1bmN0aW9uPHZvaWQoUGFzc1JlZlB0cjxJREJEYXRhYmFzZUVycm9yPik+IGNvbXBs ZXRpb25DYWxsYmFjaykKIHsKICAgICBJREJCYWNraW5nU3RvcmVUcmFuc2FjdGlvbkxldmVsREIq IGJhY2tpbmdTdG9yZVRyYW5zYWN0aW9uID0gbV9iYWNraW5nU3RvcmVUcmFuc2FjdGlvbnMuZ2V0 KHRyYW5zYWN0aW9uLmlkKCkpOwogICAgIEFTU0VSVChiYWNraW5nU3RvcmVUcmFuc2FjdGlvbik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGll bnRFZmwuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVm bC5oCmluZGV4IDY0ZWEyNGE2MWVmOTA2MTEyMDlkYTIwNTczOTcyOTQyYjhlNjI4NDEuLmJkOTJj ZDExNzRiZTI4NWZkYzgzZWJkYjBhOWQ5ODg5ZjRkMzcyYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5oCkBAIC0xNDgsNyArMTQ4 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRJbnB1dE1ldGhvZFN0YXRlKGJvb2wg ZW5hYmxlZCk7CiAgICAgdmlydHVhbCB2b2lkIHJlcXVlc3RDaGVja2luZ09mU3RyaW5nKFdURjo6 UGFzc1JlZlB0cjxXZWJDb3JlOjpUZXh0Q2hlY2tpbmdSZXF1ZXN0PikgeyB9CiAjaWYgVVNFKFVO SUZJRURfVEVYVF9DSEVDS0lORykKLSAgICB2aXJ0dWFsIFZlY3RvcjxUZXh0Q2hlY2tpbmdSZXN1 bHQ+IGNoZWNrVGV4dE9mUGFyYWdyYXBoKFN0cmluZ1ZpZXcsIFRleHRDaGVja2luZ1R5cGVNYXNr IGNoZWNraW5nVHlwZXMpIHsgcmV0dXJuIFZlY3RvcjxUZXh0Q2hlY2tpbmdSZXN1bHQ+KCk7IH0K KyAgICB2aXJ0dWFsIFZlY3RvcjxUZXh0Q2hlY2tpbmdSZXN1bHQ+IGNoZWNrVGV4dE9mUGFyYWdy YXBoKFN0cmluZ1ZpZXcsIFRleHRDaGVja2luZ1R5cGVNYXNrKSB7IHJldHVybiBWZWN0b3I8VGV4 dENoZWNraW5nUmVzdWx0PigpOyB9CiAjZW5kaWYKICAgICB2aXJ0dWFsIFRleHRDaGVja2VyQ2xp ZW50KiB0ZXh0Q2hlY2tlcigpIHsgcmV0dXJuIHRoaXM7IH0KIAo=